From nobody Sun Feb 8 15:10:31 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E26151E0DF4; Tue, 29 Oct 2024 09:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730195759; cv=none; b=eww3P0o5xn+nx3iVocZqOs9oyisEpwIgZ3Po8bM3fxZKrr/0BRTGng8Ssx4mN5MQTmQfbuD7NFHsg6y7TktJcR9xwxrvScUoNfsb01pni1HoK8Tjj+WRbOgjz707AfWx1AO0JjxN6ky2yiPXD4lc3JfOS/uwKFChWuF2GE+iml4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730195759; c=relaxed/simple; bh=9011h9+KYsXeSdS1A/6gVN2tUIbaukFnUrI3F8orlHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=exujj1q5wWYHstYcbCvCYzIesiER3NYenGaLVPk3tMKEblFqjVdBSfotu3T2mLtWWUFblFJ3jybbYYwu93WkEX9YtbF3DYeHREG41mXuidnvB2zKhzdNHv1/2thrm3ddV31SvKNzdFSUuvuGUNugjPTE1acjddrNVw9efJL85xk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=nT1GAGRm; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="nT1GAGRm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=sWL+u A6N3RP7S0oEEy+dt5J028U96XG2qpaI3whbCC8=; b=nT1GAGRm3e1rS7G0nQxdk c12589OMffZqPCBHdrB63piwn1vO3q01+e6Y5o76j5mt75cxO1DDhI63vta2bqkI SNHF2pXbY+bwfkrbz9d595BqKvUtBiLptepisQ7O/p5qu+toYnxeaIwSl0LJe83k zkyqKB1cbZBVnTH2lu9/7Q= Received: from ProDesk.. (unknown [58.22.7.114]) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wD3nxoCsSBn8+3dEA--.3291S5; Tue, 29 Oct 2024 17:55:22 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, s.hauer@pengutronix.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, minhuadotchen@gmail.com, detlev.casanova@collabora.com, Andy Yan , Michael Riesch Subject: [PATCH v4 03/14] drm/rockchip: vop2: Fix the mixer alpha setup for layer 0 Date: Tue, 29 Oct 2024 17:54:56 +0800 Message-ID: <20241029095513.391006-4-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241029095513.391006-1-andyshrk@163.com> References: <20241029095513.391006-1-andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3nxoCsSBn8+3dEA--.3291S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7WrWDGF1UXryfGrWrXr4fXwb_yoW8Gr43pF s8uFWj9w40krsFqr1DJan7uF4Syan7Cay7Grs7J3W3X3W3KF9rCwnxWr98ArZ8JF4xWF4a krZrKr98Wa12vrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jBD73UUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiMwqHXmcgqJmjwgABs2 Content-Type: text/plain; charset="utf-8" From: Andy Yan The alpha setup should start from the second layer, the current calculation starts incorrectly from the first layer, a negative offset will be obtained in the following formula: offset =3D (mixer_id + zpos - 1) * 0x10 Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Andy Yan Tested-by: Derek Foreman Tested-by: Michael Riesch # on RK3568 Tested-by: Detlev Casanova --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index bff190151ae8c..c50d93df84046 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -2282,6 +2282,12 @@ static void vop2_setup_alpha(struct vop2_video_port = *vp) struct vop2_win *win =3D to_vop2_win(plane); int zpos =3D plane->state->normalized_zpos; =20 + /* + * Need to configure alpha from second layer. + */ + if (zpos =3D=3D 0) + continue; + if (plane->state->pixel_blend_mode =3D=3D DRM_MODE_BLEND_PREMULTI) premulti_en =3D 1; else --=20 2.34.1