From nobody Sun Feb 8 07:06:10 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8656420400C for ; Tue, 29 Oct 2024 08:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191608; cv=none; b=BEiCkSyQ23YT8EjapU6KVJn66UTfKumtsp/QDDUKxXkvdqaktGbabMRoe1T83A/v2t79NJO1T4SpEe2UQkh8lYrEzB1YyI9j6SsP4V91cpBVvBS1OYZwg2bvVhmUW7NK2yOe6y+S9pX+X2jpOS1nTy6zR+Vd6J5xXBPbNuizraQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191608; c=relaxed/simple; bh=lvBH4nDZzUSZ6y5ghSyZfw8hPI3PkCQivKPs3UeNvug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pZMBhrDAX8wDuPflnuM6cxzuu06WRJ6xRCanNf7PJWpcaTlleMt1QFB/0oswqywwi7uXci+id82D+vkyzalBJoyhYAGTOKO4dFRet2UZgSJnoAuehLxD3VWODFEQFLWUVchtohgxEoGvyln5WbQYOsnLAmScIqayVKAyky/ly6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=ieCSYjL8; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="ieCSYjL8" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-539fb49c64aso8597475e87.0 for ; Tue, 29 Oct 2024 01:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1730191604; x=1730796404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rwyMMsHa5HEUfO6bt7mbb/5lMim+t5T1aF2qtApwxpM=; b=ieCSYjL8IptPLaZ6hAKobBQVUhO21p62duTr9ghMpGYtc5ZkBmVVueIBViErvlFGgE NavjIn9YhmofkH8a3crQQ9DMdJW+ilmF1VIljCWPMUuObs1kiO8XCxljiguWXYiVS65J xKsk/YOdvh3ojWawT5hFbSp01kogXP/RH8Xc0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730191604; x=1730796404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rwyMMsHa5HEUfO6bt7mbb/5lMim+t5T1aF2qtApwxpM=; b=IzwOBISX3FEK9NU4isItkDDi9+xJFbAfJRTUcvaOv7zfWOozKirupgfGbIiBnXAXe0 wl9umbgz3EJnI8KpRxUglAbrg7EvcuWKogRn19ZINy4xLVpBc3LtuV0Iidt+au5CUei+ n2MzdjOncekGhP1a0EQTHDrzR9V2iBbVzUNreNa43H3SucHRkFSTGrrKIIj3PbnyArVZ DL7WWb9tq5PDZTZJGI9KuAVT7LOnuk9tmKs5SaRGXDfmZpC479um8WePGGLRMfBCAm6S RuH5hAx5WwLS4J9TpthWnNHJKv9ulBSHypJKqIV+QhbI/5ywtr9BlVTxnNc3M78nD2oe u4Kw== X-Gm-Message-State: AOJu0YzHuwVBUWjCb8iJ+Y3clHFWxd58Kl6mUpLW9BaFVdZIBn5/l2iC xYbp37k8IvJWt6s5NrHrktSHcZOY/ZkkHoXBTaZVrxg5In70GP0/54QwQACgtZf6oRlLXFQgqt0 w X-Google-Smtp-Source: AGHT+IEISmXm1iH8AiJejbMa004PxvUCwKNYOyyhBpeNGrG9KbTdzRJ6Jk4J3pez3yKENXfTWV0g2Q== X-Received: by 2002:a05:6512:1252:b0:536:a4f1:d214 with SMTP id 2adb3069b0e04-53b348cc55cmr9003984e87.19.1730191604452; Tue, 29 Oct 2024 01:46:44 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-40-68-117.business.telecomitalia.it. [79.40.68.117]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1dec7dacsm450134166b.9.2024.10.29.01.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 01:46:44 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Haibo Chen , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Rob Herring , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Vincent Mailhol , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [RFC PATCH v2 2/6] can: flexcan: use can_update_bus_error_stats() Date: Tue, 29 Oct 2024 09:44:46 +0100 Message-ID: <20241029084525.2858224-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241029084525.2858224-1-dario.binacchi@amarulasolutions.com> References: <20241029084525.2858224-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch delegates the statistics update in case of bus error to the can_update_bus_error_stats(). Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/flexcan/flexcan-core.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index ac1a860986df..790b8e162d73 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -819,7 +819,6 @@ static void flexcan_irq_bus_err(struct net_device *dev,= u32 reg_esr) struct flexcan_regs __iomem *regs =3D priv->regs; struct sk_buff *skb; struct can_frame *cf; - bool rx_errors =3D false, tx_errors =3D false; u32 timestamp; int err; =20 @@ -834,41 +833,31 @@ static void flexcan_irq_bus_err(struct net_device *de= v, u32 reg_esr) if (reg_esr & FLEXCAN_ESR_BIT1_ERR) { netdev_dbg(dev, "BIT1_ERR irq\n"); cf->data[2] |=3D CAN_ERR_PROT_BIT1; - tx_errors =3D true; } if (reg_esr & FLEXCAN_ESR_BIT0_ERR) { netdev_dbg(dev, "BIT0_ERR irq\n"); cf->data[2] |=3D CAN_ERR_PROT_BIT0; - tx_errors =3D true; } if (reg_esr & FLEXCAN_ESR_ACK_ERR) { netdev_dbg(dev, "ACK_ERR irq\n"); cf->can_id |=3D CAN_ERR_ACK; cf->data[3] =3D CAN_ERR_PROT_LOC_ACK; - tx_errors =3D true; } if (reg_esr & FLEXCAN_ESR_CRC_ERR) { netdev_dbg(dev, "CRC_ERR irq\n"); cf->data[2] |=3D CAN_ERR_PROT_BIT; cf->data[3] =3D CAN_ERR_PROT_LOC_CRC_SEQ; - rx_errors =3D true; } if (reg_esr & FLEXCAN_ESR_FRM_ERR) { netdev_dbg(dev, "FRM_ERR irq\n"); cf->data[2] |=3D CAN_ERR_PROT_FORM; - rx_errors =3D true; } if (reg_esr & FLEXCAN_ESR_STF_ERR) { netdev_dbg(dev, "STF_ERR irq\n"); cf->data[2] |=3D CAN_ERR_PROT_STUFF; - rx_errors =3D true; } =20 - priv->can.can_stats.bus_error++; - if (rx_errors) - dev->stats.rx_errors++; - if (tx_errors) - dev->stats.tx_errors++; + can_update_bus_error_stats(dev, cf); =20 err =3D can_rx_offload_queue_timestamp(&priv->offload, skb, timestamp); if (err) --=20 2.43.0