From nobody Mon Nov 25 08:39:49 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 727A71DED5D; Mon, 28 Oct 2024 19:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142677; cv=none; b=k0dF7ZiuYHAIxi6rueHh3LWxa8OKmsUdhMNjZ0KjfJzYFP/KC2GbEVOEu/4uMrhUOMLfx8eq+bJr/eesHIXlhe5neSy8nuu9lhNAoopt0iiduUXe7Q+W5HGUmFEr34wvC75iaGNWbVvzVLWwBhkP8cDeTxNud7tvENhEu15kVA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142677; c=relaxed/simple; bh=Vl+dJW1dLHWdx44iF4qkzr4xppHjV8IF1v86QpLfsa4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D6CA0HFzhbXmqZQKY0jYl5n6zxV2i3+vAylzXHxfwmdLMVv0thRozfWmet38mRwTA2Ay+sHDmQ2jI14aLcjCbjHj4Dj7V/ADiK+QwDbWHRkoxHfwQltl83GElo+nE4EV8oRopG9U6spG871qQd0mwY9SBleLMWrVDvsg0ETfwhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=Z35fHnfR; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="Z35fHnfR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730142673; bh=Vl+dJW1dLHWdx44iF4qkzr4xppHjV8IF1v86QpLfsa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z35fHnfR6Jpwz5ma/weSFzXpLqbOyazbXw45RAlxAtyBAql1nIDl5HbNKGzKcBzP2 6S3tSo3uFolDRCNtBwkuW57mTqiA5ApfC0OUlxuAkzIlUqpD60SQpXZw1eAfmAbqIK 9aR0hOYVJrhiA6ZcHws1f4/5IR9zQ0K6kOViFu/nGV58V5Q+LV6CXEmWrYWRYDeOz4 H2Xxan9fWoqs4VcIon7GLMpPGMxTz0CbyJ6o8xWcPRL4Z49UcLMWxF6o5RoJcywoP4 gmUpIeGznWcwN6TPpkabbCVkZv+qg/8lRR0X79O8t06SC/2QXyArFYX5HbrB2IeQfK yaZlhg7v6/F9g== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XcjfS2p2Zzs19; Mon, 28 Oct 2024 15:11:12 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife Subject: [RFC PATCH v4 1/4] tracing: Introduce tracepoint extended structure Date: Mon, 28 Oct 2024 15:09:24 -0400 Message-Id: <20241028190927.648953-2-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> References: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Shrink the struct tracepoint size from 80 bytes to 72 bytes on x86-64 by moving the (typically NULL) regfunc/unregfunc pointers to an extended structure. Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- include/linux/tracepoint-defs.h | 8 ++++++-- include/linux/tracepoint.h | 19 +++++++++++++------ kernel/tracepoint.c | 9 ++++----- 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/linux/tracepoint-defs.h b/include/linux/tracepoint-def= s.h index 60a6e8314d4c..967c08d9da84 100644 --- a/include/linux/tracepoint-defs.h +++ b/include/linux/tracepoint-defs.h @@ -29,6 +29,11 @@ struct tracepoint_func { int prio; }; =20 +struct tracepoint_ext { + int (*regfunc)(void); + void (*unregfunc)(void); +}; + struct tracepoint { const char *name; /* Tracepoint name */ struct static_key_false key; @@ -36,9 +41,8 @@ struct tracepoint { void *static_call_tramp; void *iterator; void *probestub; - int (*regfunc)(void); - void (*unregfunc)(void); struct tracepoint_func __rcu *funcs; + struct tracepoint_ext *ext; }; =20 #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 0dc67fad706c..83dc24ee8b13 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -302,7 +302,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) * structures, so we create an array of pointers that will be used for ite= ration * on the tracepoints. */ -#define DEFINE_TRACE_FN(_name, _reg, _unreg, proto, args) \ +#define __DEFINE_TRACE_EXT(_name, _ext, proto, args) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") =3D #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ @@ -316,9 +316,9 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) .static_call_tramp =3D STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ .iterator =3D &__traceiter_##_name, \ .probestub =3D &__probestub_##_name, \ - .regfunc =3D _reg, \ - .unregfunc =3D _unreg, \ - .funcs =3D NULL }; \ + .funcs =3D NULL, \ + .ext =3D _ext, \ + }; \ __TRACEPOINT_ENTRY(_name); \ int __traceiter_##_name(void *__data, proto) \ { \ @@ -341,8 +341,15 @@ static inline struct tracepoint *tracepoint_ptr_deref(= tracepoint_ptr_t *p) } \ DEFINE_STATIC_CALL(tp_func_##_name, __traceiter_##_name); =20 -#define DEFINE_TRACE(name, proto, args) \ - DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); +#define DEFINE_TRACE_FN(_name, _reg, _unreg, _proto, _args) \ + struct tracepoint_ext __tracepoint_ext_##_name =3D { \ + .regfunc =3D _reg, \ + .unregfunc =3D _unreg, \ + }; \ + __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); + +#define DEFINE_TRACE(_name, _proto, _args) \ + __DEFINE_TRACE_EXT(_name, NULL, PARAMS(_proto), PARAMS(_args)); =20 #define EXPORT_TRACEPOINT_SYMBOL_GPL(name) \ EXPORT_SYMBOL_GPL(__tracepoint_##name); \ diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 6474e2cf22c9..5658dc92f5b5 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -278,8 +278,8 @@ static int tracepoint_add_func(struct tracepoint *tp, struct tracepoint_func *old, *tp_funcs; int ret; =20 - if (tp->regfunc && !static_key_enabled(&tp->key)) { - ret =3D tp->regfunc(); + if (tp->ext && tp->ext->regfunc && !static_key_enabled(&tp->key)) { + ret =3D tp->ext->regfunc(); if (ret < 0) return ret; } @@ -362,9 +362,8 @@ static int tracepoint_remove_func(struct tracepoint *tp, switch (nr_func_state(tp_funcs)) { case TP_FUNC_0: /* 1->0 */ /* Removed last function */ - if (tp->unregfunc && static_key_enabled(&tp->key)) - tp->unregfunc(); - + if (tp->ext && tp->ext->unregfunc && static_key_enabled(&tp->key)) + tp->ext->unregfunc(); static_branch_disable(&tp->key); /* Set iterator static call */ tracepoint_update_call(tp, tp_funcs); --=20 2.39.5 From nobody Mon Nov 25 08:39:49 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F391E00BD; Mon, 28 Oct 2024 19:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142678; cv=none; b=CNGuB5u275fbAf08Ml6z8ycNBNNh7Mh2q9VsNHLl6cJ+9Xto4KQ8IIwHganTfZsF/H5oRPgX9eShPfCQBP+gKFFXjuEIDMJ4upec73OS7419tq4+cEPjVIJq0USRHr0/Xyp9NIi01nT77FdPIKlrs2W6soPXedwQw453gYy+nyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142678; c=relaxed/simple; bh=adS58VZKpMyBhjeczUuBLAUJ2Kusr9Rs3Sub45oP7p0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tU+sGw9sYRuFVcvGMvL35DjNj9tjkjxShDX4bJYoUUFp8o+67jWNVRO8Tp31ZUt61hesO+2n3h5xIM4IaHtEeqlrIZS2H1lL9PGl/S7SeQKixSTJtMzvGz0d3/TGN2ezPk8QcgF/foIwgWPiAmngZEvNT5Va18ygbUHrTDrNJTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=g6sZFsC5; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="g6sZFsC5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730142674; bh=adS58VZKpMyBhjeczUuBLAUJ2Kusr9Rs3Sub45oP7p0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g6sZFsC5pT/r2fXHG4MVsLNwZy9pXSuIgzAAh6KE4Mmg+5Q1rLSncWAsBRFO74KsW fwimsUmtBreOT5gT1wofFXBxKMuSdaujOk9vVQZVZdmkkVfdNhxl0EbVImEtlUdAC+ Phtp2By4nqqApBjG/PrPBELmbRkALQA4WZg6ylMuwiJ3JgEJ0Kxu6SlDCSAfCPof5d UEb5fFazfPQcLu3nCcfqcjwTieREyhUjc4GMhmxaYBjT0/lz0MyTiKuXxjwiXGOBwN itb+PjP0g+JhJ6SwFzGIUmSJACA/LNMn3eXmDjZts6GYCMg8v3it1DLuqQSnzxuvhI ClLGUi9b1PAjA== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XcjfT3R62zsN5; Mon, 28 Oct 2024 15:11:13 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife Subject: [RFC PATCH v4 2/4] tracing: Introduce tracepoint_is_faultable() Date: Mon, 28 Oct 2024 15:09:25 -0400 Message-Id: <20241028190927.648953-3-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> References: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a "faultable" flag within the extended structure to know whether a tracepoint needs rcu tasks trace grace period before reclaim. This can be queried using tracepoint_is_faultable(). Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife Acked-by noted, thanks! Acked-by: Andrii Nakryiko --- include/linux/tracepoint-defs.h | 2 ++ include/linux/tracepoint.h | 24 ++++++++++++++++++++++++ include/trace/define_trace.h | 2 +- 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/include/linux/tracepoint-defs.h b/include/linux/tracepoint-def= s.h index 967c08d9da84..aebf0571c736 100644 --- a/include/linux/tracepoint-defs.h +++ b/include/linux/tracepoint-defs.h @@ -32,6 +32,8 @@ struct tracepoint_func { struct tracepoint_ext { int (*regfunc)(void); void (*unregfunc)(void); + /* Flags. */ + unsigned int faultable:1; }; =20 struct tracepoint { diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 83dc24ee8b13..259f0ab4ece6 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -104,6 +104,12 @@ void for_each_tracepoint_in_module(struct module *mod, * tracepoint_synchronize_unregister must be called between the last trace= point * probe unregistration and the end of module exit to make sure there is no * caller executing a probe when it is freed. + * + * An alternative is to use the following for batch reclaim associated + * with a given tracepoint: + * + * - tracepoint_is_faultable() =3D=3D false: call_rcu() + * - tracepoint_is_faultable() =3D=3D true: call_rcu_tasks_trace() */ #ifdef CONFIG_TRACEPOINTS static inline void tracepoint_synchronize_unregister(void) @@ -111,9 +117,17 @@ static inline void tracepoint_synchronize_unregister(v= oid) synchronize_rcu_tasks_trace(); synchronize_rcu(); } +static inline bool tracepoint_is_faultable(struct tracepoint *tp) +{ + return tp->ext && tp->ext->faultable; +} #else static inline void tracepoint_synchronize_unregister(void) { } +static inline bool tracepoint_is_faultable(struct tracepoint *tp) +{ + return false; +} #endif =20 #ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS @@ -345,6 +359,15 @@ static inline struct tracepoint *tracepoint_ptr_deref(= tracepoint_ptr_t *p) struct tracepoint_ext __tracepoint_ext_##_name =3D { \ .regfunc =3D _reg, \ .unregfunc =3D _unreg, \ + .faultable =3D false, \ + }; \ + __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); + +#define DEFINE_TRACE_SYSCALL(_name, _reg, _unreg, _proto, _args) \ + struct tracepoint_ext __tracepoint_ext_##_name =3D { \ + .regfunc =3D _reg, \ + .unregfunc =3D _unreg, \ + .faultable =3D true, \ }; \ __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); =20 @@ -389,6 +412,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) #define __DECLARE_TRACE_SYSCALL __DECLARE_TRACE =20 #define DEFINE_TRACE_FN(name, reg, unreg, proto, args) +#define DEFINE_TRACE_SYSCALL(name, reg, unreg, proto, args) #define DEFINE_TRACE(name, proto, args) #define EXPORT_TRACEPOINT_SYMBOL_GPL(name) #define EXPORT_TRACEPOINT_SYMBOL(name) diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h index ff5fa17a6259..63fea2218afa 100644 --- a/include/trace/define_trace.h +++ b/include/trace/define_trace.h @@ -48,7 +48,7 @@ =20 #undef TRACE_EVENT_SYSCALL #define TRACE_EVENT_SYSCALL(name, proto, args, struct, assign, print, reg,= unreg) \ - DEFINE_TRACE_FN(name, reg, unreg, PARAMS(proto), PARAMS(args)) + DEFINE_TRACE_SYSCALL(name, reg, unreg, PARAMS(proto), PARAMS(args)) =20 #undef TRACE_EVENT_NOP #define TRACE_EVENT_NOP(name, proto, args, struct, assign, print) --=20 2.39.5 From nobody Mon Nov 25 08:39:49 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B439F1E0B7B; Mon, 28 Oct 2024 19:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142679; cv=none; b=Cet0WR87WAIHMCs3N9Hv1gNZ5KXAIZzIG3ruZrxX41fDFebAVezChGb90Yre/M0JGoFNAXKpePDZGkkBFQX/Yx0yBDn1fLQEA0dhaZvYNFzC6MU58C0/KQxAHngHqmYeJvMgxrl5RO89UJ5y+Ar+nwpewhX5ewpvR9li+47yxFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142679; c=relaxed/simple; bh=csBoq7DrfsGO+bhagDLyjpKpU4ToRC3SFP9oiq5xb2c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bCWiTOdXTDoFddDhTfDD10l6f72p7ofylFpT7Vv1BmoFFGVNwMaZ/S3QHAsHNYQo8CXFwW8nMrq3r/prYkIxO5E38AqDCcTyRd5ucQ89pcKO+ONOMn2LP2BPP7eVQ9h/SMlp8xb+otvGunpKBBefTnxlxnR9n2ozp+rakTx9a50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=lfCHeHjO; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="lfCHeHjO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730142675; bh=csBoq7DrfsGO+bhagDLyjpKpU4ToRC3SFP9oiq5xb2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lfCHeHjO65vOZgGbL1De9X6TJLPOjYf6eff+2COHYPSmD8ZmhOY2t/AfMcduXwb/Y kbbE9/7XY7vTflcI5hrDMSJiqvPNiBHsZbfp1IY+vQoYlObeQl8OoCoGjkQ9A7djEm u5ivmpt7/p4kJagM2f1TS0nay9GwULol8BgbWK6NS84vEaLbSJ493lJTIpUuezPsoY Yz/J1NyOZ8IcPVjmv5OjFN1baRBgSZ9X+jsDIlGi175KoLBXfv12hI3M4VWhylWr6l cN1jk4EnHgPL0TKw/R7GpqNAFF0UgkgZh+apab/N5H6BfgWIvwjyTAGd3Psl87bKla fcsfqAojJ7qQQ== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XcjfV5G5jzsfK; Mon, 28 Oct 2024 15:11:14 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife , syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com Subject: [RFC PATCH v4 3/4] tracing: Fix syscall tracepoint use-after-free Date: Mon, 28 Oct 2024 15:09:26 -0400 Message-Id: <20241028190927.648953-4-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> References: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The grace period used internally within tracepoint.c:release_probes() uses call_rcu() to batch waiting for quiescence of old probe arrays, rather than using the tracepoint_synchronize_unregister() which blocks while waiting for quiescence. With the introduction of faultable syscall tracepoints, this causes use-after-free issues reproduced with syzkaller. Fix this by using the appropriate call_rcu() or call_rcu_tasks_trace() before invoking the rcu_free_old_probes callback. This can be chosen using the tracepoint_is_faultable() API. A similar issue exists in bpf use of call_rcu(). Fixing this is left to a separate change. Reported-by: syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com Fixes: a363d27cdbc2 ("tracing: Allow system call tracepoints to handle page= faults") Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- Changes since v0: - Introduce tracepoint_call_rcu(), - Fix bpf_link_free() use of call_rcu as well. Changes since v1: - Use tracepoint_call_rcu() for bpf_prog_put as well. Changes since v2: - Do not cover bpf changes in the same commit, let bpf developers implement it. Changes since v3: - Use tracepoint_is_faultable(). --- kernel/tracepoint.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 5658dc92f5b5..1848ce7e2976 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -106,13 +106,16 @@ static void rcu_free_old_probes(struct rcu_head *head) kfree(container_of(head, struct tp_probes, rcu)); } =20 -static inline void release_probes(struct tracepoint_func *old) +static inline void release_probes(struct tracepoint *tp, struct tracepoint= _func *old) { if (old) { struct tp_probes *tp_probes =3D container_of(old, struct tp_probes, probes[0]); =20 - call_rcu(&tp_probes->rcu, rcu_free_old_probes); + if (tracepoint_is_faultable(tp)) + call_rcu_tasks_trace(&tp_probes->rcu, rcu_free_old_probes); + else + call_rcu(&tp_probes->rcu, rcu_free_old_probes); } } =20 @@ -334,7 +337,7 @@ static int tracepoint_add_func(struct tracepoint *tp, break; } =20 - release_probes(old); + release_probes(tp, old); return 0; } =20 @@ -405,7 +408,7 @@ static int tracepoint_remove_func(struct tracepoint *tp, WARN_ON_ONCE(1); break; } - release_probes(old); + release_probes(tp, old); return 0; } =20 --=20 2.39.5 From nobody Mon Nov 25 08:39:49 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1287E1E0DB2; Mon, 28 Oct 2024 19:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142679; cv=none; b=cJWws71NPvnbC1HBuEhKFX+v9o+6isjfSq3uXQIjyF5G+BP8guTaz62VDHtRxe72jnsm1093ra03ExScPFv6o4y4LeV33gm8gbPfNiL7t+xmr+GB9lq1TvI4riYI4dIc2C5TqJedo9ig1WVGV0htU7RS4/5CGEba2+N4xw7LDdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730142679; c=relaxed/simple; bh=oe4SEYpQcTZHF0AxYZqODo9TxSAdD2NyXwBNnVcz1u0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=unX5GeQSF06/njLEcYxMuebrjCVOtgUxyNRe0FLe2IIYfNWmKcPq1E44XPnlC9AR2RDsvuwCWTKqK2blRgWCIFq4c0yHZBKIZ1KxQncaySeA809bFTR1Ye0Gl8BGzfWrD0rpE5MuKYa1aJFlTlPiZT3Q0lUpg8fyxOIreeGnGvI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=nHdTMwJX; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="nHdTMwJX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730142676; bh=oe4SEYpQcTZHF0AxYZqODo9TxSAdD2NyXwBNnVcz1u0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nHdTMwJXTbvmuXGKKeTxcGet3NeRKeaG41zIXPHPhwWibKhpHTCzvWNfTOjcz2ybW pWaR7k1xxbPmj4oQD2W2PQ1O3gQwPPgG6soAhOD9biW/+p90IPVFPrP+qKxJW7WqvH FMMsxM/RQ4pg+1rC++s0MGzdN1O86Na6ERsggzoD0q+iKPcVWwAsGbqZds/EOBQQG6 SnE7xV/DEjzlvlvd91333KyHh67ChHI4P80Z4bXBVBU+OVO+whqbz0OLpwmrKMvZFH ykAb/8ng42EGPr9X8u0sDfh5pwRMWoKBMbs+fVqBMGk0g2c5H5HcHnY1vKLW1A2UG0 TwRRWVuXiiV4g== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XcjfW5Xtlzs8q; Mon, 28 Oct 2024 15:11:15 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife Subject: [RFC PATCH v4 4/4] tracing: Add might_fault() check in __DO_TRACE() for syscall Date: Mon, 28 Oct 2024 15:09:27 -0400 Message-Id: <20241028190927.648953-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> References: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Catch incorrect use of syscall tracepoints even if no probes are registered by adding a might_fault() check in __DO_TRACE() when syscall=3D1. Suggested-by: Thomas Gleixner Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife Tested-by: Jordan Rife --- include/linux/tracepoint.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 259f0ab4ece6..7bed499b7055 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -226,10 +226,12 @@ static inline struct tracepoint *tracepoint_ptr_deref= (tracepoint_ptr_t *p) if (!(cond)) \ return; \ \ - if (syscall) \ + if (syscall) { \ rcu_read_lock_trace(); \ - else \ + might_fault(); \ + } else { \ preempt_disable_notrace(); \ + } \ \ __DO_TRACE_CALL(name, TP_ARGS(args)); \ \ --=20 2.39.5