From nobody Sat Feb 7 08:23:14 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706BC18FDDF for ; Mon, 28 Oct 2024 07:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730099494; cv=none; b=lgRUv2uZMLHBDVxdigf62NfrmZE7ZFSelF8hIPh2sQeggfDdePbNIHk14HOXfdWSUV2xEMmuBqL9YEz/3ohrjUeh5qggEM49VDhaoVF/R0jr5IyUdrVXscSA+2kVLF72ZyFRrq/9caAaUyIUF2zd02D6Ef+UWemGEActsZtiP84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730099494; c=relaxed/simple; bh=iWDYd1b1Wvv6ndrxXc9PuI65UIqXmfta3N5ZMjJj6Xc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uC1dEarxZyqd9HFSkuDIU5FU0VNRh8AqxrHEpUL/IvG5yikZC2D1zk7ArnB0q73x1JoHN8ccxo6fb65aUimTjncQP5EZxqcK523tpbFgG/q57zbKFpY/qwrB31f4G0wd2IISFE87g0h1WXCBO4C+OKyVvBYTCM2+Sh63zuZEwng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jMIhhggk; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jMIhhggk" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-37d4ba20075so2755788f8f.0 for ; Mon, 28 Oct 2024 00:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730099491; x=1730704291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nowgTJuac2Yh7X/z94khQScVguetvtBTtzCKLVQFaas=; b=jMIhhggkoeJ2WIkYNg++2nLfEIhjZnTrAQYlMJrDSDqg1zewTDJKn1TKIs2QVDjqLl GJLhJ4cu41WZtX6e+zDuPY4jEQdOrnNgphhefO+30dHtaJvzQGG9Oe4SRsK1/sg0Qeh6 oA+eRjl54HOz7QOtxgHgDaGeLkSxayVivB2CRPx/Tq0XxCin3pDMyJkeCQqRjMlBKdVj bsOorXcPq1c9kPhcxUSKd3UwCsAFWHjtG0hUKB49dSamS2d6lVVo0XzlFxRBeuP7sAR7 x2AQC7ecW6H/11PjMKHVQfx2qFOZcDe2Ijd94EZaUy/RN70F/oPo2eq8v7o98eYCOEmy 3AyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730099491; x=1730704291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nowgTJuac2Yh7X/z94khQScVguetvtBTtzCKLVQFaas=; b=Hk6N80gh9cFCTgQAapKILcGjekeaXuG7a0gLDBr+yzNPuVIPkK/fT1NiryKM8SIjKH ivhZtl+wwiKHgj+hGUPA7jOxC/nXrP3M+nAHqd+x6LRs/pJOc4gc4tQmTsneZk+Ro7wn Jz6ibqmgcM98pJhvqOIXWzg38u7cD1td3xLBMuMkFFADyJqRkiIid05nWzNfHFlf5cZV 8yz1HgiGRj5vhI2Gj6y7CgLMlCTMq/7LaoMjDWceQPCWxUBQprBohHaf7zHQo4S6hue7 92Be1C3izCqsKQc1HgSVrD3liFMbqk1rZiDHZLSqShD8hXrqnCcA1pv/TyFQBbXTdE9Z vK8g== X-Forwarded-Encrypted: i=1; AJvYcCXtq7ywIBoytuliWKzb1V+t5l/XqpaAGfD1PPi+wtuyW1yKakM5JMQjg+//NxJgslR9gKOKlXqgqtvbP/8=@vger.kernel.org X-Gm-Message-State: AOJu0YyROdmfDKPUWFWCRFkDxMiXGpmLk5oT3silllHEx+ZCtscf927l CkkPeVaOlYM7GFaqgYzgGhSjR+Z2hMsis7acnGtiZUcCZ9JySy0XEgBhYuXRM/k= X-Google-Smtp-Source: AGHT+IGAkVXhRYlzG5465u6RhebnlFP7K5tzK+c6Ystc8SSucFk35yCRMrvtFQSJh6XMRRrMNs4PAA== X-Received: by 2002:adf:f84d:0:b0:374:b3a3:3f83 with SMTP id ffacd0b85a97d-38061222394mr5179934f8f.53.1730099490785; Mon, 28 Oct 2024 00:11:30 -0700 (PDT) Received: from axelh-ThinkPad-T450s.home (lfbn-nic-1-251-169.w2-15.abo.wanadoo.fr. [2.15.94.169]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b3c236sm8615383f8f.35.2024.10.28.00.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 00:11:30 -0700 (PDT) From: ahaslam@baylibre.com To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Axel Haslam Subject: [PATCH 6/6] iio: dac: ad5791: Use devm_iio_device_register Date: Mon, 28 Oct 2024 08:11:18 +0100 Message-Id: <20241028071118.699951-7-ahaslam@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241028071118.699951-1-ahaslam@baylibre.com> References: <20241028071118.699951-1-ahaslam@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Axel Haslam Use devm_iio_device_register to automatically free the iio device. since this is the last remaining resource that was not automatically freed, we can drop the ".remove" callback. Suggested-by: David Lechner Signed-off-by: Axel Haslam --- drivers/iio/dac/ad5791.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c index cf3d41a10c20..21332c9aca5d 100644 --- a/drivers/iio/dac/ad5791.c +++ b/drivers/iio/dac/ad5791.c @@ -405,24 +405,12 @@ static int ad5791_probe(struct spi_device *spi) if (ret) return dev_err_probe(&spi->dev, ret, "fail to write ctrl register\n"); =20 - spi_set_drvdata(spi, indio_dev); indio_dev->info =3D &ad5791_info; indio_dev->modes =3D INDIO_DIRECT_MODE; indio_dev->channels =3D &st->chip_info->channel; indio_dev->num_channels =3D 1; indio_dev->name =3D st->chip_info->name; - ret =3D iio_device_register(indio_dev); - if (ret) - return dev_err_probe(&spi->dev, ret, "unable to register iio device\n"); - - return 0; -} - -static void ad5791_remove(struct spi_device *spi) -{ - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - - iio_device_unregister(indio_dev); + return devm_iio_device_register(&spi->dev, indio_dev); } =20 static const struct of_device_id ad5791_of_match[] =3D { @@ -451,7 +439,6 @@ static struct spi_driver ad5791_driver =3D { .of_match_table =3D ad5791_of_match, }, .probe =3D ad5791_probe, - .remove =3D ad5791_remove, .id_table =3D ad5791_id, }; module_spi_driver(ad5791_driver); --=20 2.34.1