From nobody Mon Feb 9 13:21:51 2026 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8364186287 for ; Sat, 26 Oct 2024 17:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729965594; cv=none; b=E2LxL54RbIq5skbKpcRSRaocmB2BohhUYJltnkKSS2hqb2G9WjGOlJ4H6qQRiDb9IdjcdcnwbZZisf5ruUczI8qu8GoOZE0CS+NgRhSZXrXdWlu5vLcbVtjRdlS7V6c+/k8nfi3OHUF3GcUoFkRTgJM8UDRByF4oY3tN0yQKrjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729965594; c=relaxed/simple; bh=W+RGPqPnbhu9Q3x8lJkcTlZu/uDp2T0PEcID/5CYBT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qLjopLg1aK0oDm7ofYKRVRP+JYepQeFvXxReBLzTLAV21nMVrmcLEa6zJgPhSum4tRITYBZQdrjUyH4FGEi04Wpxfp9fsR4+qmiudQI8Rkmi8sKoEDKNe1qf7dHC1KdCFKecyamsNWOgWVY8matNMvZaX1XnN2Abr7ALnnPHVFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vXgZP2q5; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vXgZP2q5" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2fb498a92f6so30454681fa.1 for ; Sat, 26 Oct 2024 10:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729965591; x=1730570391; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ix2+YHi6Hwn7k02ZYsRrumtAZZIu1FGEvAr1ZAiI+6Y=; b=vXgZP2q5rcMAzuE6kJnyGR8hR9XDGLOMI9/Pq4I/8SpnIKYaWkVfzuzOnwzXnNFYMN n5dkHEVYOHzbJhs7sNHVR4vUszvzXpdQh/OY5eggenm8jnoJi4WsETR+KmFcbGdFr3VP Jf62r2066QfLcJ0dQqCguf1x89F9Cmbp/9U1tChYz00cQRnHE4YiHrkE2Nq6PyUrwAxi cvLqZys9Xqo2i/GJdtFFJ2kDHp1TAuIhfBZYg3gt2Itv8U3+77y9Ndan9RL0g8hVqz98 PrDdJiPHWHamGxhLSJmXfCYjPN2X2iU6uTJXXyIpQxnG3e20cuVF6OL70jKGZgOq1B7+ IyWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729965591; x=1730570391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ix2+YHi6Hwn7k02ZYsRrumtAZZIu1FGEvAr1ZAiI+6Y=; b=Jk9dW9IE+icnUjSw9Tt8cW4+MRVi4og6itjG8ZV9fIDTYXjvxyqkDDs1u48zBHbcpn JCrIpZ1bgQ2+0lhPVi4ANvWlS8lsVkdwC2a5QmSyNeElomOv0vRWPokmWf0EEMwYXc5q g4823KvxrQ/wltGTbWpzUb4cKuteJ2NoNMjjPAMrpBCwXlZZic+5k+FgZ7ps1WCa9Ggq wqpa82paz3vmDVTZh+EegHAu+WUWWEzLQG5q1peUDhMKL7tqxG5ehsThoM9uFCfq5Gwh 7RNFhE6wHnbPAtrTrK6d63lo3196GvyiMKtjs4iKGySXUIUjvs8rS5K331RcBFpd6G+i jFLw== X-Forwarded-Encrypted: i=1; AJvYcCVQMoE+ycMker3+MQhyBd4h6WfQ4GILOS+p6m8ZAnVd58XEafzqRHFQSV6XPZEYuTgnZad+FzAe5ovFVbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw++zFPX9IEZxWydqXqGexZqa93XtdEzdA1xrt1dXosnfWduJlQ yB/X/mUoEA/xg1ViMLM7W17yIdNKhEOe/Mag2YLx0gGja8w5PsLHzTVoFJSndX4= X-Google-Smtp-Source: AGHT+IHJENZiqkul8liw5mKMMkdYQixr2MLk7dKug07H53qh3Nesxap3BkNWKvtYQ7V/0e9vXr2p7w== X-Received: by 2002:a05:651c:2228:b0:2fb:5a19:5b92 with SMTP id 38308e7fff4ca-2fcbe0b5efbmr10792691fa.40.1729965590716; Sat, 26 Oct 2024 10:59:50 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fcb453e53esm5970631fa.71.2024.10.26.10.59.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 10:59:49 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 26 Oct 2024 20:59:40 +0300 Subject: [PATCH v2 1/2] arm64: dts: qcom: sm8550: correct MDSS interconnects Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241026-fix-sm8x50-mdp-icc-v2-1-fd8ddf755acc@linaro.org> References: <20241026-fix-sm8x50-mdp-icc-v2-0-fd8ddf755acc@linaro.org> In-Reply-To: <20241026-fix-sm8x50-mdp-icc-v2-0-fd8ddf755acc@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Abhinav Kumar , Rob Clark , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, stable@kernel.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1570; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=W+RGPqPnbhu9Q3x8lJkcTlZu/uDp2T0PEcID/5CYBT8=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ7qsnkCq4pN4vY07jQTfy5q8zGCe4SiUm9PW0GGbxFejW r7uk0wnozELAyMXg6yYIotPQcvUmE3JYR92TK2HGcTKBDKFgYtTACbitZH9D4eYlZRfaDrfjvKQ qsvNvnIXXAUbkzOS2RZ6pOy+2eUxR59nC0fDsjIJoZC3Jy93/72mtuKe1JeJahsrup+d0j+iJt7 5741AqZRv3nlDGyNjLeveK9ZNZvdZNttesV/29x2f7+yPe35cSHmg9as+/ZdLqtnLSeYeic8dsi +euXIqSe7xzFP3Fk7dnpSgG74q01qf1zhhWt7GIv46do2iiQZT8/4r/xdss1Q7s+Dij6fbjl/4f 5NfXlar/O/jjuu53gIXHl9wOfWn5wM7c9el3HzFPLcOk+dVm3MzyvYlObzcZPm8b+/vXaXz0lna XYJaDMqDtAp/Mm8+I2VxqlSiY3JHduuixGXf37vkMGUDAA== X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A SM8550 lists two interconnects for the display subsystem, mdp0-mem (between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory). The second interconnect is a misuse. mdpN-mem paths should be used for several outboud MDP interconnects rather than the path between LLCC and memory. This kind of misuse can result in bandwidth underflows, possibly degrading picture quality as the required memory bandwidth is divided between all mdpN-mem paths (and LLCC-EBI should not be a part of such division). Drop the second path and use direct MDP-EBI path for mdp0-mem until we support separate MDP-LLCC and LLCC-EBI paths. Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware device= s") Cc: stable@kernel.org Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index 9dc0ee3eb98f..cca10f9faa14 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2871,9 +2871,8 @@ mdss: display-subsystem@ae00000 { =20 power-domains =3D <&dispcc MDSS_GDSC>; =20 - interconnects =3D <&mmss_noc MASTER_MDP 0 &gem_noc SLAVE_LLCC 0>, - <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; - interconnect-names =3D "mdp0-mem", "mdp1-mem"; + interconnects =3D <&mmss_noc MASTER_MDP 0 &mc_virt SLAVE_EBI1 0>; + interconnect-names =3D "mdp0-mem"; =20 iommus =3D <&apps_smmu 0x1c00 0x2>; =20 --=20 2.39.5 From nobody Mon Feb 9 13:21:51 2026 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEB71D6DB4 for ; Sat, 26 Oct 2024 17:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729965597; cv=none; b=Q/Cmiwh452vBs17rl2U1z+QO9Nwl5cXAMW/bJtMxs4Nf4pSQPIo5XdA1RkuczEPJFH/iAG94raqJZaYUBcbJxEAtFL+rTjdLhL+Zt5qHTgjJ9x+tCrw/OnxQYardKDw5h5ylNcUPpcU6fEF+SFks/+omXYDvRKN3RJdh21vhd6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729965597; c=relaxed/simple; bh=sKr/BvUYAOgHY4ZN/Rmk88OHIStViu1F6gSvWhlDBxg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IjuKSPEdoPkEr/Jx+aKWett/SqdNxf0MePPG4y4DA2xcFHFpp8tJqEtIxHX6PmC9SszgL74phC/KLXodZhJaMr06yMp2teJfreZ8Hy5Y5v83XTIfNJAzYUr3RJ2EN0zHyvgTTSF5Ij9wBWLDbaBft8TqsKTRC1Ix2Vd9Q52CO5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=meCUF9iV; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="meCUF9iV" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2fb6110c8faso28234081fa.1 for ; Sat, 26 Oct 2024 10:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729965593; x=1730570393; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HC7ge2GOnUS59w3CE63WILUVafzgzFctamSgq8O3ZPw=; b=meCUF9iVHngXK+oq4yUEm5igZ/abXODbOWbYK9OcAw0tESS5DgFH0+tYrSYiT9NZOx ULwfCumTh7j7oWPDEhJ3VOAPqooMz/lKZQZt5O0Dl+lyXZE1/vGM7tIkJzc0O17j47ow +JNmKsWvjmfH2le+ICd79iUCVDed27IUxMh1reFXMgKFjrghiR4B57VPQpKjJfPYGydl xaAO5ZdgHQUbczUNmA4FB9nyZ826CRaFR0roz7xPM86EGHkJrUktKcQsHuhfh74uLKnX 7S94PGiOvisv6BjwHizKRYgXPZpaWQ2ByqDfgjowDtjDDp26jGAKRLW6wlO9vVn84MPp b5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729965593; x=1730570393; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HC7ge2GOnUS59w3CE63WILUVafzgzFctamSgq8O3ZPw=; b=EidYojsvHXKN8TgVmuzTnLZP0QqJAW2sRJY0oFhrVV/gwLqjkzvU6uLGwBuIRqM3fe mAXB3ojWO038jXPxjq/i179mL4TPfOm1a9nXkXWMcf6zEZPfttGOvmREX0FKEGGnPMYs hKI8Z0WlnjZoJP3sgQkjRtk1qFXmTYajHJWCsGBoiCPRPIROKRjdOJGT2PnMhYxU9dib CHYIpDYGYbiPeXSSAv7QP/KCijK0mUkLgEl/0Hci97NSbIONjQ1voWEPKp43o2GEMxqr 3QDLX94iXvHXbwPxENDvICY6Grav5gV3bNWfO4c8+btbzuX+Syp4xe9hqplC5WjevaIr o3HA== X-Forwarded-Encrypted: i=1; AJvYcCUK0tPef5hLCnqLNkyT7k0wuuKywVRfHi7H6D1QlNF8JxEL7e8tHn6lGD5hZJ9VoVcs1ei9rEUbYpLU1Zo=@vger.kernel.org X-Gm-Message-State: AOJu0YzRgO+9YD2wefqaBeK6kjOX22l7GsbylDTbO6pKLsXhXt+vzT4s fLeCOqfGdmPGgliNIhduSmwC6sH3/StgDG8xDEA627nJGiHfr58Gon6um6EI7YU= X-Google-Smtp-Source: AGHT+IFJvk2eNmqZSTIMMdLk2drsnkEsAJMC4XT55QA6zfIctduoHpgiK823S4bxnu7DmuXh4AFEog== X-Received: by 2002:a2e:b8c3:0:b0:2fb:382e:410f with SMTP id 38308e7fff4ca-2fcbdfdb11cmr12029921fa.26.1729965593257; Sat, 26 Oct 2024 10:59:53 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fcb453e53esm5970631fa.71.2024.10.26.10.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 10:59:51 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 26 Oct 2024 20:59:41 +0300 Subject: [PATCH v2 2/2] arm64: dts: qcom: sm8650: correct MDSS interconnects Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241026-fix-sm8x50-mdp-icc-v2-2-fd8ddf755acc@linaro.org> References: <20241026-fix-sm8x50-mdp-icc-v2-0-fd8ddf755acc@linaro.org> In-Reply-To: <20241026-fix-sm8x50-mdp-icc-v2-0-fd8ddf755acc@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Abhinav Kumar , Rob Clark , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, stable@kernel.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1617; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=sKr/BvUYAOgHY4ZN/Rmk88OHIStViu1F6gSvWhlDBxg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnHS4R7YHfOs4vIQeSo2IOXxytBfzXP+eHYtHzL 0nOcTCBSWGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZx0uEQAKCRCLPIo+Aiko 1X3rCACPYqXa+RxJnVbTxsJwFRK+SLlbiS+cH1oWzz8Dx17wMpLr5kcR+oSiY42YGNV5g7xNtNy cmHF6Lce4m8UGHXobrl+NMJXqE77MuIa6xh7ND0vZ+FgVRWyXbEK7q134sK2u42WXJ9O0kPQYhN GlPzawZy+sg+iwfe6IkLOktfij65TS2pzSnyMgAg5mV2qZIG7Nw5/FeSh7fuU8DPBUq2OMB5YL3 MEUnkoWEki/n0DbSZWzXa1YsfYbdJH8JBvNa8tMttePSFko4o2gEuD8XzmQTgqFNEEHCDRYv+yC +/OPUfSRK8hNGyZ303ln8mAkWa7Murcj4CemJEVCtKQRxw+A X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A SM8650 lists two interconnects for the display subsystem, mdp0-mem (between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory). The second interconnect is a misuse. mdpN-mem paths should be used for several outboud MDP interconnects rather than the path between LLCC and memory. This kind of misuse can result in bandwidth underflows, possibly degrading picture quality as the required memory bandwidth is divided between all mdpN-mem paths (and LLCC-EBI should not be a part of such division). Drop the second path and use direct MDP-EBI path for mdp0-mem until we support separate MDP-LLCC and LLCC-EBI paths. Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent = device nodes") Cc: stable@kernel.org Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 173e092b15e2..4b54063c0e0c 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -3455,11 +3455,8 @@ mdss: display-subsystem@ae00000 { resets =3D <&dispcc DISP_CC_MDSS_CORE_BCR>; =20 interconnects =3D <&mmss_noc MASTER_MDP QCOM_ICC_TAG_ALWAYS - &gem_noc SLAVE_LLCC QCOM_ICC_TAG_ALWAYS>, - <&mc_virt MASTER_LLCC QCOM_ICC_TAG_ALWAYS &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; - interconnect-names =3D "mdp0-mem", - "mdp1-mem"; + interconnect-names =3D "mdp0-mem"; =20 power-domains =3D <&dispcc MDSS_GDSC>; =20 --=20 2.39.5