From nobody Mon Nov 25 23:33:29 2024 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D041AF0A3 for ; Thu, 24 Oct 2024 07:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729755217; cv=none; b=bmiSFgue/0a6So7F5KgbEeKyjugUaEohDEoLqskdSs2W7ZPaZfArsNU2A5y8mt2clDsJydqbTJdDQlvDMuHhY8yRkjyEK/zkEwkml5JZk/U1x+6jR7gcjttkgkz/oT2UqavegeKiY7auCk+lfROQjn7Urqn/rqL9r3y29J3mh6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729755217; c=relaxed/simple; bh=bl0TwbExu4G349NNkk4dquZriD14f6vKBPjGiiViYyk=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=s0UVqw5Hlb4IE6nijQ4kd/ofq5BndycEUcisCONMQiXNxWcaw5f4sJr2sy6c2jKWuwVpbUmtv4DtD/GgUulvEGHHN6vJR1err79JBb34P8F+U9Otio15PQVQz53d3mg58vpYn6Wa0MH2d+t2av/rZ8iLqhDwoML9f7lJYSt3R9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ekG/xcrn; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ekG/xcrn" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6dbbeee08f0so23142837b3.0 for ; Thu, 24 Oct 2024 00:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729755215; x=1730360015; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=2yVnPqZ8RpP/8r+vCUjKwDzk1QDMtk4+iGqU5/U/LQI=; b=ekG/xcrnDqq9cTA/iiFLKRbhy2VEQpERIDNrGShuwpJYyNxZlcP1hBgNMaWr6Qkp8a 4jzOSM9ZmwSyo2pLq6L68MKpQL1EwyQbhkhecfW6oUni1lD5yyakzmMoZlhVhu4VlWs0 pjXa9yKYRRwWQPPHaA4+g1lfAdzbqD1PgXqjIJFL/YqEacOSM3uUe1tHWkbSHh48KpRu eE1VWd1PR9ZpFIWyDa5akuwPQ7+UzPbgLuVOz8hSGXnoCiTTIUyqHkbJ8p0+xFglvYLi Ols8upXCRFUGC6HD73ZOovnmf/6pdup8YzAHvHSZEQbQc9KJjzEgyOJ9HRRFlSFZR/0R dEVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729755215; x=1730360015; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2yVnPqZ8RpP/8r+vCUjKwDzk1QDMtk4+iGqU5/U/LQI=; b=rzWblKJzUgjXXwkg66q0O0qzo30H8OQUhl0ST+92MI6fC+ozHWjxraxaiOGYigc9+v h0RrzfG2v+jNohJKo4x3Ru6p8VQn8skXnkdZmUPdZ4I3z74Yesl6n8bKMuQd3XnXlnIg e1bqbUvPdasH1kXipmok10NCL3fZ/q+6hpzsqqMh1aYNMV799APvnmqzj2YXi5F6qb0u KoHNUlnXLuo8z7RmuOP3UEhZXwGxcojFM29sIqqRV0tLauRoUNxTOaISNn2nYClpaYhP ZDCt6LED/wt3I8tW666ufF1vHA+tOGNPJifMetdyqXFEBXejpo4GZkTH7EUUSsofNaiq rNHg== X-Forwarded-Encrypted: i=1; AJvYcCUFqiyMzhZAjQTu1TA2DcYl6kWl4WLsxhga+/5R4LsqkwSa2SP8ssnXShy/3qODGo9YFgQ/mtmaNjVQtY8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8dijlQOQapbk13kZL0bY6JaIuRhWCqcx4s35pJm2aZEba5Z5Q cLP4EjXbJCz0NnPg6Ta+IXE80hDQVtRhnTxWBPqTmyaeQQawm8KsdnYtvw5mOu4uDBHZCBtFpzY 3gFJPng== X-Google-Smtp-Source: AGHT+IFhAeOq6ksfdCCDp5Gvm3pCls8guQL8J1bSwHwpWmahAPhyCJrGStCtgKeRCOJldq5aosIa1voblhde X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:2391:e0be:5394:f85d]) (user=irogers job=sendgmr) by 2002:a5b:60c:0:b0:e29:7587:66d6 with SMTP id 3f1490d57ef6-e2ee7b732efmr5876276.4.1729755214276; Thu, 24 Oct 2024 00:33:34 -0700 (PDT) Date: Thu, 24 Oct 2024 00:33:17 -0700 In-Reply-To: <20241024073324.1513433-1-irogers@google.com> Message-Id: <20241024073324.1513433-4-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241024073324.1513433-1-irogers@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Subject: [PATCH v4 03/10] perf test: Reduce scope of parallel variable From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Howard Chu , Athira Jajeev , Michael Petlan , Veronika Molnarova , Dapeng Mi , Thomas Richter , Ilya Leoshkevich , Colin Ian King , Weilin Wang , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable duplicates sequential but is only used for command line argument processing. Reduce scope to make the behavior clearer. Tested-by: James Clark Signed-off-by: Ian Rogers --- tools/perf/tests/builtin-test.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-tes= t.c index 57d2e9e03fbc..0e8f877f4b1f 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -41,9 +41,6 @@ static bool dont_fork; /* Don't fork the tests in parallel and wait for their completion. */ static bool sequential =3D true; -/* Do it in parallel, lacks infrastructure to avoid running tests that cla= sh for resources, - * So leave it as the developers choice to enable while working on the nee= ded infra */ -static bool parallel; const char *dso_to_test; const char *test_objdump_path =3D "objdump"; =20 @@ -578,6 +575,12 @@ int cmd_test(int argc, const char **argv) const char *skip =3D NULL; const char *workload =3D NULL; bool list_workloads =3D false; + /* + * Run tests in parallel, lacks infrastructure to avoid running tests + * that clash for resources, So leave it as the developers choice to + * enable while working on the needed infra. + */ + bool parallel =3D false; const struct option test_options[] =3D { OPT_STRING('s', "skip", &skip, "tests", "tests to skip"), OPT_INCR('v', "verbose", &verbose, --=20 2.47.0.163.g1226f6d8fa-goog