From nobody Mon Nov 25 22:51:54 2024 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03AF17836B for ; Thu, 24 Oct 2024 06:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750439; cv=none; b=C2PJGQgDO26Em2tLAm0/HJt12Q+Mq/2GovXWaSjb5v7AQrTSpQkeW3pUbSyLna9jmUhtcMBfTaQuAJAT6soBo8viyg9DH0KD/lpeVlUbukDofclzvkMy3FYfdzBJ01kkdd/FfLYQsxdeCGDV/+1fF68gWScGafKY6RoCk4m+A3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750439; c=relaxed/simple; bh=l8D/9i6mXjdrnGYXKluLekzKk5HyhssFtVUnJ+7Jyfw=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Cc:Content-Type; b=gS8nx4muz7qFwu+o6HvUwJ03nbmGamdbajiO3uQqiyBY8RThroe+dZ//rVr6QoTg6AessXWw8iVLvtVRjDiyZpGuSkfL1LIRfLCmNRgEhO0hcUmperOJkbpsYDlMIY4mW1PbH2OqHxt/HbROq7aRVW+GF1jUEUnNNDFYX1h9RSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VpDNcNux; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VpDNcNux" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6e7fb84f999so9654767b3.2 for ; Wed, 23 Oct 2024 23:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750436; x=1730355236; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=VpDNcNuxDW34hq19vrx2nfDDXyLZw9bizU2zwZj38NQDPHK0zGHXvmBriTeVxkvWaO fzs2G2jqEm4VPeKGYqTPHToGn5Orrfbt+fjiBfIceWHkKoIi8PCaEHHhYlbq+WyHaUcz ahvuRJ2IQUH/HCNoMve6hne17gbkYkhbQZrq/X6XZL6cWy7NOnieBzKWjOkkm+an13wx 0PkV9LDNsi2zWwHYpRu/fd/5lfbUKQPl998X6S4W18P4jVrKp+W6Li6G4tUXwkOBCzEx 56+tTE0pPKKOGucPFiAYV7o7LowWGajA3KrfQujnV8Lp1ddFY7dQrappplH9BngQnF4G LISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750436; x=1730355236; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=jkxGonSUCOyGcyuTBuJOJXd11fiKNPVh9U4XEZRioYHhmchNKgrBjZlCAMug49DRPw d0Getx/aavSquipQqLyLmrIfoNPrgMV6GexDf0sVRDa3a97lDRxIVSn4NEuWp6f7JuwD 9BvcnrRHQWL4++eCmX03dWxvQzilAegBtKXz7VIiFTTlO1gD0GHnUin2jnjWJxK7n4Yr kSZpgK3Clnl9IACC2alKX9Equw3oLRgY7fg74xdVAZZO+gZI6/sR7olnWHYhR3QO9xdg CRysk8cvO25tAc9dtkozfnTXv4F3IyZ0z3lan13e/qb53/GoMxNmMMYttTTE+KexCOK6 ZMFA== X-Forwarded-Encrypted: i=1; AJvYcCX6vPoAKfyO/7K28MH9ZE7GMEpA86hDJ8ncF99Rl1NQQwFHZvzTaMZcs896NS5rT57+cNkzO7jAoqHObJk=@vger.kernel.org X-Gm-Message-State: AOJu0YxxxKGyBQdlhFvrBnIVWp6+flfCChwHVZop84Mq57yTQLViT+8Y 8mXqMSXTPQZ+pnFRxacLpN4wgVll48i8S7Vad0JBZs8Vbq2OrJmWRhi+qPiYaQJtEH0iQXkiHgn RhFdDaBXEv+3Qtw== X-Google-Smtp-Source: AGHT+IHCEMkQ2RfyYdNtjaLmn7Q1IV6vv3d2IoDuURVXiH0KtdFNDJTv0BNk9TxANKxuJUTxCoodn7NIA1qQz7g= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:6811:b0:6e3:19d7:382a with SMTP id 00721157ae682-6e85813d7f5mr589267b3.1.1729750435897; Wed, 23 Oct 2024 23:13:55 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:42 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-2-saravanak@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 1/3] drm: display: Set fwnode for aux bus devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , "=?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?=" , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with = backlight-lcd0 Reported-by: "N=C3=ADcolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@no= tapiano/ Tested-by: "N=C3=ADcolas F. R. A. Prado" Signed-off-by: Saravana Kannan Reviewed-by: Dmitry Baryshkov Reviewed-by: Thierry Reding --- drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/dis= play/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent =3D aux->dev; aux_ep->dev.bus =3D &dp_aux_bus_type; aux_ep->dev.type =3D &dp_aux_device_type_type; - aux_ep->dev.of_node =3D of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); =20 ret =3D device_register(&aux_ep->dev); --=20 2.47.0.105.g07ac214952-goog From nobody Mon Nov 25 22:51:54 2024 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A692C17C225 for ; Thu, 24 Oct 2024 06:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750443; cv=none; b=dq/oIXRUYvTcMKVwyrGvCc+8GFrGUnG+7KObDm18MXq8RwLTTmxo4fn9BdF329gm15Ii02SC+cshe1K42VXD/Fle62KIisluB2bT90qeLRKYLX3F2OdnP5nMn5Zt3chJnA7xMLAZ2GDpbpWToFqsCF2yilBsTJzNlCQgpyzG3Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750443; c=relaxed/simple; bh=Mr5FjaOgXQrzsjuJQ+4UFZauI2YyRX/0dCS+xJPRDiI=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Cc:Content-Type; b=OK6iOQSc0XWRm8o0k+8XMeFlLVLfAslyT/iLDqYFhAjiZ8L47eo9JNXC2nHFAIthvVbHC/HjuTIZc3vNXwB8AFI7kq9dbuP8DiG/ZdQeHJbcvphG1wHrxGt/qOKhCO+emPDAzurMCgwYE6SkenxCmThAVWp9FHrtobBMshSYiHk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=l+O9FxV8; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l+O9FxV8" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6e3497c8eb0so7635807b3.0 for ; Wed, 23 Oct 2024 23:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750441; x=1730355241; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=l+O9FxV8zMyJLtiECjyP6uxQWt+z7Nh6pOzPxwoTy8TsQ03yElJJbJEDsG7X+fc0Hs xy6vdkz4D9T4FDkX35/oZorIHOCxHE+TjfGMmAo1Z1p2E10gftpnjinn5ugwFGJKk/8I SBggeJTTd8zvE9c0l0HiBbDuZ6zaGBT8Q0C+Q1j7VTHRxtsE383CG9JRO9b9oKiLYEA+ Kr6WqBGJglU5SxMwE2G/yD8qA/q5hw7j51c3SU62dvGh7R2W6mUApmAWoal2Za7EB+ve ytm+q88bMY+9g7fDguAX/z/KGEX5HPLGoBg5+V3zKFb+Crl5ByyspT+02b17GBarf1EJ 8wlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750441; x=1730355241; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=FXDCrQFAG213sOg8VWA6piITvx5LawoFfBE5jHsNnl3NLPtmyzgH5uNcPo1frukMvM 3iRsmX0cHEldpOLZMXJNys0vqTvAk/S3iKYdlDjLu6JzL2s/tXnAGX1F8DcB1cLWpGT7 9K+/eFImEFNwX7siqxkSfyEsgiF8dduNEFQ/SuFYCYk+ry+5C/RC/i3hCag87zTXZwJb FymK8f7HLGfn8/HsWigwmEDKdyf8Rzjbxa7pBKGTdYSuCXknWn+WwKo1/CTDOjqPP+pd M8WGQsBsYDKnBbZeSiQe8tKSXhRHa1YlTj5wfluYl0FpqNSrmvQIM+7fx9LjpdAuB7fx YQKQ== X-Forwarded-Encrypted: i=1; AJvYcCUKs1AjrvrAiPF+8spg3qV2IFJpx1n7LEnJlZhXdZvLuIATHxfTFO63gpb8MeJ6+SaifME2rSLFvb60J4E=@vger.kernel.org X-Gm-Message-State: AOJu0YzTqjSpmz76pB548Ohrbrw0N4BxTYlblo6XINSGe04Yd1spb5pE TuPR6nvfxh6kjKpbO9aQYqgRpGr//JBKB0+a3vYQwK0oYH2cvnwIQZ6EpkzDsSvz4pl8P7caYNF gVrp64GarSzak+g== X-Google-Smtp-Source: AGHT+IEvWKI797qzaVIyJQytUKUTuDrxqDTilc69F1bH77+J3k5wYMBvLRY6cYuzVgsPwwCo2eftygSjpmQuXoI= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:9c06:b0:6e3:c4cb:689b with SMTP id 00721157ae682-6e866350bbfmr483267b3.4.1729750440665; Wed, 23 Oct 2024 23:14:00 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:43 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-3-saravanak@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , "=?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?=" , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with= 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia= .com/ Tested-by: Jon Hunter Suggested-by: "N=C3=ADcolas F. R. A. Prado" Signed-off-by: Saravana Kannan Acked-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port = *port, =20 device_initialize(&port->dev); port->dev.type =3D &tegra_xusb_port_type; - port->dev.of_node =3D of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent =3D padctl->dev; =20 err =3D dev_set_name(&port->dev, "%s-%u", name, index); --=20 2.47.0.105.g07ac214952-goog From nobody Mon Nov 25 22:51:54 2024 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB803188717 for ; Thu, 24 Oct 2024 06:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750448; cv=none; b=Sy60xPerye3BolQsEgDE9qYwtjwSEEr+BFRXnIamTto2fd6bOWAFGkDP4ko7QpWaI0CHv4ozFNZ88vXdgIVi1DXyodw9s1NdX3o10jA5uYyK/PuLQtaGHqNFEKJC+CbjQWMYbeFSVxM1wa8XDaAJjF0mT6QzG4Dm519MYogKBZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729750448; c=relaxed/simple; bh=zDXiwnNbOAqIIc1NRxGfQ1iF2PdUDrS7EJdjH4bGXdI=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Cc:Content-Type; b=km63DEXbj9J38/b036lmAKnvx0cy6a5aiHRnptOgn42YdvMKWbiUi5ZouAFopbeGnGxP2S/LpS1EKPkEeyYWQKMrznf7rfGrEQLH/aP1GffpPzeXPBT44I5L8loR+LFAjp66ngb6R7C9UejkOZHJolqHMn/gPLxvwmYe/dpbe1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qNEVLB5w; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qNEVLB5w" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e3d6713619so8355387b3.2 for ; Wed, 23 Oct 2024 23:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750446; x=1730355246; darn=vger.kernel.org; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=qNEVLB5wZAWqkQZOWbj/Bsr8QbqAdt9Bl0pjOuCJDLT2e8y5c9qH2MhHxRb4VNpIlV KUComeNF9rKthKH4gBKx44hhF9jmGI5ELiKu5rGsCYEubKqdJwSvAVR2FodktfEts0GA mnBKO6vhkxWsy6MI1Hs8M8eA4RXWL4KYEjw62phwE9Z2Je1IWtQmjmhO/0kGRpNTn2bt oghgvA7Qv3qeiqIyk7XllXn29z2AeW6K/5ik2PhqPU8Nltk1zGyji9QwbxvMkG7hhFsK q1ARqz3AMtoaouUWaGautpsveoGOXGu67WRBr1klrng+K6XtL/7T1xXx+ieHZfXH1Z3u Vedg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750446; x=1730355246; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=FJ4yLViu95qGuJscyfYAvRtpC2lHlIqyY/j0yUbCUbQvRHF+KdXWgdVNia+/IrNtQY pHLUNAR5PD/rsvH5L074o63sj6nGMnvJKBiXs/b4av9v/zOLBVsM7daD342FOZBQptmN BF6DmrMihBej6TvLX5Q4s0ELIjyfj6UMG8JdWxgSAoMeJvT1y36TgYWWguCc/mPwHxe6 /sJ8HMU/8opzIRkNfTW9tcLXvVT14eDBn5j2eLzVZNyMnehXhxzwZ1CfGJXOne3E48yl D+6WTo7OxM6aF5Nbr61EUgY8hQS3zYveM69GOFm9IJgQ+XCKDClWEbNWKLpzuDvX78+d T69A== X-Forwarded-Encrypted: i=1; AJvYcCXfaSgQDHFy6mqphGQAw8EkaGVrn+yE4CG48M8AkHp2Uyuh9ZkFQaD5YqYf5GN8W4hBWlkOf8GZ+YTQNiY=@vger.kernel.org X-Gm-Message-State: AOJu0YzxDOmZFs++yuPmnYZb1qN34UJWJtLpqRispsSG5OCG2WnvwoQA q0+8ozXua/3NDS/fgn2RjNDpOePUdznggTxUAa94timUnY4Acf02xLkXSPoLt2imacDSzr4EPdL LDNFIJ666YOkSGA== X-Google-Smtp-Source: AGHT+IEJXaAAeZpuDAkTsefFXLL2kex4B2AlfwjdclQcvPn636A6m5nX8BurNhgR4ykV7U+QaaWd5sb2nHuey3k= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:3749:b0:6e2:4b3:ee22 with SMTP id 00721157ae682-6e866359b6fmr171667b3.6.1729750445961; Wed, 23 Oct 2024 23:14:05 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:44 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-4-saravanak@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , "=?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?=" , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@nota= piano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.c= om/ Signed-off-by: Saravana Kannan --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index a4c853411a6b..3b13fed1c3e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2181,8 +2181,8 @@ static int fw_devlink_create_devlink(struct device *c= on, } =20 if (con !=3D sup_dev && !device_link_add(con, sup_dev, flags)) { - dev_err(con, "Failed to create device link (0x%x) with %s\n", - flags, dev_name(sup_dev)); + dev_err(con, "Failed to create device link (0x%x) with supplier %s for = %pfwf\n", + flags, dev_name(sup_dev), link->consumer); ret =3D -EINVAL; } =20 --=20 2.47.0.105.g07ac214952-goog