From nobody Tue Nov 26 04:16:12 2024 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DADE1FB3FF for ; Tue, 22 Oct 2024 21:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729632896; cv=none; b=I3J1ViFCYr97PzozN38zBrUeRAZYKL8ICRUGbsPo1Yl4kkVYji9liXffBvYf2m/IgP0y7Zt5DUtJBjc2nfgJPJ21hkJmdXH/qkvDycu4G6GvF495k08VqpWq77qhK1xikZ7nO7qcAaMTV4agBkHpvvuRAAmbeHM6cOpqI2vnNDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729632896; c=relaxed/simple; bh=72lvWaZVrGD5CN/tN9hRoU+ByQZLYWyjLH11N4oA4Bs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MOM78W+GaYHbTkpFoRqOwLmF/P9h8CdZFnKyZxsM/ca8gPLPPFDP+mzLY2hBdfa5sdPwRKwXYe2L7EW1XPXm8SFzRnJRDHH6Rawb7hCOs64x6Lzhyveey0paSfPQRdNfX+8vWNHOpFfE//O5csN1ANVPtcc/H22UDRyd5W/Ggtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=ekCC9UkA; arc=none smtp.client-ip=209.85.222.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="ekCC9UkA" Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-84fc5aaccf8so1912168241.3 for ; Tue, 22 Oct 2024 14:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1729632893; x=1730237693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ufKC44gX2rTxHnQ7e/iieQk2KCFejx60Yu8CtfOC82k=; b=ekCC9UkA7HGcDb+gU9nt3WT/Ko16sornmZ0xWFUuznEIUjoN4A1AK5BpvA545P8lf/ 77Z895PRVVelKrK2iWnHEEBczsACczIG0KVa7G1u5bTNO+XCXPTIpG2Yj6m9dK122VRP UBzUVaQBSinudRDDcsI85eLJsyu3DAqp0VJXn6aczdBJDbCBkT2LG99uX1zKmOPpTE0U wMqT7PtbLcEHmkl92y8kQczvUMjjY+pMuqYdpN9TojXEcm20W8HQHWPfZ8y0yq1RBmPk BBpOcfe/gKSV0EkIZauTXOG+gt/ky028pdwJa9lTO/TZ44minSYYKyAE8LajYyVWjv98 i54w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729632893; x=1730237693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ufKC44gX2rTxHnQ7e/iieQk2KCFejx60Yu8CtfOC82k=; b=sTOieX0Pwm15gdJE+58qatuMtsxP+azv74bym1UscyiKslYxle2I2+C1ndTO7Wxd4c q2iBrZ1JbLAzZlVc0S3osbo0zMXK2IDi5gKB5XZMmL3blp3yzOXwmUtHXI8xyOOvlZ9F Bfr7BPYViiqK0xJE1dbUSCHMG8qgBDILLQIv1WBvM0QkOS01U+Y57IbPN/zhQlPNSASk gtDUV3psFxekByGInwPFcx+GWlYiNJMZwDZ80rDUQz8VdIBvVDs9734wnsOWIuKu+iCo FndFhA9MeIwXORqceMhOSQkHnDrUFj/c9j5N469rDx0xIAg/ZrYVBbFz+gvtPVfP81L6 UPUQ== X-Forwarded-Encrypted: i=1; AJvYcCXtm128fWKvBGp6ztn6ulNDW85oE/d14E2TT7EVXb2SocQdWc6ja15b/5kaStcjJE7teI/g0kPZGRo4oNg=@vger.kernel.org X-Gm-Message-State: AOJu0YxgniaXVl9qiTbVE0ZjGd5kigxDBUVMsMfF2PiW4N+J3+UFzrCf PCKNY0Ijuzah3B+pxxwykXu05cG9wJOVXZKdua/kRraATx3WWB7keC/iUzJtg1Y= X-Google-Smtp-Source: AGHT+IE++oEhimUSC/n6odFHU11d3lmzvoMxQ3GR+KJvVhAk1j85ECkXjUx948Kl/hJd8+RlCzZn1g== X-Received: by 2002:a05:6102:3a07:b0:4a5:c74b:66a7 with SMTP id ada2fe7eead31-4a751c94d11mr591818137.19.1729632893322; Tue, 22 Oct 2024 14:34:53 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460d3c62f4dsm33845841cf.28.2024.10.22.14.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 14:34:52 -0700 (PDT) From: Gregory Price To: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org Cc: linux-cxl@kvack.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, gourry@gourry.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: [PATCH v3 1/3] memory: implement memory_block_advise/probe_max_size Date: Tue, 22 Oct 2024 17:34:48 -0400 Message-ID: <20241022213450.15041-2-gourry@gourry.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241022213450.15041-1-gourry@gourry.net> References: <20241022213450.15041-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hotplug memory sources may have opinions on what the memblock size should be - usually for alignment purposes. For example, CXL memory extents can be 256MB with a matching alignment. If this size/alignment is smaller than the block size, it can result in stranded capacity. Implement memory_block_advise_max_size for use prior to allocator init, for software to advise the system on the max block size. Implement memory_block_probe_max_size for use by arch init code to calculate the best block size. Use of advice is architecture defined. The probe value can never change after first probe. Calls to advise after probe will return -EBUSY to aid debugging. On systems without hotplug, always return -ENODEV and 0 respectively. Suggested-by: Ira Weiny Signed-off-by: Gregory Price --- drivers/base/memory.c | 43 ++++++++++++++++++++++++++++++++++++++++++ include/linux/memory.h | 10 ++++++++++ 2 files changed, 53 insertions(+) diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 67858eeb92ed..a0fd9e1451aa 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -110,6 +110,49 @@ static void memory_block_release(struct device *dev) kfree(mem); } =20 +/* + * @size: suggestion for maximum block size. must be aligned on power of 2. + * + * Early boot software (pre-allocator init) may advise archs on the max bl= ock + * size.This value can only decrease after initialization, as the intent i= s to + * identify the largest supported alignment for all sources. + * + * Use of this value is arch dependent, as is min/max block size. + * + * Returns: 0 on success + * -EINVAL if size is 0 or not pow2 aligned + * -EBUSY if value has already been probed + */ +static size_t memory_block_advised_sz; +static bool memory_block_size_probed; +int memory_block_advise_max_size(size_t bz) +{ + if (!bz || (bz & (bz - 1)) !=3D 0) + return -EINVAL; + + if (memory_block_size_probed) + return -EBUSY; + + if (memory_block_advised_sz) + memory_block_advised_sz =3D min(bz, memory_block_advised_sz); + else + memory_block_advised_sz =3D bz; + + return 0; +} + +/* + * memory_block_probe_max_size provides a suggested maximum memory block + * size value. After the first call, the value can never change. + * + * Returns: advised size in bytes, or 0 if never set. + */ +size_t memory_block_probe_max_size(void) +{ + memory_block_size_probed =3D true; + return memory_block_advised_sz; +} + unsigned long __weak memory_block_size_bytes(void) { return MIN_MEMORY_BLOCK_SIZE; diff --git a/include/linux/memory.h b/include/linux/memory.h index c0afee5d126e..47c00d6e1165 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -149,6 +149,14 @@ static inline int hotplug_memory_notifier(notifier_fn_= t fn, int pri) { return 0; } +static inline int memory_block_advise_max_size(size_t size) +{ + return -ENODEV; +} +static inline size_t memory_block_probe_max_size(void) +{ + return 0; +} #else /* CONFIG_MEMORY_HOTPLUG */ extern int register_memory_notifier(struct notifier_block *nb); extern void unregister_memory_notifier(struct notifier_block *nb); @@ -181,6 +189,8 @@ int walk_dynamic_memory_groups(int nid, walk_memory_gro= ups_func_t func, void memory_block_add_nid(struct memory_block *mem, int nid, enum meminit_context context); #endif /* CONFIG_NUMA */ +int memory_block_advise_max_size(size_t size); +size_t memory_block_probe_max_size(void); #endif /* CONFIG_MEMORY_HOTPLUG */ =20 /* --=20 2.43.0