From nobody Tue Nov 26 03:42:40 2024 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687691C8FB0 for ; Tue, 22 Oct 2024 17:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729618285; cv=none; b=Qh/P4selEI/mx8fdJhnLjwe58w8teVV/1WmXRjWQahh4UV7/efc5K/Q4XD4p71pJdKe/0Dt/3Gn7xJULjyZvG0vGJ+B/p8MHrbj8zsEmKzrP8cgCU/SrZbikrv44oPMh0DjEnIkgXhD3jSncsQx8dT3dAQc0l78nTDkurShhat0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729618285; c=relaxed/simple; bh=lW07OjyjtiP7BSeHvWrJwzhwe6xJuxZ4Ci6QSD1wU8E=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=JZed3b7IKEEtMTgNtie8IGnXAg1UNhmS07+KWIRszBAmPLChXgHX6ggYvPC8xo5mbJw8QRM36AY1llbba+ElZs6RmosjaP43U7Iva9MwQ+OpJk1ntWcYSYiRBr3Wi18Mvp7MliDIMcNHAA36KxmtNGCsA3hF0484B8meFySrxs4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gNiUk3xM; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gNiUk3xM" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e292dbfd834so8933364276.3 for ; Tue, 22 Oct 2024 10:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729618282; x=1730223082; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=t8Sn8jdbA+NjEGCeG6Gm1wYYNvd28v2iQntXlq3XUm8=; b=gNiUk3xMhmyGl/0MUuffKd9G0n4ZpHByYjGyedlmNCRYpxxVsp+BHusFqgYei3brhA +lxzkiOXfWClRrZ0oBFGbSb6HAkm01JIFVrM3IOqtEunVotlmnFFZv+rvrhzY4nDetWM mDsLI7g0a7A0jr/LNOFHez5cW4+3IJ8EqL8mp2d2sk9c1Vm7OuRPORx/8ZEGnBr1kWPe /cedoV6foI/HEVYBuavh+YWRXTjB4Fo7KjZGRO6P+7ZI/ZmL1V0soS2f+fzuljnE2p6A KgS15U0KWa2ySSgQ2dByBzxpB8adRm05qvdgahlyQL5NhMT2nJRXk2CPo/guvGN0d91R Jetw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729618282; x=1730223082; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t8Sn8jdbA+NjEGCeG6Gm1wYYNvd28v2iQntXlq3XUm8=; b=V4yg6a4Nya1OMNgP3wn7q9lDI6bvvcBQU+PqcTAw51MS5L6rCiKjiEB9gGpWTSF3Dd kRcujVlZMPYSR9At+EvLgziSMPd1lV3SVfRU7LQNah7AhguBbq0Tmc3iQPlmHpA+nTDG F1Rk6+0ryQK9Ee/v77jJS8WrlqiGSxIfQsVQd9/AC2b8/8UK4xhkIkfWs6FFAzA7nBLM Dkp7jfdm3rP6XLXOCBV+excB5NPUN/UM7BHFb+yX5+I3iTf2ZW4Ca6EgbwVuuLuE850S uszlUCcuZpNB/Ho+7gnHlLotvzHVIHTZ9LCGm0KTwe5tMcmweECmEX3xpsvVXICNcCwY R4Uw== X-Forwarded-Encrypted: i=1; AJvYcCVb1Zci7kWAPbiseONGxBQvb+irxurtLLsHPdrFoXEWQwNMrDA8QtrUrXYmxz+uk4xBhqdT0u2UQLhB8vg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5/rhUjR4zCnOwQ5RbWvrDZspxPSW3cDh1CAeB8nKF1YaubC/W LLBlbwjwkqofE+mc/2+AjgemV4gguPgzAuPBMId/rpCyDbdYt+r9wzJ5hQBtF5Y6u0fjjqsCi7v Po9GU3w== X-Google-Smtp-Source: AGHT+IH9/EN5Q/+v0NKTCOkVpwJedIXeesZVaCnYSA/yidNa2oMOS06NMBkkfS9kppFI17/jXw7kZB9ilOvg X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:57ba:88e0:aaf6:282]) (user=irogers job=sendgmr) by 2002:a25:9c82:0:b0:e28:fe07:9cc1 with SMTP id 3f1490d57ef6-e2bb11dfda8mr36214276.3.1729618282343; Tue, 22 Oct 2024 10:31:22 -0700 (PDT) Date: Tue, 22 Oct 2024 10:30:12 -0700 In-Reply-To: <20241022173015.437550-1-irogers@google.com> Message-Id: <20241022173015.437550-15-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241022173015.437550-1-irogers@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Subject: [PATCH v3 14/16] perf kwork: Make perf_kwork_add_work a callback From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Howard Chu , Athira Jajeev , Michael Petlan , Veronika Molnarova , Dapeng Mi , Thomas Richter , Ilya Leoshkevich , Colin Ian King , Weilin Wang , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" perf_kwork_add_work is declared in builtin-kwork, whereas much kwork code is in util. To avoid needing to stub perf_kwork_add_work in python.c, add a callback to struct perf_kwork and initialize it in builtin-kwork to perf_kwork_add_work - this is the only struct perf_kwork. This removes the need for the stub in python.c. Signed-off-by: Ian Rogers --- tools/perf/builtin-kwork.c | 3 ++- tools/perf/util/bpf_kwork.c | 2 +- tools/perf/util/bpf_kwork_top.c | 2 +- tools/perf/util/kwork.h | 6 ++++-- tools/perf/util/python.c | 12 ------------ 5 files changed, 8 insertions(+), 17 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index c1daf82c9b92..fabfcb74800b 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1846,7 +1846,7 @@ static void process_skipped_events(struct perf_kwork = *kwork, } } =20 -struct kwork_work *perf_kwork_add_work(struct perf_kwork *kwork, +static struct kwork_work *perf_kwork_add_work(struct perf_kwork *kwork, struct kwork_class *class, struct kwork_work *key) { @@ -2344,6 +2344,7 @@ int cmd_kwork(int argc, const char **argv) .all_runtime =3D 0, .all_count =3D 0, .nr_skipped_events =3D { 0 }, + .add_work =3D perf_kwork_add_work, }; static const char default_report_sort_order[] =3D "runtime, max, count"; static const char default_latency_sort_order[] =3D "avg, max, count"; diff --git a/tools/perf/util/bpf_kwork.c b/tools/perf/util/bpf_kwork.c index 6c7126b7670d..5cff755c71fa 100644 --- a/tools/perf/util/bpf_kwork.c +++ b/tools/perf/util/bpf_kwork.c @@ -285,7 +285,7 @@ static int add_work(struct perf_kwork *kwork, (bpf_trace->get_work_name(key, &tmp.name))) return -1; =20 - work =3D perf_kwork_add_work(kwork, tmp.class, &tmp); + work =3D kwork->add_work(kwork, tmp.class, &tmp); if (work =3D=3D NULL) return -1; =20 diff --git a/tools/perf/util/bpf_kwork_top.c b/tools/perf/util/bpf_kwork_to= p.c index 7261cad43468..b6f187dd9136 100644 --- a/tools/perf/util/bpf_kwork_top.c +++ b/tools/perf/util/bpf_kwork_top.c @@ -255,7 +255,7 @@ static int add_work(struct perf_kwork *kwork, struct wo= rk_key *key, bpf_trace =3D kwork_class_bpf_supported_list[type]; tmp.class =3D bpf_trace->class; =20 - work =3D perf_kwork_add_work(kwork, tmp.class, &tmp); + work =3D kwork->add_work(kwork, tmp.class, &tmp); if (!work) return -1; =20 diff --git a/tools/perf/util/kwork.h b/tools/perf/util/kwork.h index 76fe2a821bcf..29352ca1d497 100644 --- a/tools/perf/util/kwork.h +++ b/tools/perf/util/kwork.h @@ -251,12 +251,14 @@ struct perf_kwork { * perf kwork top data */ struct kwork_top_stat top_stat; -}; =20 -struct kwork_work *perf_kwork_add_work(struct perf_kwork *kwork, + /* Add work callback. */ + struct kwork_work *(*add_work)(struct perf_kwork *kwork, struct kwork_class *class, struct kwork_work *key); =20 +}; + #ifdef HAVE_BPF_SKEL =20 int perf_kwork__trace_prepare_bpf(struct perf_kwork *kwork); diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index c52da509ae58..6e2ff0076daa 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -16,7 +16,6 @@ #include "thread_map.h" #include "trace-event.h" #include "mmap.h" -#include "util/kwork.h" #include "util/sample.h" #include =20 @@ -1297,14 +1296,3 @@ PyMODINIT_FUNC PyInit_perf(void) PyErr_SetString(PyExc_ImportError, "perf: Init failed!"); return module; } - - -/* The following are stubs to avoid dragging in builtin-* objects. */ -/* TODO: move the code out of the builtin-* file into util. */ - -struct kwork_work *perf_kwork_add_work(struct perf_kwork *kwork __maybe_un= used, - struct kwork_class *class __maybe_unused, - struct kwork_work *key __maybe_unused) -{ - return NULL; -} --=20 2.47.0.163.g1226f6d8fa-goog