From nobody Tue Nov 26 04:37:17 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139971BDA81 for ; Tue, 22 Oct 2024 17:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729617850; cv=none; b=p/z/XcpvWaCF6z8Z9kIVATLmE6U4eMDoIIqUwrMByf9avI95BHCFMerb8RdV+hy9r+h38D1g7vE11frmVLOrIo7pX27ZpxrHL9Yigity0G6HAAGLLpNOO2k15IMoR0LZyAsgMSmX86JpchEeC6kwcNZIFURXSAHN2d3NLoqjCqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729617850; c=relaxed/simple; bh=JmAPWXy5Vw82/y6UIjvkoXH3JKleNwrq4qEmYsUb6Tk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eRzKHouLZaaPSQ1SPTCRgNko1B/+Y3Sp3RfcuvCMujsFeE2ZkmP6ya/ax/Ls3YfdPsYdF7PjXVs26pCuu2+WacoX/KLIqcJfYCjm+/em7i5Yyah0oInrfUCbGimk/6CrQvntESYtL/WWURuvsgS/z5M62mQhxfX25q9DItVII9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iiotXc66; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iiotXc66" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729617848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RYRR3poErCjI6KOljjS6hUlitC7Nqrgyj2rhxhner44=; b=iiotXc66kc3mehOFoMgqRtMXII9f6/MudbgHI7NNemQcd/ItMUR4nRddXww7C7+k21VFUy NNIh7TKGoG/Me1AEOVt6BgBzl1C8l16tuuivn71D2iEQkCAumRff4k3O78ba2v+KwpFD6/ ScWY+VBl2OlsHgwC0UFf9jvNwE05XDU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-33VY614oMV2Pruptxc8tHA-1; Tue, 22 Oct 2024 13:24:02 -0400 X-MC-Unique: 33VY614oMV2Pruptxc8tHA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FDFA1955F3C; Tue, 22 Oct 2024 17:24:00 +0000 (UTC) Received: from f39.redhat.com (unknown [10.39.192.92]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3F4BD19560B2; Tue, 22 Oct 2024 17:23:55 +0000 (UTC) From: Eder Zulian To: bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, acme@redhat.com, vmalik@redhat.com, williams@redhat.com Subject: [PATCH v2 2/3] libbpf: Prevent compiler warnings/errors Date: Tue, 22 Oct 2024 19:23:28 +0200 Message-ID: <20241022172329.3871958-3-ezulian@redhat.com> In-Reply-To: <20241022172329.3871958-1-ezulian@redhat.com> References: <20241022172329.3871958-1-ezulian@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Initialize 'new_off' and 'pad_bits' to 0 and 'pad_type' to NULL in btf_dump_emit_bit_padding to prevent compiler warnings/errors which are observed when compiling with 'EXTRA_CFLAGS=3D-g -Og' options, but do not happen when compiling with current default options. For example, when compiling libbpf with $ make "EXTRA_CFLAGS=3D-g -Og" -C tools/lib/bpf/ clean all Clang version 17.0.6 and GCC 13.3.1 fail to compile btf_dump.c due to following errors: btf_dump.c: In function =E2=80=98btf_dump_emit_bit_padding=E2=80=99: btf_dump.c:903:42: error: =E2=80=98new_off=E2=80=99 may be used uninitial= ized [-Werror=3Dmaybe-uninitialized] 903 | if (new_off > cur_off && new_off <=3D next_off) { | ~~~~~~~~^~~~~~~~~~~ btf_dump.c:870:13: note: =E2=80=98new_off=E2=80=99 was declared here 870 | int new_off, pad_bits, bits, i; | ^~~~~~~ btf_dump.c:917:25: error: =E2=80=98pad_type=E2=80=99 may be used uninitia= lized [-Werror=3Dmaybe-uninitialized] 917 | btf_dump_printf(d, "\n%s%s: %d;", pfx(lvl= ), pad_type, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~ 918 | in_bitfield ? new_off - c= ur_off : 0); | ~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~ btf_dump.c:871:21: note: =E2=80=98pad_type=E2=80=99 was declared here 871 | const char *pad_type; | ^~~~~~~~ btf_dump.c:930:20: error: =E2=80=98pad_bits=E2=80=99 may be used uninitia= lized [-Werror=3Dmaybe-uninitialized] 930 | if (bits =3D=3D pad_bits) { | ^ btf_dump.c:870:22: note: =E2=80=98pad_bits=E2=80=99 was declared here 870 | int new_off, pad_bits, bits, i; | ^~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: Eder Zulian --- tools/lib/bpf/btf_dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c index 8440c2c5ad3e..468392f9882d 100644 --- a/tools/lib/bpf/btf_dump.c +++ b/tools/lib/bpf/btf_dump.c @@ -867,8 +867,8 @@ static void btf_dump_emit_bit_padding(const struct btf_= dump *d, } pads[] =3D { {"long", d->ptr_sz * 8}, {"int", 32}, {"short", 16}, {"char", 8} }; - int new_off, pad_bits, bits, i; - const char *pad_type; + int new_off =3D 0, pad_bits =3D 0, bits, i; + const char *pad_type =3D NULL; =20 if (cur_off >=3D next_off) return; /* no gap */ --=20 2.46.2