From nobody Tue Nov 26 09:42:08 2024 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B2D2E401 for ; Mon, 21 Oct 2024 01:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729475633; cv=none; b=bZ0wDmDedK3tf0JYodXXDcHHkFxP6ftl2tS0XdIasgHvSFc16CoQ7lfGFuEcoZWutolfxhDqXLoLAt0EzAK+adux5gjc/RB/fFPUEQv8Ql7uHft63fG2eTNs1jB66UjSih5EloyeYoxPozL0sdndxYPRwVMNdnJc1UQefbUO950= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729475633; c=relaxed/simple; bh=VE4qm8jApOLVerU00KCWXCwt/67d+CL4QjGzcJExsOA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QrzM/re6gp7Kbj1vucKSMpzIbXkVJFQbOR1V3a+fagjTuFYqEa3lpedQFMdQ1klXHDHILpI5yyX/KyARiQ5JTLXG3G/+YtL3NSUIOrReKOtZhcZBAHGALDKps/u8NqTsQCfDStBqfHfEM3d1OlsnoPEfAlBXqdpiLBo7wvJoQNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=BbCVy6X3; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="BbCVy6X3" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20cbca51687so40027135ad.1 for ; Sun, 20 Oct 2024 18:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1729475631; x=1730080431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AfpWC01kTavxQZPrDblAx1MDT+scLEsoUAk88HI2mLY=; b=BbCVy6X3EKt5jkfPv5QHE8O0pIVG9Uq7APlMayjzsAbeaLZnZ6+8U/3Nzmgy6NHyW8 /LUNkv4036NJYFQEyG8y734hZMhWbU8Vr1yndJFzFad7TShSBuJMQxh/qd3TRtAWLwaf xDrgF0eJefo8cgZZ0/Kfv5/Hb/OLUN8SCagDo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729475631; x=1730080431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AfpWC01kTavxQZPrDblAx1MDT+scLEsoUAk88HI2mLY=; b=gxyhJ8Zmzj124CWUlfjzhS4vm7jPQVLHTuYKZ4So4CxLp+S6cRvQUXBOrtDvSTo5UR I1bamacYUrM19zxrYDrlpEC8jcN1dePGCnFu5V32Z5IhUjPSXJ9g6hJu5TPYRmjfhzDZ FdWCRREmQrhR6YA+m9I0T/o8z6XRgjJT4ubBjJR/eZgBJS5aRAU9zjjEnIvaDOuw1ghb u4Za/G/ojUelftDaau8Xjf+kOqf1jqjVjn31j9fTmsFePn2yJdai4f2TBctn01MUoVBF CvjAa3+O5FlWuHXQzu7vWG6vQGln1Z3QnZ5QnlFeB0JdbPpT7IgdOZR09l5kDRSWBGnr KgrQ== X-Forwarded-Encrypted: i=1; AJvYcCVM41LE1N/GbeKDFTcPfNMGf7BgDOEkg8dV+BZQPBBkV/puLvUgHg8thbfiZcWIwLUvNX5etm1XuAeuYrc=@vger.kernel.org X-Gm-Message-State: AOJu0YxhXBsxd60Jh+17G/ZAJ2KMGYJAbm9qRBD+Tsr/qZc9U556jAzV MEv/j5IDnyQsla24aPYcNyrcetZJKSL9cKEIgt6+b8gQj59nI2rd9s3zGOUKQGU= X-Google-Smtp-Source: AGHT+IGjTJnjyjVlBYRXVayLwuiOfn+qQDvfmpxxzMcQOZPyIDPOAhsGL2RHj1rLhlA3CwruLaZYlQ== X-Received: by 2002:a17:902:cec1:b0:1fb:57e7:5bb4 with SMTP id d9443c01a7336-20e5a9061d1mr121980015ad.37.1729475630765; Sun, 20 Oct 2024 18:53:50 -0700 (PDT) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7eee650bsm15859985ad.34.2024.10.20.18.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Oct 2024 18:53:50 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org Cc: namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Martin Karsten , Joe Damato , "David S. Miller" , Paolo Abeni , Donald Hunter , Jesper Dangaard Brouer , Mina Almasry , Xuan Zhuo , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Alexander Lobakin , Johannes Berg , Daniel Jurgens , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next v2 1/6] net: Add napi_struct parameter irq_suspend_timeout Date: Mon, 21 Oct 2024 01:52:56 +0000 Message-Id: <20241021015311.95468-2-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241021015311.95468-1-jdamato@fastly.com> References: <20241021015311.95468-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Martin Karsten Add a per-NAPI IRQ suspension parameter, which can be get/set with netdev-genl. This patch doesn't change any behavior but prepares the code for other changes in the following commits which use irq_suspend_timeout as a timeout for IRQ suspension. Signed-off-by: Martin Karsten Co-developed-by: Joe Damato Signed-off-by: Joe Damato Tested-by: Joe Damato Tested-by: Martin Karsten --- v1 -> v2: - Rewrote this patch to make irq_suspend_timeout per-NAPI via netdev-genl. rfc -> v1: - Removed napi.rst documentation from this patch; added to patch 6. Documentation/netlink/specs/netdev.yaml | 7 +++++++ include/linux/netdevice.h | 2 ++ include/uapi/linux/netdev.h | 1 + net/core/dev.c | 2 ++ net/core/dev.h | 25 +++++++++++++++++++++++++ net/core/netdev-genl-gen.c | 5 +++-- net/core/netdev-genl.c | 12 ++++++++++++ tools/include/uapi/linux/netdev.h | 1 + 8 files changed, 53 insertions(+), 2 deletions(-) diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlin= k/specs/netdev.yaml index f9cb97d6106c..cbb544bd6c84 100644 --- a/Documentation/netlink/specs/netdev.yaml +++ b/Documentation/netlink/specs/netdev.yaml @@ -263,6 +263,11 @@ attribute-sets: the end of a NAPI cycle. This may add receive latency in exch= ange for reducing the number of frames processed by the network st= ack. type: uint + - + name: irq-suspend-timeout + doc: The timeout, in nanoseconds, of how long to suspend irq + processing, if event polling finds events + type: uint - name: queue attributes: @@ -653,6 +658,7 @@ operations: - pid - defer-hard-irqs - gro-flush-timeout + - irq-suspend-timeout dump: request: attributes: @@ -704,6 +710,7 @@ operations: - id - defer-hard-irqs - gro-flush-timeout + - irq-suspend-timeout =20 kernel-family: headers: [ "linux/list.h"] diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 8feaca12655e..9c3be8455707 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -347,6 +347,7 @@ struct gro_list { */ struct napi_config { u64 gro_flush_timeout; + u64 irq_suspend_timeout; u32 defer_hard_irqs; unsigned int napi_id; }; @@ -383,6 +384,7 @@ struct napi_struct { struct hrtimer timer; struct task_struct *thread; unsigned long gro_flush_timeout; + unsigned long irq_suspend_timeout; u32 defer_hard_irqs; /* control-path-only fields follow */ struct list_head dev_list; diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h index e3ebb49f60d2..e4be227d3ad6 100644 --- a/include/uapi/linux/netdev.h +++ b/include/uapi/linux/netdev.h @@ -124,6 +124,7 @@ enum { NETDEV_A_NAPI_PID, NETDEV_A_NAPI_DEFER_HARD_IRQS, NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, + NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, =20 __NETDEV_A_NAPI_MAX, NETDEV_A_NAPI_MAX =3D (__NETDEV_A_NAPI_MAX - 1) diff --git a/net/core/dev.c b/net/core/dev.c index c682173a7642..68d0b16c2f2c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6662,6 +6662,7 @@ static void napi_restore_config(struct napi_struct *n) { n->defer_hard_irqs =3D n->config->defer_hard_irqs; n->gro_flush_timeout =3D n->config->gro_flush_timeout; + n->irq_suspend_timeout =3D n->config->irq_suspend_timeout; /* a NAPI ID might be stored in the config, if so use it. if not, use * napi_hash_add to generate one for us. It will be saved to the config * in napi_disable. @@ -6676,6 +6677,7 @@ static void napi_save_config(struct napi_struct *n) { n->config->defer_hard_irqs =3D n->defer_hard_irqs; n->config->gro_flush_timeout =3D n->gro_flush_timeout; + n->config->irq_suspend_timeout =3D n->irq_suspend_timeout; n->config->napi_id =3D n->napi_id; napi_hash_del(n); } diff --git a/net/core/dev.h b/net/core/dev.h index 7881bced70a9..d043dee25a68 100644 --- a/net/core/dev.h +++ b/net/core/dev.h @@ -236,6 +236,31 @@ static inline void netdev_set_gro_flush_timeout(struct= net_device *netdev, netdev->napi_config[i].gro_flush_timeout =3D timeout; } =20 +/** + * napi_get_irq_suspend_timeout - get the irq_suspend_timeout + * @n: napi struct to get the irq_suspend_timeout from + * + * Return: the per-NAPI value of the irq_suspend_timeout field. + */ +static inline unsigned long +napi_get_irq_suspend_timeout(const struct napi_struct *n) +{ + return READ_ONCE(n->irq_suspend_timeout); +} + +/** + * napi_set_irq_suspend_timeout - set the irq_suspend_timeout for a napi + * @n: napi struct to set the irq_suspend_timeout + * @timeout: timeout value to set + * + * napi_set_irq_suspend_timeout sets the per-NAPI irq_suspend_timeout + */ +static inline void napi_set_irq_suspend_timeout(struct napi_struct *n, + unsigned long timeout) +{ + WRITE_ONCE(n->irq_suspend_timeout, timeout); +} + int rps_cpumask_housekeeping(struct cpumask *mask); =20 #if defined(CONFIG_DEBUG_NET) && defined(CONFIG_BPF_SYSCALL) diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c index 21de7e10be16..a89cbd8d87c3 100644 --- a/net/core/netdev-genl-gen.c +++ b/net/core/netdev-genl-gen.c @@ -92,10 +92,11 @@ static const struct nla_policy netdev_bind_rx_nl_policy= [NETDEV_A_DMABUF_FD + 1] }; =20 /* NETDEV_CMD_NAPI_SET - do */ -static const struct nla_policy netdev_napi_set_nl_policy[NETDEV_A_NAPI_GRO= _FLUSH_TIMEOUT + 1] =3D { +static const struct nla_policy netdev_napi_set_nl_policy[NETDEV_A_NAPI_IRQ= _SUSPEND_TIMEOUT + 1] =3D { [NETDEV_A_NAPI_ID] =3D { .type =3D NLA_U32, }, [NETDEV_A_NAPI_DEFER_HARD_IRQS] =3D NLA_POLICY_FULL_RANGE(NLA_U32, &netde= v_a_napi_defer_hard_irqs_range), [NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT] =3D { .type =3D NLA_UINT, }, + [NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT] =3D { .type =3D NLA_UINT, }, }; =20 /* Ops table for netdev */ @@ -186,7 +187,7 @@ static const struct genl_split_ops netdev_nl_ops[] =3D { .cmd =3D NETDEV_CMD_NAPI_SET, .doit =3D netdev_nl_napi_set_doit, .policy =3D netdev_napi_set_nl_policy, - .maxattr =3D NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, + .maxattr =3D NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, .flags =3D GENL_ADMIN_PERM | GENL_CMD_CAP_DO, }, }; diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index b49c3b4e5fbe..765ce7c9d73b 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -161,6 +161,7 @@ static int netdev_nl_napi_fill_one(struct sk_buff *rsp, struct napi_struct *napi, const struct genl_info *info) { + unsigned long irq_suspend_timeout; unsigned long gro_flush_timeout; u32 napi_defer_hard_irqs; void *hdr; @@ -196,6 +197,11 @@ netdev_nl_napi_fill_one(struct sk_buff *rsp, struct na= pi_struct *napi, napi_defer_hard_irqs)) goto nla_put_failure; =20 + irq_suspend_timeout =3D napi_get_irq_suspend_timeout(napi); + if (nla_put_uint(rsp, NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, + irq_suspend_timeout)) + goto nla_put_failure; + gro_flush_timeout =3D napi_get_gro_flush_timeout(napi); if (nla_put_uint(rsp, NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, gro_flush_timeout)) @@ -306,6 +312,7 @@ int netdev_nl_napi_get_dumpit(struct sk_buff *skb, stru= ct netlink_callback *cb) static int netdev_nl_napi_set_config(struct napi_struct *napi, struct genl_info *info) { + u64 irq_suspend_timeout =3D 0; u64 gro_flush_timeout =3D 0; u32 defer =3D 0; =20 @@ -314,6 +321,11 @@ netdev_nl_napi_set_config(struct napi_struct *napi, st= ruct genl_info *info) napi_set_defer_hard_irqs(napi, defer); } =20 + if (info->attrs[NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT]) { + irq_suspend_timeout =3D nla_get_uint(info->attrs[NETDEV_A_NAPI_IRQ_SUSPE= ND_TIMEOUT]); + napi_set_irq_suspend_timeout(napi, irq_suspend_timeout); + } + if (info->attrs[NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT]) { gro_flush_timeout =3D nla_get_uint(info->attrs[NETDEV_A_NAPI_GRO_FLUSH_T= IMEOUT]); napi_set_gro_flush_timeout(napi, gro_flush_timeout); diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/n= etdev.h index e3ebb49f60d2..e4be227d3ad6 100644 --- a/tools/include/uapi/linux/netdev.h +++ b/tools/include/uapi/linux/netdev.h @@ -124,6 +124,7 @@ enum { NETDEV_A_NAPI_PID, NETDEV_A_NAPI_DEFER_HARD_IRQS, NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, + NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, =20 __NETDEV_A_NAPI_MAX, NETDEV_A_NAPI_MAX =3D (__NETDEV_A_NAPI_MAX - 1) --=20 2.25.1