From nobody Tue Nov 26 10:31:59 2024 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A85B1DFE15 for ; Sat, 19 Oct 2024 08:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729327293; cv=none; b=BcYtDi3l8es1l8TdNitlsLaHmFjtEBhQkFXiAfvoGmPlTX6tHJz5+KSPF00vwnEIPjs6B8XI2BHnaKq4u2w5UgxQzhcT//Pg275AvawNcjkv1zPi9APD7K4HltHB1YfMiMCR9efMkJj97US/wBJKXojIQMiyt5E/wich8bjTBpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729327293; c=relaxed/simple; bh=FdZGL3TUN1+9A4uGfIiXR1Sq/tjCCI8qWbE31y09qPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ppbAIina7meyh+U9Dldpo7BbU5nP5u4tUmvC2qvv1btRRlFG5vpuBF2t401taDioZnH0Cy5p8b5Vt64CpsK6vPuuGbOw8omYd8BX/poStKGklql7RJvX2x2WFjuIEa0zMzs3Q1pB14FpB7fBKFBjJhd8kdUPWV7qmeUQfHEVRoE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wiredspace.de; spf=pass smtp.mailfrom=wiredspace.de; dkim=pass (1024-bit key) header.d=wiredspace.de header.i=@wiredspace.de header.b=ZWZY5S6X; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wiredspace.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wiredspace.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=wiredspace.de header.i=@wiredspace.de header.b="ZWZY5S6X" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wiredspace.de; s=key1; t=1729327289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KlaPX7c91DzUEtQUWFgG6dPxHB9a7LWLFKVDaWQe3BQ=; b=ZWZY5S6X1TE8qJMvrVbE5TbHr8v548I7F0KyOtN9jh+8qIfAoboP+5+h5GO0zIbc07NKUu ju155gNT2gTZn3dIn0+gGhSDkANGJmtm77dKCm0snHb2jec8siWJNB/4D39wHFxx4xqyBW Az5vjYuIN8dxytv3DgZcDfVoZNtKxQY= From: =?UTF-8?q?Thomas=20B=C3=B6hler?= To: Miguel Ojeda , Alex Gaynor , Jocelyn Falempe Cc: Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , rust-for-linux@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Thomas=20B=C3=B6hler?= Subject: [PATCH v2 5/7] drm/panic: correctly indent continuation of line in list item Date: Sat, 19 Oct 2024 10:22:50 +0200 Message-ID: <20241019084048.22336-6-witcher@wiredspace.de> In-Reply-To: <20241019084048.22336-1-witcher@wiredspace.de> References: <20241019084048.22336-1-witcher@wiredspace.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT It is common practice in Rust to indent the next line the same amount of space as the previous one if both belong to the same list item. Clippy checks for this with the lint `doc_lazy_continuation`. error: doc list item without indentation --> drivers/gpu/drm/drm_panic_qr.rs:979:5 | 979 | /// conversion to numeric segments. | ^ | =3D help: if this is supposed to be its own paragraph, add a blank line =3D help: for further information visit https://rust-lang.github.io/rus= t-clippy/master/index.html#doc_lazy_continuation =3D note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` =3D help: to override `-D warnings` add `#[allow(clippy::doc_lazy_conti= nuation)]` help: indent this line | 979 | /// conversion to numeric segments. | ++ Indent the offending line by 2 more spaces to remove this Clippy error. Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") Reported-by: Miguel Ojeda Link: https://github.com/Rust-for-Linux/linux/issues/1123 Signed-off-by: Thomas B=C3=B6hler Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic_qr.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr= .rs index 5b2386a515fa..58c46f366f76 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -976,7 +976,7 @@ fn draw_all(&mut self, data: impl Iterator= ) { /// * `url_len`: Length of the URL. /// /// * If `url_len` > 0, remove the 2 segments header/length and also count= the -/// conversion to numeric segments. +/// conversion to numeric segments. /// * If `url_len` =3D 0, only removes 3 bytes for 1 binary segment. #[no_mangle] pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) = -> usize { --=20 2.46.2