From nobody Tue Nov 26 08:28:24 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C01B1DE4CE; Sat, 19 Oct 2024 11:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336577; cv=none; b=njon1o3nAL7wykFg5eYT4ZWdbMV3aSg48UVo/QEyql/U3dHY0ANtyVesj0qKbCTFPR8V9WIgY7ZRjC4gQIwYg/5MrvuXmGRK2sejRXB8PtZubGyihf63A+tOlLMljvfqGJe/6hv1rfZCiBPoiW3vHIVsEIguY3F/6vg4x43eMug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336577; c=relaxed/simple; bh=liu6AH5wskPRdG1LJazp0t8ejwo/RTs1GpUY5J41pVw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GTkTs45UyRjRQcb1P4/03cQ+QkivW8T6MBP1m9Cl6iSVqYFHGzLsfvGcDEgVAysBgR6ab7/YLYVX3sn8SbDXKl5kqKemtABqxbBPaCmJW7T/fCcBQnVwl0+scPugZfXc4SZ7UhD1aBxRlbV2Ztf23O1YCnrRlOuwdTa/YGnKDhw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=qVU66crB; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="qVU66crB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729336572; bh=liu6AH5wskPRdG1LJazp0t8ejwo/RTs1GpUY5J41pVw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qVU66crBEtIarbBDM6UIaDebVYjVUIqq9OgLgGDj/8Plf7LeI/V/sFpOGlKHsdhph 5ZZYcIUQD8ImZqmXdLA3Uyyz5A9ifyoQUXHvNz3KQiZxB4kReTVC/2+OiyTZlvR77O cQ8xAZRL2dFGwrzDlTQvPpu/aEnGQvg8sYFCfZIcslV8FCJyD5UGMe+G1YpdKXINCQ aeNuUo4mr/DHSmje3jF2qm8scIs3dBfWutk5aTjGkaqGYNTcQvwb9He/TzdF9zPUvk bZYFBJcD/znLVQxZMtcP9szYy7cxKI0bPwaeTl7zUGlann8CCS/xylJdgPozDzxAdp vXBh9Ea7uMeyQ== Received: from localhost (unknown [188.24.146.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 699C017E35CB; Sat, 19 Oct 2024 13:16:12 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 19 Oct 2024 14:16:00 +0300 Subject: [PATCH v4 1/4] clk: Provide devm_clk_bulk_get_all_enabled() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241019-clk_bulk_ena_fix-v4-1-57f108f64e70@collabora.com> References: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> In-Reply-To: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> To: Michael Turquette , Stephen Boyd , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Jingoo Han , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.14.2 Commit 265b07df758a ("clk: Provide managed helper to get and enable bulk clocks") added devm_clk_bulk_get_all_enable() function, but missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument. Without knowing the number, it's not possible to iterate these clocks when needed, hence the argument is useless and could have been simply removed. Introduce devm_clk_bulk_get_all_enabled() variant, which is consistent with devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored =3D 0 if there are no clocks < 0 if an error occurred Moreover, the naming is consistent with devm_clk_get_enabled(), i.e. use the past form of 'enable'. To reduce code duplication and improve patch readability, make devm_clk_bulk_get_all_enable() use the new helper, as suggested by Stephen Boyd. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea --- drivers/clk/clk-devres.c | 28 +++++++++++++++++++--------- include/linux/clk.h | 24 ++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 9 deletions(-) diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index 82ae1f26e634572b943d18b8d86267f0a69911a6..975fac29b27f3709e292531a114= 975c9108287db 100644 --- a/drivers/clk/clk-devres.c +++ b/drivers/clk/clk-devres.c @@ -220,6 +220,15 @@ static void devm_clk_bulk_release_all_enable(struct de= vice *dev, void *res) =20 int __must_check devm_clk_bulk_get_all_enable(struct device *dev, struct clk_bulk_data **clks) +{ + int ret =3D devm_clk_bulk_get_all_enabled(dev, clks); + + return ret > 0 ? 0 : ret; +} +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable); + +int __must_check devm_clk_bulk_get_all_enabled(struct device *dev, + struct clk_bulk_data **clks) { struct clk_bulk_devres *devres; int ret; @@ -230,25 +239,26 @@ int __must_check devm_clk_bulk_get_all_enable(struct = device *dev, return -ENOMEM; =20 ret =3D clk_bulk_get_all(dev, &devres->clks); - if (ret > 0) { - *clks =3D devres->clks; - devres->num_clks =3D ret; - } else { + if (ret <=3D 0) { devres_free(devres); return ret; } =20 + *clks =3D devres->clks; + devres->num_clks =3D ret; + ret =3D clk_bulk_prepare_enable(devres->num_clks, *clks); - if (!ret) { - devres_add(dev, devres); - } else { + if (ret) { clk_bulk_put_all(devres->num_clks, devres->clks); devres_free(devres); + return ret; } =20 - return ret; + devres_add(dev, devres); + + return devres->num_clks; } -EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable); +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enabled); =20 static int devm_clk_match(struct device *dev, void *res, void *data) { diff --git a/include/linux/clk.h b/include/linux/clk.h index 851a0f2cf42c8c1bbada49d991bc185587942155..158c5072852e36c1583dc47ca75= 16fcdd928fe59 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -511,6 +511,24 @@ int __must_check devm_clk_bulk_get_all(struct device *= dev, int __must_check devm_clk_bulk_get_all_enable(struct device *dev, struct clk_bulk_data **clks); =20 +/** + * devm_clk_bulk_get_all_enabled - Get and enable all clocks of the consum= er (managed) + * @dev: device for clock "consumer" + * @clks: pointer to the clk_bulk_data table of consumer + * + * Returns a positive value for the number of clocks obtained while the + * clock references are stored in the clk_bulk_data table in @clks field. + * Returns 0 if there're none and a negative value if something failed. + * + * This helper function allows drivers to get all clocks of the + * consumer and enables them in one operation with management. + * The clks will automatically be disabled and freed when the device + * is unbound. + */ + +int __must_check devm_clk_bulk_get_all_enabled(struct device *dev, + struct clk_bulk_data **clks); + /** * devm_clk_get - lookup and obtain a managed reference to a clock produce= r. * @dev: device for clock "consumer" @@ -1040,6 +1058,12 @@ static inline int __must_check devm_clk_bulk_get_all= _enable(struct device *dev, return 0; } =20 +static inline int __must_check devm_clk_bulk_get_all_enabled(struct device= *dev, + struct clk_bulk_data **clks) +{ + return 0; +} + static inline struct clk *devm_get_clk_from_child(struct device *dev, struct device_node *np, const char *con_id) { --=20 2.47.0 From nobody Tue Nov 26 08:28:24 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFC6190688; Sat, 19 Oct 2024 11:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336577; cv=none; b=eG3cxL3YB4ZGFSFZ3uus/aUzh47fkfshAwQ82dKZPSZUw4VIlfEe9Rv/gEvwm2vP1aCPUUCXiVriB7fdDlN1KOKx0T7RbzOanhyjbND3ZLNiCRHGfm7Z9UqoZkKaLRfgFY066P4INrd0s+XzViyD28BBh8VV26jPOmz9sPEhlMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336577; c=relaxed/simple; bh=+ppoxTPO/igxME3lIs+D7CFzw+ePdaoHzXKCgEyp3Ig=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n2cYKJe9O9wgBZ3ouO8lF6/gcxUpU5bVmPUfZXMsSB8xhl2/UyOIF8hIpX0OtT5nZhSSx+zld582qgqc+f7OMaOvmTpYM96Obiz2cR6mgT5b9/rHE83i1MJO1cVxwW53wymiA2+nmDCj6K+7xRIYYsuysWZmA6VXYCC+1Ylmc/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=HvWq5L2j; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="HvWq5L2j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729336573; bh=+ppoxTPO/igxME3lIs+D7CFzw+ePdaoHzXKCgEyp3Ig=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=HvWq5L2jdWOetnT7uwg5JX4j6UctFRZk9UvbvGOmxo/oU8ES21dapAIV+BxNg2l+Y 0KipfkNVRtWaMEVF9Hoixyuy97phZIwcQZffAQGAIpTTJ3ux0OMRzgE4fA06nEd8mj w31bWqyfN7oRIAnl487pM5Wwmrjm2rgWLN+2l58ZFFGlJUay3SSgLK/lswz9Wl/Rg9 uGaaS0qS7qg4hWpy7Ly4pRmIpuU7p48s+j2QhrFOOuuTmSIz+FW5peiPAfkzTR9isx mpbkG6m6PRpsyjks1yhC1X9Sr0Zk96yuPbZssRvpFKgohAS9HcridZQh/RxjLLsLkl ADBYKCRQsl3yQ== Received: from localhost (unknown [188.24.146.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 27C2317E35D3; Sat, 19 Oct 2024 13:16:13 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 19 Oct 2024 14:16:01 +0300 Subject: [PATCH v4 2/4] soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241019-clk_bulk_ena_fix-v4-2-57f108f64e70@collabora.com> References: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> In-Reply-To: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> To: Michael Turquette , Stephen Boyd , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Jingoo Han , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.14.2 The helper devm_clk_bulk_get_all_enable() missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument and, therefore, will be dropped. Use the newly introduced devm_clk_bulk_get_all_enabled() variant instead, which is consistent with devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored =3D 0 if there are no clocks < 0 if an error occurred Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea --- drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index 9fdc0ef79202618d0bd0188d0bf53152285c6c51..0bcd8582637550c90c1c6df6190= 77b7df7bb0048 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2518,8 +2518,8 @@ static int pwrap_probe(struct platform_device *pdev) } } =20 - ret =3D devm_clk_bulk_get_all_enable(wrp->dev, &clk); - if (ret) + ret =3D devm_clk_bulk_get_all_enabled(wrp->dev, &clk); + if (ret < 0) return dev_err_probe(wrp->dev, ret, "failed to get clocks\n"); =20 --=20 2.47.0 From nobody Tue Nov 26 08:28:24 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E96341DEFC6; Sat, 19 Oct 2024 11:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336578; cv=none; b=Odt2Z8/+tkEAYGLEjnb+jKoyBSbm5Nz+hjOXKXd4ci5zwqrg60mmEewVyV3n/UdaHg8ZhQXx496GjIOWMXXl9VDCdhggDp4317dH5smE34HqwD/X4ILFMRpzp02RKZpQfjpUnSgAHoeJLXezykhHKiYzbyTUnoCrhR1j9RD+l0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336578; c=relaxed/simple; bh=iEUcW5EbPc3CuJsIl+m7Y0Zgw3NQlSs/GEI0BoftKtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GglBE+rsyo6GaFPpzjanS7IWAqmc5gG6Zplon3qc23Z55vabQmg1XIfWCvhkTc/pWjTtVcqVVzUkXYX4Us0e2Mvony13jvNEgsbbd+I3DRAK5w7//Xe1xKV3ghbGsYaOaDcnaBhY/5vnR2POzrgTokZgazBZTiyZse2qaPaPxQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=l+K7cjD/; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="l+K7cjD/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729336574; bh=iEUcW5EbPc3CuJsIl+m7Y0Zgw3NQlSs/GEI0BoftKtU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=l+K7cjD/pTs0weGajKDR9txdYrJWQmLpsz5ovpm+fdxl1yifaBF7e/x6TCdNIYw18 oDArNc35ONstfzKL5jttKHoGxfyeZnl7tOxtyUCUlcAQbOf3OVRb2E7m6kJtjAtSFg lME+5Ox/0eJr1tNmedv6dSSy8FHHolpRJ0uRKvNx+g+z2YOQBjkp00jx9efxZIVvAZ R5xsp3jEc1iVEJatT69AHe2eSEA5SSC2vHdFOJ1615UlUhqgjUzbLJlo5L4jDCOgJw B/PWsqE4K8+r3Zkt98B7KRJrZ3qQTkrwb46Iv2AJBGrEZBdCCojM3nhSJqc4FNAyoC vLuSym2o1NUnw== Received: from localhost (unknown [188.24.146.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id F34CE17E35DC; Sat, 19 Oct 2024 13:16:13 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 19 Oct 2024 14:16:02 +0300 Subject: [PATCH v4 3/4] PCI: exynos: Switch to devm_clk_bulk_get_all_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241019-clk_bulk_ena_fix-v4-3-57f108f64e70@collabora.com> References: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> In-Reply-To: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> To: Michael Turquette , Stephen Boyd , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Jingoo Han , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.14.2 The helper devm_clk_bulk_get_all_enable() missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument and, therefore, will be dropped. Use the newly introduced devm_clk_bulk_get_all_enabled() variant instead, which is consistent with devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored =3D 0 if there are no clocks < 0 if an error occurred Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea --- drivers/pci/controller/dwc/pci-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controll= er/dwc/pci-exynos.c index 6a830166d37fff5bbbc35aaa7cc1b67b03e6ec3b..ace736b025b1b7d4cdcbd51d2e9= d99af29f21149 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -300,7 +300,7 @@ static int exynos_pcie_probe(struct platform_device *pd= ev) if (IS_ERR(ep->elbi_base)) return PTR_ERR(ep->elbi_base); =20 - ret =3D devm_clk_bulk_get_all_enable(dev, &ep->clks); + ret =3D devm_clk_bulk_get_all_enabled(dev, &ep->clks); if (ret < 0) return ret; =20 --=20 2.47.0 From nobody Tue Nov 26 08:28:24 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00101DFDBF; Sat, 19 Oct 2024 11:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336578; cv=none; b=hV2SYimvwkf0G0tzgXg5e29gIt8T0B1L89d5vz/Yx6C2py1ix4ElL7l+3NSqSkJoKVj/moASOahQdn0f2TCgKTFz0XaoAMiuoJdyfCn1SKpgj9x7X5ePznrBZWxnzEUZIpqmj1aSRHiCrOhcMld+CU0EpTNEGrxFWeknyuELZ6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729336578; c=relaxed/simple; bh=nwnH2KnIkk1D0r4Y5YjAkX/ex3xblGmY05q5UghzuYc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nLy8GN9BQGtUzBwtwBm3koVzyzbf2zr9Yp7IddcPfuhM4TMcV4ZPvwv/YDLyZkLkIfuFh69unjQo4llmV7ihhsgl1trdhmAjzOgQT7muqEC+SEa1iaJvJPuTgPrMnn9737DdOXxPzxIFSaaRhaKjsbo5feFHZHyzk94V49yhce0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bWe+LYlJ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bWe+LYlJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729336574; bh=nwnH2KnIkk1D0r4Y5YjAkX/ex3xblGmY05q5UghzuYc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bWe+LYlJ+pQOag0E5xHE7EuueK+0GVC8RcVxylv8YC87PqUsSZm9vt4yZxVZiaPsH 9QBMh68gROeNvwwTxJggCHvEvRu0SJywBsp0KflY9zmDZdCUIqLSPigU7ePrJ+Wfhu 0hoQPGY4g4i704gw3dStPBsAGp3IlHpP7Op1A3pycDrwXgrNVuMt2aLFQAlCVRjtk6 WjCCNyNdDGYd+KO4SliUXTDSF3bIVNKEMM1PyW6fZALEZFvny0LNhUl/QlShjfrGEm TwMv5ia2KYeUyGZsqQ5/2stzj4hJsljgakdei/fwbq0bi31wFPNmNOXZKCvPngIbDw 11AnIgf7CRZ/w== Received: from localhost (unknown [188.24.146.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C188C17E35E0; Sat, 19 Oct 2024 13:16:14 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 19 Oct 2024 14:16:03 +0300 Subject: [PATCH v4 4/4] clk: Drop obsolete devm_clk_bulk_get_all_enable() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241019-clk_bulk_ena_fix-v4-4-57f108f64e70@collabora.com> References: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> In-Reply-To: <20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com> To: Michael Turquette , Stephen Boyd , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Jingoo Han , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.14.2 Commit 265b07df758a ("clk: Provide managed helper to get and enable bulk clocks") added devm_clk_bulk_get_all_enable() function, but missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument. Without knowing the number, it's not possible to iterate these clocks when needed, hence the argument is useless and could have been simply removed. A new helper devm_clk_bulk_get_all_enabled() has been introduced, which is consistent with devm_clk_bulk_get_all() in terms of the returned value. Drop the obsolete function since all users switched to the new helper. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea --- drivers/clk/clk-devres.c | 9 --------- include/linux/clk.h | 22 ---------------------- 2 files changed, 31 deletions(-) diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index 975fac29b27f3709e292531a114975c9108287db..0ae385403f9b08d29d0ec7cb206= 6f02d46cb90c9 100644 --- a/drivers/clk/clk-devres.c +++ b/drivers/clk/clk-devres.c @@ -218,15 +218,6 @@ static void devm_clk_bulk_release_all_enable(struct de= vice *dev, void *res) clk_bulk_put_all(devres->num_clks, devres->clks); } =20 -int __must_check devm_clk_bulk_get_all_enable(struct device *dev, - struct clk_bulk_data **clks) -{ - int ret =3D devm_clk_bulk_get_all_enabled(dev, clks); - - return ret > 0 ? 0 : ret; -} -EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable); - int __must_check devm_clk_bulk_get_all_enabled(struct device *dev, struct clk_bulk_data **clks) { diff --git a/include/linux/clk.h b/include/linux/clk.h index 158c5072852e36c1583dc47ca7516fcdd928fe59..b607482ca77e987b9344c38f25e= bb5c8d35c1d39 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -495,22 +495,6 @@ int __must_check devm_clk_bulk_get_optional(struct dev= ice *dev, int num_clks, int __must_check devm_clk_bulk_get_all(struct device *dev, struct clk_bulk_data **clks); =20 -/** - * devm_clk_bulk_get_all_enable - Get and enable all clocks of the consume= r (managed) - * @dev: device for clock "consumer" - * @clks: pointer to the clk_bulk_data table of consumer - * - * Returns success (0) or negative errno. - * - * This helper function allows drivers to get all clocks of the - * consumer and enables them in one operation with management. - * The clks will automatically be disabled and freed when the device - * is unbound. - */ - -int __must_check devm_clk_bulk_get_all_enable(struct device *dev, - struct clk_bulk_data **clks); - /** * devm_clk_bulk_get_all_enabled - Get and enable all clocks of the consum= er (managed) * @dev: device for clock "consumer" @@ -1052,12 +1036,6 @@ static inline int __must_check devm_clk_bulk_get_all= (struct device *dev, return 0; } =20 -static inline int __must_check devm_clk_bulk_get_all_enable(struct device = *dev, - struct clk_bulk_data **clks) -{ - return 0; -} - static inline int __must_check devm_clk_bulk_get_all_enabled(struct device= *dev, struct clk_bulk_data **clks) { --=20 2.47.0