From nobody Tue Nov 26 10:26:44 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C92F2746B for ; Fri, 18 Oct 2024 15:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729264136; cv=none; b=MDBIfvr3hzL4VHf6B4dUdc5doKhWFtu+OYxOR1IefuOXYKISK6QbWum/hgGoQL3bxKLaor7mj9NDaeQKEh2jEWa+rIxsG7vYCUrwrTY4B46O8QTk5MuPE9/tqzFiokd/pi1bWIzCEr9ywBStrRpMqsci7L8sQ8F6QtRYL6A4hzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729264136; c=relaxed/simple; bh=latyxkadioFYo8ef1ZgGf1RqY2UASR0JhFNU12tkpec=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Q6I5Cso3rDNa7sNUjETZQDNms0EZv+Q7ZXiUlRc64fGyv1V6wnST0/Gydt7LDMRbBISlGePfAviMQvt1+fe1Qn7mWTANIb6RGxFL9DV8YgyEe832XnFm6fMH6jzygQJ8g7f4OUt+inSwtI8N0v47wxn6L2Zkgn5PmxO05GSGpDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C4DnIe2D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C4DnIe2D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43ECDC4CEC3; Fri, 18 Oct 2024 15:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729264136; bh=latyxkadioFYo8ef1ZgGf1RqY2UASR0JhFNU12tkpec=; h=From:To:Cc:Subject:Date:From; b=C4DnIe2DzJVIt7yxvdCcvRJ8TX2cwMtXPLpRvalEy5uc4PHdNmq4I0nXgVfutkJZg 7RIGXcv9d1jRThiGiIpyvyD7SZDosUOJ3OCjSVOC7yFpNemmrQ8zzOxfV466nXqx3/ 0vjTIn8LNtcFka+u3VUUVuNTknhdlQcdArm8v5ceYNjCW/Sw78QoI51VBe4mMGBn6Q G4suXjg5164IcWmV6KDSqfyKIsEC1nLoBjGYbwWHc7z5VXF6L+KZHHPUrjUJVK3zMM 3yef58A3BPvdFlzwZwYZnSnWsjdvPqDS/n5sZ7ARQz8m6Fz2DIop7EGaZrffpZRejv gecmkvYdIp9Ig== From: Arnd Bergmann To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Philipp Zabel Cc: Arnd Bergmann , Jani Nikula , Geert Uytterhoeven , Imre Deak , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge-connector: select DRM_DISPLAY_HELPER from DRM_BRIDGE_CONNECTOR Date: Fri, 18 Oct 2024 15:08:45 +0000 Message-Id: <20241018150850.3418359-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The imx display drivers use the new bridge connector helpers but don't explicitly select CONFIG_DRM_DISPLAY_HELPER, leading to a link failure in rare configurations: ld.lld-20: error: undefined symbol: drm_bridge_connector_init >>> referenced by imx-ldb.c >>> drivers/gpu/drm/imx/ipuv3/imx-ldb.o:(imx_ldb_bind) in arc= hive vmlinux.a >>> referenced by parallel-display.c >>> drivers/gpu/drm/imx/ipuv3/parallel-display.o:(imx_pd_bind= ) in archive vmlinux.a Move DRM_BRIDGE_CONNECTOR out of the DRM_DISPLAY_HELPER block and instead select that symbol indirectly. Fixes: f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridg= e / drm_bridge_connector") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/display/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kcon= fig index 0f07cf1483ff..beb05d9bab50 100644 --- a/drivers/gpu/drm/display/Kconfig +++ b/drivers/gpu/drm/display/Kconfig @@ -11,14 +11,15 @@ config DRM_DISPLAY_HELPER help DRM helpers for display adapters. =20 -if DRM_DISPLAY_HELPER - config DRM_BRIDGE_CONNECTOR bool select DRM_DISPLAY_HDMI_STATE_HELPER + select DRM_DISPLAY_HELPER help DRM connector implementation terminating DRM bridge chains. =20 +if DRM_DISPLAY_HELPER + config DRM_DISPLAY_DP_AUX_CEC bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" select DRM_DISPLAY_DP_HELPER --=20 2.39.5