From nobody Tue Nov 26 10:45:42 2024 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B740202F6E; Fri, 18 Oct 2024 13:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258899; cv=none; b=CCmHCEnAkk6PXeOiVhnC0/GdRG/kMmYLrYCtUWKlGeKmJMacNLjZ3Jkv9QaGKwd8759cx+JLvQEovzhwPN7O31Z2ABwG4HWuS+2p6MRwzKsLCA0eobAXbWlrAcFluth7N7srhOfKS7TnhUVdYWRDOwH806ARHmWlhPpfuQ/NjFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258899; c=relaxed/simple; bh=p+LcWe4Pxmo+7KAiEvXg9Bx598A+WiRwIXC7KBxOeyc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qkhWk4LIFDPr5rasZpTseHKWEbPZQGOhXUX9GlMgODVH7s1s75/ZNAtyWKD22vwH/jeaS3Ek9LyIVefsc9rBVfqkgL+/0XOiS4PwxH+5oNyUvwwZJS18DfHxgtj2VppXK9OBV5iIZzpQc/m6JkcfBssBiffk7faaUio4Klgl8PU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BbiwEaOr; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BbiwEaOr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729258898; x=1760794898; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p+LcWe4Pxmo+7KAiEvXg9Bx598A+WiRwIXC7KBxOeyc=; b=BbiwEaOr+d8WJOHBnNxUQ5qzJZOGeASNVQLb+Pc9Cbl0MlQI9s79Ytwc 1Hy9JaDoGG1GyiYgyYX+aISTE98n2XIJAGIijZJCSwTJORUNiM3+dKa3S q9uZQ8T6+csDeGH9CDLKBbSdJf1Omh4tGRmPrCyEEXFe6pvzFH0tyGfP4 5U9O+0PZzjL09PsWzrFL7O3yJUa9lBO/n52pszTExaBemIdQwrdLlzjo0 IGFNrA8aIRZd5cQEexR6cWlAPM3IxFEF/v+rqCIHiAzn0LubpQSsgJUqp NyYRJT/i4xS3JmirmnWc+96x9hoqxSsvXwIfqC+Pvi5ePAnkZjoMckR5Z g==; X-CSE-ConnectionGUID: 9ee6BAucSG6M7q1z0hRXLQ== X-CSE-MsgGUID: 5S3Ln1WNQnu1aYhomFhWKw== X-IronPort-AV: E=McAfee;i="6700,10204,11229"; a="28251461" X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="28251461" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 06:41:33 -0700 X-CSE-ConnectionGUID: ZsxW+LyIR0qVZ4VDwo2zXg== X-CSE-MsgGUID: Ksh33eSHQY2jVhg2YK4KLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="83935284" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa004.jf.intel.com with ESMTP; 18 Oct 2024 06:41:31 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 12235343; Fri, 18 Oct 2024 16:41:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 1/4] gpio: xgene-sb: Remove unneeded definitions for properties Date: Fri, 18 Oct 2024 16:32:32 +0300 Message-ID: <20241018134129.2058068-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> References: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are three definitions for the property names. Remove them as: 1) each of them is only used once; 2) in all cases the definition is longer than the value. In the result code is better and grepping on the property immediately gets the function in which is being used which helps to guess the type of the value. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xgene-sb.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 836fcf1c82fe..ae592528001d 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -17,11 +17,6 @@ =20 #include "gpiolib-acpi.h" =20 -/* Common property names */ -#define XGENE_NIRQ_PROPERTY "apm,nr-irqs" -#define XGENE_NGPIO_PROPERTY "apm,nr-gpios" -#define XGENE_IRQ_START_PROPERTY "apm,irq-start" - #define XGENE_DFLT_MAX_NGPIO 22 #define XGENE_DFLT_MAX_NIRQ 6 #define XGENE_DFLT_IRQ_START_PIN 8 @@ -252,18 +247,17 @@ static int xgene_gpio_sb_probe(struct platform_device= *pdev) =20 /* Retrieve start irq pin, use default if property not found */ priv->irq_start =3D XGENE_DFLT_IRQ_START_PIN; - if (!device_property_read_u32(&pdev->dev, - XGENE_IRQ_START_PROPERTY, &val32)) + if (!device_property_read_u32(&pdev->dev, "apm,irq-start", &val32)) priv->irq_start =3D val32; =20 /* Retrieve number irqs, use default if property not found */ priv->nirq =3D XGENE_DFLT_MAX_NIRQ; - if (!device_property_read_u32(&pdev->dev, XGENE_NIRQ_PROPERTY, &val32)) + if (!device_property_read_u32(&pdev->dev, "apm,nr-irqs", &val32)) priv->nirq =3D val32; =20 /* Retrieve number gpio, use default if property not found */ priv->gc.ngpio =3D XGENE_DFLT_MAX_NGPIO; - if (!device_property_read_u32(&pdev->dev, XGENE_NGPIO_PROPERTY, &val32)) + if (!device_property_read_u32(&pdev->dev, "apm,nr-gpios", &val32)) priv->gc.ngpio =3D val32; =20 dev_info(&pdev->dev, "Support %d gpios, %d irqs start from pin %d\n", --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Tue Nov 26 10:45:42 2024 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF770202F65; Fri, 18 Oct 2024 13:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258899; cv=none; b=TGEv4TXV40WCFffHjkTkvFtnAquQtAzffe/hK8a3KpUPPL3asUK0s50ask5iMpm7Vz4JEVtTc6K008IuMeo7piQQjSyoukcAqboeRVW/3f+2Vkvnscz5V7+F0M/HJJvMdYV8HwLjRYWC3QNBLGa+BOcukauEtV3Vw4tVZuWOwuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258899; c=relaxed/simple; bh=EYNNF+5aJRFe9/tUlCRhCAsCUJZjtEJ1sW7ZwuGiSQU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kVGDFHjL4dnQNrZ2WQm0SfLI8FZn/4WPdwa877DfBufh8mIARDOwVbYSCaE9Ko5ZrfmFvTTbL16ghAMp77w+Lv9Z5WXRYB4VItAw1nm0/G4jqVVOIKvTl6G9bRIwaQgPNCFtqJXYBS6Jpq0MwDu9z2ujQ7lgTrnie62/IVqRh+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YOz9Rrwa; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YOz9Rrwa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729258897; x=1760794897; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EYNNF+5aJRFe9/tUlCRhCAsCUJZjtEJ1sW7ZwuGiSQU=; b=YOz9Rrwa/JeY56fLKrag+kwG2r/kBtOHdeJ1dcipLCOyJRuErge9KXhF 8C+3rBqpoOurHf7qJmYwuRKO9yFAsoyi5r5Usd4MNwUqhgFnx5VgT9nQh mhr9YnJNUF7Idq0oOG0OoB80QYUx9XUoEE1BZ2pSrPa0p/qXNxfyPz4/J HRpgkqZ23H8dWPf0PyvK+d7TjCrblld3b56JJWGz8kIpWWg55Q46AzLR+ jLeyV6Wyoi6hN/t9sSmU+8CeXaIiLkp36v2bgCghJBtYGkbTvLlL7NrBO I5yE4H2deyZgS+S5K1W+7ZmJ/okLPTGFYBW7+r88VtK5vdAyEhzLUzFGq Q==; X-CSE-ConnectionGUID: y6sjlCbzRNylONXQ8qBpCQ== X-CSE-MsgGUID: +1aueQgDSlK66k7fExfGLg== X-IronPort-AV: E=McAfee;i="6700,10204,11229"; a="28251458" X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="28251458" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 06:41:33 -0700 X-CSE-ConnectionGUID: Df6Dh2ONTayY881pcVzUEQ== X-CSE-MsgGUID: UuOCaxT0S32+i1Gn8ngs+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="83935282" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa004.jf.intel.com with ESMTP; 18 Oct 2024 06:41:31 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1BF8B503; Fri, 18 Oct 2024 16:41:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 2/4] gpio: xgene-sb: don't use "proxy" headers Date: Fri, 18 Oct 2024 16:32:33 +0300 Message-ID: <20241018134129.2058068-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> References: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xgene-sb.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index ae592528001d..69faf9b8d460 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -8,12 +8,19 @@ * Quan Nguyen . */ =20 -#include +#include +#include #include +#include +#include +#include +#include #include #include +#include +#include + #include -#include =20 #include "gpiolib-acpi.h" =20 --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Tue Nov 26 10:45:42 2024 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DE5E1DFDAC; Fri, 18 Oct 2024 13:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258895; cv=none; b=Jgxo+oRI/+Cu/tUpSJengZrR9FbIHU40/Ro5wbMfATDfzR4OyQcYyXokRig2j8a1cWZEXkEAKCiWkWaGZs9zH7/5DyRDJBwL0MSUAZuyxxUctUO3f8/DgckhLAxPXlRZ0PGtTsEUKYlGw67j6wu3VbCrHLGnJ8oeYisihJXctlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258895; c=relaxed/simple; bh=L5LBOWRbs6RQyopASyxlp/rwUvKWPtIoKIfUqFcMlhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iKfOvo5e8M2hRfOXY10oV7Zdj1D3imNdeX1ude0jGKXsdsaEBCleKlp5EOK7ljxHEo6+/TLeGu2hVMRiCofjSRgCfAYovvi5DtgNpTyAjxWoENHHAYa1zT+tqMtEIpinbpB3TeNFE57OCCn62j1LwRZrYK4p1nMMYHt2QhGyQcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fCRJHyix; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fCRJHyix" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729258893; x=1760794893; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L5LBOWRbs6RQyopASyxlp/rwUvKWPtIoKIfUqFcMlhI=; b=fCRJHyix//Qedbi1mm9kSsUFgaeUgX34ZGmtl5FLcrxcJVh1SrifNXbQ Bci8POZsyufLG64QQdQ+ROmo3yysMlZsDoCdbEANQgUboMlhz+cJJyxdU yeWMirm3ReanvXUFwadgEIpcgrGwB4hWUVonfhMSiImFQ/fs8HmY9ZkEb 0Pdxh+9Ew89cCxBHQgzzcxzEdWq9MLxP0CWtifI8aDCcq37Dsh5jHNcYk UWJZESbsNbutAPI4l1tQAXxnIjB/Mphs3MskMP0rKeHZIIA3ypdf4wk7+ FxBsRj3FQvhTI/V2XlwqXFgm3jaoU3rkEhBA2h+VfDugx8Cohr4AB1mzw Q==; X-CSE-ConnectionGUID: E3rvXA7tRJS66hgYvE8Bag== X-CSE-MsgGUID: LDZ0YgZ1RnCIHTpbM/LLKg== X-IronPort-AV: E=McAfee;i="6700,10204,11229"; a="28251447" X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="28251447" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 06:41:32 -0700 X-CSE-ConnectionGUID: 3CDAcyrCTpCcu9jpJNI0tQ== X-CSE-MsgGUID: KwAS7hqsTrSZAbt/N55Oxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="83935280" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa004.jf.intel.com with ESMTP; 18 Oct 2024 06:41:31 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2E0A75A7; Fri, 18 Oct 2024 16:41:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 3/4] gpio: xgene-sb: Drop ACPI_PTR() and CONFIG_ACPI guards Date: Fri, 18 Oct 2024 16:32:34 +0300 Message-ID: <20241018134129.2058068-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> References: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The complexity of config guards needed for ACPI_PTR() is not worthwhile for the small amount of saved data. This example was doing it correctly but I am proposing dropping this so as to reduce chance of cut and paste where it is done wrong. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xgene-sb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 69faf9b8d460..0ebe3b215634 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -311,20 +311,18 @@ static const struct of_device_id xgene_gpio_sb_of_mat= ch[] =3D { }; MODULE_DEVICE_TABLE(of, xgene_gpio_sb_of_match); =20 -#ifdef CONFIG_ACPI static const struct acpi_device_id xgene_gpio_sb_acpi_match[] =3D { {"APMC0D15", 0}, {}, }; MODULE_DEVICE_TABLE(acpi, xgene_gpio_sb_acpi_match); -#endif =20 static struct platform_driver xgene_gpio_sb_driver =3D { .driver =3D { .name =3D "xgene-gpio-sb", .of_match_table =3D xgene_gpio_sb_of_match, - .acpi_match_table =3D ACPI_PTR(xgene_gpio_sb_acpi_match), - }, + .acpi_match_table =3D xgene_gpio_sb_acpi_match, + }, .probe =3D xgene_gpio_sb_probe, .remove =3D xgene_gpio_sb_remove, }; --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Tue Nov 26 10:45:42 2024 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17EA41F4265; Fri, 18 Oct 2024 13:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258897; cv=none; b=HpbG6u9FEto6JMf7vu+6bNaDqocNTnezIeFGGjKp9qpu9fXlVtpeTZesqPsenvmAgpdgAfjAVuIb94ULJVOmKg08AEkXL428eyGPhS7bhqKuVJtTeVh9guilkZ+mqCuaxdVloEvuX4OGM/ktkeEWGcjOkQTL55ps3i6eAdg4txA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729258897; c=relaxed/simple; bh=BMKOrCU5z2rmEQgUEoHRlV/x9cOoFl97PDC+MzdSL7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TxeJZjMSmi6n7mpGQpndWbiKZWKLBl7zXkCXIv1njMcwgX8qsPXYlM4M7mzNdJ34hx9ayHoqaVdd+v2aLBJRQErjAH5loeheFj/O6B/ET8ob1za+Aer5MU/WabTbkH3sqMlNoNh6GMRNHey/3IqccDltkok5FsqKKxzwYYC7Bv0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DY2QMddy; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DY2QMddy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729258896; x=1760794896; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BMKOrCU5z2rmEQgUEoHRlV/x9cOoFl97PDC+MzdSL7I=; b=DY2QMddy/lBFle06w8ZtK4p2j0fdXx7bGqMry9obw1EXfsuI2rnOTuP5 stWPhs2vRb6L7xwhkV7VtGzntdqsLsvNynlWrwW0XANeRSWBccrpNdPXq ymi7vsXK5WRplCs0GoSfjTaiMlBeWydAHya7FiEfaTZlcImx6M8l4RZWK SfJpqtJ/nxZ9M0LcHMBOa4EBqIzQ3X9157MMOJRggLWDKDMRZ7Y7XPTz6 mpMFxLf5bfa4PQ9CvXMhThVYxLNt7WRroKwoto2ynsJ8a/oI/YPWByqhb c2wywdawlzsCYLDKnY8Cz5TKpQIg6WyispSIY0V/ipUmM8uWel5z5pbNv w==; X-CSE-ConnectionGUID: IZdl7NxqRjKt8nOh/zY+Gw== X-CSE-MsgGUID: l0rt+2IJRLy0+OOGLmoT1A== X-IronPort-AV: E=McAfee;i="6700,10204,11229"; a="28251454" X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="28251454" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 06:41:33 -0700 X-CSE-ConnectionGUID: 34YAGRVcT92LgWs0LEtLug== X-CSE-MsgGUID: JMM3dTlJTRqkT/MJVPSerQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="83935283" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa004.jf.intel.com with ESMTP; 18 Oct 2024 06:41:31 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 38FDE5C3; Fri, 18 Oct 2024 16:41:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 4/4] gpio: xgene-sb: Tidy up ACPI and OF ID tables Date: Fri, 18 Oct 2024 16:32:35 +0300 Message-ID: <20241018134129.2058068-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> References: <20241018134129.2058068-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tidy up the ACPI and OF ID tables: - remove explicit driver_data initializer - drop comma in the terminator entry Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xgene-sb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 0ebe3b215634..48b829733b15 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -306,14 +306,14 @@ static void xgene_gpio_sb_remove(struct platform_devi= ce *pdev) } =20 static const struct of_device_id xgene_gpio_sb_of_match[] =3D { - {.compatible =3D "apm,xgene-gpio-sb", }, - {}, + { .compatible =3D "apm,xgene-gpio-sb" }, + {} }; MODULE_DEVICE_TABLE(of, xgene_gpio_sb_of_match); =20 static const struct acpi_device_id xgene_gpio_sb_acpi_match[] =3D { - {"APMC0D15", 0}, - {}, + { "APMC0D15" }, + {} }; MODULE_DEVICE_TABLE(acpi, xgene_gpio_sb_acpi_match); =20 --=20 2.43.0.rc1.1336.g36b5255a03ac