From nobody Tue Nov 26 14:31:39 2024 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5081757F3; Fri, 18 Oct 2024 02:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729218052; cv=none; b=WDryJY1ZdWJz6S/HyJtS/zzch9cDOz85ktZ9LjZrkkwagQPdhgc432ulSOjBf3BLznTnPiCjd0pMzqYNVdgORvudS7Yx5rr+7K64dD68+E5uzMTtWSb6X0xgN/ZJHz26NPb48Pfs0z8gmbsrusoo1ptIqzUujGalhG3WdAL1iso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729218052; c=relaxed/simple; bh=/P2lHO5vWncBAOwBlvr/1osZQXMBtbNHEmnzYnt4CWg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hx/q0oA08pwTP3jCET+swSpTQ51vz/9Ki88MtwJONLZm6D9Y+d9VVk89vfYnF+CxIfsw0GV5tdhs2aa1irFoo+UselR5eL8aaiPlz+VF4szVzzr5EKC9RwgOOXTAQzVGOFbDA+Hs0mbgbhOG7Kk0UB4sgsHwtRa1N1ekOH9TwiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XV7cJ2K2lz1HLC6; Fri, 18 Oct 2024 10:16:32 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 735161400FD; Fri, 18 Oct 2024 10:20:47 +0800 (CST) Received: from huawei.com (10.175.101.6) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 18 Oct 2024 10:20:46 +0800 From: Yue Haibing To: , , , , , , , , , , , , , , , , , CC: , , , , Subject: [PATCH v2 net 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp() Date: Fri, 18 Oct 2024 10:37:32 +0800 Message-ID: <20241018023734.1912166-3-yuehaibing@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241018023734.1912166-1-yuehaibing@huawei.com> References: <20241018023734.1912166-1-yuehaibing@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf500002.china.huawei.com (7.185.36.57) Content-Type: text/plain; charset="utf-8" igb_run_xdp() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in igb_clean_rx_irq(). Remove this error pointer handing instead use plain int return value. Fixes: 9cbc948b5a20 ("igb: add XDP support") Signed-off-by: Yue Haibing Reviewed-by: Maciej Fijalkowski --- drivers/net/ethernet/intel/igb/igb_main.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethern= et/intel/igb/igb_main.c index f1d088168723..50c23dfcf304 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -8584,9 +8584,8 @@ static struct sk_buff *igb_build_skb(struct igb_ring = *rx_ring, return skb; } =20 -static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter, - struct igb_ring *rx_ring, - struct xdp_buff *xdp) +static int igb_run_xdp(struct igb_adapter *adapter, struct igb_ring *rx_ri= ng, + struct xdp_buff *xdp) { int err, result =3D IGB_XDP_PASS; struct bpf_prog *xdp_prog; @@ -8626,7 +8625,7 @@ static struct sk_buff *igb_run_xdp(struct igb_adapter= *adapter, break; } xdp_out: - return ERR_PTR(-result); + return result; } =20 static unsigned int igb_rx_frame_truesize(struct igb_ring *rx_ring, @@ -8752,10 +8751,6 @@ static bool igb_cleanup_headers(struct igb_ring *rx_= ring, union e1000_adv_rx_desc *rx_desc, struct sk_buff *skb) { - /* XDP packets use error pointer so abort at this point */ - if (IS_ERR(skb)) - return true; - if (unlikely((igb_test_staterr(rx_desc, E1000_RXDEXT_ERR_FRAME_ERR_MASK)))) { struct net_device *netdev =3D rx_ring->netdev; @@ -8879,6 +8874,7 @@ static int igb_clean_rx_irq(struct igb_q_vector *q_ve= ctor, const int budget) struct xdp_buff xdp; u32 frame_sz =3D 0; int rx_buf_pgcnt; + int xdp_res =3D 0; =20 /* Frame size depend on rx_ring setup when PAGE_SIZE=3D4K */ #if (PAGE_SIZE < 8192) @@ -8936,12 +8932,10 @@ static int igb_clean_rx_irq(struct igb_q_vector *q_= vector, const int budget) /* At larger PAGE_SIZE, frame_sz depend on len size */ xdp.frame_sz =3D igb_rx_frame_truesize(rx_ring, size); #endif - skb =3D igb_run_xdp(adapter, rx_ring, &xdp); + xdp_res =3D igb_run_xdp(adapter, rx_ring, &xdp); } =20 - if (IS_ERR(skb)) { - unsigned int xdp_res =3D -PTR_ERR(skb); - + if (xdp_res) { if (xdp_res & (IGB_XDP_TX | IGB_XDP_REDIR)) { xdp_xmit |=3D xdp_res; igb_rx_buffer_flip(rx_ring, rx_buffer, size); @@ -8960,7 +8954,7 @@ static int igb_clean_rx_irq(struct igb_q_vector *q_ve= ctor, const int budget) &xdp, timestamp); =20 /* exit if we failed to retrieve a buffer */ - if (!skb) { + if (!xdp_res && !skb) { rx_ring->rx_stats.alloc_failed++; rx_buffer->pagecnt_bias++; break; @@ -8974,7 +8968,7 @@ static int igb_clean_rx_irq(struct igb_q_vector *q_ve= ctor, const int budget) continue; =20 /* verify the packet layout is correct */ - if (igb_cleanup_headers(rx_ring, rx_desc, skb)) { + if (xdp_res || igb_cleanup_headers(rx_ring, rx_desc, skb)) { skb =3D NULL; continue; } --=20 2.34.1