From nobody Tue Nov 26 11:50:58 2024 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C05A2032A for ; Fri, 18 Oct 2024 12:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729252995; cv=none; b=N/GAs6sPGbPj/LUumJuy7dqihg20xqXa7kMbSjkT42r3pmJG0AJziEwXgSMIFGUtYJ87NJjj+3s9BvFCxRTFj7ozdNVejMGdHK1tAFjJGfC7lm96TDyRc1oLzndgHA6mUVb5rkhpBHdOGrD1gNaHoiNqewg85XHfRm0+MiQk4tY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729252995; c=relaxed/simple; bh=hNoTBErVoPI3sr4GvnFFK7rrLhzYBTpq+ocPOGBcaKU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nr9aKxjSItZWwWRg9c+eesaYRKlkp3d82Lwmnf03YmShmgGxwKwUpbu6UGhxrfYXATgUiDTe4atuWnuVPYhpotpZtGXDCbhw4B0iI1z6TVuAjTmgTG/jhb3f+D6UvAoF7fLJWntgVbWZ166JBKNaUbnhN1pK23ww0P4uRkj4W0I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QlR1Wae5; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QlR1Wae5" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-718e9c8bd83so2264867b3a.1 for ; Fri, 18 Oct 2024 05:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729252993; x=1729857793; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EYlu7kUyVVFvizFrzeSTtKVIpspDxNh9CaA9Lpt1VR8=; b=QlR1Wae5PZ0CNSvrSpd5w3rBqcCBbB4TPgM3hK9ymMtsTYT/IAsmwhZROaLQUC3VSA ZlbmcNszLyK+sONaXLbqFQ8Kttr4W4LHZnvjz99/ROLcLaYk9uVJdwttpxEfz30syJxg vp5hJ1flyCKIsll8VZGOmP0xJmoP0LfrCym8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729252993; x=1729857793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EYlu7kUyVVFvizFrzeSTtKVIpspDxNh9CaA9Lpt1VR8=; b=qc0ZWFkZRlsXt2SJMl/1lN/rRGZekSbO6GA+R7HYjW4SB4U3P1JTK5x+AiRsk8eeYp UnwAx7aB1syiVwi4TEpZlmPRUNVwxUPVmMkTbx8UE5jJjBl5GsXMNYx2Ir4E8Ugb2lm4 A/q9G7SQf4c8HfOcqDXAG+vi4YolmXeqnhSjixK/KvOGyAwWI1axppFduC+7zmM1HzYc 7Yi0crKqk0v8VbvCN23fiRnOpuwj+uDNlsA2DlF+PJl3r8wVuzL+Ed6DROPCWZPBlH5W Ml8nyJfip+ACQ1Z/nN69Kz8hEd/M60tZ1/iVX3XZAQpiSVtByh0rV2W8qk/VkH6n0HY8 Q5NA== X-Forwarded-Encrypted: i=1; AJvYcCW6dyH9oGOj3eIsZEE+Nwr4lWXEELynYVvEPmtUG/ssImjspFuCGTfDyQWnb4ImG6e74u4e+D/arNrHU1o=@vger.kernel.org X-Gm-Message-State: AOJu0YzubT7QNVw7jOuLtKar3pZyzP2gn65IYMhCTQ/QSb4pZKwsT2Mu Kzn9QNOCZFzmJna9gWck0EI6GsCq4Em2ELTUGl1e7iRj8VJ6jNQxbLvargQT+w== X-Google-Smtp-Source: AGHT+IEGcDG3wlVNeyTnkESm9SQYHh/INABqC103bGWJJBZMyFepMcJaZpMON7AKaGrz5XrQO641SA== X-Received: by 2002:a05:6a00:2c5:b0:71e:674b:474 with SMTP id d2e1a72fcca58-71e8fd72e7amr9523466b3a.8.1729252992874; Fri, 18 Oct 2024 05:03:12 -0700 (PDT) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea34ae672sm1274014b3a.204.2024.10.18.05.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 05:03:12 -0700 (PDT) From: Hsin-Te Yuan Date: Fri, 18 Oct 2024 12:03:04 +0000 Subject: [PATCH 1/2] arm64: dts: mediatek: mt8183: Fix race condition of pinctrl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241018-post-reset-v1-1-5aadb7550037@chromium.org> References: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> In-Reply-To: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f Some mt8183 devices use second source touchscreen/trackpad and share the same pinctrl property with the original touchscreen/trackpad. Currently, multiple touchscreen/trackpad drivers might probe simultaneously, causing a race condition of getting the same pin. Move the pinctrl property to the i2c node to workaround this issue. Fixes: dd6e3b06214f ("arm64: dts: mt8183: Add kukui-jacuzzi-burnet board") Fixes: 52e84f233459 ("arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board") Fixes: 6cd7fdc8c530 ("arm64: dts: mt8183: Add kukui-jacuzzi-fennel board") Fixes: 124d64392de2 ("arm64: dts: mt8183: Add kukui-jacuzzi-juniper board") Fixes: f006bcf1c972 ("arm64: dts: mt8183: Add kukui-jacuzzi-willow board") Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board") Signed-off-by: Hsin-Te Yuan --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++---= ---- 12 files changed, 3 insertions(+), 35 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts b= /arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts index 19c1e2bee494c98c0db87308494713a26e304cd2..32ec6fd30fdb7449e9e606f69d1= 6556bcdecc369 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts @@ -21,8 +21,6 @@ &i2c0 { touchscreen@2c { compatible =3D "hid-over-i2c"; reg =3D <0x2c>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; =20 post-power-on-delay-ms =3D <200>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts b/= arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts index f34964afe39b5353de7b17e82d14d1fba88551ab..b75ab2d33550808196f2d1d4bf0= d34ccb713a07a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts @@ -23,9 +23,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/a= rch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index 0b45aee2e29953b6117b462034a00dff2596b9ff..ebe6e161354c414d91859494ec9= 295db75a3baf9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -19,8 +19,6 @@ &touchscreen { compatible =3D "hid-over-i2c"; reg =3D <0x10>; interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; =20 post-power-on-delay-ms =3D <10>; hid-descr-addr =3D <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 72852b7600383972d98d9b0edd40b6e99e34a85b..2dc64cc539f815b9848b8243e5b= 487f22d605a6d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -32,8 +32,6 @@ &touchscreen { compatible =3D "hid-over-i2c"; reg =3D <0x10>; interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; =20 post-power-on-delay-ms =3D <10>; hid-descr-addr =3D <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 757d0afd14fb064fc1de4608e65eb1a561c4dfa6..53e996f9c605dc36df03d4b0051= a91e19fefb38d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -19,8 +19,6 @@ &touchscreen { compatible =3D "hid-over-i2c"; reg =3D <0x10>; interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; =20 post-power-on-delay-ms =3D <10>; hid-descr-addr =3D <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index 6641b087e7c5f3a957e43ac985137dfd84ac7878..d7db621383c6b823af08ca07e07= 94758d062e211 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -19,8 +19,6 @@ &touchscreen { compatible =3D "hid-over-i2c"; reg =3D <0x10>; interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; =20 post-power-on-delay-ms =3D <10>; hid-descr-addr =3D <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi = b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi index bbe6c338f465ee7c11bfbfc30767bdb142706480..e5b51b27980ae90a8f1099f71a8= 91bb0562a375a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi @@ -16,9 +16,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi= b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi index 078bc765646f57fd8c55e97325893ab50e4dac51..a96c64a9251044b2c1ba4289467= b411e6c744abe 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi @@ -12,9 +12,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts b/a= rch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts index 8ce9568fee95a6faba0c238f6c43f43948c26d9b..2c740b3e5d3d91980ed89e07a6b= e70ff51906145 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts @@ -25,9 +25,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/= arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts index cce326aec1aa594deb6f5b14340d3552d110b160..bce368fcc884008086c091a29e3= f69e541215ee5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts @@ -38,9 +38,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi = b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi index 76d33540166f900c99c419c4f97ca0a56cf658f5..9b1600d5c4c1247c97fd59aa760= 3eaa835420117 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi @@ -12,9 +12,6 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/= arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 783c333107bcbf7368398feae0a29e5f0ee50c19..65f70627f2dcc4af832b8a08f7c= dce354c800fae 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -100,14 +100,13 @@ &dsi_out { =20 &i2c0 { status =3D "okay"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&touchscreen_pins>; =20 touchscreen: touchscreen@10 { compatible =3D "elan,ekth3500"; reg =3D <0x10>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&touchscreen_pins>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; =20 reset-gpios =3D <&pio 156 GPIO_ACTIVE_LOW>; @@ -116,7 +115,7 @@ touchscreen: touchscreen@10 { =20 &i2c2 { pinctrl-names =3D "default"; - pinctrl-0 =3D <&i2c2_pins>; + pinctrl-0 =3D <&i2c2_pins>, <&trackpad_pins>; status =3D "okay"; clock-frequency =3D <400000>; =20 @@ -124,9 +123,6 @@ trackpad@15 { compatible =3D "elan,ekth3000"; reg =3D <0x15>; =20 - pinctrl-names =3D "default"; - pinctrl-0 =3D <&trackpad_pins>; - interrupts-extended =3D <&pio 7 IRQ_TYPE_LEVEL_LOW>; =20 wakeup-source; --=20 2.47.0.rc1.288.g06298d1525-goog From nobody Tue Nov 26 11:50:58 2024 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7929244384 for ; Fri, 18 Oct 2024 12:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729252997; cv=none; b=hi9vHZLTlaVPK495g96svOY5IQoUtU9x6g3yOmi45gDyD/4w6v2EZu590OoIHLCt++vFOXgDwrlp6IHPMwOCxyNGvJkDwpVmFCYLxgSRmBn64eKwRQfX9qauXoCZGLL2j8KaRh7tvHJ72HgA8ja5K5jcG9Ow9G3rp8Ewudr2lFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729252997; c=relaxed/simple; bh=8Klwv7FKRpCBVZDGms6vZqbLr10aymsVwSzujYvPBP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k+VbhYfOOuZQZpo7kvL5BvD7flXckQOg8ZBHbVrsQPXLensQCafcYzFWbYkwRbMOT2/UF0P3Vo+TkF9I/QIJHYFXUPT0UER8SbzGYMwUVFKbJaMFB5fz3n/bjZ5Sz1MmtCuZaoHYw/x/N5gmGhQJLx3xd+A7Yhnl4hbUVsylJDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nLKi+J+X; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nLKi+J+X" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71e67d12d04so1531091b3a.1 for ; Fri, 18 Oct 2024 05:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729252996; x=1729857796; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=nLKi+J+XytYXQKwQPMDRY/OROdVY0NpnDNyFu6wd+ll/qIWnYk9lmAF9zsTRIC3DVQ r/QORbpsqN6tsl2hKq5JwZidILsLYkpRFySID8XQtSkZleLQ8R9oZznwInCVggbgFoQM LQi6IOjPgeWBdSC28udfIK4f3i9TSRiGpu8jw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729252996; x=1729857796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=IGHjlTRFfN7dgLzHKVmyo6D0n4JIaq9uGBzcz9hbQ7vpx2so3SnMLoW35uw4/ndfNX VHySWUo89sJmmp8fIOB3+qo3zgOiPcywqzI7+0yUsSJCmpchn6mKCLVmimXzrkbY7MEH jAxt4ex5cOzMSgDsFEZqam1vQ3lBdqczUYEmmF2BHRUpPvo6UxcrnGrpGeAZS36qDeDE 0Ci5nfFG4gh+TENXica71QMhJeeFHNI90k5EndnPjUGrAV3og+2QV3hSYJpkkoANQcld QkpgCEPxx5Bt8Gd2AH+X5/vxJc5qnHu08RwW4IU6l8q1uEtH4VI6aIk/Q+6TOZEhr45o RBfQ== X-Forwarded-Encrypted: i=1; AJvYcCUUnNs5IJkxmvEA9dkwi1pvph0S1fGfgASRChnAfCR5sAWxtSNpXmIx+hd29UZHnwtFOleLWMO5t1FfDs0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0BwtQdKk35VcCFc4Lii111D/3fFiCB5BdOFHRDliCNnRVpQ97 D3kD9ztd21U+8sJHToF1TFYHFN5dc0YLEoU/hiE/WJrvYYIXL2AQ7prGj/CTU+wKlQRiuDah1vs = X-Google-Smtp-Source: AGHT+IEMoyV6BqxdhGrDIRhbQDdZfec7fHmtNYn4YW1cd/EZHjfSnxgL4d4cV9mzhYNOQP54WR2zaw== X-Received: by 2002:a05:6a00:cc4:b0:71e:3b8:666b with SMTP id d2e1a72fcca58-71ea325b489mr2897763b3a.15.1729252995698; Fri, 18 Oct 2024 05:03:15 -0700 (PDT) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea34ae672sm1274014b3a.204.2024.10.18.05.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 05:03:15 -0700 (PDT) From: Hsin-Te Yuan Date: Fri, 18 Oct 2024 12:03:05 +0000 Subject: [PATCH 2/2] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241018-post-reset-v1-2-5aadb7550037@chromium.org> References: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> In-Reply-To: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), the i2c-hid-of driver used by some mt8183 devices resets the touchscreen without having enough post-reset delay. This makes those touchscreen fail to get probed. Switch to Elan touchscreen driver, which has enough post-reset delay. Fixes: 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of= ") Signed-off-by: Hsin-Te Yuan --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 10 +++---= ---- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 9 ++----= --- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 9 ++----= --- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 9 ++----= --- 4 files changed, 9 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/a= rch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index ebe6e161354c414d91859494ec9295db75a3baf9..b98a3530511e576347a4ed291d3= 7d45dd42fec97 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -14,14 +14,10 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; + vccio-supply =3D <&pp1800_alw>; }; =20 &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 2dc64cc539f815b9848b8243e5b487f22d605a6d..9fb329626a82034e44fb5fbd2d0= ad9675c0a5afa 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -27,14 +27,9 @@ &cros_ec_pwm { }; =20 &touchscreen { - status =3D "okay"; - - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; + compatible =3D "elan,ekth6a12nay"; =20 - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 53e996f9c605dc36df03d4b0051a91e19fefb38d..6d547361fc4f9d2ab1f9b048af4= 43495c9bed323 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -14,14 +14,9 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 =20 diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index d7db621383c6b823af08ca07e0794758d062e211..39ab09ce28aa2ed4335d5279a96= 5f23a8458688e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -14,14 +14,9 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 =20 --=20 2.47.0.rc1.288.g06298d1525-goog