From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736671DF969 for ; Thu, 17 Oct 2024 16:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183849; cv=none; b=ZPj5bnz7YR0LWeeT5NbYCf5W5sEVv3X/lIh4pbmCif9qYeHgYQ4GrHo8nZgZz/YY/AHFnsp2TQpjLWYzZq5f/0a5aszJMs2PcvcIsXuC7ZDMEv513spLqbXv8ldnvUrnzyWIetCWVo+PMKVL0ftnRtuumioikWnMQWtRbuLXt+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183849; c=relaxed/simple; bh=xeBqyUWWupzyM/TcXcUV+DS4MauYaKO2a0dTN/w+A/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J5Kv5XS8VDB3Wvjw/ABdaBi5woU8okYHLwemoIpU7+6p6fdnfNVkd7poN3MuWBxHhSlhlRnyoOzJ7C5F6bCoEa1PEEjEdTYAlJ8X88FV9vPzhvbh6TvuFsa+M4nDNjT6U3FJsHuv9AJFQ1kOCws1EX/UW+aZp9MtfmkxqCFgf58= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U9pywovj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U9pywovj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A73E9C4CECD; Thu, 17 Oct 2024 16:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183849; bh=xeBqyUWWupzyM/TcXcUV+DS4MauYaKO2a0dTN/w+A/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U9pywovjwGu8ETQqlUbElaekqiq0LDPsFi+xdIkH7Neal/nSJARDKrZU6BKW20lTy v6ELSRthrW7x2LHh0JzQpnfrqriNPYn87ZPSrRT0LhVVIdDqDl8MvvkHAz9CE+iUef mDTE0lwLCQwTwu766RQlw1xvdW5+SzNQvQjNrgu/olCuCRLry/ylDwsOlN5SNc0S4+ 1G1W4MVbfIkSNENqyysIO3EK4wsdQO6R0L2+tbvHg7EG26R/yXbgZpSSI4OkIbC5QA 9NhKRfbzROv4l1JExErbDdH0XgdfWLDADr2X2WQmF9z6Zdxf90h14RBQK2t8kXoIZY jOng5X9NPoayw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 01/10] clockevents: Improve clockevents_notify_released() comment Date: Thu, 17 Oct 2024 18:50:32 +0200 Message-ID: <20241017165041.6954-2-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a new clockevent device is added and replaces a previous device, the latter is put into the released list. Then the released list is added back. This may look counter-intuitive but the reason is that released device might be suitable for other uses. For example a released CPU regular clockevent can be a better replacement for the current broadcast event. Similarly a released broadcast clockevent can be a better replacement for the current regular clockevent of a given CPU. Improve comments stating about these subtleties. Signed-off-by: Frederic Weisbecker --- kernel/time/clockevents.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 78c7bd64d0dd..4af27994db93 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -337,13 +337,21 @@ int clockevents_program_event(struct clock_event_devi= ce *dev, ktime_t expires, } =20 /* - * Called after a notify add to make devices available which were - * released from the notifier call. + * Called after a clockevent has been added which might + * have replaced a current regular or broadcast device. A + * released normal device might be a suitable replacement + * for the current broadcast device. Similarly a released + * broadcast device might be a suitable replacement for a + * normal device. */ static void clockevents_notify_released(void) { struct clock_event_device *dev; =20 + /* + * Keep iterating as long as tick_check_new_device() + * replaces a device. + */ while (!list_empty(&clockevents_released)) { dev =3D list_entry(clockevents_released.next, struct clock_event_device, list); --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C981DFDA1 for ; Thu, 17 Oct 2024 16:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183851; cv=none; b=agd+7VlIch0LpNel0IoIcBDgOiE0LjJdMnvzv78RoCaNNgsgP6pgVhoBpvNvplVeswiQargymA5QdwYeFzsAoqI+EJUpqb/RG8/wGVm02a43/ssJJ8RGZr+RA1e/zsvJULi/aNvBRgX6T6c5wPXz/rZ8WoqaJCvDO6DyXdQUjSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183851; c=relaxed/simple; bh=ReHV9EcaEtqbsXSnw8gIYFjB+jlPXGkfJVT0049j+Mk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xfw7KvW3w4SXXhd0imCl5VnUknBdZQQdlUTT1FPDU/o2m60Xa2ORzbNuJ7JsTr3YmDKHtB0tBpW0IUdaxxvAsuF9PIAiuo8mJqpZ1xvZUJNAnE2PBhg/uHKVWquATxgFeM82c6FWROm8YOeUbf2XkROmhEcmCvPNbcTzHOzQiAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bVSJpQLT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bVSJpQLT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71D5FC4CEC3; Thu, 17 Oct 2024 16:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183850; bh=ReHV9EcaEtqbsXSnw8gIYFjB+jlPXGkfJVT0049j+Mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bVSJpQLTFqZD4iOOy36hwPoW0SHeuNtI47ouUGvTzyX7No5t0ibxLNguYWtH7ion1 SJ/mt8ATWNsxkhBAKHVTgtD0mJOTGU8xfOsb0RM+c7DBdlBjqnYPRcMs+6ULJXDk1T qIh24/8FQWJe0NpacMKc/DLsGC2tYoIe4bvDmW3+iAa6BnLemsg7NbSGvrWXYLaBoY MsBOeF2Ch2wKrGw7Evg55QOa+z4Eo2WY9vGGse9kw+qD/g+h+4j/qbHJ5vJ+Wl3WTA hXRsHPma2o4f/1rUklsAdLOUJHRtaaA0cXyx3GJeV06Tw4FY5Wofl10DO+Pw8+TrDp wJiWUee2G83gA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 02/10] clockevents: Shutdown and unregister current clockevents at CPUHP_AP_TICK_DYING Date: Thu, 17 Oct 2024 18:50:33 +0200 Message-ID: <20241017165041.6954-3-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The way the clockevent devices are finally stopped while a CPU is offlining is currently chaotic. The layout being by order: 1) tick_sched_timer_dying() stops the tick and the underlying clockevent but only for oneshot case. The periodic tick and its related clockevent still runs. 2) tick_broadcast_offline() detaches and stops the per-cpu oneshot broadcast and append it to the released list. 3) Some individual clockevent drivers stop the clockevents (a second time if the tick is oneshot) 4) Once the CPU is dead, a control CPU remotely detaches and stops (a 3rd time if oneshot mode) the CPU clockevent and adds it to the released list. 5) The released list containing the broadcast device released on step 2) and the remotely detached clockevent from step 4) are unregistered. These random events can be factorized if the current clockevent is detached and stopped by the dying CPU at the generic layer, that is from the dying CPU: a) Stop the tick b) Stop/detach the underlying per-cpu oneshot broadcast clockevent c) Stop/detach the underlying clockevent d) Release / unregister the clockevents from b) and c) e) Release / unregister the remaining clockevents from the dying CPU. This part could be performed by the dying CPU This way the drivers and the tick layer don't need to care about clockevent operations during cpuhotplug down. This also unifies the tick behaviour on offline CPUs between oneshot and periodic modes, avoiding offline ticks altogether for sanity. Adopt the simplification and verify no further clockevent can be registered for the dying CPU after the final release. Signed-off-by: Frederic Weisbecker --- include/linux/tick.h | 2 -- kernel/cpu.c | 2 -- kernel/time/clockevents.c | 33 ++++++++++++++------------------- 3 files changed, 14 insertions(+), 23 deletions(-) diff --git a/include/linux/tick.h b/include/linux/tick.h index 72744638c5b0..b0c74bfe0600 100644 --- a/include/linux/tick.h +++ b/include/linux/tick.h @@ -20,12 +20,10 @@ extern void __init tick_init(void); extern void tick_suspend_local(void); /* Should be core only, but XEN resume magic and ARM BL switcher require i= t */ extern void tick_resume_local(void); -extern void tick_cleanup_dead_cpu(int cpu); #else /* CONFIG_GENERIC_CLOCKEVENTS */ static inline void tick_init(void) { } static inline void tick_suspend_local(void) { } static inline void tick_resume_local(void) { } -static inline void tick_cleanup_dead_cpu(int cpu) { } #endif /* !CONFIG_GENERIC_CLOCKEVENTS */ =20 #if defined(CONFIG_GENERIC_CLOCKEVENTS) && defined(CONFIG_HOTPLUG_CPU) diff --git a/kernel/cpu.c b/kernel/cpu.c index d293d52a3e00..895f3287e3f3 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1338,8 +1338,6 @@ static int takedown_cpu(unsigned int cpu) =20 cpuhp_bp_sync_dead(cpu); =20 - tick_cleanup_dead_cpu(cpu); - /* * Callbacks must be re-integrated right away to the RCU state machine. * Otherwise an RCU callback could block a further teardown function diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 4af27994db93..4ac562ef7f40 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -452,6 +452,9 @@ void clockevents_register_device(struct clock_event_dev= ice *dev) { unsigned long flags; =20 + if (WARN_ON_ONCE(cpu_is_offline(raw_smp_processor_id()))) + return; + /* Initialize state to DETACHED */ clockevent_set_state(dev, CLOCK_EVT_STATE_DETACHED); =20 @@ -618,39 +621,30 @@ void clockevents_resume(void) =20 #ifdef CONFIG_HOTPLUG_CPU =20 -# ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST /** - * tick_offline_cpu - Take CPU out of the broadcast mechanism + * tick_offline_cpu - Shutdown all clock events related + * to this CPU and take it out of the + * broadcast mechanism. * @cpu: The outgoing CPU * - * Called on the outgoing CPU after it took itself offline. + * Called by the dying CPU during teardown. */ void tick_offline_cpu(unsigned int cpu) -{ - raw_spin_lock(&clockevents_lock); - tick_broadcast_offline(cpu); - raw_spin_unlock(&clockevents_lock); -} -# endif - -/** - * tick_cleanup_dead_cpu - Cleanup the tick and clockevents of a dead cpu - * @cpu: The dead CPU - */ -void tick_cleanup_dead_cpu(int cpu) { struct clock_event_device *dev, *tmp; - unsigned long flags; =20 - raw_spin_lock_irqsave(&clockevents_lock, flags); + raw_spin_lock(&clockevents_lock); =20 + tick_broadcast_offline(cpu); tick_shutdown(cpu); + /* * Unregister the clock event devices which were - * released from the users in the notify chain. + * released above. */ list_for_each_entry_safe(dev, tmp, &clockevents_released, list) list_del(&dev->list); + /* * Now check whether the CPU has left unused per cpu devices */ @@ -662,7 +656,8 @@ void tick_cleanup_dead_cpu(int cpu) list_del(&dev->list); } } - raw_spin_unlock_irqrestore(&clockevents_lock, flags); + + raw_spin_unlock(&clockevents_lock); } #endif =20 --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D95F61DEFE5 for ; Thu, 17 Oct 2024 16:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183852; cv=none; b=R2KGhYJtcyKjYCPcucM1Wv90v2g3Bmpj/4qt7WpkfjsgPSQgEGYMgWZgELJBDuRrJffWzDevvlDW2ZO/1uqLOgv/5zLVi6mLUn3cDqWdJYv/VB04NGiRMscq2nN/l+e7n1e/lmCGArrU1BABfpvRdtAje/VKmyVmLGiNOtFi9n8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183852; c=relaxed/simple; bh=6aXvULtk6P46L533gMCv6UHWYGmMTNxFbGJJ5TXot5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ltbQLJkvlyOuC7GHMcOGHgUILJsvIJLltJhiFsl/du1IKjuTeh3CVBc9kkC1HDrfOw/EIxZ+ne3/oV410V7+O8cH4Y49MdM/torjSEGpru/tnr55t16yZVLQ3DtaOZxF3XNraq1WDlDOVMxfFdACy7/sNQYNRx9b36WZHecSYQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eaTz8Z2m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eaTz8Z2m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FCBAC4CECD; Thu, 17 Oct 2024 16:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183852; bh=6aXvULtk6P46L533gMCv6UHWYGmMTNxFbGJJ5TXot5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eaTz8Z2mU1Ob+nyqvi409KbvSvdQAUAd003Em9Upkk9cekH855Hyk7JrfPHPFVd80 OxLlKlXayRescmRDn44IZkVyR4gLdoJV8RnpcouPj+OUZHDv4wacmVtdrIl64i1dlC HSVq1Bh59SYwSkL7VVBloEK/5AVSk4rBRjYrKyBwvHtxMPgil1gx+WZCvSfwhtbzOF 2nfZ/mJF+GZEd5EkFnGhgOFpFpejSARZxJCYjrH9Jp0FS6qd7BKGrNX0fZkgQ6v6Sa AMOtmAQcMx9WojQJvizo8tmlG61AQKcpFFQa72FfWJUd4yFLwijK/Ww8qYYJ+IaTES 948pDpCDyRTLg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 03/10] tick: Remove now unneeded low-res tick stop on CPUHP_AP_TICK_DYING Date: Thu, 17 Oct 2024 18:50:34 +0200 Message-ID: <20241017165041.6954-4-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The generic clockevent layer now detaches and stops the underlying clockevent from the dying CPU, unifying the tick behaviour for both periodic and oneshot mode on offline CPUs. There is no more need for the tick layer to care about that. Signed-off-by: Frederic Weisbecker --- kernel/time/tick-sched.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 753a184c7090..9f90c7333b1d 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -311,14 +311,6 @@ static enum hrtimer_restart tick_nohz_handler(struct h= rtimer *timer) return HRTIMER_RESTART; } =20 -static void tick_sched_timer_cancel(struct tick_sched *ts) -{ - if (tick_sched_flag_test(ts, TS_FLAG_HIGHRES)) - hrtimer_cancel(&ts->sched_timer); - else if (tick_sched_flag_test(ts, TS_FLAG_NOHZ)) - tick_program_event(KTIME_MAX, 1); -} - #ifdef CONFIG_NO_HZ_FULL cpumask_var_t tick_nohz_full_mask; EXPORT_SYMBOL_GPL(tick_nohz_full_mask); @@ -1055,7 +1047,10 @@ static void tick_nohz_stop_tick(struct tick_sched *t= s, int cpu) * the tick timer. */ if (unlikely(expires =3D=3D KTIME_MAX)) { - tick_sched_timer_cancel(ts); + if (tick_sched_flag_test(ts, TS_FLAG_HIGHRES)) + hrtimer_cancel(&ts->sched_timer); + else + tick_program_event(KTIME_MAX, 1); return; } =20 @@ -1604,21 +1599,13 @@ void tick_setup_sched_timer(bool hrtimer) */ void tick_sched_timer_dying(int cpu) { - struct tick_device *td =3D &per_cpu(tick_cpu_device, cpu); struct tick_sched *ts =3D &per_cpu(tick_cpu_sched, cpu); - struct clock_event_device *dev =3D td->evtdev; ktime_t idle_sleeptime, iowait_sleeptime; unsigned long idle_calls, idle_sleeps; =20 /* This must happen before hrtimers are migrated! */ - tick_sched_timer_cancel(ts); - - /* - * If the clockevents doesn't support CLOCK_EVT_STATE_ONESHOT_STOPPED, - * make sure not to call low-res tick handler. - */ - if (tick_sched_flag_test(ts, TS_FLAG_NOHZ)) - dev->event_handler =3D clockevents_handle_noop; + if (tick_sched_flag_test(ts, TS_FLAG_HIGHRES)) + hrtimer_cancel(&ts->sched_timer); =20 idle_sleeptime =3D ts->idle_sleeptime; iowait_sleeptime =3D ts->iowait_sleeptime; --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED9931DFE36 for ; Thu, 17 Oct 2024 16:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183855; cv=none; b=JuKvOJ3NLTOJEtdVBPNExNRoGZPkLlCjA1Q53x7mOI0kPrQuvKrBdnmTx6138z1XGkoPmeznV0XLRbBwOe4KTaEzmWQxmaZoscYgZ5BjA8FGea09ziWLDFN9rIyisGUEIpEd+FhpqNNsdrnB430kb6lPJDaCLxADpiwy3816MrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183855; c=relaxed/simple; bh=wsrgcgckUzKVDFRbi/YSgS+i6orOaA/wjwoY2un0FkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lcUi9v2HYvBP7tmfNpnQyAIF00VaQoqAmg6F4Bc/TOElp47A0tYEHTwXYfWVr8GewG+gP3Qng6scR6wJAfFbY1ATQrnY9R0q8dbgRJu3CA9ongukbFvlyOsMgg2SGiymdfKY5BYkQVvzFzMdDIMwzvVds94tQwLcd/PAn/+Z96s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kPSdJdCh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kPSdJdCh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD84C4CED1; Thu, 17 Oct 2024 16:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183854; bh=wsrgcgckUzKVDFRbi/YSgS+i6orOaA/wjwoY2un0FkI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kPSdJdChZ4CsjAXpj7jll/CSOcrp9Fsardvs+Zx5SUFf58aH/0PdA4KStFuh7BG95 oLflm20l62VCdmIvyJC7E6rs/z5qNUB3fuBfszWD/zd2MxpCmLvGtfvhmPOWJyj1MM fuww8dwrcN6WmYn4VBA0ak+NNTtuyaiuI8oAOcHU1lJqQZY0sY8F3FawIfwMY3XDT6 z7QAj/62kseMB483JxxBzMDK0mWnPhNjtMh/xGcvXPqZcaDHojcgwk1K5gb3CsH/5X WMLkv3G8qbkad8pqVOBPmGAzlz6v+f4Rte9dexDGcbfTRdescapMvrruq8ovHAJhJP NNvJE5WfpWgJA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , Russell King , linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/10] arm/twd: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:35 +0200 Message-ID: <20241017165041.6954-5-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- arch/arm/kernel/smp_twd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 9a14f721a2b0..42a3706e16a6 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -93,7 +93,6 @@ static void twd_timer_stop(void) { struct clock_event_device *clk =3D raw_cpu_ptr(twd_evt); =20 - twd_shutdown(clk); disable_percpu_irq(clk->irq); } =20 --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41EA41E00A8 for ; Thu, 17 Oct 2024 16:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183857; cv=none; b=iGMRmdXAQarTjz5Qeu/xyT7jQb7NnchWJirDXdWfXmzMHswVJ+lcSZyp/fF0j1EHbUWnBOZ5gSSXab2RSHkisr5Q7AiBgtLrElMrOIHBoSfG2EFJk/oSOkSS01c8qTVv9ZwO8zptDbisAtl4VrLYi5OO/dlA0a8GKINEPHIR9/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183857; c=relaxed/simple; bh=LSVbONdYSI3CZ/dJAq35R0rVW7RNPedEHyCHamPd/X4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kgCBoQoh9sYObjrTNzeMfGEfqG5VmF9N82PdKWMKTq+9dW4RYSg7v33QxqKfaUGW4pX+VbzsaPcpKnNtf9SJabQpl9G3buQq7Xx7X3YlOQmIvhTIpzzQtooIRCwerH9HCtrR7JWKxFnwYjVNqblb//MatJ0DXTe2uN4UpCEBKLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aIQTBZQp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aIQTBZQp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C77C4CEC3; Thu, 17 Oct 2024 16:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183856; bh=LSVbONdYSI3CZ/dJAq35R0rVW7RNPedEHyCHamPd/X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aIQTBZQp84Ia/ch94EF3cCuXu+IVDl2CyVe6PXaftl8EeW2bwIPRDm+gnJ6Cy68R4 bu6Uo/31++jynHj+p4k9GLYlAtC9v0AXI5FHqecuTUf2WGPrf34QZV/WS4PWkWh+CB Xt6YzX4F/b1DpXBxOXCl0mKpUWxue2/0bKfn968ciH77Z5E1z+4mZJP6jycVfj6YWB PKGIBIg1I9sShmI94NHE1HH8ZByoZGx0O27EjS7Gm3xlYDu6MrZ728tZ6GIvE1wTlu uAw+iTWOV44MdC9gtKJ4xSPqNk7FpB9VXGnTe+Mk47MtCvVDfWbg9/ZnVhZhJVECtm CgC5ddDs+iwEA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , Mark Rutland , Marc Zyngier , linux-arm-kernel@lists.infradead.org Subject: [PATCH 05/10] clocksource/drivers/arm_arch_timer: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:36 +0200 Message-ID: <20241017165041.6954-6-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/arm_arch_timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm= _arch_timer.c index 03733101e231..2bba81e25aa2 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b/drivers/clocksource/arm_arch_timer.c @@ -1179,8 +1179,6 @@ static void arch_timer_stop(struct clock_event_device= *clk) disable_percpu_irq(arch_timer_ppi[arch_timer_uses_ppi]); if (arch_timer_has_nonsecure_ppi()) disable_percpu_irq(arch_timer_ppi[ARCH_TIMER_PHYS_NONSECURE_PPI]); - - clk->set_state_shutdown(clk); } =20 static int arch_timer_dying_cpu(unsigned int cpu) --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA321DF754 for ; Thu, 17 Oct 2024 16:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183858; cv=none; b=Hr/eApwhLrYXt9NhAsOS9SowtW7YXGAEsYmrwVfWBjQglLdujkiUQb9lmxBD5ndUAfYvgWp0tjzbVVQzdR7dbSpO/8lM8lzpyHolcow/rlOjinxnvrJlqXs5vSgHG+TSEGplWMGpC/gy6QqMEKOJ2Dq2MAqVwSJjVxa8eG9R700= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183858; c=relaxed/simple; bh=ohm5m/FEq12JHJkouCz6F5DIQ6ro0AAeDjfyVqNditQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M6cDjejF5AchtttoL10KVhIWEy9F1A6lhBc67/Y7lGVYX52qTcQAZG2UjFQIhLxeuKTwSABK/+L4fqEIlLJpRpjzqKxVWvbO0OJRoRgMQ/y4jPVtp536C62cO2AvE6PtW0RW7weWZtNRDTfd0DFGgXjW2s7nwIVCfe4lLUr4GWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HBKLIDg7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HBKLIDg7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DB4AC4CECE; Thu, 17 Oct 2024 16:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183858; bh=ohm5m/FEq12JHJkouCz6F5DIQ6ro0AAeDjfyVqNditQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HBKLIDg7vejluna9ytgUb4LHK7sdDU7oqfV7yErYzd5nQdeGSD1MFac1Hz1xcdpq5 aRrQiu6m9HBk0r+WUopP2JYDblNExvZUn9oKHRySr/MX66XwXV7dhAs+7ljKPN6xyJ uPjssWeNWcPV6S9jqdnP0J/gaIA29CvGpeaox4Y6aF+5ZLXFgM9ca7xVI75iE51GIA hXBtGl34rnvSMOTkjZRQqZorsD0U1Z8/X/jbv+duNZtvJYovUXzGNoSz6xQqr7MmJF isPtP/DUvTK62i94mqsw0nHd5o9f2+T5H6daHkld/SyxcEw8viYC8QujE9N9Q9Gthz dD6EjJwo8ZvSg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , Patrice Chotard , linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/10] clocksource/driver/arm_global_timer: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:37 +0200 Message-ID: <20241017165041.6954-7-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/arm_global_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/a= rm_global_timer.c index a05cfaab5f84..2d86bbc2764a 100644 --- a/drivers/clocksource/arm_global_timer.c +++ b/drivers/clocksource/arm_global_timer.c @@ -195,7 +195,6 @@ static int gt_dying_cpu(unsigned int cpu) { struct clock_event_device *clk =3D this_cpu_ptr(gt_evt); =20 - gt_clockevent_shutdown(clk); disable_percpu_irq(clk->irq); return 0; } --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F9A1E04B0; Thu, 17 Oct 2024 16:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183861; cv=none; b=Z0ysGKsApGXpOBXfbGQJEjihlIr9WN8iV+qVUeVXWPnFMBACmtU6iFjy+K9hiKE4NHd0KH+fnxK+E24IZLqvTnm5a3qS4/JJtaixapoDyqUBlFpd+3k9gyvIWB3bD6FUFaGBbZyJ2v/OEYkHuJ0TEYd1E4CXlqJU0OimGlPLeKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183861; c=relaxed/simple; bh=SMDyXbB2S/Xna6nklNIq1bBj07R+0sg6UmAJM+SQqgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lrg+Tw/0QKhdPASZFdzFzJzQ9wLUE4/1lYrg+zkrYJRH4ZscOkS7iIPjpHgCcG60l9XiBdwSKsZGFiQ141sXCvRC/LDC9QnmZ1gtS1DtCuh4Ssa80/SOf5vRn5ME3nlEbngg2I60lNhctdzQCIkhasgHe4ip2cnEmeeqCvb/Y/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LQJMtAwm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LQJMtAwm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 127E9C4CECE; Thu, 17 Oct 2024 16:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183861; bh=SMDyXbB2S/Xna6nklNIq1bBj07R+0sg6UmAJM+SQqgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LQJMtAwmSg5pAPwoiUin+EfrcQ7i+f7AhT7GUVcIWyAJPHfZNpsZ7G89+ihAgqnPm Xh9KK69pNKuybifDjJYPnZu+hLH6l0C1iWWpOdFz9+b4KjoGpBV75fuDukL+PjhcEl 3vehkk6QPwrkkFG4MvGNW77ycEgOt74ZYlta+f7YPa3y7jeDdQg6StgV3Q5VkHTaem SLPV4YE7vansfEhkcpzpALGakE6PAo9MGdPQpTB10RLh7w9XcgCrE5ajhXjjkiDwPE rQ3hHWO0NDEI/+7UCBdIGzjmAviJCTX7becTTrR3HnzeQ5XtU7MPlu6hDEfs83Dh6W J0RuBY+staWzA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 07/10] drivers/clocksource/exynos_mct: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:38 +0200 Message-ID: <20241017165041.6954-8-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/exynos_mct.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_= mct.c index ef8cb1b71be4..e6a02e351d77 100644 --- a/drivers/clocksource/exynos_mct.c +++ b/drivers/clocksource/exynos_mct.c @@ -496,7 +496,6 @@ static int exynos4_mct_dying_cpu(unsigned int cpu) per_cpu_ptr(&percpu_mct_tick, cpu); struct clock_event_device *evt =3D &mevt->evt; =20 - evt->set_state_shutdown(evt); if (mct_int_type =3D=3D MCT_INT_SPI) { if (evt->irq !=3D -1) disable_irq_nosync(evt->irq); --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081691E0B61 for ; Thu, 17 Oct 2024 16:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183863; cv=none; b=dptCDLheMhYwP/q5nCFlnBKZWMiyR+b7vo5miLUUT4S4rDE4Y+C5lIvyv6eEkUvFRlGM5WIyenmo+2W8qa7H6VlJKlDADMSVzIk/Jw6uosQomOXB+LJngcjnsIRz/zlgjjWFzmh9eQes78y1OETenkUSjvBdG7YJYk2BJg6FvzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183863; c=relaxed/simple; bh=osLJ67WkCleliN3lQ7XuVH0lOjALLrP6N6qy/Qc6chM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gutVgqeZxUKL3lba1yGDv6BC3q/MDFVg6tDcdjTV2Ked3UlRy2woNUFzwYg+ybwKg/946WXx1jjqdzSvo6LR12jbL8m9JrSQ97v6aHOJAPydK1lFFZ17Dth8iQUH5LldkrXOokCrMXt9/HkmuVpdzp2xqboT7lH4sxcrQowURJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bSe9sPEg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bSe9sPEg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E491C4CED1; Thu, 17 Oct 2024 16:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183862; bh=osLJ67WkCleliN3lQ7XuVH0lOjALLrP6N6qy/Qc6chM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bSe9sPEgsjvI3YtOJUQUwnMcYsWyba7qC6Jprks9dAQOtzpoffQCkj4oisd7+9cHE DVRwwIHcAjN8dKvn0wlvAivEEQL1eQ9S1yqoDO4sQXULSD73aWNqqwZuR59dv+Pe4W bnSUSSQ8L9P4TkPrIdWbxXE7sYZZrB4gQ7l2HRT+zVQZUtrV9OOWWDpMW3oyGKHkzF zuWZiyzOtdxnVuK+SDeIJT+7al7FLdqjVXGYEZLDscsztfwK6tylSmiiyBmzsrnmjf cILANsVA5Cv2VU6PXZ+LV+MZy6ylGd0uuE/zTR7MaQmOVtoHQbByhidwi+3crRDRH3 e70pC/QNy1Wiw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 08/10] clocksource/drivers/armada-370-xp: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:39 +0200 Message-ID: <20241017165041.6954-9-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/timer-armada-370-xp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/timer-armada-370-xp.c b/drivers/clocksourc= e/timer-armada-370-xp.c index 6ec565d6939a..54284c1c0651 100644 --- a/drivers/clocksource/timer-armada-370-xp.c +++ b/drivers/clocksource/timer-armada-370-xp.c @@ -201,7 +201,6 @@ static int armada_370_xp_timer_dying_cpu(unsigned int c= pu) { struct clock_event_device *evt =3D per_cpu_ptr(armada_370_xp_evt, cpu); =20 - evt->set_state_shutdown(evt); disable_percpu_irq(evt->irq); return 0; } --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F991E0DCA; Thu, 17 Oct 2024 16:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183865; cv=none; b=NF3g12AEsm2VuGLwshP8q10wLnaB1rynrVeqcCQwf182V/FSwc0yLu3hnEo90t//oFPquttN8vlxdVVEoYtKyuLSrs4PN3jLSjfLF5G09LoYdd+OihHz/QOWvid/Jez/Soq+X8umgFJpfVnvX9ZpPxhhswRbu2oX7I4bF+0ySbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183865; c=relaxed/simple; bh=mWVAxP270eizg+NnieHw5y6Ei6lA/IiWWZmJ1Makxbg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=miL/bfArCgmLj8pdJn1FhKQxsB9dOUQCiYXQUmbolqb8FrTrs8kHviCQFUTo/R23alSWEqk7A61gIwD1mprBq2CFATE2Uw3s3rmryskTAfW8do3G0dBgDiCJssiTGDLMSat7WWJa6XEBnYxtiqBqAuQD0fTai9msTCZbC71jIb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ciipJH8U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ciipJH8U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F65C4CEC3; Thu, 17 Oct 2024 16:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183864; bh=mWVAxP270eizg+NnieHw5y6Ei6lA/IiWWZmJ1Makxbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ciipJH8U6IzHb52iUHwuJjDu2drcUx8yvwVKx66zIM1CSx46UGPkekCwmMO5RWHhQ lRWBy8VAml+ls7XuJS6tB81ePHpFAKAYIackjkxUxnG4AVs1E7LGEUZh4hidCaLC8w PbsFzGTIbUcU0ZCt4BzeKlw14ZFeGgdEKjMJWwKQNTtSwwNDkEPD6kHcy+SUTY0C7U FV58ToKdts/zDXsXEv0Xjcm78Z5RBgS1le/PC+jmkq0N0T3xGXvg+SOQSVQt7hjYM2 uhNoJmwTKFycDxSp2NpAlIEQBI50uOoGr9mMTKEQNCie03+wpoel1jlB0oH2xvauqX aplUpQc7f8FKQ== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , linux-arm-msm@vger.kernel.org Subject: [PATCH 09/10] clocksource/drivers/qcom: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:40 +0200 Message-ID: <20241017165041.6954-10-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/timer-qcom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/timer-qcom.c b/drivers/clocksource/timer-q= com.c index eac4c95c6127..ddb1debe6a6b 100644 --- a/drivers/clocksource/timer-qcom.c +++ b/drivers/clocksource/timer-qcom.c @@ -130,7 +130,6 @@ static int msm_local_timer_dying_cpu(unsigned int cpu) { struct clock_event_device *evt =3D per_cpu_ptr(msm_evt, cpu); =20 - evt->set_state_shutdown(evt); disable_percpu_irq(evt->irq); return 0; } --=20 2.46.0 From nobody Tue Nov 26 13:17:47 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C1E1DF985; Thu, 17 Oct 2024 16:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183867; cv=none; b=dsj+aUT0PIuY4kKtMzc1fWHNjcTs9wYB3gM5cyNE/+t+38OqrxPYh0Sn+VgMGvD2oUYxV+kbCFwmkrpT/RjKmk1CCwXVV9saNpa3Me4p3xss0diB0zb4JHTVfFYlocqcLqq8TOLvhNohH3zRkthgMzzg5f5TJ914y/YHfapb3tE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183867; c=relaxed/simple; bh=qWttzDemKi/gYPJZ/lRMbh7Bi4m3BbF9VbCZIpdWK8A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ndp8tWqAknIVXFXZn8gFyiksRQAGxuanK2d/f6i13i4RZ7PrsdbL2d6CFNMCsPmlch6bPtJkm/3PFXrtHg6SmHCKktfgZVDSK9KbiBco2aaewoRMM9EyBWp7w+WDfka8v+Y1dM9hmJOoqOA3NlO0Vv32dlA0Ht2KT3m+6Mvrvvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KIsCIWEv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KIsCIWEv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 287F3C4CECE; Thu, 17 Oct 2024 16:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729183867; bh=qWttzDemKi/gYPJZ/lRMbh7Bi4m3BbF9VbCZIpdWK8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KIsCIWEvkznDlw5q5sG62VX0pnuqPxncDE+0xrbEQ22SAc+DdQp/m9KysEfAzMGvE uq/H+HAIRs29EHnwZtffWCz8RsNLOkbgVqiNEGV79xVC43GXrkdzluhy+KPkDU3iNY bHp2uC/N0BhK7IGPJqBkpLVmYBDtlTcbAbpdiN2yPv75hay+ap0HeHXG6v1RlQixEH pY2B4Sz9pi74MSIThIOIUIXUaaK1eFErtGkh+F/Yb9GGk7vUgZkstFR8I1QBPJphMw q/t2h07bx5J94OvPjqIcIGO2PfHA6nUrJh2TZpy/bWJJDFINbCsYrlLZujBFIzlEc1 qbqtxRkatBlNA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org Subject: [PATCH 10/10] drivers/clocksource/timer-tegra: Remove clockevents shutdown call on offlining Date: Thu, 17 Oct 2024 18:50:41 +0200 Message-ID: <20241017165041.6954-11-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241017165041.6954-1-frederic@kernel.org> References: <20241017165041.6954-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Frederic Weisbecker --- drivers/clocksource/timer-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/timer-tegra.c b/drivers/clocksource/timer-= tegra.c index e9635c25eef4..35b6ce9deffa 100644 --- a/drivers/clocksource/timer-tegra.c +++ b/drivers/clocksource/timer-tegra.c @@ -158,7 +158,6 @@ static int tegra_timer_stop(unsigned int cpu) { struct timer_of *to =3D per_cpu_ptr(&tegra_to, cpu); =20 - to->clkevt.set_state_shutdown(&to->clkevt); disable_irq_nosync(to->clkevt.irq); =20 return 0; --=20 2.46.0