From nobody Tue Nov 26 13:43:18 2024 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7CDF1DED74 for ; Thu, 17 Oct 2024 16:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183027; cv=none; b=LBpbe+BTJyR+lPsUfBHft6HzK0Mx++dKVpwd01hKSHvG8a8rNcn7CKly3bw6/+mr2n8ByAEiaUkRb6Hco8tQv7/tlKV2G5VH0ptRgxXZ46xDIR4nDi2n12L9bkVBWC2w9nKDmyZL1DDd3A0XSBEBrFV13KjBmdOkoD1HIrTOtFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183027; c=relaxed/simple; bh=yP4mrDR7TT7zFyehxyjt1XbOaha8+P66CXX4RkC2Y+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WLxb2sDYhE0HIoDC/yIXG9ovoDbzgIDHZgSSKPeVfJxucoHnoBfMaUiyGu+jbU6JtUct5lGV/6iaSZg7STQTVOZVBnBuqeFmOill8iUF1CTDrcDhmZCpELQhsmqqLVwpNM6+L5iPE8HSesp/fivQsx14+nfYARh8Fz0MeOSwEHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sOFJ1ptl; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sOFJ1ptl" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-431286f50e1so16156965e9.0 for ; Thu, 17 Oct 2024 09:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729183019; x=1729787819; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mWAw/cKeoVi0DyEgj1WlGf9TcvQWH3bdvfqRpdguuZo=; b=sOFJ1ptlOQb8HlANxoHjnAvMZoL5LIvjPqzEtMPnGuvkLSO2jOwEGSBDymYbfQyKEN qHcsBgIwRhBx30+mkyaaqXLi4w/73/JwxdLXF1mZUC5wljmUgok/s3Sut1aiRiE547cg ziNY/8emLw5vTTmY7jQdmyAahWcyJzcT9o0SXkXtKCrDaVzTgJklxpdvjKEky7bdsDzD Ypm72+jVC/MQprFxDiJnzN0za5G2EWx9/q5KFUXWEHj8/sAUsLTGoK3IS4hWA0s1HapO M/o0BbewKSSwmkG3d1FVcIxLxQD6JMtU7lcC/QF3QdUVzUKge5e3kuxRjgby9LUQJ0f8 SF7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183019; x=1729787819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mWAw/cKeoVi0DyEgj1WlGf9TcvQWH3bdvfqRpdguuZo=; b=nXIXJeXjTDOXZlSHlKu+D2bRLwqJUHZB6KC1KRSDTmFu6SQLLG+3G+XUtpr38a5Y6g SFRqYkimwnYr4jnm3fizSn/ylRHUv8kKIwUr3WFvkl+otsCj8xt4qeRc4eclHFvo5F3X V0OV5aY3p5td2dxaJHnwRwh49A2UKHUPJcx6ZbAW8epgiwLYgtc6dTiQeFWkkDh46Pvj ndml3t+Z4UCZ/ofU8YSJ590VR1TE7SP6JG4KSFT5vEXmYH2EQnu9LrgaWhQsaLD25Utv SWTp1F9iKo5tQFO+on3AVjrlzdI2lsObHeUPO5SOSzCG9YEcEhB9YS25C0cEkgUqkZOS CLdg== X-Forwarded-Encrypted: i=1; AJvYcCWx5GsZ9i4Zr9wv8K3MeYXoR5m24eJ++jw1jSupAy/AxrP70p3C/Nl8zSrxNctjETsjqiR2gAgZYLWyyOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yws0Pjqf2fkS0Y6I1kpvmLdw7HkqcHS0byD3fNn/VStn5W4JXYj 4KG136j2qFr0/2yIjPBYL/kyX0sQKf8IQxcm5Ku9z2zUkPcuU/+1dT0Lfu7CHBY= X-Google-Smtp-Source: AGHT+IFh75U3p5IpYJoVMgO26bnm/M6DBFZJl+8VSyq5GjFpTMpDfHMxcpbrX2E8ip7LUNeMJt/4xA== X-Received: by 2002:a05:600c:4f49:b0:431:5c3d:1700 with SMTP id 5b1f17b1804b1-4315c3d18b2mr26898195e9.21.1729183019046; Thu, 17 Oct 2024 09:36:59 -0700 (PDT) Received: from ta2.c.googlers.com.com (32.134.38.34.bc.googleusercontent.com. [34.38.134.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fc11aefsm7710376f8f.93.2024.10.17.09.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:36:57 -0700 (PDT) From: Tudor Ambarus To: jassisinghbrar@gmail.com, krzk@kernel.org Cc: alim.akhtar@samsung.com, mst@redhat.com, javierm@redhat.com, tzimmermann@suse.de, bartosz.golaszewski@linaro.org, luzmaximilian@gmail.com, sudeep.holla@arm.com, conor.dooley@microchip.com, bjorn@rivosinc.com, ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, marcan@marcan.st, neal@gompa.dev, alyssa@rosenzweig.io, broonie@kernel.org, andre.draszik@linaro.org, willmcvicker@google.com, peter.griffin@linaro.org, kernel-team@android.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Tudor Ambarus Subject: [PATCH v2 1/2] mailbox: add async request mechanism to empower controllers w/ hw queues Date: Thu, 17 Oct 2024 16:36:48 +0000 Message-ID: <20241017163649.3007062-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog In-Reply-To: <20241017163649.3007062-1-tudor.ambarus@linaro.org> References: <20241017163649.3007062-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current form of the mailbox framework doesn't allow controllers to benefit of their hardware queue capabilities as the framework handles a single active request at a time. The active request is considered completed when TX completes. But it seems that TX is not in direct relation with RX, so a client can't know to which TX data the RX data corresponds to. Let's consider a client sends TX1 data, mbox->ops->send_data() is called, timer is started immediately, last_tx_done() returns true and the client is notified that TX1 completed. Client sends TX2 and gets notified that TX2 completed. RX comes, mbox_chan_received_data(chan, mssg) is called after both TX1 and TX2 completed. Client can't know if the received mssg belongs to TX1 or TX2. In order to address these shortcomings, add a simple async mechanism based on requests. A request will contain pointers to tx and rx (if any) data, along with a pointer to a completion struct. Is the responsibility of the client to allocate and fill the request: static int client_send_request(struct demo_client *dc, void *data, size_t data_len) { DECLARE_MBOX_WAIT(wait); struct mbox_request req; int ret; req.wait =3D &wait; req.tx =3D data; req.txlen =3D data_len; /* * Set req.rx =3D NULL if no response is expected. Here we * use the same memory to get the response. */ req.rx =3D data; req.rxlen =3D data_len; ret =3D mbox_send_request(dc->mbox_chan, &req); ret =3D mbox_wait_request(ret, &wait); if (ret) dev_err(dc->dev, "%s failed %d\n", __func__, ret); return ret; } mbox_send_request() sends a message on the bus. The call may be in atomic context. Returns -EINPROGRESS if data is fed into hardware, -ENOSPC when the hardware queue is full, or zero when the request completes. The message (queue) handling is thus deferred to the controller. Similar mechanism is used in the crypto subsystem. The async req mechanism is mutual exclusive with the current message software queue handling. In the future the software queue handling can be used as an opt-in backlog choice for users that need it. But we'll have to do the conversion from ``void *message`` to ``struct mbox_request *req`` throughout the API. Signed-off-by: Tudor Ambarus --- drivers/mailbox/mailbox.c | 127 +++++++++++++++++++++++------ include/linux/mailbox_client.h | 4 + include/linux/mailbox_controller.h | 7 ++ include/linux/mailbox_request.h | 33 ++++++++ 4 files changed, 148 insertions(+), 23 deletions(-) create mode 100644 include/linux/mailbox_request.h diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index d3d26a2c9895..4fe905710458 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -158,6 +158,11 @@ static enum hrtimer_restart txdone_hrtimer(struct hrti= mer *hrtimer) */ void mbox_chan_received_data(struct mbox_chan *chan, void *mssg) { + if (chan->mbox->ops->send_request) { + dev_dbg(chan->mbox->dev, "Operation not supported for mailbox requests\n= "); + return; + } + /* No buffering the received data */ if (chan->cl->rx_callback) chan->cl->rx_callback(chan->cl, mssg); @@ -176,6 +181,11 @@ EXPORT_SYMBOL_GPL(mbox_chan_received_data); */ void mbox_chan_txdone(struct mbox_chan *chan, int r) { + if (chan->mbox->ops->send_request) { + dev_dbg(chan->mbox->dev, "Operation not supported for mailbox requests\n= "); + return; + } + if (unlikely(!(chan->txdone_method & TXDONE_BY_IRQ))) { dev_err(chan->mbox->dev, "Controller can't run the TX ticker\n"); @@ -197,6 +207,11 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone); */ void mbox_client_txdone(struct mbox_chan *chan, int r) { + if (chan->mbox->ops->send_request) { + dev_dbg(chan->mbox->dev, "Operation not supported for mailbox requests\n= "); + return; + } + if (unlikely(!(chan->txdone_method & TXDONE_BY_ACK))) { dev_err(chan->mbox->dev, "Client can't run the TX ticker\n"); return; @@ -261,6 +276,11 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) if (!chan || !chan->cl) return -EINVAL; =20 + if (chan->mbox->ops->send_request) { + dev_dbg(chan->mbox->dev, "Operation not supported for mailbox requests\n= "); + return -EOPNOTSUPP; + } + t =3D add_to_rbuf(chan, mssg); if (t < 0) { dev_err(chan->mbox->dev, "Try increasing MBOX_TX_QUEUE_LEN\n"); @@ -289,6 +309,39 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) } EXPORT_SYMBOL_GPL(mbox_send_message); =20 +int mbox_send_request(struct mbox_chan *chan, struct mbox_request *req) +{ + return chan->mbox->ops->send_request(chan, req); +} +EXPORT_SYMBOL_GPL(mbox_send_request); + +int mbox_wait_request(int err, struct mbox_wait *wait) +{ + switch (err) { + case -EINPROGRESS: + wait_for_completion(&wait->completion); + reinit_completion(&wait->completion); + err =3D wait->err; + break; + } + + return err; +} +EXPORT_SYMBOL_GPL(mbox_wait_request); + +void mbox_request_complete(struct mbox_request *req, int err) +{ + struct mbox_wait *wait; + + if (err =3D=3D -EINPROGRESS) + return; + + wait =3D req->wait; + wait->err =3D err; + complete(&wait->completion); +} +EXPORT_SYMBOL_GPL(mbox_request_complete); + /** * mbox_flush - flush a mailbox channel * @chan: mailbox channel to flush @@ -311,24 +364,44 @@ int mbox_flush(struct mbox_chan *chan, unsigned long = timeout) return -ENOTSUPP; =20 ret =3D chan->mbox->ops->flush(chan, timeout); - if (ret < 0) + if (ret < 0 && !chan->mbox->ops->send_request) tx_tick(chan, ret); =20 return ret; } EXPORT_SYMBOL_GPL(mbox_flush); =20 +static int mbox_chan_startup(struct mbox_chan *chan, struct mbox_client *c= l) +{ + struct mbox_controller *mbox =3D chan->mbox; + struct device *dev =3D cl->dev; + int ret; + + if (!mbox->ops->startup) + return 0; + + ret =3D mbox->ops->startup(chan); + if (ret) { + dev_err(dev, "Unable to startup the chan (%d)\n", ret); + mbox_free_channel(chan); + } + + return ret; +} + static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *= cl) { struct device *dev =3D cl->dev; unsigned long flags; - int ret; =20 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) { dev_dbg(dev, "%s: mailbox not free\n", __func__); return -EBUSY; } =20 + if (chan->mbox->ops->send_request) + return mbox_chan_startup(chan, cl); + spin_lock_irqsave(&chan->lock, flags); chan->msg_free =3D 0; chan->msg_count =3D 0; @@ -341,17 +414,7 @@ static int __mbox_bind_client(struct mbox_chan *chan, = struct mbox_client *cl) =20 spin_unlock_irqrestore(&chan->lock, flags); =20 - if (chan->mbox->ops->startup) { - ret =3D chan->mbox->ops->startup(chan); - - if (ret) { - dev_err(dev, "Unable to startup the chan (%d)\n", ret); - mbox_free_channel(chan); - return ret; - } - } - - return 0; + return mbox_chan_startup(chan, cl); } =20 /** @@ -474,13 +537,18 @@ EXPORT_SYMBOL_GPL(mbox_request_channel_byname); */ void mbox_free_channel(struct mbox_chan *chan) { + struct mbox_controller *mbox; unsigned long flags; =20 if (!chan || !chan->cl) return; =20 - if (chan->mbox->ops->shutdown) - chan->mbox->ops->shutdown(chan); + mbox =3D chan->mbox; + if (mbox->ops->shutdown) + mbox->ops->shutdown(chan); + + if (mbox->ops->send_request) + return module_put(mbox->dev->driver->owner); =20 /* The queued TX requests are simply aborted, no callbacks are made */ spin_lock_irqsave(&chan->lock, flags); @@ -489,7 +557,7 @@ void mbox_free_channel(struct mbox_chan *chan) if (chan->txdone_method =3D=3D TXDONE_BY_ACK) chan->txdone_method =3D TXDONE_BY_POLL; =20 - module_put(chan->mbox->dev->driver->owner); + module_put(mbox->dev->driver->owner); spin_unlock_irqrestore(&chan->lock, flags); } EXPORT_SYMBOL_GPL(mbox_free_channel); @@ -506,6 +574,13 @@ of_mbox_index_xlate(struct mbox_controller *mbox, return &mbox->chans[ind]; } =20 +static void mbox_controller_add_tail(struct mbox_controller *mbox) +{ + mutex_lock(&con_mutex); + list_add_tail(&mbox->node, &mbox_cons); + mutex_unlock(&con_mutex); +} + /** * mbox_controller_register - Register the mailbox controller * @mbox: Pointer to the mailbox controller. @@ -520,6 +595,17 @@ int mbox_controller_register(struct mbox_controller *m= box) if (!mbox || !mbox->dev || !mbox->ops || !mbox->num_chans) return -EINVAL; =20 + if (mbox->ops->send_request && mbox->ops->send_data) + return -EINVAL; + + if (!mbox->of_xlate) + mbox->of_xlate =3D of_mbox_index_xlate; + + if (mbox->ops->send_request) { + mbox_controller_add_tail(mbox); + return 0; + } + if (mbox->txdone_irq) txdone =3D TXDONE_BY_IRQ; else if (mbox->txdone_poll) @@ -549,12 +635,7 @@ int mbox_controller_register(struct mbox_controller *m= box) spin_lock_init(&chan->lock); } =20 - if (!mbox->of_xlate) - mbox->of_xlate =3D of_mbox_index_xlate; - - mutex_lock(&con_mutex); - list_add_tail(&mbox->node, &mbox_cons); - mutex_unlock(&con_mutex); + mbox_controller_add_tail(mbox); =20 return 0; } @@ -578,7 +659,7 @@ void mbox_controller_unregister(struct mbox_controller = *mbox) for (i =3D 0; i < mbox->num_chans; i++) mbox_free_channel(&mbox->chans[i]); =20 - if (mbox->txdone_poll) + if (!mbox->ops->send_request && mbox->txdone_poll) hrtimer_cancel(&mbox->poll_hrt); =20 mutex_unlock(&con_mutex); diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h index 734694912ef7..2eb951fdee0b 100644 --- a/include/linux/mailbox_client.h +++ b/include/linux/mailbox_client.h @@ -9,6 +9,7 @@ =20 #include #include +#include =20 struct mbox_chan; =20 @@ -47,4 +48,7 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /= * atomic */ bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ void mbox_free_channel(struct mbox_chan *chan); /* may sleep */ =20 +int mbox_send_request(struct mbox_chan *chan, struct mbox_request *req); +int mbox_wait_request(int err, struct mbox_wait *wait); + #endif /* __MAILBOX_CLIENT_H */ diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_con= troller.h index 6fee33cb52f5..0582964b10a0 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -8,6 +8,7 @@ #include #include #include +#include =20 struct mbox_chan; =20 @@ -20,6 +21,10 @@ struct mbox_chan; * transmission of data is reported by the controller via * mbox_chan_txdone (if it has some TX ACK irq). It must not * sleep. + * @send_request: The API asks the MBOX controller driver to transmit a me= ssage + * on the bus. The call may be in atomic context. Returns + * -EINPROGRESS if data is fed into hardware, -ENOSPC when = the + * hardware queue is full, or zero when the request complet= es. * @flush: Called when a client requests transmissions to be blocking but * the context doesn't allow sleeping. Typically the controller * will implement a busy loop waiting for the data to flush out. @@ -45,6 +50,7 @@ struct mbox_chan; */ struct mbox_chan_ops { int (*send_data)(struct mbox_chan *chan, void *data); + int (*send_request)(struct mbox_chan *chan, struct mbox_request *req); int (*flush)(struct mbox_chan *chan, unsigned long timeout); int (*startup)(struct mbox_chan *chan); void (*shutdown)(struct mbox_chan *chan); @@ -131,6 +137,7 @@ int mbox_controller_register(struct mbox_controller *mb= ox); /* can sleep */ void mbox_controller_unregister(struct mbox_controller *mbox); /* can slee= p */ void mbox_chan_received_data(struct mbox_chan *chan, void *data); /* atomi= c */ void mbox_chan_txdone(struct mbox_chan *chan, int r); /* atomic */ +void mbox_request_complete(struct mbox_request *req, int err); /*can sleep= */ =20 int devm_mbox_controller_register(struct device *dev, struct mbox_controller *mbox); diff --git a/include/linux/mailbox_request.h b/include/linux/mailbox_reques= t.h new file mode 100644 index 000000000000..69e897e7d3a4 --- /dev/null +++ b/include/linux/mailbox_request.h @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2024 Linaro Ltd. + */ + +#ifndef __MAILBOX_REQUEST_H +#define __MAILBOX_REQUEST_H + +#include +#include +#include + +struct mbox_wait { + struct completion completion; + int err; +}; + +#define DECLARE_MBOX_WAIT(_wait) \ + struct mbox_wait _wait =3D { \ + COMPLETION_INITIALIZER_ONSTACK((_wait).completion), 0 } + +#define MBOX_REQ_MAY_SLEEP BIT(0) + +struct mbox_request { + struct mbox_wait *wait; + void *tx; + void *rx; + unsigned int txlen; + unsigned int rxlen; + u32 flags; +}; + +#endif /* __MAILBOX_H */ --=20 2.47.0.rc1.288.g06298d1525-goog From nobody Tue Nov 26 13:43:18 2024 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E17A1DF727 for ; Thu, 17 Oct 2024 16:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183026; cv=none; b=rHu6fMpY/yU7O1NjJgR6hxkCeRS64JHTIFDE/Xto7tEwREJEACra8njXx7ZGN8ZrSEq51Fm+OBIlNpbGwy10UdTfD7z/DYDlCk4ieNdHA4VQXRKoZbe0OcO9m/17YKXbK8sabIvo4yCAXrYixFBZNL3EWnkFzMFZ9rvhqt7qvJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729183026; c=relaxed/simple; bh=pEAg3BV8hVbp6/IvhRT9mnW0VxRpwj8+ykLv61h9LEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UWbCKaO+nJl3pwQfHTkLoPb3420789Mv7kf+FmUXiBP5y8L5ko3CDK1kHcEZbUVkjPuaGmHkIO52B/A1q91GsWhcCQs1OZQewsB59xwaevZZccnrgo84ijLs7Z1aOamcON8rOLvfAA58ZpYaz2/yR7Z4aWdo1YgySPF+FuyP3N8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Wq/Qf5Nh; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Wq/Qf5Nh" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-37d538fe5f2so923967f8f.2 for ; Thu, 17 Oct 2024 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729183020; x=1729787820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vrs/rkcHckY0+9RCZ7gIRsGkHSYprTIMbd0b9dYUHdY=; b=Wq/Qf5NhGmtwmB6ASrnEIc/fktCdOe+l59pTdi57lPJvGcfq5+dktm7UtIln4oEZqF UHtjvtobbSDcmshFg3loEzbyz2QEVYo5FodePPPghhjYGNtWLnUUnUsS299akDaTAwTR gSx+GCiXs9SFmKdNRnoN+mU+YnhJEzpa00NlA2cNCRtjC5vAnFAk8UhPdSQPzUFlf7h8 kWdjizHLZ5z+nFf7hp0koPZTCxHwcABv38ZGb8vw9T+E838dEaQETKcNsm7dP/SGCti8 lIi7jxxBdyLhlCaSMZFS6QaZH1I7FsyGTocXo03JOdHI0q8a+MV01TmsBJ+1xDhY5qML E3Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183020; x=1729787820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vrs/rkcHckY0+9RCZ7gIRsGkHSYprTIMbd0b9dYUHdY=; b=HEUGpWGVrbSJuh5vLF3+OsXkwrOLimIu1a7SrvbsNlzg7CzdvarsHLQLOWsBGUwOqC mBoJllO++4qnDqoCDT26fH9jKZPupQGWdY5roctsxW3d3td9KQeogAd5nye8/MUm6NBw Ip9fx9+iP7GHJRyHQtW3HEqOTd4Wj/uM06exycIYjYM7+DFoaAY6x1MKroLcRWpHgP8J Y957SO3YCa86r1vCnqISAK1SRpnSHxPP4Z69LL/AfvJHCLex73hmpB++GZSCFcLOObaf oq5M/9UZGljWhv9CJiRCNwL+v5TwqxYIqblPDIpOkJtKrW5QS3WdgErk4+3v84z4YWsG zxsQ== X-Forwarded-Encrypted: i=1; AJvYcCWc35ylq4r37aLvtCgvEFuO2UUtRmDXzSv8pRj+M6m/LhdS2D6ABNvgSIOUGq6yAnIiUxBMKIyxQUkAvvM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHoeq1o0RPnzPBwPgRCHAw3S9zaJZD5ChKn9Amch81eGIxyEif 32W8bEL4PxZ+7I1ZKeyim2JMQ18GOTAdCzgQEal7TYSvf56hoHLySRa5ZnetWhg= X-Google-Smtp-Source: AGHT+IFOyIaYXdCCszo26xoFWnT8Xt5gQHbaygrlHmrifbKPqO9ZzqbIREvSzDxmIyeAWqKvR2U+hA== X-Received: by 2002:a5d:46d1:0:b0:37d:4d31:e86c with SMTP id ffacd0b85a97d-37d5529f0b7mr13944451f8f.44.1729183020361; Thu, 17 Oct 2024 09:37:00 -0700 (PDT) Received: from ta2.c.googlers.com.com (32.134.38.34.bc.googleusercontent.com. [34.38.134.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fc11aefsm7710376f8f.93.2024.10.17.09.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:36:59 -0700 (PDT) From: Tudor Ambarus To: jassisinghbrar@gmail.com, krzk@kernel.org Cc: alim.akhtar@samsung.com, mst@redhat.com, javierm@redhat.com, tzimmermann@suse.de, bartosz.golaszewski@linaro.org, luzmaximilian@gmail.com, sudeep.holla@arm.com, conor.dooley@microchip.com, bjorn@rivosinc.com, ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, marcan@marcan.st, neal@gompa.dev, alyssa@rosenzweig.io, broonie@kernel.org, andre.draszik@linaro.org, willmcvicker@google.com, peter.griffin@linaro.org, kernel-team@android.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Tudor Ambarus Subject: [PATCH v2 2/2] firmware: add exynos acpm driver Date: Thu, 17 Oct 2024 16:36:49 +0000 Message-ID: <20241017163649.3007062-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog In-Reply-To: <20241017163649.3007062-1-tudor.ambarus@linaro.org> References: <20241017163649.3007062-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ACPM (Alive Clock and Power Manager) is a firmware that operates on the APM (Active Power Management) module that handles overall power management activities. ACPM and masters regard each other as independent hardware component and communicate with each other using mailbox messages and shared memory. The mailbox channels are initialized based on the configuration data found at a specific offset into the shared memory (mmio-sram). The configuration data consists of channel id, message and queue lengths, pointers to the RX and TX queues which are also part of the SRAM, and whether RX works by polling or interrupts. All known clients of this driver are using polling channels, thus the driver implements for now just polling mode. Add support for the exynos acpm core driver. Helper drivers will follow. These will construct the mailbox messages in the format expected by the firmware. Signed-off-by: Tudor Ambarus --- drivers/firmware/Kconfig | 1 + drivers/firmware/Makefile | 1 + drivers/firmware/samsung/Kconfig | 11 + drivers/firmware/samsung/Makefile | 3 + drivers/firmware/samsung/exynos-acpm.c | 703 ++++++++++++++++++++ include/linux/mailbox/exynos-acpm-message.h | 21 + 6 files changed, 740 insertions(+) create mode 100644 drivers/firmware/samsung/Kconfig create mode 100644 drivers/firmware/samsung/Makefile create mode 100644 drivers/firmware/samsung/exynos-acpm.c create mode 100644 include/linux/mailbox/exynos-acpm-message.h diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 71d8b26c4103..24edb956831b 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -267,6 +267,7 @@ source "drivers/firmware/meson/Kconfig" source "drivers/firmware/microchip/Kconfig" source "drivers/firmware/psci/Kconfig" source "drivers/firmware/qcom/Kconfig" +source "drivers/firmware/samsung/Kconfig" source "drivers/firmware/smccc/Kconfig" source "drivers/firmware/tegra/Kconfig" source "drivers/firmware/xilinx/Kconfig" diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile index 7a8d486e718f..91efcc868a05 100644 --- a/drivers/firmware/Makefile +++ b/drivers/firmware/Makefile @@ -33,6 +33,7 @@ obj-y +=3D efi/ obj-y +=3D imx/ obj-y +=3D psci/ obj-y +=3D qcom/ +obj-y +=3D samsung/ obj-y +=3D smccc/ obj-y +=3D tegra/ obj-y +=3D xilinx/ diff --git a/drivers/firmware/samsung/Kconfig b/drivers/firmware/samsung/Kc= onfig new file mode 100644 index 000000000000..f908773c1441 --- /dev/null +++ b/drivers/firmware/samsung/Kconfig @@ -0,0 +1,11 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config EXYNOS_ACPM + tristate "Exynos ACPM (Alive Clock and Power Manager) driver support" + select MAILBOX + help + ACPM is a firmware that operates on the APM (Active Power Management) + module that handles overall power management activities. ACPM and + masters regard each other as independent hardware component and + communicate with each other using mailbox messages and shared memory. + This module provides the means to communicate with the ACPM firmware. diff --git a/drivers/firmware/samsung/Makefile b/drivers/firmware/samsung/M= akefile new file mode 100644 index 000000000000..35ff3076bbea --- /dev/null +++ b/drivers/firmware/samsung/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_EXYNOS_ACPM) +=3D exynos-acpm.o diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/sams= ung/exynos-acpm.c new file mode 100644 index 000000000000..c3ad4dc7a9e0 --- /dev/null +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -0,0 +1,703 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2020 Samsung Electronics Co., Ltd. + * Copyright 2020 Google LLC. + * Copyright 2024 Linaro Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define EXYNOS_ACPM_MCUCTRL 0x0 /* Mailbox Control Register */ +#define EXYNOS_ACPM_INTCR0 0x24 /* Interrupt Clear Register 0 */ +#define EXYNOS_ACPM_INTMR0 0x28 /* Interrupt Mask Register 0 */ +#define EXYNOS_ACPM_INTSR0 0x2c /* Interrupt Status Register 0 */ +#define EXYNOS_ACPM_INTMSR0 0x30 /* Interrupt Mask Status Register 0 */ +#define EXYNOS_ACPM_INTGR1 0x40 /* Interrupt Generation Register 1 */ +#define EXYNOS_ACPM_INTMR1 0x48 /* Interrupt Mask Register 1 */ +#define EXYNOS_ACPM_INTSR1 0x4c /* Interrupt Status Register 1 */ +#define EXYNOS_ACPM_INTMSR1 0x50 /* Interrupt Mask Status Register 1 */ + +#define EXYNOS_ACPM_INTMR0_MASK GENMASK(15, 0) +#define EXYNOS_ACPM_PROTOCOL_SEQNUM GENMASK(21, 16) + +/* The unit of counter is 20 us. 5000 * 20 =3D 100 ms */ +#define EXYNOS_ACPM_POLL_TIMEOUT 5000 +#define EXYNOS_ACPM_TX_TIMEOUT_US 500000 + +/** + * struct exynos_acpm_shmem - mailbox shared memory configuration informat= ion. + * @reserved: reserved for future use. + * @chans: offset to array of struct exynos_acpm_shmem_chan. + * @reserved1: reserved for future use. + * @num_chans: number of channels. + */ +struct exynos_acpm_shmem { + u32 reserved[2]; + u32 chans; + u32 reserved1[3]; + u32 num_chans; +}; + +/** + * struct exynos_acpm_shmem_chan - descriptor of a shared memory channel. + * + * @id: channel ID. + * @reserved: reserved for future use. + * @rx_rear: rear pointer of RX queue. + * @rx_front: front pointer of RX queue. + * @rx_base: base address of RX queue. + * @reserved1: reserved for future use. + * @tx_rear: rear pointer of TX queue. + * @tx_front: front pointer of TX queue. + * @tx_base: base address of TX queue. + * @qlen: queue length. Applies to both TX/RX queues. + * @mlen: message length. Applies to both TX/RX queues. + * @reserved2: reserved for future use. + * @polling: true when the channel works on polling. + */ +struct exynos_acpm_shmem_chan { + u32 id; + u32 reserved[3]; + u32 rx_rear; + u32 rx_front; + u32 rx_base; + u32 reserved1[3]; + u32 tx_rear; + u32 tx_front; + u32 tx_base; + u32 qlen; + u32 mlen; + u32 reserved2[2]; + u32 polling; +}; + +/** + * struct exynos_acpm_queue - exynos acpm queue. + * + * @rear: rear address of the queue. + * @front: front address of the queue. + * @base: base address of the queue. + */ +struct exynos_acpm_queue { + void __iomem *rear; + void __iomem *front; + void __iomem *base; +}; + +/** + * struct exynos_acpm_rx_data - RX queue data. + * + * @cmd: pointer to where the data shall be saved. + * @response: true if the client expects the RX data. + */ +struct exynos_acpm_rx_data { + u32 *cmd; + bool response; +}; + +#define EXYNOS_ACPM_SEQNUM_MAX 64 + +/** + * struct exynos_acpm_chan - driver internal representation of a channel. + * @tx: TX queue. The enqueue is done by the host. + * - front index is written by the host. + * - rear index is written by the firmware. + * + * @rx: RX queue. The enqueue is done by the firmware. + * - front index is written by the firmware. + * - rear index is written by the host. + * @rx_lock: protects RX queue. The RX queue is accessed just in + * process context. + * @tx_lock: protects TX queue. + * @qlen: queue length. Applies to both TX/RX queues. + * @mlen: message length. Applies to both TX/RX queues. + * @seqnum: sequence number of the last message enqueued on TX queue. + * @id: channel ID. + * @polling: true when the channel works on polling. + * @bitmap_seqnum: bitmap that tracks the messages on the TX/RX queues. + * @rx_data: internal buffer used to drain the RX queue. + */ +struct exynos_acpm_chan { + struct exynos_acpm_queue tx; + struct exynos_acpm_queue rx; + struct mutex rx_lock; + spinlock_t tx_lock; + + unsigned int qlen; + unsigned int mlen; + u8 seqnum; + u8 id; + bool polling; + + DECLARE_BITMAP(bitmap_seqnum, EXYNOS_ACPM_SEQNUM_MAX - 1); + struct exynos_acpm_rx_data rx_data[EXYNOS_ACPM_SEQNUM_MAX]; +}; + +/** + * struct exynos_acpm - driver's private data. + * @shmem: pointer to the SRAM configuration data. + * @chans: pointer to the ACPM channel parameters retrieved from SRAM. + * @sram_base: base address of SRAM. + * @regs: mailbox registers base address. + * @mbox: pointer to the mailbox controller. + * @wq: pointer to workqueue. + * @dev: pointer to the exynos-acpm device. + * @pclk: pointer to the mailbox peripheral clock. + * @num_chans: number of channels available for this controller. + */ +struct exynos_acpm { + struct exynos_acpm_shmem *shmem; + struct exynos_acpm_chan *chans; + void __iomem *sram_base; + void __iomem *regs; + struct mbox_controller *mbox; + struct workqueue_struct *wq; + struct device *dev; + struct clk *pclk; + u32 num_chans; +}; + +/** + * struct exynos_acpm_work_data - data structure representing the work. + * @mbox_chan: pointer to the mailbox channel. + * @req: pointer to the mailbox request. + * @callback: pointer to a callback function to be invoked upon + * completion of this request. + * @work: describes the task to be executed. + */ +struct exynos_acpm_work_data { + struct mbox_chan *mbox_chan; + struct mbox_request *req; + void (*callback)(struct exynos_acpm_work_data *work_data, int status); + struct work_struct work; +}; + +static int exynos_acpm_get_rx(struct mbox_chan *mbox_chan, + struct mbox_request *req) +{ + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + struct exynos_acpm_message *tx =3D req->tx; + struct exynos_acpm_message *rx =3D req->rx; + struct exynos_acpm_rx_data *rx_data; + const void __iomem *base, *addr; + u32 rx_front, rx_seqnum, tx_seqnum, seqnum; + u32 i, val, mlen; + bool rx_set =3D false; + + rx_front =3D readl_relaxed(chan->rx.front); + i =3D readl_relaxed(chan->rx.rear); + + /* Bail out if RX is empty. */ + if (i =3D=3D rx_front) + return 0; + + base =3D chan->rx.base; + mlen =3D chan->mlen; + + tx_seqnum =3D FIELD_GET(EXYNOS_ACPM_PROTOCOL_SEQNUM, tx->cmd[0]); + + /* Drain RX queue. */ + do { + /* Read RX seqnum. */ + addr =3D base + mlen * i; + val =3D readl_relaxed(addr); + + rx_seqnum =3D FIELD_GET(EXYNOS_ACPM_PROTOCOL_SEQNUM, val); + if (!rx_seqnum) + return -EIO; + /* + * mssg seqnum starts with value 1, whereas the driver considers + * the first mssg at index 0. + */ + seqnum =3D rx_seqnum - 1; + rx_data =3D &chan->rx_data[seqnum]; + + if (rx_data->response) { + if (rx_seqnum =3D=3D tx_seqnum) { + __ioread32_copy(rx->cmd, addr, req->rxlen / 4); + rx_set =3D true; + clear_bit(seqnum, chan->bitmap_seqnum); + } else { + /* + * The RX data corresponds to another request. + * Save the data to drain the queue, but don't + * clear yet the bitmap. It will be cleared + * after the response is copied to the request. + */ + __ioread32_copy(rx_data->cmd, addr, + req->rxlen / 4); + } + } else { + clear_bit(seqnum, chan->bitmap_seqnum); + } + + i =3D (i + 1) % chan->qlen; + } while (i !=3D rx_front); + + /* We saved all responses, mark RX empty. */ + writel_relaxed(rx_front, chan->rx.rear); + + /* Flush SRAM posted writes. */ + readl_relaxed(chan->rx.front); + + /* + * If the response was not in this iteration of the queue, check if the + * RX data was previously saved. + */ + rx_data =3D &chan->rx_data[tx_seqnum - 1]; + if (!rx_set && rx_data->response) { + rx_seqnum =3D FIELD_GET(EXYNOS_ACPM_PROTOCOL_SEQNUM, + rx_data->cmd[0]); + + if (rx_seqnum =3D=3D tx_seqnum) { + memcpy(rx->cmd, rx_data->cmd, req->rxlen); + clear_bit(rx_seqnum - 1, chan->bitmap_seqnum); + } + } + + return 0; +} + +static int exynos_acpm_dequeue_by_polling(struct mbox_chan *mbox_chan, + struct mbox_request *req) +{ + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + struct exynos_acpm_message *tx =3D req->tx; + struct device *dev =3D mbox_chan->mbox->dev; + unsigned int cnt_20us =3D 0; + u32 seqnum; + int ret; + + seqnum =3D FIELD_GET(EXYNOS_ACPM_PROTOCOL_SEQNUM, tx->cmd[0]); + + do { + ret =3D mutex_lock_interruptible(&chan->rx_lock); + if (ret) + return ret; + ret =3D exynos_acpm_get_rx(mbox_chan, req); + mutex_unlock(&chan->rx_lock); + if (ret) + return ret; + + if (!test_bit(seqnum - 1, chan->bitmap_seqnum)) { + dev_vdbg(dev, "cnt_20us =3D %d.\n", cnt_20us); + return 0; + } + + /* Determined experimentally. */ + usleep_range(20, 30); + cnt_20us++; + } while (cnt_20us < EXYNOS_ACPM_POLL_TIMEOUT); + + dev_err(dev, "Timeout! ch:%u s:%u bitmap:%lx, cnt_20us =3D %d.\n", + chan->id, seqnum, chan->bitmap_seqnum[0], cnt_20us); + + return -ETIME; +} + +static void exynos_acpm_done(struct exynos_acpm_work_data *work_data, int = status) +{ + struct mbox_request *req =3D work_data->req; + + kfree(work_data); + mbox_request_complete(req, status); +} + +static void exynos_acpm_work_handler(struct work_struct *work) +{ + struct exynos_acpm_work_data *work_data =3D + container_of(work, struct exynos_acpm_work_data, work); + struct mbox_chan *mbox_chan =3D work_data->mbox_chan; + int ret; + + ret =3D exynos_acpm_dequeue_by_polling(mbox_chan, work_data->req); + work_data->callback(work_data, ret); +} + +static struct exynos_acpm_work_data * + exynos_acpm_init_work(struct mbox_chan *mbox_chan, + struct mbox_request *req) +{ + struct exynos_acpm_work_data *work_data; + gfp_t gfp =3D (req->flags & MBOX_REQ_MAY_SLEEP) ? GFP_KERNEL : GFP_ATOMIC; + + work_data =3D kmalloc(sizeof(*work_data), gfp); + if (!work_data) + return ERR_PTR(-ENOMEM); + + work_data->mbox_chan =3D mbox_chan; + work_data->req =3D req; + work_data->callback =3D exynos_acpm_done; + INIT_WORK(&work_data->work, exynos_acpm_work_handler); + + return work_data; +} + +static void exynos_acpm_prepare_request(struct mbox_chan *mbox_chan, + struct mbox_request *req) +{ + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + struct exynos_acpm_message *tx =3D req->tx; + struct exynos_acpm_rx_data *rx_data; + + /* Prevent chan->seqnum from being re-used */ + do { + if (++chan->seqnum =3D=3D EXYNOS_ACPM_SEQNUM_MAX) + chan->seqnum =3D 1; + } while (test_bit(chan->seqnum - 1, chan->bitmap_seqnum)); + + tx->cmd[0] |=3D FIELD_PREP(EXYNOS_ACPM_PROTOCOL_SEQNUM, chan->seqnum); + + /* Clear data for upcoming responses */ + rx_data =3D &chan->rx_data[chan->seqnum - 1]; + memset(rx_data->cmd, 0, sizeof(*(rx_data->cmd)) * chan->mlen); + if (req->rx) + rx_data->response =3D true; + + /* Flag the index based on seqnum. (seqnum: 1~63, bitmap: 0~62) */ + set_bit(chan->seqnum - 1, chan->bitmap_seqnum); +} + +static int exynos_acpm_wait_for_queue_slots(struct mbox_chan *mbox_chan, + u32 next_tx_front) +{ + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + struct device *dev =3D mbox_chan->mbox->dev; + u32 val, ret; + + /* + * Wait for RX front to keep up with TX front. Make sure there's at + * least one element between them. + */ + ret =3D readl_relaxed_poll_timeout_atomic(chan->rx.front, val, + next_tx_front !=3D val, 1, + EXYNOS_ACPM_TX_TIMEOUT_US); + if (ret) { + dev_err(dev, "RX front can not keep up with TX front.\n"); + return ret; + } + + ret =3D readl_relaxed_poll_timeout_atomic(chan->tx.rear, val, + next_tx_front !=3D val, 1, + EXYNOS_ACPM_TX_TIMEOUT_US); + if (ret) + dev_err(dev, "TX queue is full.\n"); + + return ret; +} + +static int exynos_acpm_send_request(struct mbox_chan *mbox_chan, + struct mbox_request *req) +{ + struct exynos_acpm *exynos_acpm =3D dev_get_drvdata(mbox_chan->mbox->dev); + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + struct exynos_acpm_message *tx =3D req->tx; + struct exynos_acpm_work_data *work_data; + u32 idx, tx_front; + unsigned long flags; + int ret; + + if (!tx || !tx->cmd || req->txlen > chan->mlen || + req->rxlen > chan->mlen) + return -EINVAL; + + work_data =3D exynos_acpm_init_work(mbox_chan, req); + if (IS_ERR(work_data)) + return PTR_ERR(work_data); + + spin_lock_irqsave(&chan->tx_lock, flags); + + tx_front =3D readl_relaxed(chan->tx.front); + idx =3D (tx_front + 1) % chan->qlen; + + ret =3D exynos_acpm_wait_for_queue_slots(mbox_chan, idx); + if (ret) + goto exit; + + exynos_acpm_prepare_request(mbox_chan, req); + + /* Write TX command. */ + __iowrite32_copy(chan->tx.base + chan->mlen * tx_front, tx->cmd, + req->txlen / 4); + + /* Advance TX front. */ + writel_relaxed(idx, chan->tx.front); + + /* Flush SRAM posted writes. */ + readl_relaxed(chan->tx.front); + + /* Generate ACPM interrupt. */ + writel_relaxed(BIT(chan->id), exynos_acpm->regs + EXYNOS_ACPM_INTGR1); + + /* Flush mailbox controller posted writes. */ + readl_relaxed(exynos_acpm->regs + EXYNOS_ACPM_MCUCTRL); + + spin_unlock_irqrestore(&chan->tx_lock, flags); + + queue_work(exynos_acpm->wq, &work_data->work); + + return -EINPROGRESS; +exit: + spin_unlock_irqrestore(&chan->tx_lock, flags); + kfree(work_data); + return ret; +} + +static int exynos_acpm_chan_startup(struct mbox_chan *mbox_chan) +{ + struct exynos_acpm_chan *chan =3D mbox_chan->con_priv; + + if (!chan->polling) { + dev_err(mbox_chan->mbox->dev, "IRQs not supported.\n"); + return -EINVAL; + } + + return 0; +} + +static const struct mbox_chan_ops exynos_acpm_chan_ops =3D { + .send_request =3D exynos_acpm_send_request, + .startup =3D exynos_acpm_chan_startup, +}; + +static void __iomem *exynos_acpm_get_iomem_addr(void __iomem *base, + void __iomem *addr) +{ + u32 offset; + + offset =3D readl_relaxed(addr); + return base + offset; +} + +static void exynos_acpm_rx_queue_init(struct exynos_acpm *exynos_acpm, + struct exynos_acpm_shmem_chan *shmem_chan, + struct exynos_acpm_queue *rx) +{ + void __iomem *base =3D exynos_acpm->sram_base; + + rx->base =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->tx_base); + rx->front =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->tx_front); + rx->rear =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->tx_rear); +} + +static void exynos_acpm_tx_queue_init(struct exynos_acpm *exynos_acpm, + struct exynos_acpm_shmem_chan *shmem_chan, + struct exynos_acpm_queue *tx) +{ + void __iomem *base =3D exynos_acpm->sram_base; + + tx->base =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->rx_base); + tx->front =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->rx_front); + tx->rear =3D exynos_acpm_get_iomem_addr(base, &shmem_chan->rx_rear); +} + +static int exynos_acpm_alloc_cmds(struct exynos_acpm *exynos_acpm, + struct exynos_acpm_chan *chan) +{ + struct device *dev =3D exynos_acpm->dev; + struct exynos_acpm_rx_data *rx_data; + unsigned int mlen =3D chan->mlen; + int i; + + for (i =3D 0; i < EXYNOS_ACPM_SEQNUM_MAX; i++) { + rx_data =3D &chan->rx_data[i]; + rx_data->cmd =3D devm_kcalloc(dev, mlen, sizeof(*(rx_data->cmd)), + GFP_KERNEL); + if (!rx_data->cmd) + return -ENOMEM; + } + + return 0; +} + +static int exynos_acpm_chans_init(struct exynos_acpm *exynos_acpm) +{ + struct exynos_acpm_shmem_chan *shmem_chans, *shmem_chan; + struct exynos_acpm_shmem *shmem =3D exynos_acpm->shmem; + struct mbox_chan *mbox_chan, *mbox_chans; + struct exynos_acpm_chan *chan, *chans; + struct device *dev =3D exynos_acpm->dev; + int i, ret; + + exynos_acpm->num_chans =3D readl_relaxed(&shmem->num_chans); + + mbox_chans =3D devm_kcalloc(dev, exynos_acpm->num_chans, + sizeof(*mbox_chans), GFP_KERNEL); + if (!mbox_chans) + return -ENOMEM; + + chans =3D devm_kcalloc(dev, exynos_acpm->num_chans, sizeof(*chans), + GFP_KERNEL); + if (!chans) + return -ENOMEM; + + shmem_chans =3D exynos_acpm_get_iomem_addr(exynos_acpm->sram_base, + &shmem->chans); + + for (i =3D 0; i < exynos_acpm->num_chans; i++) { + shmem_chan =3D &shmem_chans[i]; + mbox_chan =3D &mbox_chans[i]; + chan =3D &chans[i]; + + /* Set parameters for the mailbox channel. */ + mbox_chan->con_priv =3D chan; + mbox_chan->mbox =3D exynos_acpm->mbox; + + /* Set parameters for the ACPM channel. */ + chan->mlen =3D readl_relaxed(&shmem_chan->mlen); + + ret =3D exynos_acpm_alloc_cmds(exynos_acpm, chan); + if (ret) + return ret; + + chan->polling =3D readl_relaxed(&shmem_chan->polling); + chan->id =3D readl_relaxed(&shmem_chan->id); + chan->qlen =3D readl_relaxed(&shmem_chan->qlen); + + exynos_acpm_rx_queue_init(exynos_acpm, shmem_chan, &chan->rx); + exynos_acpm_tx_queue_init(exynos_acpm, shmem_chan, &chan->tx); + + mutex_init(&chan->rx_lock); + spin_lock_init(&chan->tx_lock); + + dev_vdbg(dev, "ID =3D %d poll =3D %d, mlen =3D %d, qlen =3D %d\n", + chan->id, chan->polling, chan->mlen, chan->qlen); + } + + /* Save pointers to the ACPM and mailbox channels. */ + exynos_acpm->mbox->chans =3D mbox_chans; + exynos_acpm->chans =3D chans; + + return 0; +} + +static const struct of_device_id exynos_acpm_match[] =3D { + { .compatible =3D "google,gs101-acpm" }, + {}, +}; +MODULE_DEVICE_TABLE(of, exynos_acpm_match); + +static int exynos_acpm_probe(struct platform_device *pdev) +{ + struct device_node *node =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; + struct exynos_acpm *exynos_acpm; + struct mbox_controller *mbox; + struct device_node *shmem; + resource_size_t size; + struct resource res; + const __be32 *prop; + int ret; + + exynos_acpm =3D devm_kzalloc(dev, sizeof(*exynos_acpm), GFP_KERNEL); + if (!exynos_acpm) + return -ENOMEM; + + mbox =3D devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL); + if (!mbox) + return -ENOMEM; + + exynos_acpm->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(exynos_acpm->regs)) + return PTR_ERR(exynos_acpm->regs); + + shmem =3D of_parse_phandle(node, "shmem", 0); + ret =3D of_address_to_resource(shmem, 0, &res); + of_node_put(shmem); + if (ret) { + dev_err(dev, "Failed to get shared memory.\n"); + return ret; + } + + size =3D resource_size(&res); + exynos_acpm->sram_base =3D devm_ioremap(dev, res.start, size); + if (!exynos_acpm->sram_base) { + dev_err(dev, "Failed to ioremap shared memory.\n"); + return -ENOMEM; + } + + prop =3D of_get_property(node, "initdata-base", NULL); + if (!prop) { + dev_err(dev, "Parsing initdata_base failed.\n"); + return -EINVAL; + } + + exynos_acpm->pclk =3D devm_clk_get(dev, "pclk"); + if (IS_ERR(exynos_acpm->pclk)) { + dev_err(dev, "Missing peripheral clock.\n"); + return PTR_ERR(exynos_acpm->pclk); + } + + ret =3D clk_prepare_enable(exynos_acpm->pclk); + if (ret) { + dev_err(dev, "Failed to enable the peripheral clock.\n"); + return ret; + } + + exynos_acpm->wq =3D alloc_workqueue("exynos-acpm-wq", 0, 0); + if (!exynos_acpm->wq) + return -ENOMEM; + + exynos_acpm->dev =3D dev; + exynos_acpm->mbox =3D mbox; + exynos_acpm->shmem =3D exynos_acpm->sram_base + be32_to_cpup(prop); + + ret =3D exynos_acpm_chans_init(exynos_acpm); + if (ret) + return ret; + + mbox->num_chans =3D exynos_acpm->num_chans; + mbox->dev =3D dev; + mbox->ops =3D &exynos_acpm_chan_ops; + + platform_set_drvdata(pdev, exynos_acpm); + + /* Mask out all interrupts. We support just polling channels for now. */ + writel_relaxed(EXYNOS_ACPM_INTMR0_MASK, + exynos_acpm->regs + EXYNOS_ACPM_INTMR0); + + ret =3D devm_mbox_controller_register(dev, mbox); + if (ret) + dev_err(dev, "Failed to register mbox_controller(%d).\n", ret); + + return ret; +} + +static void exynos_acpm_remove(struct platform_device *pdev) +{ + struct exynos_acpm *exynos_acpm =3D platform_get_drvdata(pdev); + + flush_workqueue(exynos_acpm->wq); + destroy_workqueue(exynos_acpm->wq); + clk_disable_unprepare(exynos_acpm->pclk); +} + +static struct platform_driver exynos_acpm_driver =3D { + .probe =3D exynos_acpm_probe, + .remove =3D exynos_acpm_remove, + .driver =3D { + .name =3D "exynos-acpm", + .owner =3D THIS_MODULE, + .of_match_table =3D exynos_acpm_match, + }, +}; +module_platform_driver(exynos_acpm_driver); + +MODULE_AUTHOR("Tudor Ambarus "); +MODULE_DESCRIPTION("EXYNOS ACPM mailbox driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mailbox/exynos-acpm-message.h b/include/linux/ma= ilbox/exynos-acpm-message.h new file mode 100644 index 000000000000..3799868c40b8 --- /dev/null +++ b/include/linux/mailbox/exynos-acpm-message.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2024 Linaro Ltd. + */ + +#ifndef _LINUX_EXYNOS_ACPM_MESSAGE_H_ +#define _LINUX_EXYNOS_ACPM_MESSAGE_H_ + +#include + +/** + * struct exynos_acpm_message - exynos ACPM mailbox message format. + * @cmd: pointer to u32 command. + * @len: length of the command. + */ +struct exynos_acpm_message { + u32 *cmd; + size_t len; +}; + +#endif /* _LINUX_EXYNOS_ACPM_MESSAGE_H_ */ --=20 2.47.0.rc1.288.g06298d1525-goog