From nobody Thu Dec 18 21:34:22 2025 Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908EE1DDA24 for ; Thu, 17 Oct 2024 14:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.86.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729175517; cv=none; b=CHr75dykddgenkkjm1wn9MjK3LXXIuwy8MN2UIErUgkwPqUUfUpR03GCmMSaFbcrwzqutrB9DJkJhfBbjwIqkTeDX5QAfNELDekseGw08ptLSiWqu59oyB9fBwl1MIcv2KMwxxp/VTvZbONDngLoGEyjgjkOOiWRdyLUXEETY5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729175517; c=relaxed/simple; bh=pI7lWvnf5Gc0raspsQhtAK6TAnRr7EXkekDltWsfqV0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Q/RXgEa3PIBaFnTB2XQdlbd1juUgoOvvb4pFnUvuLi2OsKoj7T2B6JAeB1cLWxiE8LFZFBoAKeK/Cny8SEn9nmOnTjQRTPUHRiOC2h8faqQH86ZFUArHWCRn3kPRlGcfgczgesOBiW60zvGsgULLxGCuVf2k+HG4L/Z8ACcAVKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b=QyLdbVMZ; arc=none smtp.client-ip=173.37.86.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="QyLdbVMZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=2102; q=dns/txt; s=iport; t=1729175512; x=1730385112; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NNevI5c7bUcc5if4XkYhDFr7yVELYRPdbyKO8NXMmWo=; b=QyLdbVMZM0GeEBuG5lly1Jz8pmB1jbEpfuRpPKqszdZvy4OxfuNSNbOA hjGRvmBt2lmChHHew6ZyajnXrPlG2SNmg5FlqyHvfaLrg6u3cvqKi80as UCRkWdnp72AIHh3BstsqV50IzsLIE8hys7yWoj8odkp8gpmxGTytWgE4B I=; X-CSE-ConnectionGUID: M6RYoCbtSUyOr8sU9hOJYA== X-CSE-MsgGUID: tCCoSDg2QIq+os5+rX8iiw== X-IPAS-Result: =?us-ascii?q?A0AqAAAjHxFn/4v/Ja1aHAEBAQEBAQcBARIBAQQEAQGBe?= =?us-ascii?q?wcBAQsBgkqBT0NIjHKVRpIigSUDVg8BAQEPRAQBAYUHiiQCJjQJDgECBAEBA?= =?us-ascii?q?QEDAgMBAQEBAQEBAQENAQEFAQEBAgEHBYEOE4YIhl0rCwFGKWMxARKDAYJlA?= =?us-ascii?q?65QgXkzgQHeM4FsGIEwAY1FhWcnG4FJRIJQgi2LBwSdbyWJP4Fvj1lIgSEDW?= =?us-ascii?q?SECEQFVEw0KCwkFiTWDAAUhKYFrgQkWgnKCTAKCV4FnCWCEOoMrYoEHLYERg?= =?us-ascii?q?R86R4E8gTYvGyELgiGBNhWBIYEGgk9qTjcCDQI3giQkXIJRhhRAAwsYDUgRL?= =?us-ascii?q?DUGDhsGPm4HrFlGglMHgQ58yBmEJKE/GjOqSwGTIIVXIqQYhGaBZzyBWXAVg?= =?us-ascii?q?yJSGQ/ZIUYyOwIHCwEBAwmOBwEB?= IronPort-Data: A9a23:W5Eh9q75VET7agsN84htawxRtDDGchMFZxGqfqrLsTDasY5as4F+v mBJUWjSPfuDZGKgfNFwbIi3o0wFvpKDzYVjQVFo+y4xZn8b8sCt6fZ1gavT04J+CuWZESqLO u1HMoGowPgcFyKa+1H3dOC4/RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUw6mJSqYDR7zil5 5Wr+qUzBHf/g2QoazpNtPrfwP9SlK2aVA0w7wRWic9j5Dcyp1FNZLoDKKe4KWfPQ4U8NoaSW +bZwbilyXjS9hErB8nNuu6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTaJLwXXxqZwChxLid/ jniWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I0DuKxPRL/tS4E4eGNMiy+FcC311y O0/MmAWU0GDoMCH6efuIgVsrpxLwMjDJogTvDRkiDreF/tjGcqFSKTR7tge1zA17ixMNa+BP IxCNnw1MUmGOkYeUrsUIMpWcOOAjGb2bCdKuVS9rqss6G+Vxwt0uFToGICKJ4DTGZ8Mxy50o Era1E/+OT0VbuW+0HmC6S/vnN+fnCLkDdd6+LqQs6QCbEeo7m8SEx0RU3O4rOO/h0r4XMhQQ 2QK+S0zqYAx+VatQ927WAe3yFaAvxgBS59IE/wS7ACW1rGS4gCXHGEIQzdNLts8u6ceQT0sy 0/MnN7zAzFrmKOaRGjb9bqOqz62fy8PIgc/iTQsVwAJ5Zzn5Yo0lB+KFowlG6+uhdqzEjb1q 9yXkBUDa3wopZZj/82GEZrv027ESkThJuLt2jjqYw== IronPort-HdrOrdr: A9a23:NQDGba7cdCFe3vrEnQPXwMnXdLJyesId70hD6qm+c3Nom6uj5q WTdZsgtCMc5Ax9ZJhCo6HjBED/exPhHPdOiOF7V4tKNzOJhILHFu1fBKLZslnd8lXFh41gPW MKSdkZNDU2ZmIK6vrH3A== X-Talos-CUID: 9a23:i0uKsmBuY0K7q8/6Eww5zn8TMco5SUDM622AOHLpCUFLeZTAHA== X-Talos-MUID: =?us-ascii?q?9a23=3AVoWP7Q/+2G8GgHkIMqQBKIWQf9tDyKOVJE9XqLQ?= =?us-ascii?q?f+M6faG9qC2ecjSviFw=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.11,211,1725321600"; d="scan'208";a="275414211" Received: from rcdn-l-core-02.cisco.com ([173.37.255.139]) by rcdn-iport-5.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 17 Oct 2024 14:30:36 +0000 Received: from sjc-ads-7158.cisco.com (sjc-ads-7158.cisco.com [10.30.217.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-02.cisco.com (Postfix) with ESMTPS id 1E57E18000236; Thu, 17 Oct 2024 14:30:36 +0000 (GMT) Received: by sjc-ads-7158.cisco.com (Postfix, from userid 1776881) id 97BCCCC1280; Thu, 17 Oct 2024 07:30:35 -0700 (PDT) From: Bartosz Wawrzyniak To: Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: xe-linux-external@cisco.com, Daniel Walker , Bartosz Stania , Bartosz Wawrzyniak Subject: [PATCH] phy: cadence: Sierra: Add multilink SGMII + SGMII register configuration Date: Thu, 17 Oct 2024 14:30:08 +0000 Message-Id: <20241017143008.983439-1-bwawrzyn@cisco.com> X-Mailer: git-send-email 2.28.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Auto-Response-Suppress: DR, OOF, AutoReply X-Outbound-SMTP-Client: 10.30.217.233, sjc-ads-7158.cisco.com X-Outbound-Node: rcdn-l-core-02.cisco.com Content-Type: text/plain; charset="utf-8" Add multilink SGMII + SGMII register configuration (no SSC) for the cdns,sierra-phy-t0 compatibility string. In the case of multilink, when two links are of the same type,=20 do not enable PLL LC1. Use PLL LC for both links. Signed-off-by: Bartosz Wawrzyniak --- drivers/phy/cadence/phy-cadence-sierra.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence= /phy-cadence-sierra.c index aeec6eb6be23..c606b281da39 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -1262,12 +1262,18 @@ static int cdns_sierra_phy_configure_multilink(stru= ct cdns_sierra_phy *sp) clk_set_rate(sp->input_clks[CMN_REFCLK_DIG_DIV], 25000000); clk_set_rate(sp->input_clks[CMN_REFCLK1_DIG_DIV], 25000000); =20 - /* PHY configured to use both PLL LC and LC1 */ - regmap_field_write(sp->phy_pll_cfg_1, 0x1); - phy_t1 =3D sp->phys[0].phy_type; phy_t2 =3D sp->phys[1].phy_type; =20 + + /* + * Configure both PLL LC and LC1 when link types are different. + * If both links are of the same type, there is no need to use + * a second PLL. + */ + if (phy_t1 !=3D phy_t2) + regmap_field_write(sp->phy_pll_cfg_1, 0x1); + /* * PHY configuration for multi-link operation is done in two steps. * e.g. Consider a case for a 4 lane PHY with PCIe using 2 lanes and QSGM= II other 2 lanes. @@ -2541,6 +2547,9 @@ static const struct cdns_sierra_data cdns_map_sierra = =3D { [TYPE_NONE] =3D { [NO_SSC] =3D &sgmii_cmn_vals, }, + [TYPE_SGMII] =3D { + [NO_SSC] =3D &sgmii_cmn_vals, + }, [TYPE_PCIE] =3D { [NO_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_cmn_vals, [EXTERNAL_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_cmn_vals, @@ -2582,6 +2591,9 @@ static const struct cdns_sierra_data cdns_map_sierra = =3D { [TYPE_NONE] =3D { [NO_SSC] =3D &sgmii_pma_ln_vals, }, + [TYPE_SGMII] =3D { + [NO_SSC] =3D &sgmii_pma_ln_vals, + }, [TYPE_PCIE] =3D { [NO_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_ln_vals, [EXTERNAL_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_ln_vals, --=20 2.28.0