From nobody Tue Nov 26 17:16:48 2024 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69594770FE for ; Thu, 17 Oct 2024 06:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146742; cv=none; b=NxzT7TOoRMY0r1yUjD4wUsWNBQHdbW5G2WHjTlEu9L2i7RvTetBMWjo4f1R3X1N5B63RXFenlTH/bGNf5FpvBygsx0Z5KQ7yIuaQuotMYywqkzTQwgGMA2SWIFk8YAkSMBK/vqtskYJhhEXlaWKIxA1KF3xYVZOGGmHO4VPfQ9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146742; c=relaxed/simple; bh=0hZlqEhR7nJ33Q9ezfhN9rUbE4E/bxTRVRVNjn3qkDk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YRioeqKhM2NMj1Xtt2GgFBxKIPJHUfQn22csFWNkkpjEWS/Li3GKoe3jBTX/sarUXHqcLixmQfL3gJqN0RAxHcphO2mb3ea38JZ6GTf8ibdBUgkrcGbyjbD666xq8/KBUsf6TTcHFX6+MouHymI6VZaXQN42PjGIYuh5a94sD2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XTdJx6dftzQrld; Thu, 17 Oct 2024 14:31:29 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id B7E6A180AEA; Thu, 17 Oct 2024 14:32:09 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 14:32:08 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 3/4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create() Date: Thu, 17 Oct 2024 14:31:24 +0800 Message-ID: <20241017063125.3080347-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241017063125.3080347-1-ruanjinjie@huawei.com> References: <20241017063125.3080347-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe ttm_device_test and then rmmod ttm_device_test, the following memory leaks occurs: The ttm->pages allocated in ttm_tt_init() is not freed after calling ttm_tt_simple_create(), which cause the memory leak: unreferenced object 0xffffff80caf27750 (size 8): comm "kunit_try_catch", pid 2242, jiffies 4295055735 hex dump (first 8 bytes): c0 1e 3d c3 fe ff ff ff ..=3D..... backtrace (crc 3d11615a): [<000000007f57312a>] kmemleak_alloc+0x34/0x40 [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4 [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144 [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm] [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper] [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000002db94a1f>] kthread+0x2e8/0x374 [<000000002c457ad7>] ret_from_fork+0x10/0x20 ...... Fix it by calling ttm_tt_fini() in the exit function. Cc: stable@vger.kernel.org Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt") Reviewed-by: Nirmoy Das Signed-off-by: Jinjie Ruan --- v3: - s/fllowing/following/ v2: - Add Reviewed-by. --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/dr= m/ttm/tests/ttm_kunit_helpers.c index b91c13f46225..9ff216ec58ef 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buf= fer_object *bo, u32 pag =20 static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *= ttm) { + ttm_tt_fini(ttm); kfree(ttm); } =20 --=20 2.34.1