From nobody Tue Nov 26 15:45:56 2024 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E836E199225 for ; Thu, 17 Oct 2024 06:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146743; cv=none; b=FMYz4DH6qnYz/52MroOe66w01qDjoqGab1I8R8LRaaVf4ZGc88k3OjCtoFkpmsRpnjxzOhFjGXB0gsPgg9Z3O3GQ6aIpRL1fCcgPf3UPOqXWSAglDs3TGdsvJi5LSOGmTaRVzg5BliY/ELt2wSLR1mnRAJlIbbcFUmcB9OL/Cpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146743; c=relaxed/simple; bh=d1k/Uibkv+Qb/y+aFd16WXpfhb1FGOdE+3/mACZ2x2s=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NZO7egKptENCfERWe7sQDfdQ5ocEkzK/9yKLK8T3BZpV3Z9qwsdHmunZ4fPEQ6FX9xi1APFuXwGrbcULNAj3FtK743FvH36CWClrQDPb/DOzL/iiWQYlqAkX4/GsjterXIBW1/G97WCP7WPr3sDUXdY2+KpyViloT1b/JtdW+L8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XTdDp05hvz1HL0F; Thu, 17 Oct 2024 14:27:54 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 3C1A81A016C; Thu, 17 Oct 2024 14:32:08 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 14:32:07 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 1/4] drm/tests: helpers: Add helper for drm_display_mode_from_cea_vic() Date: Thu, 17 Oct 2024 14:31:22 +0800 Message-ID: <20241017063125.3080347-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241017063125.3080347-1-ruanjinjie@huawei.com> References: <20241017063125.3080347-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" As Maxime suggested, add a new helper drm_kunit_display_mode_from_cea_vic(), it can replace the direct call of drm_display_mode_from_cea_vic(), and it will help solving the `mode` memory leaks. Acked-by: Maxime Ripard Suggested-by: Maxime Ripard Signed-off-by: Jinjie Ruan --- v3: - Adjust drm/drm_edid.h header to drm_kunit_helpers.c. - Drop the "helper" in the helper name. - Add Acked-by. --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 40 +++++++++++++++++++++++ include/drm/drm_kunit_helpers.h | 4 +++ 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/te= sts/drm_kunit_helpers.c index aa62719dab0e..565172990044 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -311,6 +312,45 @@ drm_kunit_helper_create_crtc(struct kunit *test, } EXPORT_SYMBOL_GPL(drm_kunit_helper_create_crtc); =20 +static void kunit_action_drm_mode_destroy(void *ptr) +{ + struct drm_display_mode *mode =3D ptr; + + drm_mode_destroy(NULL, mode); +} + +/** + * drm_kunit_display_mode_from_cea_vic() - return a mode for CEA VIC + for a KUnit test + * @test: The test context object + * @dev: DRM device + * @video_code: CEA VIC of the mode + * + * Creates a new mode matching the specified CEA VIC for a KUnit test. + * + * Resources will be cleaned up automatically. + * + * Returns: A new drm_display_mode on success or NULL on failure + */ +struct drm_display_mode * +drm_kunit_display_mode_from_cea_vic(struct kunit *test, struct drm_device = *dev, + u8 video_code) +{ + struct drm_display_mode *mode; + int ret; + + mode =3D drm_display_mode_from_cea_vic(dev, video_code); + + ret =3D kunit_add_action_or_reset(test, + kunit_action_drm_mode_destroy, + mode); + if (ret) + return NULL; + + return mode; +} +EXPORT_SYMBOL_GPL(drm_kunit_display_mode_from_cea_vic); + MODULE_AUTHOR("Maxime Ripard "); MODULE_DESCRIPTION("KUnit test suite helper functions"); MODULE_LICENSE("GPL"); diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helper= s.h index e7cc17ee4934..afdd46ef04f7 100644 --- a/include/drm/drm_kunit_helpers.h +++ b/include/drm/drm_kunit_helpers.h @@ -120,4 +120,8 @@ drm_kunit_helper_create_crtc(struct kunit *test, const struct drm_crtc_funcs *funcs, const struct drm_crtc_helper_funcs *helper_funcs); =20 +struct drm_display_mode * +drm_kunit_display_mode_from_cea_vic(struct kunit *test, struct drm_device = *dev, + u8 video_code); + #endif // DRM_KUNIT_HELPERS_H_ --=20 2.34.1 From nobody Tue Nov 26 15:45:56 2024 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1960770FE for ; Thu, 17 Oct 2024 06:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146736; cv=none; b=XXiaJoiYp49b4qyuefhC697/pJHumo37hOGY5UQV/tLLD0dEZeRnPhHuNdMbhfcKVGJfY2VSfM8Fj3JUZffBLRe+n/zK7HYztoidcESWjv3ArVPizRC+P8lVf6O03zrOReLQ7ojBb0Sq2q74ljqOEnV6dpI5bHKRVOMJyVSBRY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146736; c=relaxed/simple; bh=UltIMtbRajHyqbkzlgyOpJEiBobJAoVqcdsYtEHomeA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ac2IczzwnwodsPv9kkDe2vxPXyp6wJNoGEd/Zp4E88uXm3dERT674Hm2RGNpXQu05z6A5gz4yZ2b/lUKUlLomZUSVL8r0b16M6yGiDPvBbZfPJ6ErLuP+GStYVNgEpK510stAGPn6XrdH0lBU52sE1fqizXgE7e+IT7qvtuB1NQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4XTdJF154vz1SCpc; Thu, 17 Oct 2024 14:30:53 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 0136A1404D8; Thu, 17 Oct 2024 14:32:09 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 14:32:08 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 2/4] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic() Date: Thu, 17 Oct 2024 14:31:23 +0800 Message-ID: <20241017063125.3080347-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241017063125.3080347-1-ruanjinjie@huawei.com> References: <20241017063125.3080347-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe drm_connector_test and then rmmod drm_connector_test, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80cb0ee400 (size 128): comm "kunit_try_catch", pid 1948, jiffies 4294950339 hex dump (first 32 bytes): 14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04 .D............8. 3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00 <.A.e........... backtrace (crc 90e9585c): [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40 [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98 [<00000000d8f2c8b4>] 0xffffffdc982a4868 [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000006ea56ca0>] kthread+0x2e8/0x374 [<000000000676063f>] ret_from_fork+0x10/0x20 ...... Free `mode` by using drm_kunit_display_mode_from_cea_vic() to fix it. Cc: stable@vger.kernel.org Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests") Acked-by: Maxime Ripard Signed-off-by: Jinjie Ruan --- v3: - Update the commit message. - Add Acked-by. v2: - Fix it with new introduced helper instead of drm_mode_destroy(). - Update the commit message. --- drivers/gpu/drm/tests/drm_connector_test.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/t= ests/drm_connector_test.c index 15e36a8db685..6bba97d0be88 100644 --- a/drivers/gpu/drm/tests/drm_connector_test.c +++ b/drivers/gpu/drm/tests/drm_connector_test.c @@ -996,7 +996,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(st= ruct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1017,7 +1017,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1038,7 +1038,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc_vic_1(struct kunit *t unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 rate =3D drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB); @@ -1056,7 +1056,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1077,7 +1077,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc_vic_1(struct kunit *t unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 rate =3D drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB); @@ -1095,7 +1095,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= double(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 6); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 6); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_TRUE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1118,7 +1118,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_valid(struct kunit unsigned long long rate; unsigned int vic =3D *(unsigned int *)test->param_value; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1155,7 +1155,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_10_bpc(struct kuni drm_hdmi_compute_mode_clock_yuv420_vic_valid_tests[0]; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1180,7 +1180,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_12_bpc(struct kuni drm_hdmi_compute_mode_clock_yuv420_vic_valid_tests[0]; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1203,7 +1203,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_8_bpc(struct kunit struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1225,7 +1225,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_10_bpc(struct kuni struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1247,7 +1247,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_12_bpc(struct kuni struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); --=20 2.34.1 From nobody Tue Nov 26 15:45:56 2024 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69594770FE for ; Thu, 17 Oct 2024 06:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146742; cv=none; b=NxzT7TOoRMY0r1yUjD4wUsWNBQHdbW5G2WHjTlEu9L2i7RvTetBMWjo4f1R3X1N5B63RXFenlTH/bGNf5FpvBygsx0Z5KQ7yIuaQuotMYywqkzTQwgGMA2SWIFk8YAkSMBK/vqtskYJhhEXlaWKIxA1KF3xYVZOGGmHO4VPfQ9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146742; c=relaxed/simple; bh=0hZlqEhR7nJ33Q9ezfhN9rUbE4E/bxTRVRVNjn3qkDk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YRioeqKhM2NMj1Xtt2GgFBxKIPJHUfQn22csFWNkkpjEWS/Li3GKoe3jBTX/sarUXHqcLixmQfL3gJqN0RAxHcphO2mb3ea38JZ6GTf8ibdBUgkrcGbyjbD666xq8/KBUsf6TTcHFX6+MouHymI6VZaXQN42PjGIYuh5a94sD2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XTdJx6dftzQrld; Thu, 17 Oct 2024 14:31:29 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id B7E6A180AEA; Thu, 17 Oct 2024 14:32:09 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 14:32:08 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 3/4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create() Date: Thu, 17 Oct 2024 14:31:24 +0800 Message-ID: <20241017063125.3080347-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241017063125.3080347-1-ruanjinjie@huawei.com> References: <20241017063125.3080347-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe ttm_device_test and then rmmod ttm_device_test, the following memory leaks occurs: The ttm->pages allocated in ttm_tt_init() is not freed after calling ttm_tt_simple_create(), which cause the memory leak: unreferenced object 0xffffff80caf27750 (size 8): comm "kunit_try_catch", pid 2242, jiffies 4295055735 hex dump (first 8 bytes): c0 1e 3d c3 fe ff ff ff ..=3D..... backtrace (crc 3d11615a): [<000000007f57312a>] kmemleak_alloc+0x34/0x40 [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4 [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144 [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm] [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper] [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000002db94a1f>] kthread+0x2e8/0x374 [<000000002c457ad7>] ret_from_fork+0x10/0x20 ...... Fix it by calling ttm_tt_fini() in the exit function. Cc: stable@vger.kernel.org Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt") Reviewed-by: Nirmoy Das Signed-off-by: Jinjie Ruan --- v3: - s/fllowing/following/ v2: - Add Reviewed-by. --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/dr= m/ttm/tests/ttm_kunit_helpers.c index b91c13f46225..9ff216ec58ef 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buf= fer_object *bo, u32 pag =20 static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *= ttm) { + ttm_tt_fini(ttm); kfree(ttm); } =20 --=20 2.34.1 From nobody Tue Nov 26 15:45:56 2024 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5B91B6D09 for ; Thu, 17 Oct 2024 06:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146747; cv=none; b=q3aJdkJHSsHetqmtciAdEFbi+rvku31d/m3IwUm3qotCiDO3fxOipnFzV5cR3pT3YQPFlunXc7wqLV2sY2QMaL+xwx7jkKAXrnzr3uuW9iThMzzb9fAZ13MOOrxXF/A1AfFTjfSm/neJIIWC6GjDlOZE292dvDN08mosW5nFQb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729146747; c=relaxed/simple; bh=azXntv+UyVFnf1m8MaiGbtyNsBRlg6UhTczO4U4Ra4I=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J28B4UVbaJ+ep6EOkcm940YWYtXOi5B6fnA8P+XB1PJkJUs1pZZUwnGNx3m5EIdirtWwlZRaaw2WJXqnYrieV6PkeNleyrzqXsxRnLFfZJ4AF81DR2zKFjpOlUL+FzytWi+lQ7bCjg5g7nZWuhtQC8hMQaoaBpIn1BVaUMzqCQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XTdHY0PyPzcpQH; Thu, 17 Oct 2024 14:30:17 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 3F3A81800D2; Thu, 17 Oct 2024 14:32:15 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 14:32:09 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 4/4] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic() Date: Thu, 17 Oct 2024 14:31:25 +0800 Message-ID: <20241017063125.3080347-5-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241017063125.3080347-1-ruanjinjie@huawei.com> References: <20241017063125.3080347-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe drm_hdmi_state_helper_test and then rmmod it, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80ccd18100 (size 128): comm "kunit_try_catch", pid 1851, jiffies 4295059695 hex dump (first 32 bytes): 57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01 Wb........ ..... ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00 ................ backtrace (crc c2f1aa95): [<000000000f10b11b>] kmemleak_alloc+0x34/0x40 [<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c [<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98 [<0000000019daaacf>] 0xffffffedc11ae69c [<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac [<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000000a0b2e9e>] kthread+0x2e8/0x374 [<00000000bd668858>] ret_from_fork+0x10/0x20 ...... Free `mode` by using drm_kunit_display_mode_from_cea_vic() to fix it. Cc: stable@vger.kernel.org Fixes: 4af70f19e559 ("drm/tests: Add RGB Quantization tests") Acked-by: Maxime Ripard Signed-off-by: Jinjie Ruan --- v3: - Update the commit message. - Add Acked-by. v2: - Fix it with new introduced helper instead of drm_mode_destroy(). - Update the commit message. --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/g= pu/drm/tests/drm_hdmi_state_helper_test.c index 34ee95d41f29..294773342e71 100644 --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c @@ -441,7 +441,7 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_= vic_1(struct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -555,7 +555,7 @@ static void drm_test_check_broadcast_rgb_full_cea_mode_= vic_1(struct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -671,7 +671,7 @@ static void drm_test_check_broadcast_rgb_limited_cea_mo= de_vic_1(struct kunit *te ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -1263,7 +1263,7 @@ static void drm_test_check_output_bpc_format_vic_1(st= ruct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 /* --=20 2.34.1