From nobody Tue Nov 26 19:44:52 2024 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E596620B20A; Wed, 16 Oct 2024 12:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729082598; cv=none; b=Okodrv6MVqbXI5JjXoTuOGq5j50l+ixW/M4n5T9qCNbEQgyjiHUr4olVhDZD4yqkIgrm0nVJlfEGF3Up9i5lJmI3sIIm055pvadEGauOOlQty/Lee6dwVUo+VW82egU1peRse/Wj5lNXIo4BKnIOTEiUI2qubRO5060S1kuHy00= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729082598; c=relaxed/simple; bh=LBdAfU8Kqu/fwBNvbyHjVHYadinYm9GDo39TryH+pVo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=me4a64EymR4QEwng57CphtQcJviTnumoYYI20w9fVdReLYLcFvPjxOR6+2FIv3ELSpOAg+LjCTvSkd/j6wNfmosB6bTQ53fbZnMT+6M6ri32mBYJpE4nRa8xdPLGauho9uXaBvgU/XUxf+8T3L+JyeX3HQZMdVT9sbuAJ17I/ys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=Ug25Oite; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="Ug25Oite" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49GBRcaj026281; Wed, 16 Oct 2024 14:43:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= +kNC9WvxILqPos1K+zUy/g4I3JBkEYea0nY08omeYVo=; b=Ug25OiteKs9hbXIj T4M0T9XVnlyrQmTz6Gs/6zZV594KdIlbcNJM9RT4ACvtO09InkZREJWkFhKoJVio xJfhf4CC7642GUgKY1kIo/wwiYDyTUePUi8KEYBkb6+B7w3wCOQX0wleyO7LaJoz CWY9BNEAwmVhSdkFrVau8S0gyvbeP3U8vRULaKAFeR0IEKmsgQtep3qyQE1uuliz GirNip8klunxWgFvR6sNufKrR78Y9e0CKjypsnxCHU+YJQs+Rlyg0z/ARNjtxuj3 ywV5yQV2scoHlOITXcDO/YgEnnqWsmoQUlxGSvloV+Kry2OBgISGXI0ZKLd/ih5g quVL8w== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 42842jfv6p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2024 14:43:07 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id B75BF40051; Wed, 16 Oct 2024 14:41:24 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EAD9F23CB5B; Wed, 16 Oct 2024 14:40:24 +0200 (CEST) Received: from localhost (10.252.17.239) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Wed, 16 Oct 2024 14:40:24 +0200 From: Amelie Delaunay Date: Wed, 16 Oct 2024 14:39:58 +0200 Subject: [PATCH v3 6/9] dmaengine: stm32-dma3: clamp AXI burst using match data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20241016-dma3-mp25-updates-v3-6-8311fe6f228d@foss.st.com> References: <20241016-dma3-mp25-updates-v3-0-8311fe6f228d@foss.st.com> In-Reply-To: <20241016-dma3-mp25-updates-v3-0-8311fe6f228d@foss.st.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue CC: , , , , , Amelie Delaunay X-Mailer: b4 0.14.2 X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 STM32 DMA3 can be interconnected with AXI3 or AXI4 busses. In case it is interconnected with AXI3, the maximum burst length supported by AXI3 protocol is 16 beats, which is lower than the maximum burst length supported by STM32 DMA3. So the programmed burst has to be shortened when AXI port is used. Introduce struct stm32_dma3_pdata to specify the specific configurations (e.g. AXI maximum burst length) required by the SoC, so implied by the SoC specific compatible. Signed-off-by: Amelie Delaunay --- Changes in v2: - Rework AXI maximum burst length management using SoC specific compatible instead of st,axi-max-burst-len DT property, as pointed out by Rob. --- drivers/dma/stm32/stm32-dma3.c | 59 ++++++++++++++++++++++++++++++++------= ---- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c index fc874fec729df733fd8a6b4362fe1a937e9443c7..0c6c4258b19561c94f1c68f26ad= e16b82660ebe6 100644 --- a/drivers/dma/stm32/stm32-dma3.c +++ b/drivers/dma/stm32/stm32-dma3.c @@ -230,6 +230,8 @@ enum stm32_dma3_port_data_width { #define STM32_DMA3_CFG_SET_BOTH (STM32_DMA3_CFG_SET_DT | STM32_DMA3_CFG_S= ET_DMA) =20 #define STM32_DMA3_MAX_BLOCK_SIZE ALIGN_DOWN(CBR1_BNDT, 64) +#define STM32_DMA3_MAX_BURST_LEN (1 + min_t(u32, FIELD_MAX(CTR1_SBL_1), \ + FIELD_MAX(CTR1_DBL_1))) #define port_is_ahb(maxdw) ({ typeof(maxdw) (_maxdw) =3D (maxdw); \ ((_maxdw) !=3D DW_INVALID) && ((_maxdw) =3D=3D DW_32); }) #define port_is_axi(maxdw) ({ typeof(maxdw) (_maxdw) =3D (maxdw); \ @@ -295,6 +297,10 @@ struct stm32_dma3_chan { u32 dma_status; }; =20 +struct stm32_dma3_pdata { + u32 axi_max_burst_len; +}; + struct stm32_dma3_ddata { struct dma_device dma_dev; void __iomem *base; @@ -303,6 +309,7 @@ struct stm32_dma3_ddata { u32 dma_channels; u32 dma_requests; enum stm32_dma3_port_data_width ports_max_dw[2]; + u32 axi_max_burst_len; }; =20 static inline struct stm32_dma3_ddata *to_stm32_dma3_ddata(struct stm32_dm= a3_chan *chan) @@ -535,7 +542,8 @@ static enum dma_slave_buswidth stm32_dma3_get_max_dw(u3= 2 chan_max_burst, return 1 << __ffs(len | addr | max_dw); } =20 -static u32 stm32_dma3_get_max_burst(u32 len, enum dma_slave_buswidth dw, u= 32 chan_max_burst) +static u32 stm32_dma3_get_max_burst(u32 len, enum dma_slave_buswidth dw, + u32 chan_max_burst, u32 bus_max_burst) { u32 max_burst =3D chan_max_burst ? chan_max_burst / dw : 1; =20 @@ -546,8 +554,9 @@ static u32 stm32_dma3_get_max_burst(u32 len, enum dma_s= lave_buswidth dw, u32 cha /* * HW doesn't modify the burst if burst size <=3D half of the fifo size. * If len is not a multiple of burst size, last burst is shortened by HW. + * Take care of maximum burst supported on interconnect bus. */ - return max_burst; + return min_t(u32, max_burst, bus_max_burst); } =20 static int stm32_dma3_chan_prep_hw(struct stm32_dma3_chan *chan, enum dma_= transfer_direction dir, @@ -556,6 +565,7 @@ static int stm32_dma3_chan_prep_hw(struct stm32_dma3_ch= an *chan, enum dma_transf { struct stm32_dma3_ddata *ddata =3D to_stm32_dma3_ddata(chan); struct dma_device dma_device =3D ddata->dma_dev; + u32 src_max_burst =3D STM32_DMA3_MAX_BURST_LEN, dst_max_burst =3D STM32_D= MA3_MAX_BURST_LEN; u32 sdw, ddw, sbl_max, dbl_max, tcem, init_dw, init_bl_max; u32 _ctr1 =3D 0, _ctr2 =3D 0; u32 ch_conf =3D chan->dt_config.ch_conf; @@ -596,10 +606,14 @@ static int stm32_dma3_chan_prep_hw(struct stm32_dma3_= chan *chan, enum dma_transf _ctr1 |=3D CTR1_SINC; if (sap) _ctr1 |=3D CTR1_SAP; + if (port_is_axi(sap_max_dw)) /* AXI - apply axi maximum burst limitation = */ + src_max_burst =3D ddata->axi_max_burst_len; if (FIELD_GET(STM32_DMA3_DT_DINC, tr_conf)) _ctr1 |=3D CTR1_DINC; if (dap) _ctr1 |=3D CTR1_DAP; + if (port_is_axi(dap_max_dw)) /* AXI - apply axi maximum burst limitation = */ + dst_max_burst =3D ddata->axi_max_burst_len; =20 _ctr2 |=3D FIELD_PREP(CTR2_REQSEL, chan->dt_config.req_line) & ~CTR2_SWRE= Q; if (FIELD_GET(STM32_DMA3_DT_BREQ, tr_conf)) @@ -619,11 +633,12 @@ static int stm32_dma3_chan_prep_hw(struct stm32_dma3_= chan *chan, enum dma_transf /* Set destination (device) data width and burst */ ddw =3D min_t(u32, ddw, stm32_dma3_get_max_dw(chan->max_burst, dap_max_d= w, len, dst_addr)); - dbl_max =3D min_t(u32, dbl_max, stm32_dma3_get_max_burst(len, ddw, chan-= >max_burst)); + dbl_max =3D min_t(u32, dbl_max, stm32_dma3_get_max_burst(len, ddw, chan-= >max_burst, + dst_max_burst)); =20 /* Set source (memory) data width and burst */ sdw =3D stm32_dma3_get_max_dw(chan->max_burst, sap_max_dw, len, src_addr= ); - sbl_max =3D stm32_dma3_get_max_burst(len, sdw, chan->max_burst); + sbl_max =3D stm32_dma3_get_max_burst(len, sdw, chan->max_burst, src_max_= burst); if (!!FIELD_GET(STM32_DMA3_DT_NOPACK, tr_conf)) { sdw =3D ddw; sbl_max =3D dbl_max; @@ -653,11 +668,12 @@ static int stm32_dma3_chan_prep_hw(struct stm32_dma3_= chan *chan, enum dma_transf /* Set source (device) data width and burst */ sdw =3D min_t(u32, sdw, stm32_dma3_get_max_dw(chan->max_burst, sap_max_d= w, len, src_addr)); - sbl_max =3D min_t(u32, sbl_max, stm32_dma3_get_max_burst(len, sdw, chan-= >max_burst)); + sbl_max =3D min_t(u32, sbl_max, stm32_dma3_get_max_burst(len, sdw, chan-= >max_burst, + src_max_burst)); =20 /* Set destination (memory) data width and burst */ ddw =3D stm32_dma3_get_max_dw(chan->max_burst, dap_max_dw, len, dst_addr= ); - dbl_max =3D stm32_dma3_get_max_burst(len, ddw, chan->max_burst); + dbl_max =3D stm32_dma3_get_max_burst(len, ddw, chan->max_burst, dst_max_= burst); if (!!FIELD_GET(STM32_DMA3_DT_NOPACK, tr_conf) || ((_ctr2 & CTR2_PFREQ) && ddw > sdw)) { /* Packing to wider ddw not s= upported */ ddw =3D sdw; @@ -689,22 +705,24 @@ static int stm32_dma3_chan_prep_hw(struct stm32_dma3_= chan *chan, enum dma_transf init_dw =3D sdw; init_bl_max =3D sbl_max; sdw =3D stm32_dma3_get_max_dw(chan->max_burst, sap_max_dw, len, src_addr= ); - sbl_max =3D stm32_dma3_get_max_burst(len, sdw, chan->max_burst); + sbl_max =3D stm32_dma3_get_max_burst(len, sdw, chan->max_burst, src_max_= burst); if (chan->config_set & STM32_DMA3_CFG_SET_DMA) { sdw =3D min_t(u32, init_dw, sdw); - sbl_max =3D min_t(u32, init_bl_max, - stm32_dma3_get_max_burst(len, sdw, chan->max_burst)); + sbl_max =3D min_t(u32, init_bl_max, stm32_dma3_get_max_burst(len, sdw, + chan->max_burst, + src_max_burst)); } =20 /* Set destination (memory) data width and burst */ init_dw =3D ddw; init_bl_max =3D dbl_max; ddw =3D stm32_dma3_get_max_dw(chan->max_burst, dap_max_dw, len, dst_addr= ); - dbl_max =3D stm32_dma3_get_max_burst(len, ddw, chan->max_burst); + dbl_max =3D stm32_dma3_get_max_burst(len, ddw, chan->max_burst, dst_max_= burst); if (chan->config_set & STM32_DMA3_CFG_SET_DMA) { ddw =3D min_t(u32, init_dw, ddw); - dbl_max =3D min_t(u32, init_bl_max, - stm32_dma3_get_max_burst(len, ddw, chan->max_burst)); + dbl_max =3D min_t(u32, init_bl_max, stm32_dma3_get_max_burst(len, ddw, + chan->max_burst, + dst_max_burst)); } =20 _ctr1 |=3D FIELD_PREP(CTR1_SDW_LOG2, ilog2(sdw)); @@ -1647,8 +1665,12 @@ static u32 stm32_dma3_check_rif(struct stm32_dma3_dd= ata *ddata) return chan_reserved; } =20 +static struct stm32_dma3_pdata stm32mp25_pdata =3D { + .axi_max_burst_len =3D 16, +}; + static const struct of_device_id stm32_dma3_of_match[] =3D { - { .compatible =3D "st,stm32mp25-dma3", }, + { .compatible =3D "st,stm32mp25-dma3", .data =3D &stm32mp25_pdata, }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, stm32_dma3_of_match); @@ -1656,6 +1678,7 @@ MODULE_DEVICE_TABLE(of, stm32_dma3_of_match); static int stm32_dma3_probe(struct platform_device *pdev) { struct device_node *np =3D pdev->dev.of_node; + const struct stm32_dma3_pdata *pdata; struct stm32_dma3_ddata *ddata; struct reset_control *reset; struct stm32_dma3_chan *chan; @@ -1750,6 +1773,16 @@ static int stm32_dma3_probe(struct platform_device *= pdev) else /* Dual master ports */ ddata->ports_max_dw[1] =3D FIELD_GET(G_M1_DATA_WIDTH_ENC, hwcfgr); =20 + /* axi_max_burst_len is optional, if not defined, use STM32_DMA3_MAX_BURS= T_LEN */ + ddata->axi_max_burst_len =3D STM32_DMA3_MAX_BURST_LEN; + pdata =3D device_get_match_data(&pdev->dev); + if (pdata && pdata->axi_max_burst_len) { + ddata->axi_max_burst_len =3D min_t(u32, pdata->axi_max_burst_len, + STM32_DMA3_MAX_BURST_LEN); + dev_dbg(&pdev->dev, "Burst is limited to %u beats through AXI port\n", + ddata->axi_max_burst_len); + } + ddata->chans =3D devm_kcalloc(&pdev->dev, ddata->dma_channels, sizeof(*dd= ata->chans), GFP_KERNEL); if (!ddata->chans) { --=20 2.25.1