From nobody Thu Dec 18 01:35:45 2025 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED250487A7; Mon, 14 Oct 2024 14:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917963; cv=none; b=I6yP5wp3cXmePJ5VSFP3SQ9p6UfsrFMG5Tl3Xt689j/DNmgFo+x9qYqZwMETt2yYlymN0D8Fisjx4OHAK5g9BJZqOqJDBxL2o92giWQxvWVqifCkPEIb8NxkuvSEB+6E9cPP8rneRFg0Py00+twSmxoDfkrQsdocT4athEnvuuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917963; c=relaxed/simple; bh=Dn19zreLRYH2na7zl/0Opm3qa+PxmwWRcIXTE94fpZs=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=d7HkFvP3opQoqR0I8321Octs0HH0z1bblVbHtqBPw6duujbDMGdEhRLb1KkmMWd1J9GBqY6M7pzhP9uIySE9LFi0iYFFQSvd6s9oYXFsQQyBL4w1zCaR8LNsS2rmcv3XcBQ9NfJihW1tfYJIoj3iXmeo3JQLQK3Cx0RQs0Uqzq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XS0h64Rc0z10N2f; Mon, 14 Oct 2024 22:57:26 +0800 (CST) Received: from kwepemm600001.china.huawei.com (unknown [7.193.23.3]) by mail.maildlp.com (Postfix) with ESMTPS id 01DC31800A7; Mon, 14 Oct 2024 22:59:17 +0800 (CST) Received: from huawei.com (10.175.113.133) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 22:59:15 +0800 From: Wang Hai To: , , , , , , , CC: , , , Subject: [PATCH net] net: bcmasp: fix potential memory leak in bcmasp_xmit() Date: Mon, 14 Oct 2024 22:59:01 +0800 Message-ID: <20241014145901.48940-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600001.china.huawei.com (7.193.23.3) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bcmasp_xmit() returns NETDEV_TX_OK without freeing skb in case of mapping fails, add dev_kfree_skb() to fix it. Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controll= er") Signed-off-by: Wang Hai Acked-by: Florian Fainelli --- drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c b/drivers/net= /ethernet/broadcom/asp2/bcmasp_intf.c index 82768b0e9026..9ea16ef4139d 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c @@ -322,6 +322,7 @@ static netdev_tx_t bcmasp_xmit(struct sk_buff *skb, str= uct net_device *dev) } /* Rewind so we do not have a hole */ spb_index =3D intf->tx_spb_index; + dev_kfree_skb(skb); return NETDEV_TX_OK; } =20 --=20 2.17.1