From nobody Wed Nov 27 02:21:09 2024 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540771A7275 for ; Mon, 14 Oct 2024 12:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910376; cv=none; b=cCDFCWaLFlp0KZBYXe2d2vp6m0NQxZ1V2G/DSF7VaowuIEibyX9sDe4blZFhleHgc8bZW9hQSm/1AUzFniG2iLX3h7Asq6ANdX244y5TSxGr5HdVbZaKpp1eNa2fBihjJzgQOpXau1mnbn43+N+EMjVQR0iQGUFkiOa4XwifIRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910376; c=relaxed/simple; bh=FdbJUPlIx2zWYl/6K63Iy8akE/QfoWgojt2z2IKvj5A=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R4f5VMYLMKj3JDVkuy5gIGyuCrFFGjo8riHkt4hFSOOm65O1VMU/l5GY17kxpKvk203Mlep9OM+eyINb6IBdHVPXuI4zCgNuaAXDEQP1zVFmotcHgn3mK8Crf+JDo+xG8pcJv4auySTHWSEzpbv5dq8+ba6ILat9y/h/OYzoGGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XRxqX2Q7kz1HKsX; Mon, 14 Oct 2024 20:48:40 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 903AD1400DA; Mon, 14 Oct 2024 20:52:51 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 20:52:50 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 1/4] drm/tests: helpers: Add helper for drm_display_mode_from_cea_vic() Date: Mon, 14 Oct 2024 20:52:01 +0800 Message-ID: <20241014125204.1294934-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014125204.1294934-1-ruanjinjie@huawei.com> References: <20241014125204.1294934-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" As Maxime suggested, add a new helper drm_kunit_helper_display_mode_from_cea_vic(), it can replace the direct call of drm_display_mode_from_cea_vic(), and it will help solving the `mode` memory leaks. Suggested-by: Maxime Ripard Signed-off-by: Jinjie Ruan Acked-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 40 +++++++++++++++++++++++ include/drm/drm_kunit_helpers.h | 6 ++++ 2 files changed, 46 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/te= sts/drm_kunit_helpers.c index aa62719dab0e..dc70bafcd394 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -311,6 +311,46 @@ drm_kunit_helper_create_crtc(struct kunit *test, } EXPORT_SYMBOL_GPL(drm_kunit_helper_create_crtc); =20 +static void kunit_action_drm_mode_destroy(void *ptr) +{ + struct drm_display_mode *mode =3D ptr; + + drm_mode_destroy(NULL, mode); +} + +/** + * drm_kunit_helper_display_mode_from_cea_vic() - return a mode for CEA VIC + for a KUnit test + * @test: The test context object + * @dev: DRM device + * @video_code: CEA VIC of the mode + * + * Creates a new mode matching the specified CEA VIC for a KUnit test. + * + * Resources will be cleaned up automatically. + * + * Returns: A new drm_display_mode on success or NULL on failure + */ +struct drm_display_mode * +drm_kunit_helper_display_mode_from_cea_vic(struct kunit *test, + struct drm_device *dev, + u8 video_code) +{ + struct drm_display_mode *mode; + int ret; + + mode =3D drm_display_mode_from_cea_vic(dev, video_code); + + ret =3D kunit_add_action_or_reset(test, + kunit_action_drm_mode_destroy, + mode); + if (ret) + return NULL; + + return mode; +} +EXPORT_SYMBOL_GPL(drm_kunit_helper_display_mode_from_cea_vic); + MODULE_AUTHOR("Maxime Ripard "); MODULE_DESCRIPTION("KUnit test suite helper functions"); MODULE_LICENSE("GPL"); diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helper= s.h index e7cc17ee4934..1e7fd4be550c 100644 --- a/include/drm/drm_kunit_helpers.h +++ b/include/drm/drm_kunit_helpers.h @@ -4,6 +4,7 @@ #define DRM_KUNIT_HELPERS_H_ =20 #include +#include =20 #include =20 @@ -120,4 +121,9 @@ drm_kunit_helper_create_crtc(struct kunit *test, const struct drm_crtc_funcs *funcs, const struct drm_crtc_helper_funcs *helper_funcs); =20 +struct drm_display_mode * +drm_kunit_helper_display_mode_from_cea_vic(struct kunit *test, + struct drm_device *dev, + u8 video_code); + #endif // DRM_KUNIT_HELPERS_H_ --=20 2.34.1 From nobody Wed Nov 27 02:21:09 2024 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5BA1A76C6 for ; Mon, 14 Oct 2024 12:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910378; cv=none; b=ikJde8uWm5fO3h6/+Y/qojRXtSy9Z+tY0UGHu3VXrp7L6Dxo5VgwuAtWcbaPAew6Mpd5UPmBMVcSo/4ujrB4ranz8BMW8WleCbuAD9eV1m8WsCwN04cqlH81JirRSwmxttYx3Tge8IM8yp3w7BM2GqhN2LDEbGNVB5gN+LAmEcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910378; c=relaxed/simple; bh=hkOe6Mz+QoI+omYih6490z25tBowWTNr3lBt1bhBm4U=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mT+0WyCOsoioelqzjXd160lM9qaesdKUEtw3kMB6GpsS8STRAXRAYkxWnidzo+MC5a0O3UsQdwtqa6ACh5Cg87vAnVNnrhizfP3zhO6HYk2LQwzB8XFqoPqz7AtwgaP6WX3yuJk0DjymGsqpyBsAMPDXGwCIj+nqcDd+JVm4LIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XRxtG08jBz10N3n; Mon, 14 Oct 2024 20:51:02 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 41375180AE9; Mon, 14 Oct 2024 20:52:52 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 20:52:51 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 2/4] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic() Date: Mon, 14 Oct 2024 20:52:02 +0800 Message-ID: <20241014125204.1294934-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014125204.1294934-1-ruanjinjie@huawei.com> References: <20241014125204.1294934-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe drm_connector_test and then rmmod drm_connector_test, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80cb0ee400 (size 128): comm "kunit_try_catch", pid 1948, jiffies 4294950339 hex dump (first 32 bytes): 14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04 .D............8. 3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00 <.A.e........... backtrace (crc 90e9585c): [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40 [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98 [<00000000d8f2c8b4>] 0xffffffdc982a4868 [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000006ea56ca0>] kthread+0x2e8/0x374 [<000000000676063f>] ret_from_fork+0x10/0x20 ...... Free `mode` by using drm_kunit_helper_display_mode_from_cea_vic() to fix it. Cc: stable@vger.kernel.org Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests") Signed-off-by: Jinjie Ruan Acked-by: Maxime Ripard --- v2: - Fix it with new introduced helper instead of drm_mode_destroy(). - Update the commit message. --- drivers/gpu/drm/tests/drm_connector_test.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/t= ests/drm_connector_test.c index 15e36a8db685..e12b39dc4fe7 100644 --- a/drivers/gpu/drm/tests/drm_connector_test.c +++ b/drivers/gpu/drm/tests/drm_connector_test.c @@ -996,7 +996,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(st= ruct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1017,7 +1017,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1038,7 +1038,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc_vic_1(struct kunit *t unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 rate =3D drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB); @@ -1056,7 +1056,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1077,7 +1077,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc_vic_1(struct kunit *t unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 rate =3D drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB); @@ -1095,7 +1095,7 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= double(struct kunit *test) unsigned long long rate; struct drm_device *drm =3D &priv->drm; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 6); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 6); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_TRUE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1118,7 +1118,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_valid(struct kunit unsigned long long rate; unsigned int vic =3D *(unsigned int *)test->param_value; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1155,7 +1155,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_10_bpc(struct kuni drm_hdmi_compute_mode_clock_yuv420_vic_valid_tests[0]; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1180,7 +1180,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_12_bpc(struct kuni drm_hdmi_compute_mode_clock_yuv420_vic_valid_tests[0]; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, vic); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, vic); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1203,7 +1203,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_8_bpc(struct kunit struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1225,7 +1225,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_10_bpc(struct kuni struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); @@ -1247,7 +1247,7 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_12_bpc(struct kuni struct drm_device *drm =3D &priv->drm; unsigned long long rate; =20 - mode =3D drm_display_mode_from_cea_vic(drm, 16); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 16); KUNIT_ASSERT_NOT_NULL(test, mode); =20 KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK); --=20 2.34.1 From nobody Wed Nov 27 02:21:09 2024 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B97B1A726B for ; Mon, 14 Oct 2024 12:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910377; cv=none; b=Cm6OtCvIeaWhe5zocrtao/RPuajWOSCEs1hPEXVZFlUrXkmpDL94hddAgClXyVNOkv092uKATfQ/M0Tg0hMgMDFi23DjX+LidvWA2kTyeQh/hhRH8wYa4i4YACFJeBxf8rUSRfAXDPq66ukxk/Xe6+73ZaWGWpjinyysf3EZ1m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910377; c=relaxed/simple; bh=htlXRjKP1CbaIGWRn8PJZGLjByyds0LcGHFb9tP94J4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OQkF6rx4ahCAj9zvRHIMAWKIgpN6+c6FAKMeuUv2A4IaT3XMXhphUHtf+od71O4aquHWUpWAIjezotAYqHGymxQPwwUTkDvksZUdJvgWuK8VPXY3iY/orAqyxrIOt2+ssbv+3VYlK3nl1gQIIdJdU2FE0vdBynMFb7xejtXbts0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XRxvZ41mjzQrhc; Mon, 14 Oct 2024 20:52:10 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id CF98A1400D8; Mon, 14 Oct 2024 20:52:52 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 20:52:52 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 3/4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create() Date: Mon, 14 Oct 2024 20:52:03 +0800 Message-ID: <20241014125204.1294934-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014125204.1294934-1-ruanjinjie@huawei.com> References: <20241014125204.1294934-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe ttm_device_test and then rmmod ttm_device_test, the fllowing memory leaks occurs: The ttm->pages allocated in ttm_tt_init() is not freed after calling ttm_tt_simple_create(), which cause the memory leak: unreferenced object 0xffffff80caf27750 (size 8): comm "kunit_try_catch", pid 2242, jiffies 4295055735 hex dump (first 8 bytes): c0 1e 3d c3 fe ff ff ff ..=3D..... backtrace (crc 3d11615a): [<000000007f57312a>] kmemleak_alloc+0x34/0x40 [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4 [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144 [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm] [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper] [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000002db94a1f>] kthread+0x2e8/0x374 [<000000002c457ad7>] ret_from_fork+0x10/0x20 ...... Fix it by calling ttm_tt_fini() in the exit function. Cc: stable@vger.kernel.org Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt") Reviewed-by: Nirmoy Das Signed-off-by: Jinjie Ruan --- v2: - Add Reviewed-by. --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/dr= m/ttm/tests/ttm_kunit_helpers.c index b91c13f46225..9ff216ec58ef 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buf= fer_object *bo, u32 pag =20 static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *= ttm) { + ttm_tt_fini(ttm); kfree(ttm); } =20 --=20 2.34.1 From nobody Wed Nov 27 02:21:09 2024 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DCC1A76AC for ; Mon, 14 Oct 2024 12:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910378; cv=none; b=jgEj4LsV7t2CM2KCkjf7aU1z9QKLow6QMfGQnweG889sTram94ACnEDN2hMDu5JMPFW/qAKgyq6FrbA9cjR9j1XUEb+U9ICihDFthHu7nTZ100NUlaJ+evUgOlvJXznFcepjFQ0XRLzWeWvKp5d1O9ZURUdNCVl+3cSa7XDDkZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910378; c=relaxed/simple; bh=z0n8+A7AO6Mi5Y2vIMnKqjSth4CbIlIBHLSqiMquYGo=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ThVaI9Rf1PeiPzJo4qemrPn9j8hloKHmLeXyaukdIsZEWNJ9j4GYVkJolyR3ktnYOsJAyQtazRAJtiOQ2jq656+zxOcafJDDI/Er7DTaqIf9VQQ1UM6wXzYKBb/JrIA8+DI0G8nAZqiF/MnZLo5Q60skmdmiUIUL0Z10/LEqli4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4XRxtH3vjxz1T8bj; Mon, 14 Oct 2024 20:51:03 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 80FCC1401F1; Mon, 14 Oct 2024 20:52:53 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 20:52:52 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 4/4] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic() Date: Mon, 14 Oct 2024 20:52:04 +0800 Message-ID: <20241014125204.1294934-5-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014125204.1294934-1-ruanjinjie@huawei.com> References: <20241014125204.1294934-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe drm_hdmi_state_helper_test and then rmmod it, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80ccd18100 (size 128): comm "kunit_try_catch", pid 1851, jiffies 4295059695 hex dump (first 32 bytes): 57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01 Wb........ ..... ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00 ................ backtrace (crc c2f1aa95): [<000000000f10b11b>] kmemleak_alloc+0x34/0x40 [<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c [<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98 [<0000000019daaacf>] 0xffffffedc11ae69c [<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac [<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000000a0b2e9e>] kthread+0x2e8/0x374 [<00000000bd668858>] ret_from_fork+0x10/0x20 ...... Free `mode` by using drm_kunit_helper_display_mode_from_cea_vic() to fix it. Cc: stable@vger.kernel.org Fixes: 4af70f19e559 ("drm/tests: Add RGB Quantization tests") Signed-off-by: Jinjie Ruan Acked-by: Maxime Ripard --- v2: - Fix it with new introduced helper instead of drm_mode_destroy(). - Update the commit message. --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/g= pu/drm/tests/drm_hdmi_state_helper_test.c index 34ee95d41f29..bb9af542cb43 100644 --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c @@ -441,7 +441,7 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_= vic_1(struct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -555,7 +555,7 @@ static void drm_test_check_broadcast_rgb_full_cea_mode_= vic_1(struct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -671,7 +671,7 @@ static void drm_test_check_broadcast_rgb_limited_cea_mo= de_vic_1(struct kunit *te ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 drm =3D &priv->drm; @@ -1263,7 +1263,7 @@ static void drm_test_check_output_bpc_format_vic_1(st= ruct kunit *test) ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); =20 - mode =3D drm_display_mode_from_cea_vic(drm, 1); + mode =3D drm_kunit_helper_display_mode_from_cea_vic(test, drm, 1); KUNIT_ASSERT_NOT_NULL(test, mode); =20 /* --=20 2.34.1