From nobody Wed Nov 27 04:41:08 2024 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E50158DD8; Mon, 14 Oct 2024 10:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728900396; cv=none; b=KoHchX+577UWiFm8Mc4e44SIgHQZ98Yfg93AgnovaH/PYjuZnTBnqcalhRQKiqxKgCO2TKxhwWjNbx8xXlQIxPeYdrrqtfG9vZ1WoqdJVjzFNREHaFOtxY9vLtNMKxz9KfFfQ1ppGAGmkumhL4sNZaGV5v3ZJQgJfHD92vFc0D8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728900396; c=relaxed/simple; bh=OG70jJR+91myI+hPfV/bHA4o5/PggLwB9TA01NFxDwc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GQRt7B39F5t8bkHPKEhiBslUN+Vz/+bec2cXWwMfR1bT3Iocl8kt7AwwHWARfAz1o8SCOg+1tB2DessRXE64BLrhshTlDEsfKAWJ/BhmkM0j9YkF7UJJZxkjHY2LMma+pVvbjRroZT2uWWgZOiwuipdNrkNsXk7YvKcS1dPeSK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=kdnrhXWv; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kdnrhXWv" Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 361D796C; Mon, 14 Oct 2024 12:04:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728900292; bh=OG70jJR+91myI+hPfV/bHA4o5/PggLwB9TA01NFxDwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kdnrhXWvsk4jeVG/EosuAP9pGJUTtvHZC2UtcyFZytQ3PvX4deCU+W3hMxlYSkYY6 QZk1+uDwpJEjJ9KUKVCteB8STI98z2+zebY5r3MtSQJIPqaC6LgihQUXQM5BTydjif bVxlUXjnKoHcSQYtPCJpvgVRsUq107FW5KM6uIfI= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Dan Carpenter , Laurent Pinchart , kernel-list@raspberrypi.com, Stefan Wahren , Umang Jain , stable@vger.kernel.org Subject: [PATCH v3 1/2] staging: vchiq_arm: Utilise devm_kzalloc() for allocation Date: Mon, 14 Oct 2024 15:36:23 +0530 Message-ID: <20241014100624.104987-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241014100624.104987-1-umang.jain@ideasonboard.com> References: <20241014100624.104987-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The struct vchiq_arm_state 'platform_state' is currently allocated dynamically using kzalloc(). Unfortunately, it is never freed and is subjected to memory leaks in the error handling paths of the probe() function. To address the issue, use device resource management helper devm_kzalloc(), to ensure cleanup after its allocation. Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver") Cc: stable@vger.kernel.org Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c = b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index af623ad87c15..7ece82c361ee 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -285,7 +285,7 @@ vchiq_platform_init_state(struct vchiq_state *state) { struct vchiq_arm_state *platform_state; =20 - platform_state =3D kzalloc(sizeof(*platform_state), GFP_KERNEL); + platform_state =3D devm_kzalloc(state->dev, sizeof(*platform_state), GFP_= KERNEL); if (!platform_state) return -ENOMEM; =20 --=20 2.45.2