From nobody Wed Nov 27 07:42:11 2024 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A7BC33C9 for ; Mon, 14 Oct 2024 07:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728890251; cv=none; b=ZezzYiKzYJ4NPTCMQqaxzJp6pGW8n7RSPOKdIs37vEsn4tDy+omAdb3eXwRNJc81hvbtbBP3XKirBXeOgdzGxhKXi6tAnt+tUPHITVV7t0Ft6snXJUK65eZCU3/aFTm/RhYb6jXLZcN2gBNFTuU8TSyFVeS1yVEpxxbGoeZYJZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728890251; c=relaxed/simple; bh=tuwsDxtdW69GdErSb/ZOPCT36ngAEcN3DcUawbNaChg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gv+pMvFq/UQqf5N2Tc9tkEZMfAAfRYxxQCup/DpwGH2UjVydHjv8YoqzvNLDNik6LcN48tGlzR8p9ct2FYb81Nb6mti5L4TzXZDVdvc4W1XMTlEtathmQb2N3orL/CNzbYvpxabZsBPnlj2UP0eBwd/xo4X4eEumEDoD1X60frY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4XRpRD28xhz1T8b9; Mon, 14 Oct 2024 15:15:36 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id EFF121400D8; Mon, 14 Oct 2024 15:17:25 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 15:17:25 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , CC: Subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic() Date: Mon, 14 Oct 2024 15:16:30 +0800 Message-ID: <20241014071632.989108-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014071632.989108-1-ruanjinjie@huawei.com> References: <20241014071632.989108-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" modprobe drm_connector_test and then rmmod drm_connector_test, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80cb0ee400 (size 128): comm "kunit_try_catch", pid 1948, jiffies 4294950339 hex dump (first 32 bytes): 14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04 .D............8. 3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00 <.A.e........... backtrace (crc 90e9585c): [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40 [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98 [<00000000d8f2c8b4>] 0xffffffdc982a4868 [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000006ea56ca0>] kthread+0x2e8/0x374 [<000000000676063f>] ret_from_fork+0x10/0x20 ...... Free `mode` by calling drm_mode_destroy() to fix it. Cc: stable@vger.kernel.org Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/tests/drm_connector_test.c | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/t= ests/drm_connector_test.c index 15e36a8db685..9c94d26b3486 100644 --- a/drivers/gpu/drm/tests/drm_connector_test.c +++ b/drivers/gpu/drm/tests/drm_connector_test.c @@ -1004,6 +1004,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(= struct kunit *test) rate =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1025,6 +1027,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc(struct kunit *test) rate =3D drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1250, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1043,6 +1047,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 10bpc_vic_1(struct kunit *t =20 rate =3D drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB); KUNIT_EXPECT_EQ(test, rate, 0); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1064,6 +1070,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc(struct kunit *test) rate =3D drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1500, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1082,6 +1090,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= 12bpc_vic_1(struct kunit *t =20 rate =3D drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB); KUNIT_EXPECT_EQ(test, rate, 0); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1103,6 +1113,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_= double(struct kunit *test) rate =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, (mode->clock * 1000ULL) * 2, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1126,6 +1138,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_valid(struct kunit rate =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_YUV420); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, (mode->clock * 1000ULL) / 2, rate); + + drm_mode_destroy(drm, mode); } =20 static const unsigned int drm_hdmi_compute_mode_clock_yuv420_vic_valid_tes= ts[] =3D { @@ -1164,6 +1178,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_10_bpc(struct kuni KUNIT_ASSERT_GT(test, rate, 0); =20 KUNIT_EXPECT_EQ(test, mode->clock * 625, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1189,6 +1205,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv420_12_bpc(struct kuni KUNIT_ASSERT_GT(test, rate, 0); =20 KUNIT_EXPECT_EQ(test, mode->clock * 750, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1211,6 +1229,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_8_bpc(struct kunit rate =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_YUV422); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1233,6 +1253,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_10_bpc(struct kuni rate =3D drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_YUV422); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate); + + drm_mode_destroy(drm, mode); } =20 /* @@ -1255,6 +1277,8 @@ static void drm_test_connector_hdmi_compute_mode_cloc= k_yuv422_12_bpc(struct kuni rate =3D drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_YUV422); KUNIT_ASSERT_GT(test, rate, 0); KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate); + + drm_mode_destroy(drm, mode); } =20 static struct kunit_case drm_hdmi_compute_mode_clock_tests[] =3D { --=20 2.34.1