From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56CDD15CD64; Sun, 13 Oct 2024 20:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851934; cv=none; b=lXKN7EJ/W1KAddDphCCJzdUW/mgvztY3u6IPmMk9DMfLosXOTozonGh6LOj5t1Ha7b1vvqEOcQkDggp+bYfCh5jjCRRxjLPCclfDXwXTykUuCEs60izCDOrnq3JBwa1ZnXWraFAjAMh2qjX7B+j/mgYdSFI8kW/Ov0zxVI33+Uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851934; c=relaxed/simple; bh=MBwMZ4xiO0sumWJtTHTe6GkRXUXySlWfbs3PmjCuG78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s3Y92DNpf0QmuORRvmhH2NpG60/bM2vdTsV3HyQTHhKePSWT9G1WW22ISalHR6EiWbvBL6upsIGNZVNnwVQYv5MTrtzfNPeDm2LFOx+Jp+8fJ5cJ7G2vqyP1xwNRPf8Uxt8MtYBnvrqdszoiH2ix2HX47XbZBNXWsTqXfgfkRs4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=fBg0dGvr; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="fBg0dGvr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=IczDtGTS4Z5CULUm4z191Tp3qUncfTs57+PPNdjNah8=; b=fBg0dGvrShDBM1NT 7mxAz6mbR8FJbIf+ZQ0TZaSLO2xWtoPtmfxWoak+VsKHfYF1dYdKYmrDUu6gwu+y58QoD8fNXRSY+ oBWT+p4ABTY9NQ5cEw6arClzaclIVIY1VzwnpAVukNGeTn6cZkGd+7I0qjrf4o8Z2OD2ac1FSzdd5 JP/KlmjkrwAI7JN3aAx5CA6Tq2e4pyxX0aY1b8Tp33s2CegmaFSufG3Jg0R4yl5zlCmGXto3VuZ1Z aeVf7HZVBIThOL8cKuWvYyCyBu2ZMNzAqiut+0H7BuT/7XsxOQqo4rb4JUYGd1AjL7qUIvkCXlzSr QFng5HnOMj4VnwTnaw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05ML-00AnUX-1m; Sun, 13 Oct 2024 20:38:37 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 1/6] cxgb4: Remove unused cxgb4_alloc/free_encap_mac_filt Date: Sun, 13 Oct 2024 21:38:26 +0100 Message-ID: <20241013203831.88051-2-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" cxgb4_alloc_encap_mac_filt() and cxgb4_free_encap_mac_filt() have been unused since commit 28b3870578ef ("cxgb4: Re-work the logic for mps refcounting") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 ---- .../net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 30 ------------------- 2 files changed, 36 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ether= net/chelsio/cxgb4/cxgb4.h index bbf7641a0fc7..1efb0a73ce0e 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h @@ -2141,12 +2141,6 @@ int cxgb4_free_mac_filt(struct adapter *adap, unsign= ed int viid, unsigned int naddr, const u8 **addr, bool sleep_ok); int cxgb4_init_mps_ref_entries(struct adapter *adap); void cxgb4_free_mps_ref_entries(struct adapter *adap); -int cxgb4_alloc_encap_mac_filt(struct adapter *adap, unsigned int viid, - const u8 *addr, const u8 *mask, - unsigned int vni, unsigned int vni_mask, - u8 dip_hit, u8 lookup_type, bool sleep_ok); -int cxgb4_free_encap_mac_filt(struct adapter *adap, unsigned int viid, - int idx, bool sleep_ok); int cxgb4_free_raw_mac_filt(struct adapter *adap, unsigned int viid, const u8 *addr, diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c b/drivers/net/e= thernet/chelsio/cxgb4/cxgb4_mps.c index a020e8490681..0e5663d19fcf 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c @@ -187,36 +187,6 @@ int cxgb4_alloc_raw_mac_filt(struct adapter *adap, return ret; } =20 -int cxgb4_free_encap_mac_filt(struct adapter *adap, unsigned int viid, - int idx, bool sleep_ok) -{ - int ret =3D 0; - - if (!cxgb4_mps_ref_dec(adap, idx)) - ret =3D t4_free_encap_mac_filt(adap, viid, idx, sleep_ok); - - return ret; -} - -int cxgb4_alloc_encap_mac_filt(struct adapter *adap, unsigned int viid, - const u8 *addr, const u8 *mask, - unsigned int vni, unsigned int vni_mask, - u8 dip_hit, u8 lookup_type, bool sleep_ok) -{ - int ret; - - ret =3D t4_alloc_encap_mac_filt(adap, viid, addr, mask, vni, vni_mask, - dip_hit, lookup_type, sleep_ok); - if (ret < 0) - return ret; - - if (cxgb4_mps_ref_inc(adap, addr, ret, mask)) { - ret =3D -ENOMEM; - t4_free_encap_mac_filt(adap, viid, ret, sleep_ok); - } - return ret; -} - int cxgb4_init_mps_ref_entries(struct adapter *adap) { spin_lock_init(&adap->mps_ref_lock); --=20 2.47.0 From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D041D9460; Sun, 13 Oct 2024 20:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851927; cv=none; b=R/RR1lRG9BBzzvFAacqs1hIPR88saunw/l+RdfZ5SVGagO79Ver5YRIMv4J2x3H9IEjmoRwr8gpF5VR+7r8/MUnPU5yGGT1WY+LMRZoGfwIFQ6sf2GFlLGxPe5Pf78pyzbWX9+jlKHkfSgM1S/sJ9D9VVJV4n32FC34pLKKtXnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851927; c=relaxed/simple; bh=/KWfG0hC7nX68cpRN5YtNXS0NTAEIxSykdwSKnDzgoM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OZuK3fCM3RMY5A4dSot34nmGu6WmhUWALPUMWKU49uPz0lQnleKY/bDBZNSy1cOD8RPGkpCz0mI+tNN9ixwjMZIQPhBHtweSBlWgIc0SFUN6nX0+dsmzwR7dwFF70Rlq0r7AF8bfJvR2GpnMxB2zQzIAHL4/4btzA8YXv8TnlFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=RcLot5Up; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="RcLot5Up" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=w+h03ZN2MorMRtu2NK0FxCln95Xj/ArcNug/uX/vzdk=; b=RcLot5Up/iMnhZg6 r/iLELPcFrFe0hQ0tv6Lxuo8nTlXOxMtKow6l3bwjzZqKGfbZmLhQp9zJaObjDZ548P6hAMN6rcDA TVl9LkCRkXa4M7nB/1OjRzpwdRe3sPEAnCtMVyxYP2LE9u6hypDB3dBe+M8fqreVJG9nK2PGtIAqS D1FnePxup310C6MSRfLs4L8sR89L42+DISvaduFKwy07k6gntSo18m/KH7rw3BGEtHJfrLPfJOtf2 QntOWQspjbjEm8gqeXzpS4Nr7szSzAm4JPXyKrWno2oJV2EiwcFZqDPondkoE4GyRUWxt8sjbQcG2 CpqjncaDL5YbclUV3g==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05MM-00AnUX-0x; Sun, 13 Oct 2024 20:38:38 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 2/6] cxgb4: Remove unused cxgb4_alloc/free_raw_mac_filt Date: Sun, 13 Oct 2024 21:38:27 +0100 Message-ID: <20241013203831.88051-3-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" cxgb4_alloc_raw_mac_filt() and cxgb4_free_raw_mac_filt() have been unused since they were added in 2019 commit 5fab51581f62 ("cxgb4: Add MPS TCAM refcounting for raw mac filters") Remove them. This was also the last use of cxgb4_mps_ref_dec(). Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 16 ----- .../net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 68 ------------------- 2 files changed, 84 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ether= net/chelsio/cxgb4/cxgb4.h index 1efb0a73ce0e..1c302dfd6503 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h @@ -2141,22 +2141,6 @@ int cxgb4_free_mac_filt(struct adapter *adap, unsign= ed int viid, unsigned int naddr, const u8 **addr, bool sleep_ok); int cxgb4_init_mps_ref_entries(struct adapter *adap); void cxgb4_free_mps_ref_entries(struct adapter *adap); -int cxgb4_free_raw_mac_filt(struct adapter *adap, - unsigned int viid, - const u8 *addr, - const u8 *mask, - unsigned int idx, - u8 lookup_type, - u8 port_id, - bool sleep_ok); -int cxgb4_alloc_raw_mac_filt(struct adapter *adap, - unsigned int viid, - const u8 *addr, - const u8 *mask, - unsigned int idx, - u8 lookup_type, - u8 port_id, - bool sleep_ok); int cxgb4_update_mac_filt(struct port_info *pi, unsigned int viid, int *tcam_idx, const u8 *addr, bool persistent, u8 *smt_idx); diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c b/drivers/net/e= thernet/chelsio/cxgb4/cxgb4_mps.c index 0e5663d19fcf..60f4d5b5eb3a 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c @@ -28,28 +28,6 @@ static int cxgb4_mps_ref_dec_by_mac(struct adapter *adap, return ret; } =20 -static int cxgb4_mps_ref_dec(struct adapter *adap, u16 idx) -{ - struct mps_entries_ref *mps_entry, *tmp; - int ret =3D -EINVAL; - - spin_lock(&adap->mps_ref_lock); - list_for_each_entry_safe(mps_entry, tmp, &adap->mps_ref, list) { - if (mps_entry->idx =3D=3D idx) { - if (!refcount_dec_and_test(&mps_entry->refcnt)) { - spin_unlock(&adap->mps_ref_lock); - return -EBUSY; - } - list_del(&mps_entry->list); - kfree(mps_entry); - ret =3D 0; - break; - } - } - spin_unlock(&adap->mps_ref_lock); - return ret; -} - static int cxgb4_mps_ref_inc(struct adapter *adap, const u8 *mac_addr, u16 idx, const u8 *mask) { @@ -141,52 +119,6 @@ int cxgb4_update_mac_filt(struct port_info *pi, unsign= ed int viid, return ret; } =20 -int cxgb4_free_raw_mac_filt(struct adapter *adap, - unsigned int viid, - const u8 *addr, - const u8 *mask, - unsigned int idx, - u8 lookup_type, - u8 port_id, - bool sleep_ok) -{ - int ret =3D 0; - - if (!cxgb4_mps_ref_dec(adap, idx)) - ret =3D t4_free_raw_mac_filt(adap, viid, addr, - mask, idx, lookup_type, - port_id, sleep_ok); - - return ret; -} - -int cxgb4_alloc_raw_mac_filt(struct adapter *adap, - unsigned int viid, - const u8 *addr, - const u8 *mask, - unsigned int idx, - u8 lookup_type, - u8 port_id, - bool sleep_ok) -{ - int ret; - - ret =3D t4_alloc_raw_mac_filt(adap, viid, addr, - mask, idx, lookup_type, - port_id, sleep_ok); - if (ret < 0) - return ret; - - if (cxgb4_mps_ref_inc(adap, addr, ret, mask)) { - ret =3D -ENOMEM; - t4_free_raw_mac_filt(adap, viid, addr, - mask, idx, lookup_type, - port_id, sleep_ok); - } - - return ret; -} - int cxgb4_init_mps_ref_entries(struct adapter *adap) { spin_lock_init(&adap->mps_ref_lock); --=20 2.47.0 From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F69E14A639; Sun, 13 Oct 2024 20:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851928; cv=none; b=Kq1wrFp3zF7yMx0qQ8Y/ZUH6MfviqjNLo4lPqwfhMM1NI4EOFGjW/3DGcD5fpDJC6Bd6BUCYpn+uapJAu874JTUrGKNbVI2n12sOIHEbRhulT4LwYGi1G0NhkOgErEiqFD0SU/8bKFUbp/riEo4u4pHg8Hc1nnB8NpJ0/3HqVLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851928; c=relaxed/simple; bh=Kz7biNrSLf2Tfv9++g6KvtSgrfeiTXUxSW0BPUXiJvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DpSJOEgMXdoM8+LB0to28Qq2RljXinJUhlT/Bv4TMbi8vcyylYXHtFnSPTLQaKeldM55CFQr2IQN0daG32LupoEoDzOroRYBG8DuR5iSuOSqGNfpHalDc4fac7yUMUKHiKoAnHSWb1XVW6EtJINQBJKAst4RGrRQVWLmdst857U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=VeuLUwR7; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="VeuLUwR7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=qjDH0t9U3Or+NZWFu+ofizReGJXC+/gny6H8OGMVhTw=; b=VeuLUwR7v9RerKGg csCuIXP1bIRILhC+IpOCwywsNz+1AAqCilXoLT1j+z7jMLGX45DAqGwRJjtQaV1Td6obME6cJBTGU 1XZocwIAmM86c8AVvzQlqQhOpIAori1MlgLhYqMM9yfkoROlxyV2fqSmGmagESm7Dq68YHz8avq90 s+Vr9z8J+PWULJftuLju8unhbRqmoIOpuqeT/gtf0i4vvDlbNrx5U85xQSkcfj0eqfXQXZh3HaRBe PG6EIW0E7jJXl06aVdKf3T+2YbkPu0XA3dx6wZ+f3AiD4KXKyQubppHhXFu8Y/ktGT+NQjZI2782O KeOTrN7m+fcx/FLJ0w==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05MN-00AnUX-05; Sun, 13 Oct 2024 20:38:39 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 3/6] cxgb4: Remove unused cxgb4_get_srq_entry Date: Sun, 13 Oct 2024 21:38:28 +0100 Message-ID: <20241013203831.88051-4-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" cxgb4_get_srq_entry() has been unused since 2018's commit e47094751ddc ("cxgb4: Add support to initialise/read SRQ entries") which added it. Remove it. Note: I'm a bit suspicious whether any of the srq code in there actually does anything useful; without this get I can't see anything that reads the data, so perhaps the whole thing should go? But that however would remove one of the opcode handlers, and I have no way to test that. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/srq.c | 58 ------------------------ drivers/net/ethernet/chelsio/cxgb4/srq.h | 2 - 2 files changed, 60 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/srq.c b/drivers/net/etherne= t/chelsio/cxgb4/srq.c index 9a54302bb046..a77d6ac1ee8c 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/srq.c +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.c @@ -51,64 +51,6 @@ struct srq_data *t4_init_srq(int srq_size) return s; } =20 -/* cxgb4_get_srq_entry: read the SRQ table entry - * @dev: Pointer to the net_device - * @idx: Index to the srq - * @entryp: pointer to the srq entry - * - * Sends CPL_SRQ_TABLE_REQ message for the given index. - * Contents will be returned in CPL_SRQ_TABLE_RPL message. - * - * Returns zero if the read is successful, else a error - * number will be returned. Caller should not use the srq - * entry if the return value is non-zero. - * - * - */ -int cxgb4_get_srq_entry(struct net_device *dev, - int srq_idx, struct srq_entry *entryp) -{ - struct cpl_srq_table_req *req; - struct adapter *adap; - struct sk_buff *skb; - struct srq_data *s; - int rc =3D -ENODEV; - - adap =3D netdev2adap(dev); - s =3D adap->srq; - - if (!(adap->flags & CXGB4_FULL_INIT_DONE) || !s) - goto out; - - skb =3D alloc_skb(sizeof(*req), GFP_KERNEL); - if (!skb) - return -ENOMEM; - req =3D (struct cpl_srq_table_req *) - __skb_put_zero(skb, sizeof(*req)); - INIT_TP_WR(req, 0); - OPCODE_TID(req) =3D htonl(MK_OPCODE_TID(CPL_SRQ_TABLE_REQ, - TID_TID_V(srq_idx) | - TID_QID_V(adap->sge.fw_evtq.abs_id))); - req->idx =3D srq_idx; - - mutex_lock(&s->lock); - - s->entryp =3D entryp; - t4_mgmt_tx(adap, skb); - - rc =3D wait_for_completion_timeout(&s->comp, SRQ_WAIT_TO); - if (rc) - rc =3D 0; - else /* !rc means we timed out */ - rc =3D -ETIMEDOUT; - - WARN_ON_ONCE(entryp->idx !=3D srq_idx); - mutex_unlock(&s->lock); -out: - return rc; -} -EXPORT_SYMBOL(cxgb4_get_srq_entry); - void do_srq_table_rpl(struct adapter *adap, const struct cpl_srq_table_rpl *rpl) { diff --git a/drivers/net/ethernet/chelsio/cxgb4/srq.h b/drivers/net/etherne= t/chelsio/cxgb4/srq.h index ec85cf93865a..d9f04bd5ffa3 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/srq.h +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.h @@ -58,8 +58,6 @@ struct srq_data { }; =20 struct srq_data *t4_init_srq(int srq_size); -int cxgb4_get_srq_entry(struct net_device *dev, - int srq_idx, struct srq_entry *entryp); void do_srq_table_rpl(struct adapter *adap, const struct cpl_srq_table_rpl *rpl); #endif /* __CXGB4_SRQ_H */ --=20 2.47.0 From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD4C14A0AA; Sun, 13 Oct 2024 20:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851927; cv=none; b=BSQIvu/ASWt2paXIeXm8V3jXQOJiXvMNgXwnOvWndoWkI61P1H+kAMxj26i8idIHa90t6eejW2/wnPJap6augFvZtUX1wUZhUqXl3m8o6soMaQprGv2+4LGKxOwDjx23eYdNVE3ckiN9qRt48cCqxkcrtLIJe3WG9AfMELO1DeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851927; c=relaxed/simple; bh=TIxQP5Qf4dF0rthcNEnMbCKB2xuY8ekbw61NFE9C49A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nohwtqIMd7N0El+WNY/nh249+x0u1lkgcpK7QaBGmTLg+fRT80eS2y86qQgLK9wHE49D3230DJllazxF2XmLD+z9vJaRxCOjl4MO8wHjgUrEOq4u6Eq6/Dnhw+YOirvl39pE02QCtqGQodx5RN2bOh0HV5lBycCb0KY0GDRNXVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=q1FSoYVn; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="q1FSoYVn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=lK6RmXXkbNlWB6G+65qiaqQK1cRZEQZCtAEaguIjHEw=; b=q1FSoYVnMnD+YN6I FSGqWwmq8MWEUA4KjK9Sudcw+g3j/JZ8BCfS5hs18t8sFFzw4cp3xnmXcR7lIwWuDY8wcYDvVOlCs GmAfqSb11Dh5HXIR12Bke5FAmlHDxUDJ9yBjfYOE3kgrsw/Q5EYVj7LumiJ7Fh5kfhjzE8MqIukl3 va6WfvfS+ZnNnSGWPcNMOxcZQ6l2o3iljJKkv39DPDmOn0Lk//an6A8fDUdBU2j9NAxg8scdl85/a lLskviXJmbsWnd4TVhYjHeJK4hdzu6f8vsZBA9UMEyPxIDE2RzMDYhs1jECm4B4aIvTdSl+9iwjiU d3pjhS6rv/iSclv/0w==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05MN-00AnUX-2I; Sun, 13 Oct 2024 20:38:39 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 4/6] cxgb4: Remove unused cxgb4_scsi_init Date: Sun, 13 Oct 2024 21:38:29 +0100 Message-ID: <20241013203831.88051-5-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" cxgb4_iscsi_init() has been unused since 2016's commit 5999299f1ce9 ("cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 12 ------------ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/= ethernet/chelsio/cxgb4/cxgb4_main.c index 2418645c8823..97a261d5357e 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -2188,18 +2188,6 @@ void cxgb4_get_tcp_stats(struct pci_dev *pdev, struc= t tp_tcp_stats *v4, } EXPORT_SYMBOL(cxgb4_get_tcp_stats); =20 -void cxgb4_iscsi_init(struct net_device *dev, unsigned int tag_mask, - const unsigned int *pgsz_order) -{ - struct adapter *adap =3D netdev2adap(dev); - - t4_write_reg(adap, ULP_RX_ISCSI_TAGMASK_A, tag_mask); - t4_write_reg(adap, ULP_RX_ISCSI_PSZ_A, HPZ0_V(pgsz_order[0]) | - HPZ1_V(pgsz_order[1]) | HPZ2_V(pgsz_order[2]) | - HPZ3_V(pgsz_order[3])); -} -EXPORT_SYMBOL(cxgb4_iscsi_init); - int cxgb4_flush_eq_cache(struct net_device *dev) { struct adapter *adap =3D netdev2adap(dev); diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h b/drivers/net/e= thernet/chelsio/cxgb4/cxgb4_uld.h index d8cafaa7ddb4..d7713038386c 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h @@ -518,8 +518,6 @@ unsigned int cxgb4_best_aligned_mtu(const unsigned shor= t *mtus, unsigned int *mtu_idxp); void cxgb4_get_tcp_stats(struct pci_dev *pdev, struct tp_tcp_stats *v4, struct tp_tcp_stats *v6); -void cxgb4_iscsi_init(struct net_device *dev, unsigned int tag_mask, - const unsigned int *pgsz_order); struct sk_buff *cxgb4_pktgl_to_skb(const struct pkt_gl *gl, unsigned int skb_len, unsigned int pull_len); int cxgb4_sync_txq_pidx(struct net_device *dev, u16 qid, u16 pidx, u16 siz= e); --=20 2.47.0 From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F3B1514CB; Sun, 13 Oct 2024 20:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851929; cv=none; b=IRaEyDhE9jhRWMuvvlRm95/PFlfXrvlcxD0fDR3UdySyxl7GgVr46T7TO6SZb9hZKB61OdF6CRfWr09I7pePsTN6sOFNTowvUmw4daEyamifmZiaqEf0GWWHknjyf99uqHaxHhgVzWEbkaQSlJfU89ULoMwtVsag0y1GgvMZJdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851929; c=relaxed/simple; bh=7/r3ahWmKb5y3GrgXA4FtVlNFSHbjzDmV4Rb2+s+4Io=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEGuvPnDWEeegIfvMN6iPXaUBkhIeEgLZfXscichDe5gHE2O55RpbRobvzqjqbIoUrS0q5bAUf3puxEmrIB4FY2CRJBR6XT1ViVYfVyRMVXoPzCrbgTh5jlR3Redw4MXj07kiZ6wP0MV0qMNdWzvayjqtB4j/M4hHRtv50S/jH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=s3g6eN04; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="s3g6eN04" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=T7awRtjFbenc+GOlGd9rhHppedzLJGsTCN5jnGB4TbE=; b=s3g6eN04lgIN9tdA zZ3lMblJ9cH9uduJ+X5f86CvcFw/O7d+cgctdMTfQLVVwuIoi12ccPuhd+8WhpBqJpvYtJawtB9kY ujzX71fiZPD4xUf+M+rRHDAaNSkFAJplCv/6JjFwkljByT08up9wa0vJ/8sGY7CEqw3k6PZaQiIbE ApiBgNfqvzOyr69m6bQIjrKw4D5zSQZ/bxG/Ig/YPjB8m9HI4A2uXALJ6Mzx3lJHlF9v20wQUAY0H PfUE6bmuIxs7PaJIhEar7uuJwfKQdmU6yEF9+4ttGiuf8HWFz8Vrkh1TpDcGFpPcc1Lj+iEMKLzkK iCprPF0EeZD/RPtBOw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05MO-00AnUX-1G; Sun, 13 Oct 2024 20:38:40 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 5/6] cxgb4: Remove unused cxgb4_l2t_alloc_switching Date: Sun, 13 Oct 2024 21:38:30 +0100 Message-ID: <20241013203831.88051-6-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" cxgb4_l2t_alloc_switching() has been unused since it was added in commit f7502659cec8 ("cxgb4: Add API to alloc l2t entry; also update existing ones") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/l2t.c | 19 ------------------- drivers/net/ethernet/chelsio/cxgb4/l2t.h | 2 -- 2 files changed, 21 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.c b/drivers/net/etherne= t/chelsio/cxgb4/l2t.c index 1e5f5b1a22a6..c02b4e9c06b2 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/l2t.c +++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.c @@ -608,25 +608,6 @@ struct l2t_entry *t4_l2t_alloc_switching(struct adapte= r *adap, u16 vlan, return e; } =20 -/** - * cxgb4_l2t_alloc_switching - Allocates an L2T entry for switch filters - * @dev: net_device pointer - * @vlan: VLAN Id - * @port: Associated port - * @dmac: Destination MAC address to add to L2T - * Returns pointer to the allocated l2t entry - * - * Allocates an L2T entry for use by switching rule of a filter - */ -struct l2t_entry *cxgb4_l2t_alloc_switching(struct net_device *dev, u16 vl= an, - u8 port, u8 *dmac) -{ - struct adapter *adap =3D netdev2adap(dev); - - return t4_l2t_alloc_switching(adap, vlan, port, dmac); -} -EXPORT_SYMBOL(cxgb4_l2t_alloc_switching); - struct l2t_data *t4_init_l2t(unsigned int l2t_start, unsigned int l2t_end) { unsigned int l2t_size; diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.h b/drivers/net/etherne= t/chelsio/cxgb4/l2t.h index 340fecb28a13..8aad7e9dee6d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/l2t.h +++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.h @@ -115,8 +115,6 @@ struct l2t_entry *cxgb4_l2t_get(struct l2t_data *d, str= uct neighbour *neigh, unsigned int priority); u64 cxgb4_select_ntuple(struct net_device *dev, const struct l2t_entry *l2t); -struct l2t_entry *cxgb4_l2t_alloc_switching(struct net_device *dev, u16 vl= an, - u8 port, u8 *dmac); void t4_l2t_update(struct adapter *adap, struct neighbour *neigh); struct l2t_entry *t4_l2t_alloc_switching(struct adapter *adap, u16 vlan, u8 port, u8 *dmac); --=20 2.47.0 From nobody Wed Nov 27 04:35:09 2024 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9EBB14F9E2; Sun, 13 Oct 2024 20:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851929; cv=none; b=WXSgC8TK/LrWq7XQ9tK7+IQcNrP9a19e8lOGK8Durwn1w5SS0UFigVafs1uZAxSp3c807aFh46qyK2tvYwbGT8VMmNRg6NJDQEb1GIo9RHCWwN4VLNhz/2sWNK9ZBYeqH+ayE50JSdnETIPS+lOVgtHZKeNkzn3V03y0lrG2Dnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728851929; c=relaxed/simple; bh=RlpXOidSIkDtXwfikagOesfLxTriDN+l1/Ar8iVwTQg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LtFmR/qjv30bLwpdKO/Tlfr0xSzrqgNh4V9Kx+EumizdRJ1xscyzwav95+X1vyPLHNUa0ihef80jOJCDonDuzA/x4orNvnCHId3m/zrafLUQ3XESQ3mfmYEh/EaeBHCSh0SL3uQKlKU2vOh8zX9fTJ+C1TNCPSYwkYC+D4z2uJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=KfabtnhZ; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="KfabtnhZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=NZNaeQVpUHOr17M4VqCALkPHgzs8AAqDAyl+ctHVJo8=; b=KfabtnhZLzFOCW1g 6qVeF5hwO2Iu+fOSkrU4Rrk6AKOFKzXb9k+Z/7pgZ5OCw3znfqcIT0iyHh1Ym86+mFYuDbcs2Y3ar wGiGInJw4eQryqfmqT0AXPcYl3X93brjfQ09703GLmFaJN0aBYE/vtJIv4owzQn35m9rS+aiG5q3B wcZlt2AgYoB6hkKtrIe8A74fvcypgOukBWHNHJ0AEm/NxvpXFi6d7dk1N79zvQEQqS2oHMjbSjidK y5nT59IXDixE/716GKIM6TYsU05rS5ebET7vD/J0wZjw5BkfTae747IR6AuLG2ipJUEjMH2gHFrIW G+XZMxj8m+u2EEKOJA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1t05MP-00AnUX-0p; Sun, 13 Oct 2024 20:38:41 +0000 From: linux@treblig.org To: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 6/6] cxgb4: Remove unused t4_free_ofld_rxqs Date: Sun, 13 Oct 2024 21:38:31 +0100 Message-ID: <20241013203831.88051-7-linux@treblig.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241013203831.88051-1-linux@treblig.org> References: <20241013203831.88051-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" t4_free_ofld_rxqs() has been unused since commit 0fbc81b3ad51 ("chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 - drivers/net/ethernet/chelsio/cxgb4/sge.c | 16 ---------------- 2 files changed, 17 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ether= net/chelsio/cxgb4/cxgb4.h index 1c302dfd6503..75bd69ff61a8 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h @@ -1608,7 +1608,6 @@ void t4_os_portmod_changed(struct adapter *adap, int = port_id); void t4_os_link_changed(struct adapter *adap, int port_id, int link_stat); =20 void t4_free_sge_resources(struct adapter *adap); -void t4_free_ofld_rxqs(struct adapter *adap, int n, struct sge_ofld_rxq *q= ); irq_handler_t t4_intr_handler(struct adapter *adap); netdev_tx_t t4_start_xmit(struct sk_buff *skb, struct net_device *dev); int cxgb4_selftest_lb_pkt(struct net_device *netdev); diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/etherne= t/chelsio/cxgb4/sge.c index de52bcb884c4..a7d76a8ed050 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c @@ -4874,22 +4874,6 @@ void free_rspq_fl(struct adapter *adap, struct sge_r= spq *rq, } } =20 -/** - * t4_free_ofld_rxqs - free a block of consecutive Rx queues - * @adap: the adapter - * @n: number of queues - * @q: pointer to first queue - * - * Release the resources of a consecutive block of offload Rx queues. - */ -void t4_free_ofld_rxqs(struct adapter *adap, int n, struct sge_ofld_rxq *q) -{ - for ( ; n; n--, q++) - if (q->rspq.desc) - free_rspq_fl(adap, &q->rspq, - q->fl.size ? &q->fl : NULL); -} - void t4_sge_free_ethofld_txq(struct adapter *adap, struct sge_eohw_txq *tx= q) { if (txq->q.desc) { --=20 2.47.0