From nobody Wed Nov 27 07:43:08 2024 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 772F213F42A for ; Sun, 13 Oct 2024 11:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728818502; cv=none; b=L8tnLA5Iwh/XKNW3D5PpJQcRYVb3xEEtgZKay4SlmLMKzJ7WkKSVUXvWnY9cfDTGogcTY8T4gxZ5m5RzKaV/Mtv8Dzh18BpPk30yIgeZkcZfKuJzg/nNYBdfkGq0PrNnLFnLrSHA3UOc/YQxBBPP+fQIGOIbLJZEn2/SR4wpSOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728818502; c=relaxed/simple; bh=WBqPaPeDJDpOXJCYWiEMmcPkk6BJUzfDh0i0SctEqUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A/T3y3ps/NOfABh7Oc98x8jUteXdSOjd6IGBX6+cZuAeZndToHYg8ubg9Iysj/GrnX2aroMlNL+phMxWh7aHpJIkJFH6hIwENT5kU5fNdE6M5WOb/IgMFqdX9EMEGfhqEmVx6O78sOj4h/44CBmEd4+meCedONi/MkvytjMYBXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CHoqoehg; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CHoqoehg" Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36B5FA06; Sun, 13 Oct 2024 13:19:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728818400; bh=WBqPaPeDJDpOXJCYWiEMmcPkk6BJUzfDh0i0SctEqUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CHoqoehgZchFDhrfYhe69aLVPhbScnTq53qGu/K8cHxy8nAn7BBqi7OLCEewnUJcD g4ZrJKH8k3C2SyONOJ7L8VrfoTZ4s2saALEfOVm/pw+d80Gyfv8gKICqzDbInLpTht +q1gOJA2OC3qMBdRPHSEHKyAcs9hN/D8BwAalo8g= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Dan Carpenter , Laurent Pinchart , kernel-list@raspberrypi.com, Stefan Wahren , Umang Jain Subject: [PATCH v4 2/6] staging: vchiq_core: Do not log debug in a separate scope Date: Sun, 13 Oct 2024 16:51:24 +0530 Message-ID: <20241013112128.397249-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241013112128.397249-1-umang.jain@ideasonboard.com> References: <20241013112128.397249-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Do not log a dev_dbg() with a separate scope. Drop the {..} scope and align the dev_dbg() to make it more readable. No functional changes intended in this patch. Signed-off-by: Umang Jain Reviewed-by: Stefan Wahren --- .../interface/vchiq_arm/vchiq_core.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c= b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index e9b60dd8d419..0324dfe59dca 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -936,6 +936,7 @@ queue_message(struct vchiq_state *state, struct vchiq_s= ervice *service, struct vchiq_service_quota *quota =3D NULL; struct vchiq_header *header; int type =3D VCHIQ_MSG_TYPE(msgid); + int svc_fourcc; =20 size_t stride; =20 @@ -1128,17 +1129,13 @@ queue_message(struct vchiq_state *state, struct vch= iq_service *service, header->msgid =3D msgid; header->size =3D size; =20 - { - int svc_fourcc; - - svc_fourcc =3D service - ? service->base.fourcc - : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); + svc_fourcc =3D service ? service->base.fourcc + : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); =20 - dev_dbg(state->dev, "core_msg: Sent Msg %s(%u) to %p4cc s:%u d:%d len:%z= u\n", - msg_type_str(VCHIQ_MSG_TYPE(msgid)), VCHIQ_MSG_TYPE(msgid), - &svc_fourcc, VCHIQ_MSG_SRCPORT(msgid), VCHIQ_MSG_DSTPORT(msgid), size); - } + dev_dbg(state->dev, "core_msg: Sent Msg %s(%u) to %p4cc s:%u d:%d len:%zu= \n", + msg_type_str(VCHIQ_MSG_TYPE(msgid)), + VCHIQ_MSG_TYPE(msgid), &svc_fourcc, + VCHIQ_MSG_SRCPORT(msgid), VCHIQ_MSG_DSTPORT(msgid), size); =20 /* Make sure the new header is visible to the peer. */ wmb(); --=20 2.45.2