From nobody Wed Nov 27 04:59:26 2024 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C3442069 for ; Sat, 12 Oct 2024 18:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728757625; cv=none; b=Xa1GSFoFFePDIui31FsE5LM3sXHJvtUxhTf0GuJI+MAIZiIQY+pfeOFNbrlGtjBNM00RgpwITgvQpGJXuBwuvHrHr6G1yBJMixaicXjhU8U4LBKeBSxxDjEfPQosYq/NMpF/CMjXvBUZ1fufMmHPCv42lYthKmGDPAc4N9+SfzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728757625; c=relaxed/simple; bh=gn1pSXgV0Wlipy2wpxpUzhBM227Q0zAyDctD2PyKtOw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dcG5ZJ0Oa15Spav49yKEAMmHLqH8/Ywe7+vMzVbONhi3EjZJ+AA+Yih9pHMYVc4HzVZpOPcOQnN84Z32HXylYzo7WkoChg7aYYaN1iG234Ha3k06deuJH25ClohkJocf6fz8FB58Sk9N3u25IdqrmR0Rilqnh0AgpTwO+CHJyEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--mmaslanka.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zo4z869V; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--mmaslanka.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zo4z869V" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e0b8fa94718so4347544276.0 for ; Sat, 12 Oct 2024 11:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728757622; x=1729362422; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Kiugjck6LqeVNWQqRF21MBTJpxvtnHKEenzbxqveaEw=; b=zo4z869VRuwJyEUJtj5ppGcffAtMQ4DtDHSSA+3OFXgGFgQpuBlb5uclfEmxa58bB2 zTapC7CexkIxa9QryB7p6kgv7t9L4awQyXUlG9jJZ5guhOXEoTU9EaemJAJFJ8uWAWS2 is/+txpsiPQfa9gXC7FoWLbZC3S6iJHlZEdJFt20AXkgADJaEF1D1yu8SXukg3GgDxkg DokTxiduDpde0rLYFZtNdXCrjuq+5ha6MagZ8eO0PofSRLm5WZJ8WbwfENYASYWpOZAL vBtEBfyK2qiQZXGozZu0+EmwCe9Xd6AQEjRuTrYJnFGutFbwqi4XflAkRG4bY3CBRndO DGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728757622; x=1729362422; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kiugjck6LqeVNWQqRF21MBTJpxvtnHKEenzbxqveaEw=; b=DGyOMTEeaMFJnlUvCtzEAc0ea5vhzG1DjWe23EKr1Nzk950ERcY2bdt+hWpABmhKC6 rhSDu9Ukbjo9P36F2YVcS8y1V3BR9vs0qE9CGA8kbVNdCzmajQNpyOnwpBl5a9ctOLOk qgAl7L4Tmh3Z0netL302fofb1qy5dzuVMytQ+9DuyUi0JkuA/JvhuO2D7hX9vkuJcezD 9tw1asfRQWxBjelD42lsRf3NvPlLVqWm7Hz/t2GYwL3hOdrVeDoBQDa3BbbwvtkLj8Kq zFiaKPa2akmeI75irGI3cNsDO7oWSA4Iq6UFWYVSJ2STDrnF2nEF/7tjy6iXfkdSNhdM oTdQ== X-Gm-Message-State: AOJu0YwmCondhLLCFjg4uTRgiR00LhzfirDGXZLJUzDDlnjnB2H5NlxR YXK07l1HbBr4cC1q6pMbowODhJmqvyLSo2jN+uTNLHkn+UT993F8ZOEghnJO811Gj5PgmQ0vjqH YYGcO/pgeUrmk/RPxAD6PGc9Y+zAu1YhMsHpeN+zXbgVqv7zPo4wU4jzUsjsLm8Pmizsc09mU/k 7+lp0EKfMP/WybkPt9+KYeojjqPEtGqny+aG5ymLSeuM84OzIahbsoEZdL X-Google-Smtp-Source: AGHT+IG7TWAKVNhAzeLYSAAvRTEQSOcM2plXA1wIkIy9bAcah9V5UxQ+c4eBsHMhKubtaEI6tU85oO3ma7qMufI= X-Received: from mmaslanka2.c.googlers.com ([fda3:e722:ac3:cc00:31:98fb:c0a8:b8d]) (user=mmaslanka job=sendgmr) by 2002:a25:8049:0:b0:e28:ee55:c3d with SMTP id 3f1490d57ef6-e2919dc14efmr22898276.1.1728757621841; Sat, 12 Oct 2024 11:27:01 -0700 (PDT) Date: Sat, 12 Oct 2024 18:26:55 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Message-ID: <20241012182656.2107178-1-mmaslanka@google.com> Subject: [PATCH] Revert "platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended" From: Marek Maslanka To: LKML Cc: Marek Maslanka , Rajneesh Bhardwaj , David E Box , Hans de Goede , "=?UTF-8?q?Ilpo=20J=C3=A4rvinen?=" , platform-driver-x86@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit e86c8186d03a6ba018e881ed45f0962ad553e861. This can cause the suspend process to hang as the pmcdev->lock in the pmc_core_acpi_pm_timer_suspend_resume might already be held by the pmc_core_mphy_pg_show or pmc_core_pll_show if the userspace gets frozen when these functions are being executed. Also, pmc_core_acpi_pm_timer_suspend_resume must not sleep, as this function is called indirectly by the tick_freeze function in kernel/time/tick-common.c, which holds the spinlock. Signed-off-by: Marek Maslanka --- drivers/platform/x86/intel/pmc/adl.c | 2 -- drivers/platform/x86/intel/pmc/cnp.c | 2 -- drivers/platform/x86/intel/pmc/core.c | 46 --------------------------- drivers/platform/x86/intel/pmc/core.h | 8 ----- drivers/platform/x86/intel/pmc/icl.c | 2 -- drivers/platform/x86/intel/pmc/mtl.c | 2 -- drivers/platform/x86/intel/pmc/spt.c | 2 -- drivers/platform/x86/intel/pmc/tgl.c | 2 -- 8 files changed, 66 deletions(-) diff --git a/drivers/platform/x86/intel/pmc/adl.c b/drivers/platform/x86/in= tel/pmc/adl.c index 9d9c07f44ff6..e7878558fd90 100644 --- a/drivers/platform/x86/intel/pmc/adl.c +++ b/drivers/platform/x86/intel/pmc/adl.c @@ -295,8 +295,6 @@ const struct pmc_reg_map adl_reg_map =3D { .ppfear_buckets =3D CNP_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D CNP_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D CNP_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .ltr_ignore_max =3D ADL_NUM_IP_IGN_ALLOWED, .lpm_num_modes =3D ADL_LPM_NUM_MODES, .lpm_num_maps =3D ADL_LPM_NUM_MAPS, diff --git a/drivers/platform/x86/intel/pmc/cnp.c b/drivers/platform/x86/in= tel/pmc/cnp.c index 513c02670c5a..dd72974bf71e 100644 --- a/drivers/platform/x86/intel/pmc/cnp.c +++ b/drivers/platform/x86/intel/pmc/cnp.c @@ -200,8 +200,6 @@ const struct pmc_reg_map cnp_reg_map =3D { .ppfear_buckets =3D CNP_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D CNP_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D CNP_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .ltr_ignore_max =3D CNP_NUM_IP_IGN_ALLOWED, .etr3_offset =3D ETR3_OFFSET, }; diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/i= ntel/pmc/core.c index ecb47f8b4f83..4e9c8c96c8cc 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -11,7 +11,6 @@ =20 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 -#include #include #include #include @@ -1258,39 +1257,6 @@ static bool pmc_core_is_pson_residency_enabled(struc= t pmc_dev *pmcdev) return val =3D=3D 1; } =20 -/* - * Enable or disable ACPI PM Timer - * - * This function is intended to be a callback for ACPI PM suspend/resume e= vent. - * The ACPI PM Timer is enabled on resume only if it was enabled during su= spend. - */ -static void pmc_core_acpi_pm_timer_suspend_resume(void *data, bool suspend) -{ - struct pmc_dev *pmcdev =3D data; - struct pmc *pmc =3D pmcdev->pmcs[PMC_IDX_MAIN]; - const struct pmc_reg_map *map =3D pmc->map; - bool enabled; - u32 reg; - - if (!map->acpi_pm_tmr_ctl_offset) - return; - - guard(mutex)(&pmcdev->lock); - - if (!suspend && !pmcdev->enable_acpi_pm_timer_on_resume) - return; - - reg =3D pmc_core_reg_read(pmc, map->acpi_pm_tmr_ctl_offset); - enabled =3D !(reg & map->acpi_pm_tmr_disable_bit); - if (suspend) - reg |=3D map->acpi_pm_tmr_disable_bit; - else - reg &=3D ~map->acpi_pm_tmr_disable_bit; - pmc_core_reg_write(pmc, map->acpi_pm_tmr_ctl_offset, reg); - - pmcdev->enable_acpi_pm_timer_on_resume =3D suspend && enabled; -} - static void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev) { debugfs_remove_recursive(pmcdev->dbgfs_dir); @@ -1486,7 +1452,6 @@ static int pmc_core_probe(struct platform_device *pde= v) struct pmc_dev *pmcdev; const struct x86_cpu_id *cpu_id; int (*core_init)(struct pmc_dev *pmcdev); - const struct pmc_reg_map *map; struct pmc *primary_pmc; int ret; =20 @@ -1545,11 +1510,6 @@ static int pmc_core_probe(struct platform_device *pd= ev) pm_report_max_hw_sleep(FIELD_MAX(SLP_S0_RES_COUNTER_MASK) * pmc_core_adjust_slp_s0_step(primary_pmc, 1)); =20 - map =3D primary_pmc->map; - if (map->acpi_pm_tmr_ctl_offset) - acpi_pmtmr_register_suspend_resume_callback(pmc_core_acpi_pm_timer_suspe= nd_resume, - pmcdev); - device_initialized =3D true; dev_info(&pdev->dev, " initialized\n"); =20 @@ -1559,12 +1519,6 @@ static int pmc_core_probe(struct platform_device *pd= ev) static void pmc_core_remove(struct platform_device *pdev) { struct pmc_dev *pmcdev =3D platform_get_drvdata(pdev); - const struct pmc *pmc =3D pmcdev->pmcs[PMC_IDX_MAIN]; - const struct pmc_reg_map *map =3D pmc->map; - - if (map->acpi_pm_tmr_ctl_offset) - acpi_pmtmr_unregister_suspend_resume_callback(); - pmc_core_dbgfs_unregister(pmcdev); pmc_core_clean_structure(pdev); } diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/i= ntel/pmc/core.h index 75fd593a7b0f..b9d3291d0bf2 100644 --- a/drivers/platform/x86/intel/pmc/core.h +++ b/drivers/platform/x86/intel/pmc/core.h @@ -68,8 +68,6 @@ struct telem_endpoint; #define SPT_PMC_LTR_SCC 0x3A0 #define SPT_PMC_LTR_ISH 0x3A4 =20 -#define SPT_PMC_ACPI_PM_TMR_CTL_OFFSET 0x18FC - /* Sunrise Point: PGD PFET Enable Ack Status Registers */ enum ppfear_regs { SPT_PMC_XRAM_PPFEAR0A =3D 0x590, @@ -150,8 +148,6 @@ enum ppfear_regs { #define SPT_PMC_VRIC1_SLPS0LVEN BIT(13) #define SPT_PMC_VRIC1_XTALSDQDIS BIT(22) =20 -#define SPT_PMC_BIT_ACPI_PM_TMR_DISABLE BIT(1) - /* Cannonlake Power Management Controller register offsets */ #define CNP_PMC_SLPS0_DBG_OFFSET 0x10B4 #define CNP_PMC_PM_CFG_OFFSET 0x1818 @@ -355,8 +351,6 @@ struct pmc_reg_map { const u8 *lpm_reg_index; const u32 pson_residency_offset; const u32 pson_residency_counter_step; - const u32 acpi_pm_tmr_ctl_offset; - const u32 acpi_pm_tmr_disable_bit; }; =20 /** @@ -432,8 +426,6 @@ struct pmc_dev { u32 die_c6_offset; struct telem_endpoint *punit_ep; struct pmc_info *regmap_list; - - bool enable_acpi_pm_timer_on_resume; }; =20 enum pmc_index { diff --git a/drivers/platform/x86/intel/pmc/icl.c b/drivers/platform/x86/in= tel/pmc/icl.c index cbbd44054468..71b0fd6cb7d8 100644 --- a/drivers/platform/x86/intel/pmc/icl.c +++ b/drivers/platform/x86/intel/pmc/icl.c @@ -46,8 +46,6 @@ const struct pmc_reg_map icl_reg_map =3D { .ppfear_buckets =3D ICL_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D CNP_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D CNP_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .ltr_ignore_max =3D ICL_NUM_IP_IGN_ALLOWED, .etr3_offset =3D ETR3_OFFSET, }; diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/in= tel/pmc/mtl.c index 91f2fa728f5c..c7d15d864039 100644 --- a/drivers/platform/x86/intel/pmc/mtl.c +++ b/drivers/platform/x86/intel/pmc/mtl.c @@ -462,8 +462,6 @@ const struct pmc_reg_map mtl_socm_reg_map =3D { .ppfear_buckets =3D MTL_SOCM_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D CNP_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D CNP_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .lpm_num_maps =3D ADL_LPM_NUM_MAPS, .ltr_ignore_max =3D MTL_SOCM_NUM_IP_IGN_ALLOWED, .lpm_res_counter_step_x2 =3D TGL_PMC_LPM_RES_COUNTER_STEP_X2, diff --git a/drivers/platform/x86/intel/pmc/spt.c b/drivers/platform/x86/in= tel/pmc/spt.c index 2cd2b3c68e46..ab993a69e33e 100644 --- a/drivers/platform/x86/intel/pmc/spt.c +++ b/drivers/platform/x86/intel/pmc/spt.c @@ -130,8 +130,6 @@ const struct pmc_reg_map spt_reg_map =3D { .ppfear_buckets =3D SPT_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D SPT_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D SPT_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .ltr_ignore_max =3D SPT_NUM_IP_IGN_ALLOWED, .pm_vric1_offset =3D SPT_PMC_VRIC1_OFFSET, }; diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/in= tel/pmc/tgl.c index 371b4e30f142..e0580de18077 100644 --- a/drivers/platform/x86/intel/pmc/tgl.c +++ b/drivers/platform/x86/intel/pmc/tgl.c @@ -197,8 +197,6 @@ const struct pmc_reg_map tgl_reg_map =3D { .ppfear_buckets =3D ICL_PPFEAR_NUM_ENTRIES, .pm_cfg_offset =3D CNP_PMC_PM_CFG_OFFSET, .pm_read_disable_bit =3D CNP_PMC_READ_DISABLE_BIT, - .acpi_pm_tmr_ctl_offset =3D SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, - .acpi_pm_tmr_disable_bit =3D SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, .ltr_ignore_max =3D TGL_NUM_IP_IGN_ALLOWED, .lpm_num_maps =3D TGL_LPM_NUM_MAPS, .lpm_res_counter_step_x2 =3D TGL_PMC_LPM_RES_COUNTER_STEP_X2, --=20 2.47.0.rc1.288.g06298d1525-goog