From nobody Wed Nov 27 09:49:57 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122EC149C69; Sat, 12 Oct 2024 08:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728723381; cv=none; b=TWEEo6QcfofuEPYD49pUVqVh6M1rKhyM32JB3r4xTPUmkkwybdEecvPp1Hz+oMV1lOpkVo0jIOFxy/b7a2Dlw/QEslH8JAMafAcIqPelB6iV9RRFO6Yp10gAgVY5X4zsQR/cAzWbhqzNv7or3oTvD1Z1RRTtem/I0IY2PyYFtMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728723381; c=relaxed/simple; bh=em0gXp35HaVAaQ5LVBaRb2iZikUKqU0WzDSVDtj5r0w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=grj+SGOFRJmFsOv/73U0ihspFwycuMlQwr2Hhq8Mx5BsxbJvPTI3Ll1LupMZW49zmR7RjeTod2ELz9Of9wnKvZWmin8pRb3TYjRtGiRcIS6yaft+NR+h6os5eFtH1z5YQ4nJ5j22YfJCyavOWTogcdi1Ks4TndunlqbrZvW5xbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r6js35hf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r6js35hf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F032C4CEC6; Sat, 12 Oct 2024 08:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728723380; bh=em0gXp35HaVAaQ5LVBaRb2iZikUKqU0WzDSVDtj5r0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r6js35hfTsCYBPvH0/JrwvBeU9mtHx7g+vztDxzxMmgalElDLnuA8SIIy3rEysGjY qPPrpmUX0pCTvkMaagKzsOoXUea1I+ByZ0rm/6JZq0/lC0+XiPvcGyGSBzm9IpwZhG qHvl7ZBmUzQX0RpKEQvc2w2k9M9aJ7ArTBan2p/E/rAnoeijuNu40ThN1dX/FM6O4+ TIRelGL66dyPX5FWiohaOtogIB4Mjl6s2FtXKwwdD4P/RurkzukCOeJzmgc2ITre51 WrYz6NtXksX6Uwkxp4BwPpzV6EzksEUW3q3pFMUc286vjH4s+90ujlzG5PAeF/VtiP 6tS5pbttJD3gw== Received: by pali.im (Postfix) id 3E4E57BD; Sat, 12 Oct 2024 10:56:15 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Steve French , Paulo Alcantara , Ronnie Sahlberg Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/7] cifs: Add support for creating WSL-style symlinks Date: Sat, 12 Oct 2024 10:56:13 +0200 Message-Id: <20241012085613.729-1-pali@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241012085252.560-1-pali@kernel.org> References: <20241012085252.560-1-pali@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This change implements support for creating new symlink in WSL-style by Linux cifs client when -o reparse=3Dwsl mount option is specified. WSL-style symlink uses reparse point with tag IO_REPARSE_TAG_LX_SYMLINK and symlink target location is stored in reparse buffer in UTF-8 encoding prefixed by 32-bit flags. Flags bits are unknown, but it was observed that WSL always sets flags to value 0x02000000. Do same in Linux cifs client. New symlinks would be created in WSL-style only in case the mount option -o reparse=3Dwsl is specified, which is not by default. So default CIFS mounts are not affected by this change. Signed-off-by: Pali Roh=C3=A1r --- fs/smb/client/reparse.c | 65 +++++++++++++++++++++++++++++++++-------- 1 file changed, 53 insertions(+), 12 deletions(-) diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c index 50048dccc5ff..b9a50eb03522 100644 --- a/fs/smb/client/reparse.c +++ b/fs/smb/client/reparse.c @@ -502,9 +502,17 @@ static int mknod_nfs(unsigned int xid, struct inode *i= node, return rc; } =20 -static int wsl_set_reparse_buf(struct reparse_data_buffer *buf, - mode_t mode, struct kvec *iov) +static int wsl_set_reparse_buf(struct reparse_data_buffer **buf, + mode_t mode, const char *symname, + struct cifs_sb_info *cifs_sb, + struct kvec *iov) { + struct reparse_wsl_symlink_data_buffer *symlink_buf; + __le16 *symname_utf16; + int symname_utf16_len; + int symname_utf8_maxlen; + int symname_utf8_len; + size_t buf_len; u32 tag; =20 switch ((tag =3D reparse_mode_wsl_tag(mode))) { @@ -512,17 +520,45 @@ static int wsl_set_reparse_buf(struct reparse_data_bu= ffer *buf, case IO_REPARSE_TAG_LX_CHR: case IO_REPARSE_TAG_LX_FIFO: case IO_REPARSE_TAG_AF_UNIX: + buf_len =3D sizeof(struct reparse_data_buffer); + *buf =3D kzalloc(buf_len, GFP_KERNEL); + if (!*buf) + return -ENOMEM; + break; + case IO_REPARSE_TAG_LX_SYMLINK: + symname_utf16 =3D cifs_strndup_to_utf16(symname, strlen(symname), + &symname_utf16_len, + cifs_sb->local_nls, + NO_MAP_UNI_RSVD); + if (!symname_utf16) + return -ENOMEM; + symname_utf8_maxlen =3D symname_utf16_len/2*3; + symlink_buf =3D kzalloc(sizeof(struct reparse_wsl_symlink_data_buffer) + + symname_utf8_maxlen, GFP_KERNEL); + if (!symlink_buf) { + kfree(symname_utf16); + return -ENOMEM; + } + /* Flag 0x02000000 is unknown, but all wsl symlinks have this value */ + symlink_buf->Flags =3D cpu_to_le32(0x02000000); + /* PathBuffer is in UTF-8 but without trailing null-term byte */ + symname_utf8_len =3D utf16s_to_utf8s(symname_utf16, symname_utf16_len/2, + UTF16_LITTLE_ENDIAN, + symlink_buf->PathBuffer, + symname_utf8_maxlen); + *buf =3D (struct reparse_data_buffer *)symlink_buf; + buf_len =3D sizeof(struct reparse_wsl_symlink_data_buffer) + symname_utf= 8_len; + kfree(symname_utf16); break; - case IO_REPARSE_TAG_LX_SYMLINK: /* TODO: add support for WSL symlinks */ default: return -EOPNOTSUPP; } =20 - buf->ReparseTag =3D cpu_to_le32(tag); - buf->Reserved =3D 0; - buf->ReparseDataLength =3D 0; - iov->iov_base =3D buf; - iov->iov_len =3D sizeof(*buf); + (*buf)->ReparseTag =3D cpu_to_le32(tag); + (*buf)->Reserved =3D 0; + (*buf)->ReparseDataLength =3D cpu_to_le16(buf_len - sizeof(struct reparse= _data_buffer)); + iov->iov_base =3D *buf; + iov->iov_len =3D buf_len; return 0; } =20 @@ -614,25 +650,29 @@ static int mknod_wsl(unsigned int xid, struct inode *= inode, const char *full_path, umode_t mode, dev_t dev, const char *symname) { + struct cifs_sb_info *cifs_sb =3D CIFS_SB(inode->i_sb); struct cifs_open_info_data data; - struct reparse_data_buffer buf; + struct reparse_data_buffer *buf; struct smb2_create_ea_ctx *cc; struct inode *new; unsigned int len; struct kvec reparse_iov, xattr_iov; int rc; =20 - rc =3D wsl_set_reparse_buf(&buf, mode, &reparse_iov); + rc =3D wsl_set_reparse_buf(&buf, mode, symname, cifs_sb, &reparse_iov); if (rc) return rc; =20 rc =3D wsl_set_xattrs(inode, mode, dev, &xattr_iov); - if (rc) + if (rc) { + kfree(buf); return rc; + } =20 data =3D (struct cifs_open_info_data) { .reparse_point =3D true, - .reparse =3D { .tag =3D le32_to_cpu(buf.ReparseTag), .buf =3D &buf, }, + .reparse =3D { .tag =3D le32_to_cpu(buf->ReparseTag), .buf =3D buf, }, + .symlink_target =3D kstrdup(symname, GFP_KERNEL), }; =20 cc =3D xattr_iov.iov_base; @@ -649,6 +689,7 @@ static int mknod_wsl(unsigned int xid, struct inode *in= ode, rc =3D PTR_ERR(new); cifs_free_open_info(&data); kfree(xattr_iov.iov_base); + kfree(buf); return rc; } =20 --=20 2.20.1