From nobody Wed Nov 27 08:33:17 2024 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 625181D0421 for ; Fri, 11 Oct 2024 18:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728672358; cv=none; b=Ckj9PH83ahxD/Hfg4/lKaNKTlxl109fqZwStg+sgqmwbFmDsVVi1ClbpDzkbrB5T4GCBGgBW+yzY8A1o7CY/rEnBetZjDUtviiU4kZuAXzfXtd2AICaX0HKUKtNvRAoM1WOP8UPBW0duKnjdg5Gv8QNR7XxYuuD0Zk1w0HbWIQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728672358; c=relaxed/simple; bh=8bCROnq391qhvbK6vLiYM25EQ9c1S2j14ZF+/SPGKz8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cWI0xxadVYJZLHTBSxFwAAOjn3cy2sCxsL4LjLjqhHBPOeaAwnidkTluKkkk4x2qf61Oc74zu6I7vkffJOlpVyYl7m8GdvzJr3RsCyACPXCQ6E0ZKcgKbg+pyX1XsOvrA/KsvfY+Km0Eb6CyGhENglIa4J+4xNfSYzwVrY/FcVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=jtOOcDhR; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="jtOOcDhR" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7db908c9c83so1400116a12.2 for ; Fri, 11 Oct 2024 11:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1728672356; x=1729277156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N45oz9QM8Oj1BURj2520V1UATs/lARHOECpxZOQBaPI=; b=jtOOcDhRoBxz6Ckk4ImR5Yu/Wbqf6sdRb8TdJlMBP7OSKkhXWdy/ohaziUA8ymxNXN gmR8g8WIQUIwvtUg30lHWoksBMdUQaKRuz4XUwJ+s/FpFhkhZFJOwq38Lp+3K3LHyLZ4 M0Gl4qDD/WG1jgCetrIqk4YzLa0kbO7JTjLEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728672356; x=1729277156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N45oz9QM8Oj1BURj2520V1UATs/lARHOECpxZOQBaPI=; b=H44M4vsLud5X9PqLn3FLAfpFaR4qy9s9pcruQoZ0m7qM9+v92yhRrbSGJTdNQ9eB89 YWluIKkIUuliM/6CnQS0XUwB+guYhAIYGHcQ6snVbl7B36hUa03t0MIwhuplsxn6/8Fb mFd8NRfQg4MEB6s4VYROT7MN0T/kc2E6n1GceLDffYzutOL+mbGzVXZ2xun9e82ptots oE3n+gLkHbZSv0O5Av648OcN3Gtv8qYJoGq67eH9rdaS0QAKNAqhaZwElRVbITAjQ5Wx wxOz4SsQr1HDGyaYHqjEBu0umW0v2zkLqKJkBxbkVpfo2WUErTUuKN4u1ftSPGo583Em JtKw== X-Forwarded-Encrypted: i=1; AJvYcCXK9Mfzo6TnKF/KwU2JedWAIdDWk2H9G+JHNHSr4GoXgTZa00oVbC0XzLMuxKoHWVzeVp8ckio8g6DWR38=@vger.kernel.org X-Gm-Message-State: AOJu0YwUyW4KX6LDdUS9SOuCKAa/IVUYjn1DYCzK6nqVMh9L20fFg69v BKld6eeqqAWI/j9XoXimokuc/zIvLcC8UNiFLQWWIY7lbKrBDL6ye2iXQ1wE+NuBJ2e03fMu5yF T X-Google-Smtp-Source: AGHT+IFCPoOYnokvNQ/2QoiFXULBQEDHRLHivUxnHE1zewct7LR//wwx5wrmKun/pN8nw2xNKOpV+A== X-Received: by 2002:a17:90a:2f21:b0:2e2:8299:2701 with SMTP id 98e67ed59e1d1-2e3152eb849mr492826a91.20.1728672356576; Fri, 11 Oct 2024 11:45:56 -0700 (PDT) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e30d848e1csm687625a91.42.2024.10.11.11.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 11:45:56 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org Cc: mkarsten@uwaterloo.ca, skhawaja@google.com, sdf@fomichev.me, bjorn@rivosinc.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, edumazet@google.com, Joe Damato , Jakub Kicinski , "David S. Miller" , Paolo Abeni , Donald Hunter , Jesper Dangaard Brouer , Mina Almasry , Xuan Zhuo , Larysa Zaremba , linux-kernel@vger.kernel.org (open list) Subject: [net-next v6 4/9] netdev-genl: Dump gro_flush_timeout Date: Fri, 11 Oct 2024 18:44:59 +0000 Message-Id: <20241011184527.16393-5-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241011184527.16393-1-jdamato@fastly.com> References: <20241011184527.16393-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support dumping gro_flush_timeout for a NAPI ID. Signed-off-by: Joe Damato Reviewed-by: Jakub Kicinski Reviewed-by: Eric Dumazet --- Documentation/netlink/specs/netdev.yaml | 9 +++++++++ include/uapi/linux/netdev.h | 1 + net/core/netdev-genl.c | 6 ++++++ tools/include/uapi/linux/netdev.h | 1 + 4 files changed, 17 insertions(+) diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlin= k/specs/netdev.yaml index 585e87ec3c16..7b47454c51dd 100644 --- a/Documentation/netlink/specs/netdev.yaml +++ b/Documentation/netlink/specs/netdev.yaml @@ -255,6 +255,14 @@ attribute-sets: type: u32 checks: max: s32-max + - + name: gro-flush-timeout + doc: The timeout, in nanoseconds, of when to trigger the NAPI watc= hdog + timer which schedules NAPI processing. Additionally, a non-ze= ro + value will also prevent GRO from flushing recent super-frames= at + the end of a NAPI cycle. This may add receive latency in exch= ange + for reducing the number of frames processed by the network st= ack. + type: uint - name: queue attributes: @@ -644,6 +652,7 @@ operations: - irq - pid - defer-hard-irqs + - gro-flush-timeout dump: request: attributes: diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h index 13dc0b027e86..cacd33359c76 100644 --- a/include/uapi/linux/netdev.h +++ b/include/uapi/linux/netdev.h @@ -123,6 +123,7 @@ enum { NETDEV_A_NAPI_IRQ, NETDEV_A_NAPI_PID, NETDEV_A_NAPI_DEFER_HARD_IRQS, + NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, =20 __NETDEV_A_NAPI_MAX, NETDEV_A_NAPI_MAX =3D (__NETDEV_A_NAPI_MAX - 1) diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index f98e5d1d0d21..ac19f2e6cfbe 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -161,6 +161,7 @@ static int netdev_nl_napi_fill_one(struct sk_buff *rsp, struct napi_struct *napi, const struct genl_info *info) { + unsigned long gro_flush_timeout; u32 napi_defer_hard_irqs; void *hdr; pid_t pid; @@ -195,6 +196,11 @@ netdev_nl_napi_fill_one(struct sk_buff *rsp, struct na= pi_struct *napi, napi_defer_hard_irqs)) goto nla_put_failure; =20 + gro_flush_timeout =3D napi_get_gro_flush_timeout(napi); + if (nla_put_uint(rsp, NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, + gro_flush_timeout)) + goto nla_put_failure; + genlmsg_end(rsp, hdr); =20 return 0; diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/n= etdev.h index 13dc0b027e86..cacd33359c76 100644 --- a/tools/include/uapi/linux/netdev.h +++ b/tools/include/uapi/linux/netdev.h @@ -123,6 +123,7 @@ enum { NETDEV_A_NAPI_IRQ, NETDEV_A_NAPI_PID, NETDEV_A_NAPI_DEFER_HARD_IRQS, + NETDEV_A_NAPI_GRO_FLUSH_TIMEOUT, =20 __NETDEV_A_NAPI_MAX, NETDEV_A_NAPI_MAX =3D (__NETDEV_A_NAPI_MAX - 1) --=20 2.25.1