From nobody Wed Nov 27 08:47:21 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34A071BF7FE for ; Fri, 11 Oct 2024 17:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728667818; cv=none; b=UaS5G/+HD5UIJ13M4tnaifXbxNrOkFUsfMYEyHxnPxU3ZMXzr1foXXENcH6rYKwh+ly/4ih2dxS2GwCt9izR08JTjHLV9kKecbR5nFOQ5eGp9qDXfKeFu9N0752hqAvpELp2Be37iAizQ4YyQl+4bzxGuN5LQwp6YUcW/xYVjb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728667818; c=relaxed/simple; bh=BNLvL2bN+2RdzPqjhwYAmB84r332uy5578mZl6pDUJo=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=SRPjgfIvNtwzHAMEIx4A+/Ttd3OQ6UmKFH6fKRvuCiL2dihL/pp19WsCtnHwY9m5HVLLX17/uznTd6pFmnac6/xzRvzSb6VcVoFBbHRoba9S/85h7dQuXz1s0kN1EaNWwRZaefj/ccLT0InNIa6MwX7QqvmcPHoLTkj/usFrSyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AFBAC4CED0; Fri, 11 Oct 2024 17:30:18 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98) (envelope-from ) id 1szJTA-00000001U0J-2skX; Fri, 11 Oct 2024 13:30:28 -0400 Message-ID: <20241011173028.545123657@goodmis.org> User-Agent: quilt/0.68 Date: Fri, 11 Oct 2024 13:30:15 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Luis Goncalves , Gabriele Monaco Subject: [for-next][PATCH 5/9] rtla: Fix consistency in getopt_long for timerlat_hist References: <20241011173010.441043942@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriele Monaco Commit e9a4062e1527 ("rtla: Add --trace-buffer-size option") adds a new long option to rtla utilities, but among all affected files, timerlat_hist misses a trailing `:` in the corresponding short option inside the getopt string (e.g. `\3:`). This patch propagates the `:`. Although this change is not functionally required, it improves consistency and slightly reduces the likelihood a future change would introduce a problem. Cc: John Kacur Cc: Luis Goncalves Cc: Tomas Glozar Link: https://lore.kernel.org/20240926143417.54039-1-gmonaco@redhat.com Signed-off-by: Gabriele Monaco Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/src/timerlat_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index a3907c390d67..1f9137c592f4 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -778,7 +778,7 @@ static struct timerlat_hist_params /* getopt_long stores the option index here. */ int option_index =3D 0; =20 - c =3D getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU01234= 56:7:8:9\1\2:\3", + c =3D getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU01234= 56:7:8:9\1\2:\3:", long_options, &option_index); =20 /* detect the end of the options. */ --=20 2.45.2