From nobody Mon Feb 9 06:28:58 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1B4820CCC6 for ; Fri, 11 Oct 2024 07:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728632194; cv=none; b=orMnINSSeChc/PIp5lLm3KhEooCzQne5MGS5ajqOuU7CrOcC7ehA+Xu6+SM3MQ96hzDB8mABrNqqr4KsRPaFvbi939L7V3OwfikfFjqzfFU4ofrbEOekawRIS8uBxF3Yer2pcUMv42PFuhVp/AephC5ca+fk6EzET1qHFOFTkuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728632194; c=relaxed/simple; bh=7cqOV3OKkh0N+su0/SwF7baEzp7XzLuZ+XLRbByZ/6Y=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=oWSU37VjVltdzG3zkQvyUYLsknineX/7TeJSU/jlOzH4s6ROpxlk7+bgneGy+AyGkHcN+7cKv1n4OPz2/QY/L+jXflj0aaa71hV3CYZajbuX3ovedZCYmzyCkjeG7+HFspOcJNmYCC04AsvwiqL1quW1sYVh66wm3LDqQYhG37c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nTKWRUil; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nTKWRUil" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e22f8dc491so33744827b3.1 for ; Fri, 11 Oct 2024 00:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728632192; x=1729236992; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=6fQaK0kCKOZGBatmn2bqZbV4z0l+dtzmVYsD8j3jWpk=; b=nTKWRUilqiqh4AEX8WKZ0HhnUIqvIufEtQ6IIEGKqTZ0Vc/mPSlFuQg0//imSejJTp CJrUXtOmHp1pQUpKZVl9ZqMzwVY9KA7KcDyq/sSxq5tLeRZgfgLpxJTj7cnsRJDqZ7CN qvF1Gk4n2UroSLAxAqv+kX6bU/o6HaMfu2VN7S14XDivJBHTCKkyEULLpIATcY8nK9ie BR3JvDRsYgSQ2hr6f5vwwkVHhiP77XpEramvO02qcPmElgb1Tt31Q1K27lI4H1tzCGc4 FhnIW+Jh82nioUu7yNMTdA1BhQpcKw7YYYUGwuQyU8y51nvXgRhWg5H0dxsLHUZoXg3T UY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728632192; x=1729236992; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6fQaK0kCKOZGBatmn2bqZbV4z0l+dtzmVYsD8j3jWpk=; b=pQl7Uqb8/6FlA8CbFicr4rNwereEvqX7F3K8NoQRyuW6BDD4/SvmD7Is2UzPkS3OZO u+pLRMC/O/OGY8J7N6yy4nsDq4OVJmYJNr3GAsM3SFHxqM3UdPFc2mcOng9n8VoPhFlg lgptSvBkD+OI9gYHchfLXVjasGTC7wRHgJxQAewNu6Ff7x63CRB/TA5L49nUSr+7r8ju 1GZbaZ5ZmxRalhgW8fG00LaQcYyH6+2SAE42/nyPKQ0PISZrCqA15wyHpE+/tKZv2LEJ d11Bjedvwk7KJCmGFO7hlFvhRZnGG/hMeHshCzQev3kmR9V0ymKK1tbUWIomfdH3fxJc RkaQ== X-Forwarded-Encrypted: i=1; AJvYcCWkEyYyRi94iQG0VbHcsBjs+iTevtBRUcI4v70IYbhZCb7Z94xF6S2UooYcOnz6hLuSDFv17ENsK4EoPLE=@vger.kernel.org X-Gm-Message-State: AOJu0YzPvAE6i6hJ+65+jnGrqvaZSzacIbZ2Xf9auQ2FSJsCKZthMbGQ N5BCeU05HARWLCJ17IQD8/BesaKM/BGh7lEkMLYaLB+cjmEzMmWExFDb+WUw445uFCotpIrnmvH QE0feTg== X-Google-Smtp-Source: AGHT+IF3KkyD+E9c898rKYU9e/dhW5sEakuibvn0Cey33Cw5++s26UatIho8gVX2C49X9jgcYvAvAPF5dAGC X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:8144:56f:2e1e:4db]) (user=irogers job=sendgmr) by 2002:a05:690c:2e13:b0:6b2:3ecc:817 with SMTP id 00721157ae682-6e347c6547dmr47247b3.8.1728632191939; Fri, 11 Oct 2024 00:36:31 -0700 (PDT) Date: Fri, 11 Oct 2024 00:35:59 -0700 In-Reply-To: <20241011073559.431302-1-irogers@google.com> Message-Id: <20241011073559.431302-9-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241011073559.431302-1-irogers@google.com> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Subject: [PATCH v1 8/8] perf test: Make parallel testing the default From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Howard Chu , Athira Jajeev , Michael Petlan , Veronika Molnarova , Dapeng Mi , Thomas Richter , Ilya Leoshkevich , Colin Ian King , Weilin Wang , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now C tests can have the "exclusive" flag to run without other tests, and shell tests can add "(exclusive)" to their description, run tests in parallel by default. Tests which flake when run in parallel can be marked exclusive to resolve the problem. Non-scientifically, the reduction on `perf test` execution time is from 8m35.890s to 3m55.115s on a Tigerlake laptop. So the tests complete in less than half the time. Signed-off-by: Ian Rogers --- tools/perf/tests/builtin-test.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-tes= t.c index fd6b50f4d145..2d62b4961f85 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -40,8 +40,8 @@ * making them easier to debug. */ static bool dont_fork; -/* Don't fork the tests in parallel and wait for their completion. */ -static bool sequential =3D true; +/* Fork the tests in parallel and wait for their completion. */ +static bool sequential; const char *dso_to_test; const char *test_objdump_path =3D "objdump"; =20 @@ -619,19 +619,12 @@ int cmd_test(int argc, const char **argv) }; const char *skip =3D NULL; const char *workload =3D NULL; - /* - * Run tests in parallel, lacks infrastructure to avoid running tests - * that clash for resources, So leave it as the developers choice to - * enable while working on the needed infra. - */ - bool parallel =3D false; const struct option test_options[] =3D { OPT_STRING('s', "skip", &skip, "tests", "tests to skip"), OPT_INCR('v', "verbose", &verbose, "be more verbose (show symbol address, etc)"), OPT_BOOLEAN('F', "dont-fork", &dont_fork, "Do not fork for testcase"), - OPT_BOOLEAN('p', "parallel", ¶llel, "Run the tests in parallel"), OPT_BOOLEAN('S', "sequential", &sequential, "Run the tests one after another rather than in parallel"), OPT_STRING('w', "workload", &workload, "work", "workload to run for testi= ng"), @@ -662,8 +655,6 @@ int cmd_test(int argc, const char **argv) =20 if (dont_fork) sequential =3D true; - else if (parallel) - sequential =3D false; =20 symbol_conf.priv_size =3D sizeof(int); symbol_conf.try_vmlinux_path =3D true; --=20 2.47.0.rc1.288.g06298d1525-goog