From nobody Wed Nov 27 14:26:51 2024 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7856C186E52; Thu, 10 Oct 2024 04:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728532849; cv=none; b=uF/JLjy3SgzXSFRVcef/1Hw6HIvis6Ke0STNO30tsh5Gc6EWXn4uE+297Y5rYtpAr2nR7PmvjeIMS6gPlrvcwM3GqOtdqi3ErsJQxtrZXPfO+A/+1ZkgkY+bRhd7QXkAcvI5X8CBZLiSOC96ekPxNrcJwtFBTHXDXbssvrd/ZP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728532849; c=relaxed/simple; bh=bMiKiivS6Hwq0GnIZyU6rmvR5xet7idTh0v0HxIRiZs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iW+JJEWwLyhlxtDA1s8oXtfdXwx1zEPqU5fbtRbEteP4XEMuBviqM8+5JV0E87u4H6KVpwPjT1dOZrjdgECWdOuT4y/CC7Bz3XjbOLyjWTntZngBZl778uielab86GzLDGCC/u7M6bRS3P6pJSP8dl9Y9k0DJCrOIgr/RfkD8Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A2RMtudG; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A2RMtudG" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71e1a715c72so397911b3a.1; Wed, 09 Oct 2024 21:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728532847; x=1729137647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXUQxyqRIc3HsDOFZodLKypqEMMMkzcDuxRdse3iogo=; b=A2RMtudGawvpVyQ1mIHRviRLxPI0LZQoNGkbC/v7Ced7NQBumH2TnhN7aLqX3FYgt3 ryWHwlhdkVsk+myLQ8Z8aO+MX6liVRdEQRjNnleOZJJjz7ndHkEPq6abc8wya43cE5cr tB+KMi9alVhshI0iFxpNPZrnjoi+xsICZjv0/hBaQpGMC8nNUsCpaPPKvlhXBT81WxtO mnsTg20zsFKwuJnRVpMqtWZZv2FRn3zEVNwSW9Jp1hnOjv8kaRqJifrKKZi/6s0MF0xk 0CDzXYgmQTemBZXMzkdHje/8BAK+Fpi8FYW16ouQ2YZVrAx2/pcNP3WzDtLTmwcR6m6R spDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728532847; x=1729137647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXUQxyqRIc3HsDOFZodLKypqEMMMkzcDuxRdse3iogo=; b=nFOtvEYvWV+w5dF4JVY2MoxzAEUeh0YMLdCMtYRmMLmpXls4hm2iBLDJVvzOT4Hzmr n5Ty0autY1cycO5C4/CHuMHyjFUFIxGzb+QHwGRIUpk0k05AuBPnUAgYk+Fh8zTjsALb dMCsmUfeUMiXkCLm4BPJQETYAQGTRDH2J6oOSgQwLIQ7dXy/jWs2OukD8rxODs+lBWcH xj/drJHeq+qIGOYDO7Fv4+PMQURvwICCzUNW/Novrub5c/6aPINBONpG18pM7i2SkJ4c thY3SfH5axVaU9Qa5kLUWhzqccMoGPmEo0s8wuqm6DsZPF/16dYImY2/YPtrb9mMCcne MvhQ== X-Forwarded-Encrypted: i=1; AJvYcCVWJqfQQo5u9SqJ7snGOPBUtu8RTu/KR4TkivTFo0GgWx5oanNBJAGJLTFfHxbpywV3nb2v2jVMuuX/KeI=@vger.kernel.org X-Gm-Message-State: AOJu0YyfQOWIJRGNpqK0jjUhsWecpWRw0OKmzz74VEfznJHwj8W6M4X9 ek4MEP1PqjtFFp+0o87GpcqMKr9WJT/dnNQS8bDEpaobqQjB9bhUbxlPZeRVl/I= X-Google-Smtp-Source: AGHT+IFzm4OFZjqxL0RAiIv9HM898L7vC4IxecD9LWuzhi9tjGPCcMSzNGtJ7AGnbqSplIGtH8d6dw== X-Received: by 2002:a05:6a00:4f91:b0:71e:c0c:598a with SMTP id d2e1a72fcca58-71e267f5216mr3748080b3a.22.1728532847426; Wed, 09 Oct 2024 21:00:47 -0700 (PDT) Received: from fedora.dns.podman ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2ab0b5dfsm187638b3a.199.2024.10.09.21.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 21:00:47 -0700 (PDT) From: Hangbin Liu To: netdev@vger.kernel.org Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shannon Nelson , Jiri Pirko , Stanislav Fomichev , Simon Horman , linux-kernel@vger.kernel.org, Hangbin Liu Subject: [PATCHv2 net-next 1/3] netdevsim: print human readable IP address Date: Thu, 10 Oct 2024 04:00:25 +0000 Message-ID: <20241010040027.21440-2-liuhangbin@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241010040027.21440-1-liuhangbin@gmail.com> References: <20241010040027.21440-1-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, IPSec addresses are printed in hexadecimal format, which is not user-friendly. e.g. # cat /sys/kernel/debug/netdevsim/netdevsim0/ports/0/ipsec SA count=3D2 tx=3D20 sa[0] rx ipaddr=3D0x00000000 00000000 00000000 0100a8c0 sa[0] spi=3D0x00000101 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[0] key=3D0x3167608a ca4f1397 43565909 941fa627 sa[1] tx ipaddr=3D0x00000000 00000000 00000000 00000000 sa[1] spi=3D0x00000100 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[1] key=3D0x3167608a ca4f1397 43565909 941fa627 This patch updates the code to print the IPSec address in a human-readable format for easier debug. e.g. # cat /sys/kernel/debug/netdevsim/netdevsim0/ports/0/ipsec SA count=3D4 tx=3D40 sa[0] tx ipaddr=3D0.0.0.0 sa[0] spi=3D0x00000100 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[0] key=3D0x3167608a ca4f1397 43565909 941fa627 sa[1] rx ipaddr=3D192.168.0.1 sa[1] spi=3D0x00000101 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[1] key=3D0x3167608a ca4f1397 43565909 941fa627 sa[2] tx ipaddr=3D:: sa[2] spi=3D0x00000100 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[2] key=3D0x3167608a ca4f1397 43565909 941fa627 sa[3] rx ipaddr=3D2000::1 sa[3] spi=3D0x00000101 proto=3D0x32 salt=3D0x0adecc3a crypt=3D1 sa[3] key=3D0x3167608a ca4f1397 43565909 941fa627 Reviewed-by: Simon Horman Signed-off-by: Hangbin Liu --- drivers/net/netdevsim/ipsec.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/netdevsim/ipsec.c b/drivers/net/netdevsim/ipsec.c index f0d58092e7e9..102b0955eb04 100644 --- a/drivers/net/netdevsim/ipsec.c +++ b/drivers/net/netdevsim/ipsec.c @@ -39,10 +39,14 @@ static ssize_t nsim_dbg_netdev_ops_read(struct file *fi= lp, if (!sap->used) continue; =20 - p +=3D scnprintf(p, bufsize - (p - buf), - "sa[%i] %cx ipaddr=3D0x%08x %08x %08x %08x\n", - i, (sap->rx ? 'r' : 't'), sap->ipaddr[0], - sap->ipaddr[1], sap->ipaddr[2], sap->ipaddr[3]); + if (sap->xs->props.family =3D=3D AF_INET6) + p +=3D scnprintf(p, bufsize - (p - buf), + "sa[%i] %cx ipaddr=3D%pI6c\n", + i, (sap->rx ? 'r' : 't'), &sap->ipaddr); + else + p +=3D scnprintf(p, bufsize - (p - buf), + "sa[%i] %cx ipaddr=3D%pI4\n", + i, (sap->rx ? 'r' : 't'), &sap->ipaddr[3]); p +=3D scnprintf(p, bufsize - (p - buf), "sa[%i] spi=3D0x%08x proto=3D0x%x salt=3D0x%08x crypt=3D%d\n", i, be32_to_cpu(sap->xs->id.spi), --=20 2.39.5 (Apple Git-154)