From nobody Wed Nov 27 18:48:05 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F9FB18C900 for ; Tue, 8 Oct 2024 09:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728379949; cv=none; b=XBkOQO/xIoZFNJ3kbfr2Hpodwc9+FQw/bLaBhe0WhaxjYxWS8vGaBUlB0firIa44ZD/38Ge7K1A7+Ex0unPQriC1MVaO2ZV7uCoDn0clEQax2PWuRCutyu9uPa8ID6u++20JVKhOCH7e2BTBhIjcidly5N37AX0MLAYtCuhA2HQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728379949; c=relaxed/simple; bh=RNy7f4IYf2GR8GpS+QPyUGvYiK6+9T8IXGPtykB2b6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P7wqbiIe2zdBFvOGwW2L0Xougqd3FC61161agKFfF+TSzZR7iaLWo5QUfqfpsdYhLf4kie6TuYDsN4fTd9LpCe+GIPX6zYeIce63dHlkDL+yjHIo4mNND8QfgYxB66bAKc7IfuXpNRZgmOsQLdDQTxSaogtL6mgUJ+TvEkAdbN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jE8yfCzH; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jE8yfCzH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1728379945; bh=RNy7f4IYf2GR8GpS+QPyUGvYiK6+9T8IXGPtykB2b6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jE8yfCzHL8c59S8JT3nca1jEHPbZlsqZrV+MC0GnYY8fyiCfgLHDna5MFhaIr9gSw U+TlUikTsTiRVQD3lmsLEzlX04JYy/AvgLLwqJRRCI3RoTaH5Yep0HO5O09RXDvVhL nLRjsrKtCQbQ3hQAlI0vngo8yAvLEU27csqmP70ZXLzyEvR7wU29cQiqBDY1bOeg5i 28e5V2pFxvb4NR/dkKFIeykRZy8Tav4Cs0RdxLW1EeZWFcCVlJsDq7Vmzw5mtttC9v 9lzrYfH4aTQVqZ7LFKD0g5uCKfNH6NL2ZLjuGjihfutNcUtd336s6qC7DPoQ5ngVoZ eMVlIIbAIoBag== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5321417E11FA; Tue, 8 Oct 2024 11:32:25 +0200 (CEST) From: AngeloGioacchino Del Regno To: linux-mediatek@lists.infradead.org Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: [PATCH v2 1/2] soc: mediatek: mtk-cmdq: Move mask build and append to function Date: Tue, 8 Oct 2024 11:32:19 +0200 Message-ID: <20241008093220.39734-2-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241008093220.39734-1-angelogioacchino.delregno@collabora.com> References: <20241008093220.39734-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move the CMDQ_CODE_MASK packet build and append logic to a new cmdq_pkt_mask() function; this reduces code duplication by 4x. Reviewed-by: Matthias Brugger Signed-off-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-cmdq-helper.c | 31 ++++++++++++-------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/= mtk-cmdq-helper.c index a8fccedba83f..620c371fd1fc 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -180,6 +180,15 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pk= t, return 0; } =20 +static int cmdq_pkt_mask(struct cmdq_pkt *pkt, u32 mask) +{ + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_MASK, + .mask =3D ~mask + }; + return cmdq_pkt_append_command(pkt, inst); +} + int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) { struct cmdq_instruction inst; @@ -196,14 +205,11 @@ EXPORT_SYMBOL(cmdq_pkt_write); int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value, u32 mask) { - struct cmdq_instruction inst =3D { {0} }; u16 offset_mask =3D offset; int err; =20 if (mask !=3D 0xffffffff) { - inst.op =3D CMDQ_CODE_MASK; - inst.mask =3D ~mask; - err =3D cmdq_pkt_append_command(pkt, inst); + err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 @@ -251,9 +257,7 @@ int cmdq_pkt_write_s_mask(struct cmdq_pkt *pkt, u16 hig= h_addr_reg_idx, struct cmdq_instruction inst =3D {}; int err; =20 - inst.op =3D CMDQ_CODE_MASK; - inst.mask =3D ~mask; - err =3D cmdq_pkt_append_command(pkt, inst); + err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 @@ -288,9 +292,7 @@ int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u= 8 high_addr_reg_idx, struct cmdq_instruction inst =3D {}; int err; =20 - inst.op =3D CMDQ_CODE_MASK; - inst.mask =3D ~mask; - err =3D cmdq_pkt_append_command(pkt, inst); + err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 @@ -409,12 +411,9 @@ EXPORT_SYMBOL(cmdq_pkt_poll); int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value, u32 mask) { - struct cmdq_instruction inst =3D { {0} }; int err; =20 - inst.op =3D CMDQ_CODE_MASK; - inst.mask =3D ~mask; - err =3D cmdq_pkt_append_command(pkt, inst); + err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 @@ -436,9 +435,7 @@ int cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, dma_addr_t= addr, u32 value, u32 mas * which enables use_mask bit. */ if (mask !=3D GENMASK(31, 0)) { - inst.op =3D CMDQ_CODE_MASK; - inst.mask =3D ~mask; - ret =3D cmdq_pkt_append_command(pkt, inst); + ret =3D cmdq_pkt_mask(pkt, mask); if (ret < 0) return ret; use_mask =3D CMDQ_POLL_ENABLE_MASK; --=20 2.46.1 From nobody Wed Nov 27 18:48:05 2024 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E508E18C90A for ; Tue, 8 Oct 2024 09:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728379950; cv=none; b=PX3OXLz9UYxA1BVqn+9AbiYNFkHkmq3tU1RnW0aTLczGBg8CYZ6gY3BHsGukhRRgzyHj0dfrN2QZzOvnZCFizJW3ja3HuZJAcTw6OcJC0FGe2nG0hHyfnFYVqJnoH9e3nKuhN4uD9lyx+lP7/TYFN8jDCRwbCeAvnX95TOLohGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728379950; c=relaxed/simple; bh=yOyGLWSlpz4zNv4SNgy61maEijgqORM9CW6RDCDBj8c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FgnzSBd0Cb8qKbDA8yakV62VicExm3MyD1IIOjPZ7pThEwr8Mc2Q2stA6obbv45ZPf5/z/6LCNKADNBEGBvTcBrEgwOS0pDlWV2VO/MhhtmH8lGUntgsW8h6Ocyfdz0J21/x0ShXOms//u5xKDEQk0Y/66lKSCs/Yxuf4A3rzK4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eaInGarh; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eaInGarh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1728379946; bh=yOyGLWSlpz4zNv4SNgy61maEijgqORM9CW6RDCDBj8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eaInGarhrOvxQIy8SWNPu5AKBQyWA8achoK3ObnALrgYM4bVkdYT5a7bX2M2NRFZj yJW0u4/BMkxVYeWYq1y7i1mLK/CB51r/7rNUQhtJvv0/dRtMzxVBhp3lHzDmiB2T79 PQLkftO4UA2Zn0I/5i5ZyG49pEfH5oq5FWBeE/VSQY0Rj2nLMFqM3QCml0R3Xc08gO E8xsJkczdi8Rbpr+yeQj4NdWYC49G8ux1t2kPiTPtdoiPq527OYRPJSRCfRm6KV0ch gvh98k/OAQFYr1MRlze6wXsaKvCs9dbAsCTPsPpwWgvOmQ6YTD/pB6x/sB2VWzYlA2 B/WtRVzwYU2aA== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id C6C5717E1201; Tue, 8 Oct 2024 11:32:25 +0200 (CEST) From: AngeloGioacchino Del Regno To: linux-mediatek@lists.infradead.org Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: [PATCH v2 2/2] soc: mediatek: mtk-cmdq: Move cmdq_instruction init to declaration Date: Tue, 8 Oct 2024 11:32:20 +0200 Message-ID: <20241008093220.39734-3-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241008093220.39734-1-angelogioacchino.delregno@collabora.com> References: <20241008093220.39734-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move, where possible, the initialization of struct cmdq_instruction variables to their declaration to compress the code. While at it, also change an instance of open-coded mask to use the GENMASK() macro instead, and instances of `ret =3D func(); return ret;` to the equivalent (but shorter) `return func()`. Signed-off-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-cmdq-helper.c | 199 ++++++++++++------------- 1 file changed, 92 insertions(+), 107 deletions(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/= mtk-cmdq-helper.c index 620c371fd1fc..0a05ee87a0fc 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -191,13 +191,12 @@ static int cmdq_pkt_mask(struct cmdq_pkt *pkt, u32 ma= sk) =20 int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) { - struct cmdq_instruction inst; - - inst.op =3D CMDQ_CODE_WRITE; - inst.value =3D value; - inst.offset =3D offset; - inst.subsys =3D subsys; - + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WRITE, + .value =3D value, + .offset =3D offset, + .subsys =3D subsys + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_write); @@ -208,30 +207,27 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subs= ys, u16 offset_mask =3D offset; int err; =20 - if (mask !=3D 0xffffffff) { + if (mask !=3D GENMASK(31, 0)) { err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 offset_mask |=3D CMDQ_WRITE_ENABLE_MASK; } - err =3D cmdq_pkt_write(pkt, subsys, offset_mask, value); - - return err; + return cmdq_pkt_write(pkt, subsys, offset_mask, value); } EXPORT_SYMBOL(cmdq_pkt_write_mask); =20 int cmdq_pkt_read_s(struct cmdq_pkt *pkt, u16 high_addr_reg_idx, u16 addr_= low, u16 reg_idx) { - struct cmdq_instruction inst =3D {}; - - inst.op =3D CMDQ_CODE_READ_S; - inst.dst_t =3D CMDQ_REG_TYPE; - inst.sop =3D high_addr_reg_idx; - inst.reg_dst =3D reg_idx; - inst.src_reg =3D addr_low; - + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_READ_S, + .dst_t =3D CMDQ_REG_TYPE, + .sop =3D high_addr_reg_idx, + .reg_dst =3D reg_idx, + .src_reg =3D addr_low + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_read_s); @@ -239,14 +235,13 @@ EXPORT_SYMBOL(cmdq_pkt_read_s); int cmdq_pkt_write_s(struct cmdq_pkt *pkt, u16 high_addr_reg_idx, u16 addr_low, u16 src_reg_idx) { - struct cmdq_instruction inst =3D {}; - - inst.op =3D CMDQ_CODE_WRITE_S; - inst.src_t =3D CMDQ_REG_TYPE; - inst.sop =3D high_addr_reg_idx; - inst.offset =3D addr_low; - inst.src_reg =3D src_reg_idx; - + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WRITE_S, + .src_t =3D CMDQ_REG_TYPE, + .sop =3D high_addr_reg_idx, + .offset =3D addr_low, + .src_reg =3D src_reg_idx + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_write_s); @@ -254,20 +249,19 @@ EXPORT_SYMBOL(cmdq_pkt_write_s); int cmdq_pkt_write_s_mask(struct cmdq_pkt *pkt, u16 high_addr_reg_idx, u16 addr_low, u16 src_reg_idx, u32 mask) { - struct cmdq_instruction inst =3D {}; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WRITE_S_MASK, + .src_t =3D CMDQ_REG_TYPE, + .sop =3D high_addr_reg_idx, + .offset =3D addr_low, + .src_reg =3D src_reg_idx, + }; int err; =20 err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 - inst.mask =3D 0; - inst.op =3D CMDQ_CODE_WRITE_S_MASK; - inst.src_t =3D CMDQ_REG_TYPE; - inst.sop =3D high_addr_reg_idx; - inst.offset =3D addr_low; - inst.src_reg =3D src_reg_idx; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_write_s_mask); @@ -275,13 +269,12 @@ EXPORT_SYMBOL(cmdq_pkt_write_s_mask); int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, u16 addr_low, u32 value) { - struct cmdq_instruction inst =3D {}; - - inst.op =3D CMDQ_CODE_WRITE_S; - inst.sop =3D high_addr_reg_idx; - inst.offset =3D addr_low; - inst.value =3D value; - + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WRITE_S, + .sop =3D high_addr_reg_idx, + .offset =3D addr_low, + .value =3D value + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_write_s_value); @@ -289,18 +282,18 @@ EXPORT_SYMBOL(cmdq_pkt_write_s_value); int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, u16 addr_low, u32 value, u32 mask) { - struct cmdq_instruction inst =3D {}; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WRITE_S_MASK, + .sop =3D high_addr_reg_idx, + .offset =3D addr_low, + .value =3D value + }; int err; =20 err =3D cmdq_pkt_mask(pkt, mask); if (err < 0) return err; =20 - inst.op =3D CMDQ_CODE_WRITE_S_MASK; - inst.sop =3D high_addr_reg_idx; - inst.offset =3D addr_low; - inst.value =3D value; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value); @@ -333,61 +326,61 @@ EXPORT_SYMBOL(cmdq_pkt_mem_move); =20 int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event, bool clear) { - struct cmdq_instruction inst =3D { {0} }; u32 clear_option =3D clear ? CMDQ_WFE_UPDATE : 0; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WFE, + .value =3D CMDQ_WFE_OPTION | clear_option, + .event =3D event + }; =20 if (event >=3D CMDQ_MAX_EVENT) return -EINVAL; =20 - inst.op =3D CMDQ_CODE_WFE; - inst.value =3D CMDQ_WFE_OPTION | clear_option; - inst.event =3D event; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_wfe); =20 int cmdq_pkt_acquire_event(struct cmdq_pkt *pkt, u16 event) { - struct cmdq_instruction inst =3D {}; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WFE, + .value =3D CMDQ_WFE_UPDATE | CMDQ_WFE_UPDATE_VALUE | CMDQ_WFE_WAIT, + .event =3D event + }; =20 if (event >=3D CMDQ_MAX_EVENT) return -EINVAL; =20 - inst.op =3D CMDQ_CODE_WFE; - inst.value =3D CMDQ_WFE_UPDATE | CMDQ_WFE_UPDATE_VALUE | CMDQ_WFE_WAIT; - inst.event =3D event; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_acquire_event); =20 int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event) { - struct cmdq_instruction inst =3D { {0} }; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WFE, + .value =3D CMDQ_WFE_UPDATE, + .event =3D event + }; =20 if (event >=3D CMDQ_MAX_EVENT) return -EINVAL; =20 - inst.op =3D CMDQ_CODE_WFE; - inst.value =3D CMDQ_WFE_UPDATE; - inst.event =3D event; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_clear_event); =20 int cmdq_pkt_set_event(struct cmdq_pkt *pkt, u16 event) { - struct cmdq_instruction inst =3D {}; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_WFE, + .value =3D CMDQ_WFE_UPDATE | CMDQ_WFE_UPDATE_VALUE, + .event =3D event + }; =20 if (event >=3D CMDQ_MAX_EVENT) return -EINVAL; =20 - inst.op =3D CMDQ_CODE_WFE; - inst.value =3D CMDQ_WFE_UPDATE | CMDQ_WFE_UPDATE_VALUE; - inst.event =3D event; - return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_set_event); @@ -395,16 +388,13 @@ EXPORT_SYMBOL(cmdq_pkt_set_event); int cmdq_pkt_poll(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) { - struct cmdq_instruction inst =3D { {0} }; - int err; - - inst.op =3D CMDQ_CODE_POLL; - inst.value =3D value; - inst.offset =3D offset; - inst.subsys =3D subsys; - err =3D cmdq_pkt_append_command(pkt, inst); - - return err; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_POLL, + .value =3D value, + .offset =3D offset, + .subsys =3D subsys + }; + return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_poll); =20 @@ -418,9 +408,7 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, return err; =20 offset =3D offset | CMDQ_POLL_ENABLE_MASK; - err =3D cmdq_pkt_poll(pkt, subsys, offset, value); - - return err; + return cmdq_pkt_poll(pkt, subsys, offset, value); } EXPORT_SYMBOL(cmdq_pkt_poll_mask); =20 @@ -474,11 +462,12 @@ int cmdq_pkt_logic_command(struct cmdq_pkt *pkt, u16 = result_reg_idx, enum cmdq_logic_op s_op, struct cmdq_operand *right_operand) { - struct cmdq_instruction inst =3D { {0} }; + struct cmdq_instruction inst; =20 if (!left_operand || !right_operand || s_op >=3D CMDQ_LOGIC_MAX) return -EINVAL; =20 + inst.value =3D 0; inst.op =3D CMDQ_CODE_LOGIC; inst.dst_t =3D CMDQ_REG_TYPE; inst.src_t =3D cmdq_operand_get_type(left_operand); @@ -494,43 +483,43 @@ EXPORT_SYMBOL(cmdq_pkt_logic_command); =20 int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) { - struct cmdq_instruction inst =3D {}; - - inst.op =3D CMDQ_CODE_LOGIC; - inst.dst_t =3D CMDQ_REG_TYPE; - inst.reg_dst =3D reg_idx; - inst.value =3D value; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_LOGIC, + .dst_t =3D CMDQ_REG_TYPE, + .reg_dst =3D reg_idx, + .value =3D value + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_assign); =20 int cmdq_pkt_jump_abs(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_pa) { - struct cmdq_instruction inst =3D {}; - - inst.op =3D CMDQ_CODE_JUMP; - inst.offset =3D CMDQ_JUMP_ABSOLUTE; - inst.value =3D addr >> shift_pa; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_JUMP, + .offset =3D CMDQ_JUMP_ABSOLUTE, + .value =3D addr >> shift_pa + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_jump_abs); =20 int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa) { - struct cmdq_instruction inst =3D { {0} }; - - inst.op =3D CMDQ_CODE_JUMP; - inst.value =3D (u32)offset >> shift_pa; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_JUMP, + .value =3D (u32)offset >> shift_pa + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_jump_rel); =20 int cmdq_pkt_eoc(struct cmdq_pkt *pkt) { - struct cmdq_instruction inst =3D { {0} }; - - inst.op =3D CMDQ_CODE_EOC; - inst.value =3D CMDQ_EOC_IRQ_EN; + struct cmdq_instruction inst =3D { + .op =3D CMDQ_CODE_EOC, + .value =3D CMDQ_EOC_IRQ_EN + }; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_eoc); @@ -541,9 +530,7 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) int err; =20 /* insert EOC and generate IRQ for each command iteration */ - inst.op =3D CMDQ_CODE_EOC; - inst.value =3D CMDQ_EOC_IRQ_EN; - err =3D cmdq_pkt_append_command(pkt, inst); + err =3D cmdq_pkt_eoc(pkt); if (err < 0) return err; =20 @@ -551,9 +538,7 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) inst.op =3D CMDQ_CODE_JUMP; inst.value =3D CMDQ_JUMP_PASS >> cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan); - err =3D cmdq_pkt_append_command(pkt, inst); - - return err; + return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_finalize); =20 --=20 2.46.1