From nobody Wed Nov 27 18:36:52 2024 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695251CABA for ; Wed, 9 Oct 2024 01:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728436663; cv=none; b=XHCjwcx3maxQYWtZoTFGxaqIVurKocMCMZVzFUBDOOkev63ki6uZEohpPfbqzoj9nS9btK0a1JpnfxSngXFhZwg6k2ZpvuS5dEj7nHg7V1hvzQxjc1hcZatVdjLQ25cp/whaF3fntLdbyWP30pFmvRDvZdmzqRm2Rs+xCzcRLDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728436663; c=relaxed/simple; bh=1mJpiNVP/4OrjcFTAp0TvKU8K5r9YHdExKD16255m4c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VV7VhFp0D9+iKK91oqHsfCRReiQe4MRgyQf64ZMi/7HL7g6zyH3rvUKCGpyqrSBb3nkRhWN23aQyr99J4JtIvK+OGNeSD1e2vboN/xC+5+59m4zk82PALE2UxB4/7bzQiKWw0a7vKdBbQu+5CrSKHUIIVuzj1UhWwFP5BhGo8X0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com; spf=pass smtp.mailfrom=tenstorrent.com; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b=eOQXGq2Q; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b="eOQXGq2Q" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7db90a28cf6so277936a12.0 for ; Tue, 08 Oct 2024 18:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1728436662; x=1729041462; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J2dcGg6sikxvnM8Tn6Zg71r8Ca2eyP6yTGUfifpMwTY=; b=eOQXGq2QJ2iHr1jNBSfI/Q0VwfCSWUHvG2RfC/p9KtCQ8HOjOlcWJjI8gYiaDNiqBn fQ6QYz82bTZDGJ10B0uU3JL/Zw67DTRT4DABHUKBQuDJo+exQvQWefzOmesGX2LILOTq HhcKpgfTqeeNESvKt0G09WZki+FMe7ROW9TgLpgnxZOrDJiQA8CTip31wokCPyYCnffA yVsCGiuAh6dPll1CPa8sdkKxKVdolLQv5wZDYTUDiAZO5wdGXjlen57yCHAlrCQP4grm vp+OjOTUAt+VWgcmPzkkNYiJd5i3/55fjN7cJsWc/l9Bn71LpqUjbeVNRlzs2MY/qz3Z vZ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728436662; x=1729041462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J2dcGg6sikxvnM8Tn6Zg71r8Ca2eyP6yTGUfifpMwTY=; b=LwhVUVdXigNIryz/UfF8I8W7qFXcrRk3/CUF4SMFdbHx7FtukqkllAS1YoZjcZ7Lss PtTHslSjMOySzSMXXWTB8UnW7jc+NbhW7tHIMUwNjL6oukSJlWqs8bPErB9beXE8aus0 RlqfvfMeaMk2RhniM2hMkyNiSH6IYy473w/xAvM6xRSrnvJN7Dz/nlEF3udvnMVs/JdI XbxUrH1TqPbHAvOBlsbHZeAd/hzO74ThxpeQZqUtAdOT0mqELJ5XNoC81WBruzYzW2iC jIl4qQc0PW1duOildcxK0bX0Q54tvP6pkPhFiF2wQ5wqzVs6xqs6sU6c3vAKahP11jUx 0H3g== X-Forwarded-Encrypted: i=1; AJvYcCUviR1HAoRm+X2H4S9Lz7IaM91pqNDBIo5/fF0pheqQu0eqAAk4i6wYwvMnBjkWEOMjwoDF6aEMq6zJFdA=@vger.kernel.org X-Gm-Message-State: AOJu0YxXbPsBQA5RDq9eMg+U0AjeJD4K4Jlf9W+cIjY8mG+nBUAONHjr YJjW0QIhIwvzL19nVyBL+kFA2UO7l6L7Ll7kQ2B7tCiwK+BWuedFT0UbXEl6Dq0= X-Google-Smtp-Source: AGHT+IG9ZtD9Zd3q75GN23Imw0rYHgFKjP1aIT3fz+CqmO5yL/j7FoVtSH5hft4DRnXSIhe/CGKLbg== X-Received: by 2002:a17:90b:503:b0:2d8:7a63:f9c8 with SMTP id 98e67ed59e1d1-2e27df3a73cmr8151836a91.14.1728436661766; Tue, 08 Oct 2024 18:17:41 -0700 (PDT) Received: from [127.0.1.1] (71-34-69-82.ptld.qwest.net. [71.34.69.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138cbbc2sm61076365ad.78.2024.10.08.18.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 18:17:41 -0700 (PDT) From: Drew Fustini Date: Tue, 08 Oct 2024 18:16:46 -0700 Subject: [PATCH v3 1/3] pinctrl: th1520: Fix return value for unknown pin error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241008-th1520-pinctrl-fixes-v3-1-5b60db446a49@tenstorrent.com> References: <20241008-th1520-pinctrl-fixes-v3-0-5b60db446a49@tenstorrent.com> In-Reply-To: <20241008-th1520-pinctrl-fixes-v3-0-5b60db446a49@tenstorrent.com> To: Drew Fustini , Guo Ren , Fu Wei , Linus Walleij Cc: linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , Drew Fustini X-Mailer: b4 0.14.1 Fix th1520_pinctrl_dt_node_to_map() to set the return value before jumping to free_configs when an unknown pin error occurs. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202410022336.xyWlV0Tf-lkp@intel.com/ Signed-off-by: Drew Fustini --- drivers/pinctrl/pinctrl-th1520.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-th1520.c b/drivers/pinctrl/pinctrl-th1= 520.c index 9331f4462480..265a75a78d5a 100644 --- a/drivers/pinctrl/pinctrl-th1520.c +++ b/drivers/pinctrl/pinctrl-th1520.c @@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl= _dev *pctldev, nmaps =3D rollback; dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n", np, child, pinname); + ret =3D -EINVAL; goto free_configs; } =20 --=20 2.34.1