From nobody Thu Nov 28 04:55:39 2024 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A6621DFD8B for ; Fri, 4 Oct 2024 19:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728070956; cv=none; b=M14IZd50Ygn73Ou7SrSgQ6xe0nW9V/bm4jUzUJ2fDbRdgj2mUisd37+oXaXn4PPvHIHUHnGuw3B4MjmsqW1TTh9jtiCkrJW3ZjkYzta4DCUANLkqpbg2vsDX6XUQgA3eASbtoSsyAU+AB3U03fNYPihWMiubl1RCRrt6pPr5NG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728070956; c=relaxed/simple; bh=mtFbC3q1FEoZoslD6LqH4b0gJ2UmfOQQFzVByMVF2Ok=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qOdIOEJfF7P/QF06ySDyMprrSBaxVecbrisg+BH0BlV4CJsQ3e4sgsOE4mga++tQBTpprfEfeiUYqRaX6BrYYtrJBfQIjj+pcJVkRwHh4BOtN55wAMSbzLeq4T/Cg1m0sitHOptKRKjWExCh/fYfQw+wxsoAbEDNTAMQiZW8Y+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nmKW5i2D; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nmKW5i2D" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728070952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zTAxN9/zmMnDPsplxNnmT42fuUHuWnOXQlHSEscsWkI=; b=nmKW5i2D+P1qcdVW0y93755NHYZ0TDQmGCCwtOGCP6ESI3Wy2aEpLk4XSDjlF73K0FfYBw NIiIxftpUyMFEYnAbYEdzHUQnwNhqDF33qFstV/BWkAuMdnjzddMoTy8QELroqIgGV/8az opv34krwACamJUI9A0eecsc/AbmERSw= From: Sui Jingfeng To: Lucas Stach , Russell King , Christian Gmeiner Cc: David Airlie , Simona Vetter , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sui Jingfeng Subject: [PATCH 1/3] drm/etnaviv: Track GPU VA size separately Date: Sat, 5 Oct 2024 03:42:05 +0800 Message-Id: <20241004194207.1013744-2-sui.jingfeng@linux.dev> In-Reply-To: <20241004194207.1013744-1-sui.jingfeng@linux.dev> References: <20241004194207.1013744-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Etnaviv assumes that GPU page size is 4KiB, yet on some systems, the CPU page size is 16KiB. The size of etnaviv buffer objects will be aligned to CPU page size on kernel side, however, userspace still assumes the page size is 4KiB and doing allocation with 4KiB page as unit. This results in userspace allocated GPU virtual address range collision and therefore unable to be inserted to the specified hole exactly. The root cause is that kernel side BO takes up bigger address space than userspace assumes when the size of it is not CPU page size aligned. To Preserve GPU VA continuous as much as possible, track the size that userspace/GPU think of it is. Yes, we still need to overallocate to suit the CPU, but there is no need to waste GPU VA space anymore. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 8 +++++--- drivers/gpu/drm/etnaviv/etnaviv_gem.h | 1 + drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 8 ++++---- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnavi= v/etnaviv_gem.c index 5c0c9d4e3be1..943fc20093e6 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c @@ -543,7 +543,7 @@ static const struct drm_gem_object_funcs etnaviv_gem_ob= ject_funcs =3D { .vm_ops =3D &vm_ops, }; =20 -static int etnaviv_gem_new_impl(struct drm_device *dev, u32 flags, +static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flag= s, const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj) { struct etnaviv_gem_object *etnaviv_obj; @@ -570,6 +570,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev,= u32 flags, if (!etnaviv_obj) return -ENOMEM; =20 + etnaviv_obj->user_size =3D size; etnaviv_obj->flags =3D flags; etnaviv_obj->ops =3D ops; =20 @@ -588,11 +589,12 @@ int etnaviv_gem_new_handle(struct drm_device *dev, st= ruct drm_file *file, { struct etnaviv_drm_private *priv =3D dev->dev_private; struct drm_gem_object *obj =3D NULL; + unsigned int user_size =3D size; int ret; =20 size =3D PAGE_ALIGN(size); =20 - ret =3D etnaviv_gem_new_impl(dev, flags, &etnaviv_gem_shmem_ops, &obj); + ret =3D etnaviv_gem_new_impl(dev, user_size, flags, &etnaviv_gem_shmem_op= s, &obj); if (ret) goto fail; =20 @@ -627,7 +629,7 @@ int etnaviv_gem_new_private(struct drm_device *dev, siz= e_t size, u32 flags, struct drm_gem_object *obj; int ret; =20 - ret =3D etnaviv_gem_new_impl(dev, flags, ops, &obj); + ret =3D etnaviv_gem_new_impl(dev, size, flags, ops, &obj); if (ret) return ret; =20 diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.h b/drivers/gpu/drm/etnavi= v/etnaviv_gem.h index a42d260cac2c..c6e27b9abb0c 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.h +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.h @@ -36,6 +36,7 @@ struct etnaviv_gem_object { const struct etnaviv_gem_ops *ops; struct mutex lock; =20 + u32 user_size; u32 flags; =20 struct list_head gem_node; diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnavi= v/etnaviv_mmu.c index 1661d589bf3e..6fbc62772d85 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c @@ -281,6 +281,7 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_context = *context, { struct sg_table *sgt =3D etnaviv_obj->sgt; struct drm_mm_node *node; + unsigned int user_size; int ret; =20 lockdep_assert_held(&etnaviv_obj->lock); @@ -303,13 +304,12 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_contex= t *context, } =20 node =3D &mapping->vram_node; + user_size =3D etnaviv_obj->user_size; =20 if (va) - ret =3D etnaviv_iommu_insert_exact(context, node, - etnaviv_obj->base.size, va); + ret =3D etnaviv_iommu_insert_exact(context, node, user_size, va); else - ret =3D etnaviv_iommu_find_iova(context, node, - etnaviv_obj->base.size); + ret =3D etnaviv_iommu_find_iova(context, node, user_size); if (ret < 0) goto unlock; =20 --=20 2.34.1