From nobody Thu Nov 28 06:39:38 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A2BD1B963; Fri, 4 Oct 2024 01:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728004452; cv=none; b=tXzwVcvBidwIbMdEu2cYabajWszMO90vYTKF3UJogg7iR7mnAhPGBNNLNzGN1L3nZpXrtK6BigGVMbE4kmLUT/dRfg/KYB4XKHN2UchsmE2jrSUJ8Ea8f1FlR+rqbo+jjmkfz9W1DPxJno6xlE0uBb5FkANSVUDUdDGJINc8w3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728004452; c=relaxed/simple; bh=iV8BNOEUAlVnHaxKIKuldZvcuyZQrIw4r05iL6v8clg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V2wNBlfgAiuK9vlKT8Lh+mdURHTpizLKJHFGcjKwuKAXaPY88UaBskIDQ0pI5/qnToyOuxFUB9+vbUDgYbYz7DpH9m+pqhoAs8HrRllhgZaMx0Ji51OjwPtQ0vpV8MSiDNwP4BevEhJsMSPm7BQrpZezo4yqQI5QX+V+WoFqJbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=JV7+FlcR; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="JV7+FlcR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1728004449; bh=iV8BNOEUAlVnHaxKIKuldZvcuyZQrIw4r05iL6v8clg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JV7+FlcR0/ACpW3SkjR7TlFyEhEqVs5hH8rbi3cK5s7r440PPii7s4uyqZ4T3FuLU O4yEzW/0j9Qc0RPHq6WlJdsKy5QWlpJYqchh/N5uFEUBsh/u2s+GI8E4EQhcGojFxm 8kgQ/DK+KIejeic4242bMAfWFje99oMhwSd10IeUH1KAtHmJfI6RgDAA0S//aWGtm/ eX1038Zl3ZG6Qo6fy4GO++bTonXt0b17zbeFENk881qKfXH+VoCr/imD3YP50SLNef QL58rp4rELltYrtA24W10ZkhZRpvUzP6LGKv1XVa+LC36qy6je+pItYjIHH5CyJAgR WQIZ6irjEe1zg== Received: from thinkos.internal.efficios.com (unknown [IPv6:2606:6d00:100:4000:cacb:9855:de1f:ded2]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XKVtm6FjRzBbj; Thu, 3 Oct 2024 21:14:08 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt , Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , linux-trace-kernel@vger.kernel.org, Andrii Nakryiko , Michael Jeanson Subject: [PATCH v2 7/7] tracing/bpf: Add might_fault check to syscall probes Date: Thu, 3 Oct 2024 21:12:01 -0400 Message-Id: <20241004011201.1681962-8-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241004011201.1681962-1-mathieu.desnoyers@efficios.com> References: <20241004011201.1681962-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a might_fault() check to validate that the bpf sys_enter/sys_exit probe callbacks are indeed called from a context where page faults can be handled. Signed-off-by: Mathieu Desnoyers Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko # BPF parts Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes --- include/trace/bpf_probe.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/trace/bpf_probe.h b/include/trace/bpf_probe.h index 211b98d45fc6..099df5c3e38a 100644 --- a/include/trace/bpf_probe.h +++ b/include/trace/bpf_probe.h @@ -57,6 +57,7 @@ __bpf_trace_##call(void *__data, proto) \ static notrace void \ __bpf_trace_##call(void *__data, proto) \ { \ + might_fault(); \ guard(preempt_notrace)(); \ CONCATENATE(bpf_trace_run, COUNT_ARGS(args))(__data, CAST_TO_U64(args)); \ } --=20 2.39.2