From nobody Thu Nov 28 10:01:03 2024 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AECA91E7646; Wed, 2 Oct 2024 11:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868032; cv=none; b=IxZlW74+7GJGVcs1T33kdhPk6Z9F5s5bCiMco9xceNW1vcKFF74D90tYepfPGDi2tnFZx8RF0gs9iVLG4XoN9On7HddYxQsKXIhoWtc0DuB4IO50AvLKNkLbsgY/hxi0fFCvMEk0XBdGBcG0Ca/u5eyq8a9+i3UpbrEWxbQ8rmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868032; c=relaxed/simple; bh=xEztw/GwwhLD/gX/2JuP2k+o9OcVESh2PGvr7/izPNU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WghZVzvrRSu8ttHRbZiApEfsXCF9Wk2NV0etDJI2MBWZddy5CsHy7wtz7h56IKzZ01RUWbUltyYQvdUXqeCts2lQzA6+2EaiZ5ah0i+ksxkZt49o7C/i4LCND4JF86BpGq0pcBc2+rfuaB8rV+cp0DS7826eWteifq3Bpcv/PdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hq5A/JZz; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hq5A/JZz" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42e5e1e6d37so60198765e9.3; Wed, 02 Oct 2024 04:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727868029; x=1728472829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pWe1LOAQAUHDMm2EMz2P+3VNJFGofn6qsW8nJYyiXVM=; b=hq5A/JZzAgZfijQFVsrHqAivcsF6kMJBwm03JkaUTqQT78Y3jTNu8uan2B9Ii/LzlX XrM0RJdS5VZ2RzmDCxRPZeHrb5xWmYGCsnR61wb2yS5ci0uGF31UyQyD2KyHSOhMJSuA TtR+T8fwWYp7Oe9m+YK9uuyVofDUi81IhsWnDehF9JN3Wf1wMUSkYdg4xcmiAneLRgsH Nob2oUeU2eXA7Dayym72LWP8DA+C/qc58c22mvYvugZ5Y1IxB9gl5gIzOeWldnURdxbl cX7GjO4VNO0RrIW5waJ0Q4BC6YzzTwwx6O6uslWZRHwEToQ+7wxUwFsXxe9+3nYvsBYL FrtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868029; x=1728472829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pWe1LOAQAUHDMm2EMz2P+3VNJFGofn6qsW8nJYyiXVM=; b=NGA6+k3XpkcBOJDhv2eX1bGVtKEgebWOVMq20zaPNQl/Olwp4BSqyGBjaSGhtRiokF sOhscuxEk8s9VZpPvbicqWBewRbDoQY/O/AbpYv2Uk9L96t3ueBYechm4+m+Q65d4N5D Y7AaxA9udHZr+T5tekO4MZiviT+NWPar2/eyyj61DINQl41/n+vgNARV/m3KLAitRO5m 5cBVjy14wFaWeaahs3tRBXlMH2yRQRJRl+7rAvLUdfvOPkhw3IXDn3XP0ad4YOIkbczn EXuA94SNglxqldxDdO8NNcti4JlEVYw+iCyeAduAVnY2zc0Gxxn0hTAfzTr9pNtGxFzg OB7g== X-Forwarded-Encrypted: i=1; AJvYcCWam9PIIY0cAWdV5A76Ntr7nCNiARw8+91zhPX3Rg/lK1K5cCw9AcwdMgNu1yUKbMjpP8/0hLhri+4T9SY=@vger.kernel.org X-Gm-Message-State: AOJu0YyEGoTbdOQYzjn1+7QbvMFv60ZnMuqC5WIBC2RLsYugmUbd7R2/ r4wCmmkgSp7wj0n9v3mvr+rtuE/okseDBt9VmdJrCAawfBU8+5LO X-Google-Smtp-Source: AGHT+IFGTSatLO1Ox4UQ8gJUxFQ+Sve6VZQyHmLuQ8fa68lXptO2HqFrHIWSzqjI6q344kc1YAHVhQ== X-Received: by 2002:a5d:6189:0:b0:374:cbc4:53b1 with SMTP id ffacd0b85a97d-37cfba0a641mr1674756f8f.40.1727868028950; Wed, 02 Oct 2024 04:20:28 -0700 (PDT) Received: from eichest-laptop.corp.toradex.com (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f771a1209sm23530685e9.0.2024.10.02.04.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:20:28 -0700 (PDT) From: Stefan Eichenberger To: o.rempel@pengutronix.de, kernel@pengutronix.de, andi.shyti@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com, Stefan Eichenberger Subject: [PATCH v4 1/4] i2c: imx: only poll for bus busy in multi master mode Date: Wed, 2 Oct 2024 13:19:39 +0200 Message-ID: <20241002112020.23913-2-eichest@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241002112020.23913-1-eichest@gmail.com> References: <20241002112020.23913-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger According to the i.MX8M Mini reference manual chapter "16.1.4.2 Generation of Start" it is only necessary to poll for bus busy and arbitration lost in multi master mode. This helps to avoid rescheduling while the i2c bus is busy and avoids SMBus devices to timeout. Signed-off-by: Stefan Eichenberger Reviewed-by: Frank Li Acked-by: Oleksij Rempel --- drivers/i2c/busses/i2c-imx.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 98539313cbc97..fbacdfaf6b28e 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -216,6 +216,8 @@ struct imx_i2c_struct { struct i2c_client *slave; enum i2c_slave_event last_slave_event; =20 + bool multi_master; + /* For checking slave events. */ spinlock_t slave_lock; struct hrtimer slave_timer; @@ -481,6 +483,9 @@ static int i2c_imx_bus_busy(struct imx_i2c_struct *i2c_= imx, int for_busy, bool a unsigned long orig_jiffies =3D jiffies; unsigned int temp; =20 + if (!i2c_imx->multi_master) + return 0; + while (1) { temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR); =20 @@ -540,8 +545,8 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *= i2c_imx, bool atomic) return -ETIMEDOUT; } =20 - /* check for arbitration lost */ - if (i2c_imx->i2csr & I2SR_IAL) { + /* In multi-master mode check for arbitration lost */ + if (i2c_imx->multi_master && (i2c_imx->i2csr & I2SR_IAL)) { dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__); i2c_imx_clear_irq(i2c_imx, I2SR_IAL); =20 @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev) goto rpm_disable; } =20 + i2c_imx->multi_master =3D of_property_read_bool(pdev->dev.of_node, "multi= -master"); + /* Set up clock divider */ i2c_imx->bitrate =3D I2C_MAX_STANDARD_MODE_FREQ; ret =3D of_property_read_u32(pdev->dev.of_node, --=20 2.43.0 From nobody Thu Nov 28 10:01:03 2024 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E04D1EC018; Wed, 2 Oct 2024 11:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868034; cv=none; b=aSTdPOQ2jAA28XLgKod0VvxzJJDpMKt/A6hTHGeKDZppJ5fgwUq3v1zeCUTWq8gkKM5fIZGP4380rF3/8tn5PPxSxEZh0mWMCA23Spiw37o4empg7uCId7O4O7vMIbpu6JlilQFux56U9+CppzT0ROe4jVgik+/05usmwzvZwww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868034; c=relaxed/simple; bh=MKnrud29RKMPTycM6l5Mca3jSG7iCjsMY4h1o9UJ3vE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kVos6XTJ3DhmX/hJ8GVHGDwLNry740NNVY9ZwPI30k5D85at8unF9FbgVyv2Q6ZSqIqGqSjTfC4iR5M16AnRmIZhr6i/H3lAwIxUOSpGieqf79qOypU7j4b71FqsckuUpmw0Wk6prskWEEHBrsB7NFMS5W3QKeArrPKFQf2AY7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zwb2DPyD; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zwb2DPyD" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42e7b7bef42so53985205e9.3; Wed, 02 Oct 2024 04:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727868031; x=1728472831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HfSuN/9R2eLcV7k6Kk+kiVJyE0XEHkvEyhQ/EQ6vegg=; b=Zwb2DPyDp+06ltoz3PxqN48G2GyGLEqZ6BQT2d79x3mjpYuWr/n9nuj5K0cjWUcCeQ hraGJlG2VcPIHNCHtbaCbNsSiNWhaWtoFZMnlukZcUbd4FoYJfqTOllDeng/MuOdbs4l LY+eZ/HppO5qXYdKL6HBTWZ3UikvR6FIrQiJq/xbfz03PcPweOKeJvPs7cCXJHKqRVo2 IiE15hbvitoqz0EbHUCPYn0jzk2273FKdr0QNXuGeCND00JWRe0lBYFxloumgfd6GE7w f+JMUaJwLyVt/apS6UJo5vBewaHuBa1lNIclF8eNCask9rnDokNVoSh1JGU8WDkQtxB4 g7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868031; x=1728472831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfSuN/9R2eLcV7k6Kk+kiVJyE0XEHkvEyhQ/EQ6vegg=; b=Z0OCCvfdS2ceoW5bJJBpQmE4sqEagAiYwHNC0Nk1RRLExHMBb90nBgI3GL2PwFxjox WpKe4uxC3gVagsnCCVYy7exEca3fD8yWqN0bbxHZFJtOMs7Dj0lLrrBElDFOPo5pN9SO Ok8NWAgfDyaAvlkUqiT9/o9qUgG9zzGSI3KnU8liLaJV5x+UdiGlKYraRy3m/vZThmVz yawCmeHUlx59OAR1fi0jjn3WpYJEez6qzZYznPTB7r4T6+qGC5FpJtrICqN4o/aOxFxj IzUrPKknmOf41dXGuvdrsVU7a9HqjDYA2LHKH7aaloewAjhOsNL5SuKPjX5FE0+7QA8X R4Bw== X-Forwarded-Encrypted: i=1; AJvYcCXZ36g1r9HuI7yrEwj9MM15Z4txqaN+E0ZzoncEm/7z4VzGZnOJOoaQHWaDsiV3J4pnz37waZgfUpRZTp4=@vger.kernel.org X-Gm-Message-State: AOJu0YwXfGpXP+uG80aZTfwZs9HV7lGVOwEC8YQG+dZpmG1Cx/hBvfn+ MCtQpcvKIHbt/JKzM0JlchqfNno7usSGOJn6Z2qs9EjqWFlhZBLl X-Google-Smtp-Source: AGHT+IHA06m26rIP/ioTpXEk53Q2NwfqbhJDeAbiLo7zhCOBS8PDUS/+gwi/4+3YNDN5go+YVrwIiA== X-Received: by 2002:a05:6000:184b:b0:374:c432:4971 with SMTP id ffacd0b85a97d-37cfb8b559cmr2069721f8f.16.1727868030624; Wed, 02 Oct 2024 04:20:30 -0700 (PDT) Received: from eichest-laptop.corp.toradex.com (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f771a1209sm23530685e9.0.2024.10.02.04.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:20:29 -0700 (PDT) From: Stefan Eichenberger To: o.rempel@pengutronix.de, kernel@pengutronix.de, andi.shyti@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com, Stefan Eichenberger Subject: [PATCH v4 2/4] i2c: imx: separate atomic, dma and non-dma use case Date: Wed, 2 Oct 2024 13:19:40 +0200 Message-ID: <20241002112020.23913-3-eichest@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241002112020.23913-1-eichest@gmail.com> References: <20241002112020.23913-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger Separate the atomic, dma and non-dma use case as a preparation step for moving the non-dma use case to the isr to avoid rescheduling while a transfer is in progress. Signed-off-by: Stefan Eichenberger Reviewed-by: Frank Li Acked-by: Oleksij Rempel --- drivers/i2c/busses/i2c-imx.c | 107 +++++++++++++++++++++++------------ 1 file changed, 70 insertions(+), 37 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index fbacdfaf6b28e..8e9cdeff278a8 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -1011,6 +1011,43 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *= i2c_imx, return i2c_imx_acked(i2c_imx); } =20 +static int i2c_imx_prepare_read(struct imx_i2c_struct *i2c_imx, + struct i2c_msg *msgs, bool atomic, + bool use_dma) +{ + int result; + unsigned int temp =3D 0; + + /* write slave address */ + imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); + result =3D i2c_imx_trx_complete(i2c_imx, atomic); + if (result) + return result; + result =3D i2c_imx_acked(i2c_imx); + if (result) + return result; + + dev_dbg(&i2c_imx->adapter.dev, "<%s> setup bus\n", __func__); + + /* setup bus to read data */ + temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + temp &=3D ~I2CR_MTX; + + /* + * Reset the I2CR_TXAK flag initially for SMBus block read since the + * length is unknown + */ + if (msgs->len - 1) + temp &=3D ~I2CR_TXAK; + if (use_dma) + temp |=3D I2CR_DMAEN; + + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR); /* dummy read */ + + return 0; +} + static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, bool is_lastmsg) { @@ -1021,6 +1058,11 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i= 2c_imx, struct imx_i2c_dma *dma =3D i2c_imx->dma; struct device *dev =3D &i2c_imx->adapter.dev; =20 + result =3D i2c_imx_prepare_read(i2c_imx, msgs, false, true); + if (result) + return result; + + dev_dbg(&i2c_imx->adapter.dev, "<%s> read data\n", __func__); =20 dma->chan_using =3D dma->chan_rx; dma->dma_transfer_dir =3D DMA_DEV_TO_MEM; @@ -1131,50 +1173,24 @@ static int i2c_imx_write(struct imx_i2c_struct *i2c= _imx, struct i2c_msg *msgs, return 0; } =20 +static int i2c_imx_atomic_write(struct imx_i2c_struct *i2c_imx, struct i2c= _msg *msgs) +{ + return i2c_imx_write(i2c_imx, msgs, true); +} + static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *ms= gs, bool is_lastmsg, bool atomic) { int i, result; unsigned int temp; int block_data =3D msgs->flags & I2C_M_RECV_LEN; - int use_dma =3D i2c_imx->dma && msgs->flags & I2C_M_DMA_SAFE && - msgs->len >=3D DMA_THRESHOLD && !block_data; =20 - dev_dbg(&i2c_imx->adapter.dev, - "<%s> write slave address: addr=3D0x%x\n", - __func__, i2c_8bit_addr_from_msg(msgs)); - - /* write slave address */ - imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); - result =3D i2c_imx_trx_complete(i2c_imx, atomic); + result =3D i2c_imx_prepare_read(i2c_imx, msgs, atomic, false); if (result) return result; - result =3D i2c_imx_acked(i2c_imx); - if (result) - return result; - - dev_dbg(&i2c_imx->adapter.dev, "<%s> setup bus\n", __func__); - - /* setup bus to read data */ - temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); - temp &=3D ~I2CR_MTX; - - /* - * Reset the I2CR_TXAK flag initially for SMBus block read since the - * length is unknown - */ - if ((msgs->len - 1) || block_data) - temp &=3D ~I2CR_TXAK; - if (use_dma) - temp |=3D I2CR_DMAEN; - imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); - imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR); /* dummy read */ =20 dev_dbg(&i2c_imx->adapter.dev, "<%s> read data\n", __func__); =20 - if (use_dma) - return i2c_imx_dma_read(i2c_imx, msgs, is_lastmsg); - /* read data */ for (i =3D 0; i < msgs->len; i++) { u8 len =3D 0; @@ -1241,6 +1257,12 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_i= mx, struct i2c_msg *msgs, return 0; } =20 +static int i2c_imx_atomic_read(struct imx_i2c_struct *i2c_imx, struct i2c_= msg *msgs, + bool is_lastmsg) +{ + return i2c_imx_read(i2c_imx, msgs, is_lastmsg, true); +} + static int i2c_imx_xfer_common(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num, bool atomic) { @@ -1248,6 +1270,7 @@ static int i2c_imx_xfer_common(struct i2c_adapter *ad= apter, int result; bool is_lastmsg =3D false; struct imx_i2c_struct *i2c_imx =3D i2c_get_adapdata(adapter); + int use_dma =3D 0; =20 /* Start I2C transfer */ result =3D i2c_imx_start(i2c_imx, atomic); @@ -1300,15 +1323,25 @@ static int i2c_imx_xfer_common(struct i2c_adapter *= adapter, (temp & I2SR_SRW ? 1 : 0), (temp & I2SR_IIF ? 1 : 0), (temp & I2SR_RXAK ? 1 : 0)); #endif + + use_dma =3D i2c_imx->dma && msgs[i].len >=3D DMA_THRESHOLD && + msgs[i].flags & I2C_M_DMA_SAFE; if (msgs[i].flags & I2C_M_RD) { - result =3D i2c_imx_read(i2c_imx, &msgs[i], is_lastmsg, atomic); + int block_data =3D msgs->flags & I2C_M_RECV_LEN; + + if (atomic) + result =3D i2c_imx_atomic_read(i2c_imx, &msgs[i], is_lastmsg); + else if (use_dma && !block_data) + result =3D i2c_imx_dma_read(i2c_imx, &msgs[i], is_lastmsg); + else + result =3D i2c_imx_read(i2c_imx, &msgs[i], is_lastmsg, false); } else { - if (!atomic && - i2c_imx->dma && msgs[i].len >=3D DMA_THRESHOLD && - msgs[i].flags & I2C_M_DMA_SAFE) + if (atomic) + result =3D i2c_imx_atomic_write(i2c_imx, &msgs[i]); + else if (use_dma) result =3D i2c_imx_dma_write(i2c_imx, &msgs[i]); else - result =3D i2c_imx_write(i2c_imx, &msgs[i], atomic); + result =3D i2c_imx_write(i2c_imx, &msgs[i], false); } if (result) goto fail0; --=20 2.43.0 From nobody Thu Nov 28 10:01:03 2024 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10079200101; Wed, 2 Oct 2024 11:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868035; cv=none; b=rX0gvoknG3gcQ9su/1IwU/El/4H7fZ7MynITK9gYhHsBH1hzaVSTQMV16weNojw6Rxhj+9lsFXdI9HylUe1+4Jx3Z6ML1agcr4zWjDdotLx2SmcPQ2+35QSto8p9ES0l31v9Qg6KLic+VyS27LjpsAO6Ysbq64g93BqTdCds7Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868035; c=relaxed/simple; bh=E1YeGuIBk8BwF197H23q4KiKySl80PzVksLcuFV4vmc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbR6esdwHuh/T7SZLAd+8yoF+dQpV0/if4v0kcvUsrGb/VXevJUEUSC89DsYvPIN93pkFk+YTg6H5/xDXDDhC7O6Pf+PDNEo1Ue/CIRKZIVBphML7Ls0yPWhIkuD8abT5IibENmxhL6zYbd3UDvhBsQRal9oM3XBvmDTB5hrH1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z4dy5qLZ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z4dy5qLZ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42cb57f8b41so80798965e9.0; Wed, 02 Oct 2024 04:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727868032; x=1728472832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4V7Qw24AIjD9e3DTOuaXw9uJfa/Y+gcgalY/kZOlqpg=; b=Z4dy5qLZNofGrevIZAVCCucNyNp5Mp2rnFo1M68jEB733pjYs2mbILoJ4jzX8/bHUk MKPiTa19GlvHHjU11p9d/r5+U6oZtvvDfMvtlP6C5Rhc7jdC85jhJI5varj85cCrJ5xp cue2Q4OxHIcrlCQA2tY5jnhc/bS56whi5nAqB/EJw6k1yyNe7AS0eMn3+Aq70MMTPKNU 5kGTX8m8OpezjqwG3VeoXdGrGChXMz+GbqQ5jNgNLyve/3WgruaTF4wPLV0w/N1V6Jnm COYRwyZ7OEk8pAUHMLgH5P3VTUczBny/G7BjHqNzgQ/4Mw8j1SB/qLvhduxWNhYoYrDt NcAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868032; x=1728472832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4V7Qw24AIjD9e3DTOuaXw9uJfa/Y+gcgalY/kZOlqpg=; b=i9FBwrGXZD9N6Bo8XMKpvum7ZJpTtsdPgpKLZDyLjeRg4Vn/aCMJA7x7AUhZUkz4rM 7RqhDR8fkd7+dE3FgEB/fV1CJiuNUurcjWa8FrCTGYeYxZaaqNAEAHpySZ87wWZwmtph RTM6054IGb6HHUQWfUuPcR8dHNQpEycZo/H3pwkGKvo5Ly+yQ9awkEvKNw5DwsqI1z1u PLB3zJA6xnGhHP2/39JMoBJcjWFDUWxxOEH3Vv/4kDL5uzokcFhPMqbZ9GUNbdyR/Kkz TtZFfAN1MMYXCyBAPPUyuIRPoa/cRJ1caZ5zxBr0hDNM2EecuhNaM/9YcwIEYr/NJJEk +69w== X-Forwarded-Encrypted: i=1; AJvYcCW66vmE+Ig32aEQdULa9L/A2H793cR4GWnm1vTzSP38qzHEncWdx0xqS7gx93hJmgsMCUjcARaG9ZsY/SY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu2d0XGMf0siYzqBsOUxXfNmwrf0jofklwrhyZcxRpPIqWXxme OPAED9fX0DhoUA96nKL2q08tKXRO8GwidTI0L+94b4ZeBN2GTYiF X-Google-Smtp-Source: AGHT+IGehBz2wvp4octtBZnLUT1OhdST1Vf9e5fzfCVsKngbJHX2vTvVmrVGdPh9ghtRzv5CYCn1eQ== X-Received: by 2002:a05:600c:1d88:b0:42c:a387:6a6f with SMTP id 5b1f17b1804b1-42f777c365fmr23211065e9.20.1727868032188; Wed, 02 Oct 2024 04:20:32 -0700 (PDT) Received: from eichest-laptop.corp.toradex.com (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f771a1209sm23530685e9.0.2024.10.02.04.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:20:31 -0700 (PDT) From: Stefan Eichenberger To: o.rempel@pengutronix.de, kernel@pengutronix.de, andi.shyti@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com, Stefan Eichenberger Subject: [PATCH v4 3/4] i2c: imx: use readb_relaxed and writeb_relaxed Date: Wed, 2 Oct 2024 13:19:41 +0200 Message-ID: <20241002112020.23913-4-eichest@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241002112020.23913-1-eichest@gmail.com> References: <20241002112020.23913-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger Use the relaxed version of readb and writeb to reduce overhead. It is safe to use the relaxed version because we either do not rely on dma completion, or we use a dma callback to ensure that the dma transfer is complete before we continue. Signed-off-by: Stefan Eichenberger Acked-by: Oleksij Rempel --- drivers/i2c/busses/i2c-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 8e9cdeff278a8..f70522a83f823 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -313,13 +313,13 @@ static inline int is_vf610_i2c(struct imx_i2c_struct = *i2c_imx) static inline void imx_i2c_write_reg(unsigned int val, struct imx_i2c_struct *i2c_imx, unsigned int reg) { - writeb(val, i2c_imx->base + (reg << i2c_imx->hwdata->regshift)); + writeb_relaxed(val, i2c_imx->base + (reg << i2c_imx->hwdata->regshift)); } =20 static inline unsigned char imx_i2c_read_reg(struct imx_i2c_struct *i2c_im= x, unsigned int reg) { - return readb(i2c_imx->base + (reg << i2c_imx->hwdata->regshift)); + return readb_relaxed(i2c_imx->base + (reg << i2c_imx->hwdata->regshift)); } =20 static void i2c_imx_clear_irq(struct imx_i2c_struct *i2c_imx, unsigned int= bits) --=20 2.43.0 From nobody Thu Nov 28 10:01:03 2024 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C0F200115; Wed, 2 Oct 2024 11:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868037; cv=none; b=pafCg0ZYeUfoq836CVOSrwJEpVW/6vSFT8jl4EZlPkjvKZ2f6oFXirCwo7L4hLfAeiT8ORYa2xXzarc0bvQoeSqG3usjDT8akJDpnXBXlhuJ/YqqXXlu0iNhtBgVnUIpz0EcUBH1LMv3Z1tnza2HZmFSHdZh6F4RZmxbQoTuRUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868037; c=relaxed/simple; bh=ZZGqjVQCfJCYZGYT2BzvvtIejK6kU4Y4wziVU9sZnqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F4RjOqiWkn9uPQfz8x/QCKwZaOq6m/v5V8OT4iNeRv/1nzmiBeCIZ5gxgvrYZx5wGlZy9f1egBYetFbEM0yct8bL/zCsnXlvBURhwyWWdZ4jXf+QdPAgDOsuNmOj9+a9EmsGcplLm570NvKVZq7AuNKrEb2bR74Hk0o7Yj/7DgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MnHP9fit; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MnHP9fit" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cb7a2e4d6so59066645e9.0; Wed, 02 Oct 2024 04:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727868033; x=1728472833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i0UqMrIXPYSH8EyqJY2SsPH+wmHdgC0pdLL8XDK1EHE=; b=MnHP9fityx6A/sXkDM5r2TvO8teOVx/ws6mfVOJgKvqONBwEYZ8BWOrQjOTPugQGOV 8rho+Zfy8z3Z2gxK+HpE3Ziz1Yryp3DE3x24JKp5uHuo8Jg86KuJTeAINLRnNlmBZrCe toEcfWJrOmwtgy+FLTYCWCR9QkzzM8NSEFcoEu5iDpGeHxAaBlD41XMQF/8dR24MBf/i k9zEwoU+7fpY/hOSKZlq9AUm8Yfbm3kGb7ndoziaghvzBRE1b5+M10e4SZnu0FxYvUZX GNB/p8uCP/813fBjcLcSghC1r1eXPK2mtMD2diBk4F2omTiox76nShiO505aelOEsHlb Um0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868033; x=1728472833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i0UqMrIXPYSH8EyqJY2SsPH+wmHdgC0pdLL8XDK1EHE=; b=lWeN+ZW1iDfc4PtRtqn6DnEM904i8jox/Ydt8WBWC1RQOTfLT3sMc5z1E88OsjM8kv lOfCowlxJ39yLBJ4RyJGNIIQxdX6KMS4FdzJ9Pgr7YcD7FzXfodHvzMLqgjs6jS30Lcr FRu8qLwwP6wCsmzuDUIyQzASaNDV9PXT629PbohvkVcA8K+b6RFRiSAFi/2Q1JhFklvE /s8Gq1MBXyvuz9Wt/dsgnLJ3vO7zrYTGt+1ytIstXoNKjLjmbP9lqtpOHhR5E0m/W+ip kmVMzlJ3BhVdLCcR4pZXdZ7pnJwk4eg/WKCTOHzMbI4XBb8v5orCoI0pVW8y+8uBE835 LPhA== X-Forwarded-Encrypted: i=1; AJvYcCWgkHz3G33qv7F9mlBUVtgbqNd5AEV1jToi3K1p/RYDYwJ2rh8RAznHvxWiZrJwcTdkBpK6exyMhQ6xMDY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp17saDvXB5MsKL9fwdTqEl+pmXk1lToCXrrphI9Jbgs4y/Bod e/uS+3ansNn0IO7iq0CCVGi9A9yrHEdDVgKZfp48F9cvYRspgWPd X-Google-Smtp-Source: AGHT+IFWUguRAwnKc+f8S01CTcv6elxrDMwcpqnVEdijvi4uwKSnK67yaYiDOJ71rmTO3oXT30QFGg== X-Received: by 2002:a05:600c:a41:b0:42c:bd5a:9479 with SMTP id 5b1f17b1804b1-42f777c8503mr20510475e9.18.1727868033283; Wed, 02 Oct 2024 04:20:33 -0700 (PDT) Received: from eichest-laptop.corp.toradex.com (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f771a1209sm23530685e9.0.2024.10.02.04.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:20:32 -0700 (PDT) From: Stefan Eichenberger To: o.rempel@pengutronix.de, kernel@pengutronix.de, andi.shyti@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com, Stefan Eichenberger Subject: [PATCH v4 4/4] i2c: imx: prevent rescheduling in non dma mode Date: Wed, 2 Oct 2024 13:19:42 +0200 Message-ID: <20241002112020.23913-5-eichest@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241002112020.23913-1-eichest@gmail.com> References: <20241002112020.23913-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger We are experiencing a problem with the i.MX I2C controller when communicating with SMBus devices. We are seeing devices time-out because the time between sending/receiving two bytes is too long, and the SMBus device returns to the idle state. This happens because the i.MX I2C controller sends and receives byte by byte. When a byte is sent or received, we get an interrupt and can send or receive the next byte. The current implementation sends a byte and then waits for an event generated by the interrupt subroutine. After the event is received, the next byte is sent and we wait again. This waiting allows the scheduler to reschedule other tasks, with the disadvantage that we may not send the next byte for a long time because the send task is not immediately scheduled. For example, if the rescheduling takes more than 25ms, this can cause SMBus devices to timeout and communication to fail. This patch changes the behavior so that we do not reschedule the send/receive task, but instead send or receive the next byte in the interrupt subroutine. This prevents rescheduling and drastically reduces the time between sending/receiving bytes. The cost in the interrupt subroutine is relatively small, we check what state we are in and then send/receive the next byte. Before we had to call wake_up, which is even less expensive. However, we also had to do some scheduling, which increased the overall cost compared to the new solution. The wake_up function to wake up the send/receive task is now only called when an error occurs or when the transfer is complete. Signed-off-by: Stefan Eichenberger Acked-by: Oleksij Rempel --- drivers/i2c/busses/i2c-imx.c | 272 ++++++++++++++++++++++++++++++++--- 1 file changed, 249 insertions(+), 23 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index f70522a83f823..d26a728aab2de 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -197,6 +197,17 @@ struct imx_i2c_dma { enum dma_data_direction dma_data_dir; }; =20 +enum imx_i2c_state { + IMX_I2C_STATE_DONE, + IMX_I2C_STATE_FAILED, + IMX_I2C_STATE_WRITE, + IMX_I2C_STATE_DMA, + IMX_I2C_STATE_READ, + IMX_I2C_STATE_READ_CONTINUE, + IMX_I2C_STATE_READ_BLOCK_DATA, + IMX_I2C_STATE_READ_BLOCK_DATA_LEN, +}; + struct imx_i2c_struct { struct i2c_adapter adapter; struct clk *clk; @@ -216,6 +227,12 @@ struct imx_i2c_struct { struct i2c_client *slave; enum i2c_slave_event last_slave_event; =20 + struct i2c_msg *msg; + unsigned int msg_buf_idx; + int isr_result; + bool is_lastmsg; + enum imx_i2c_state state; + bool multi_master; =20 /* For checking slave events. */ @@ -908,11 +925,156 @@ static int i2c_imx_unreg_slave(struct i2c_client *cl= ient) return ret; } =20 +static inline int i2c_imx_isr_acked(struct imx_i2c_struct *i2c_imx) +{ + i2c_imx->isr_result =3D 0; + + if (imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR) & I2SR_RXAK) { + i2c_imx->state =3D IMX_I2C_STATE_FAILED; + i2c_imx->isr_result =3D -ENXIO; + wake_up(&i2c_imx->queue); + } + + return i2c_imx->isr_result; +} + +static inline int i2c_imx_isr_write(struct imx_i2c_struct *i2c_imx) +{ + int result; + + result =3D i2c_imx_isr_acked(i2c_imx); + if (result) + return result; + + if (i2c_imx->msg->len =3D=3D i2c_imx->msg_buf_idx) + return 0; + + imx_i2c_write_reg(i2c_imx->msg->buf[i2c_imx->msg_buf_idx++], i2c_imx, IMX= _I2C_I2DR); + + return 1; +} + +static inline int i2c_imx_isr_read(struct imx_i2c_struct *i2c_imx) +{ + int result; + unsigned int temp; + + result =3D i2c_imx_isr_acked(i2c_imx); + if (result) + return result; + + /* setup bus to read data */ + temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + temp &=3D ~I2CR_MTX; + if (i2c_imx->msg->len - 1) + temp &=3D ~I2CR_TXAK; + + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR); /* dummy read */ + + return 0; +} + +static inline void i2c_imx_isr_read_continue(struct imx_i2c_struct *i2c_im= x) +{ + unsigned int temp; + + if ((i2c_imx->msg->len - 1) =3D=3D i2c_imx->msg_buf_idx) { + if (i2c_imx->is_lastmsg) { + /* + * It must generate STOP before read I2DR to prevent + * controller from generating another clock cycle + */ + temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + if (!(temp & I2CR_MSTA)) + i2c_imx->stopped =3D 1; + temp &=3D ~(I2CR_MSTA | I2CR_MTX); + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + } else { + /* + * For i2c master receiver repeat restart operation like: + * read -> repeat MSTA -> read/write + * The controller must set MTX before read the last byte in + * the first read operation, otherwise the first read cost + * one extra clock cycle. + */ + temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + temp |=3D I2CR_MTX; + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + } + } else if (i2c_imx->msg_buf_idx =3D=3D (i2c_imx->msg->len - 2)) { + temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + temp |=3D I2CR_TXAK; + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + } + + i2c_imx->msg->buf[i2c_imx->msg_buf_idx++] =3D imx_i2c_read_reg(i2c_imx, I= MX_I2C_I2DR); +} + +static inline void i2c_imx_isr_read_block_data_len(struct imx_i2c_struct *= i2c_imx) +{ + u8 len =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR); + + if (len =3D=3D 0 || len > I2C_SMBUS_BLOCK_MAX) { + i2c_imx->isr_result =3D -EPROTO; + i2c_imx->state =3D IMX_I2C_STATE_FAILED; + wake_up(&i2c_imx->queue); + } + i2c_imx->msg->len +=3D len; +} + static irqreturn_t i2c_imx_master_isr(struct imx_i2c_struct *i2c_imx, unsi= gned int status) { - /* save status register */ - i2c_imx->i2csr =3D status; - wake_up(&i2c_imx->queue); + /* + * This state machine handles I2C reception and transmission in non-DMA + * mode. We must process all the data in the ISR to reduce the delay + * between two consecutive messages. If the data is not processed in + * the ISR, SMBus devices may timeout, leading to a bus error. + */ + switch (i2c_imx->state) { + case IMX_I2C_STATE_DMA: + i2c_imx->i2csr =3D status; + wake_up(&i2c_imx->queue); + break; + + case IMX_I2C_STATE_READ: + if (i2c_imx_isr_read(i2c_imx)) + break; + i2c_imx->state =3D IMX_I2C_STATE_READ_CONTINUE; + break; + + case IMX_I2C_STATE_READ_CONTINUE: + i2c_imx_isr_read_continue(i2c_imx); + if (i2c_imx->msg_buf_idx =3D=3D i2c_imx->msg->len) { + i2c_imx->state =3D IMX_I2C_STATE_DONE; + wake_up(&i2c_imx->queue); + } + break; + + case IMX_I2C_STATE_READ_BLOCK_DATA: + if (i2c_imx_isr_read(i2c_imx)) + break; + i2c_imx->state =3D IMX_I2C_STATE_READ_BLOCK_DATA_LEN; + break; + + case IMX_I2C_STATE_READ_BLOCK_DATA_LEN: + i2c_imx_isr_read_block_data_len(i2c_imx); + i2c_imx->state =3D IMX_I2C_STATE_READ_CONTINUE; + break; + + case IMX_I2C_STATE_WRITE: + if (i2c_imx_isr_write(i2c_imx)) + break; + i2c_imx->state =3D IMX_I2C_STATE_DONE; + wake_up(&i2c_imx->queue); + break; + + default: + i2c_imx->i2csr =3D status; + i2c_imx->state =3D IMX_I2C_STATE_FAILED; + i2c_imx->isr_result =3D -EINVAL; + wake_up(&i2c_imx->queue); + } =20 return IRQ_HANDLED; } @@ -959,6 +1121,8 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2= c_imx, struct imx_i2c_dma *dma =3D i2c_imx->dma; struct device *dev =3D &i2c_imx->adapter.dev; =20 + i2c_imx->state =3D IMX_I2C_STATE_DMA; + dma->chan_using =3D dma->chan_tx; dma->dma_transfer_dir =3D DMA_MEM_TO_DEV; dma->dma_data_dir =3D DMA_TO_DEVICE; @@ -1012,15 +1176,14 @@ static int i2c_imx_dma_write(struct imx_i2c_struct = *i2c_imx, } =20 static int i2c_imx_prepare_read(struct imx_i2c_struct *i2c_imx, - struct i2c_msg *msgs, bool atomic, - bool use_dma) + struct i2c_msg *msgs, bool use_dma) { int result; unsigned int temp =3D 0; =20 /* write slave address */ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); - result =3D i2c_imx_trx_complete(i2c_imx, atomic); + result =3D i2c_imx_trx_complete(i2c_imx, !use_dma); if (result) return result; result =3D i2c_imx_acked(i2c_imx); @@ -1058,7 +1221,9 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2= c_imx, struct imx_i2c_dma *dma =3D i2c_imx->dma; struct device *dev =3D &i2c_imx->adapter.dev; =20 - result =3D i2c_imx_prepare_read(i2c_imx, msgs, false, true); + i2c_imx->state =3D IMX_I2C_STATE_DMA; + + result =3D i2c_imx_prepare_read(i2c_imx, msgs, true); if (result) return result; =20 @@ -1139,8 +1304,8 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2= c_imx, return 0; } =20 -static int i2c_imx_write(struct imx_i2c_struct *i2c_imx, struct i2c_msg *m= sgs, - bool atomic) +static int i2c_imx_atomic_write(struct imx_i2c_struct *i2c_imx, + struct i2c_msg *msgs) { int i, result; =20 @@ -1149,7 +1314,7 @@ static int i2c_imx_write(struct imx_i2c_struct *i2c_i= mx, struct i2c_msg *msgs, =20 /* write slave address */ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); - result =3D i2c_imx_trx_complete(i2c_imx, atomic); + result =3D i2c_imx_trx_complete(i2c_imx, true); if (result) return result; result =3D i2c_imx_acked(i2c_imx); @@ -1163,7 +1328,7 @@ static int i2c_imx_write(struct imx_i2c_struct *i2c_i= mx, struct i2c_msg *msgs, "<%s> write byte: B%d=3D0x%X\n", __func__, i, msgs->buf[i]); imx_i2c_write_reg(msgs->buf[i], i2c_imx, IMX_I2C_I2DR); - result =3D i2c_imx_trx_complete(i2c_imx, atomic); + result =3D i2c_imx_trx_complete(i2c_imx, true); if (result) return result; result =3D i2c_imx_acked(i2c_imx); @@ -1173,19 +1338,44 @@ static int i2c_imx_write(struct imx_i2c_struct *i2c= _imx, struct i2c_msg *msgs, return 0; } =20 -static int i2c_imx_atomic_write(struct imx_i2c_struct *i2c_imx, struct i2c= _msg *msgs) +static int i2c_imx_write(struct imx_i2c_struct *i2c_imx, struct i2c_msg *m= sgs) { - return i2c_imx_write(i2c_imx, msgs, true); + dev_dbg(&i2c_imx->adapter.dev, "<%s> write slave address: addr=3D0x%x\n", + __func__, i2c_8bit_addr_from_msg(msgs)); + + i2c_imx->state =3D IMX_I2C_STATE_WRITE; + i2c_imx->msg =3D msgs; + i2c_imx->msg_buf_idx =3D 0; + + /* + * By writing the device address we start the state machine in the ISR. + * The ISR will report when it is done or when it fails. + */ + imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); + wait_event_timeout(i2c_imx->queue, + i2c_imx->state =3D=3D IMX_I2C_STATE_DONE || + i2c_imx->state =3D=3D IMX_I2C_STATE_FAILED, + (msgs->len + 1) * HZ / 10); + if (i2c_imx->state =3D=3D IMX_I2C_STATE_FAILED) { + dev_err(&i2c_imx->adapter.dev, "<%s> write failed with %d\n", + __func__, i2c_imx->isr_result); + return i2c_imx->isr_result; + } + if (i2c_imx->state !=3D IMX_I2C_STATE_DONE) { + dev_err(&i2c_imx->adapter.dev, "<%s> write timedout\n", __func__); + return -ETIMEDOUT; + } + return 0; } =20 -static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *ms= gs, - bool is_lastmsg, bool atomic) +static int i2c_imx_atomic_read(struct imx_i2c_struct *i2c_imx, + struct i2c_msg *msgs, bool is_lastmsg) { int i, result; unsigned int temp; int block_data =3D msgs->flags & I2C_M_RECV_LEN; =20 - result =3D i2c_imx_prepare_read(i2c_imx, msgs, atomic, false); + result =3D i2c_imx_prepare_read(i2c_imx, msgs, false); if (result) return result; =20 @@ -1195,7 +1385,7 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_im= x, struct i2c_msg *msgs, for (i =3D 0; i < msgs->len; i++) { u8 len =3D 0; =20 - result =3D i2c_imx_trx_complete(i2c_imx, atomic); + result =3D i2c_imx_trx_complete(i2c_imx, true); if (result) return result; /* @@ -1226,7 +1416,7 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_im= x, struct i2c_msg *msgs, temp &=3D ~(I2CR_MSTA | I2CR_MTX); imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); if (!i2c_imx->stopped) - i2c_imx_bus_busy(i2c_imx, 0, atomic); + i2c_imx_bus_busy(i2c_imx, 0, true); } else { /* * For i2c master receiver repeat restart operation like: @@ -1257,10 +1447,46 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_= imx, struct i2c_msg *msgs, return 0; } =20 -static int i2c_imx_atomic_read(struct imx_i2c_struct *i2c_imx, struct i2c_= msg *msgs, - bool is_lastmsg) +static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *ms= gs, + bool is_lastmsg) { - return i2c_imx_read(i2c_imx, msgs, is_lastmsg, true); + int block_data =3D msgs->flags & I2C_M_RECV_LEN; + + dev_dbg(&i2c_imx->adapter.dev, + "<%s> write slave address: addr=3D0x%x\n", + __func__, i2c_8bit_addr_from_msg(msgs)); + + i2c_imx->is_lastmsg =3D is_lastmsg; + + if (block_data) + i2c_imx->state =3D IMX_I2C_STATE_READ_BLOCK_DATA; + else + i2c_imx->state =3D IMX_I2C_STATE_READ; + i2c_imx->msg =3D msgs; + i2c_imx->msg_buf_idx =3D 0; + + /* + * By writing the device address we start the state machine in the ISR. + * The ISR will report when it is done or when it fails. + */ + imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); + wait_event_timeout(i2c_imx->queue, + i2c_imx->state =3D=3D IMX_I2C_STATE_DONE || + i2c_imx->state =3D=3D IMX_I2C_STATE_FAILED, + (msgs->len + 1) * HZ / 10); + if (i2c_imx->state =3D=3D IMX_I2C_STATE_FAILED) { + dev_err(&i2c_imx->adapter.dev, "<%s> write failed with %d\n", + __func__, i2c_imx->isr_result); + return i2c_imx->isr_result; + } + if (i2c_imx->state !=3D IMX_I2C_STATE_DONE) { + dev_err(&i2c_imx->adapter.dev, "<%s> write timedout\n", __func__); + return -ETIMEDOUT; + } + if (!i2c_imx->stopped) + return i2c_imx_bus_busy(i2c_imx, 0, false); + + return 0; } =20 static int i2c_imx_xfer_common(struct i2c_adapter *adapter, @@ -1334,14 +1560,14 @@ static int i2c_imx_xfer_common(struct i2c_adapter *= adapter, else if (use_dma && !block_data) result =3D i2c_imx_dma_read(i2c_imx, &msgs[i], is_lastmsg); else - result =3D i2c_imx_read(i2c_imx, &msgs[i], is_lastmsg, false); + result =3D i2c_imx_read(i2c_imx, &msgs[i], is_lastmsg); } else { if (atomic) result =3D i2c_imx_atomic_write(i2c_imx, &msgs[i]); else if (use_dma) result =3D i2c_imx_dma_write(i2c_imx, &msgs[i]); else - result =3D i2c_imx_write(i2c_imx, &msgs[i], false); + result =3D i2c_imx_write(i2c_imx, &msgs[i]); } if (result) goto fail0; --=20 2.43.0