[PATCH] hwmon: (mc34vr500) Add missing dependency on REGMAP_I2C

Javier Carrasco posted 1 patch 1 week ago
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] hwmon: (mc34vr500) Add missing dependency on REGMAP_I2C
Posted by Javier Carrasco 1 week ago
This driver requires REGMAP_I2C to be selected in order to get access to
regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes: 07830d9ab34c ("hwmon: add initial NXP MC34VR500 PMIC monitoring support")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
This issue can be easily reproduced with a simple config that includes
I2C, HWMON and the affected driver, but not REGMAP_I2C.
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index ecf09cd2510c..0e7029d0176e 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1275,6 +1275,7 @@ config SENSORS_MAX31790
 config SENSORS_MC34VR500
 	tristate "NXP MC34VR500 hardware monitoring driver"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for the temperature and input
 	  voltage sensors of the NXP MC34VR500.

---
base-commit: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c
change-id: 20241002-mc34vr500-select-regmap_i2c-da2b335f27d3

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Re: [PATCH] hwmon: (mc34vr500) Add missing dependency on REGMAP_I2C
Posted by Guenter Roeck 6 days, 19 hours ago
On Wed, Oct 02, 2024 at 02:31:25AM +0200, Javier Carrasco wrote:
> This driver requires REGMAP_I2C to be selected in order to get access to
> regmap_config and devm_regmap_init_i2c. Add the missing dependency.
> 
> Fixes: 07830d9ab34c ("hwmon: add initial NXP MC34VR500 PMIC monitoring support")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---

Applied.

Thanks,
Guenter