From nobody Thu Nov 28 11:25:13 2024 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F109E1CDFB6; Tue, 1 Oct 2024 20:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727814456; cv=none; b=G6yoxkmqZqq4ljFHvAFlNKXgRGxyRjx4oaSEJQJ0tDsBP6RYlgJMVkGxu/xSiNIGPqtdhULgrWNBTqB/rmHdtHpBvfga+SJopuT66MqbJB8MfYfSfufUbV9Snffoa8g8+2ZTqNka2AaTN2/f1MOKr+Zm02GeYDkR337icgI6HgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727814456; c=relaxed/simple; bh=H4bdBSamTFamzjdwBqR2NWHqwHPg+FdIpqJlRjDUcYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=spc2z5y+xKiBAbgpG+tlelO5eczbSNR3QwcxcHIJbFXVJgGy99UwiHyQwiBMtRQlOTExBkYie8RLvj7hj98GU+NZLnZghfVAhXKgvNaJn7zcWh+aNtNcDz8CvzlMGSlWiXsw166los/AZGRC3shIb2m7M+bP0XRV0qNUZ7QcvW0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTqn+6j0; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTqn+6j0" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-37cdbdbbb1cso2175742f8f.3; Tue, 01 Oct 2024 13:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727814453; x=1728419253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qD7v3ZFGzDO3rZ5/zAQpp+VpbAmOnF0NWp2xESDN9aY=; b=BTqn+6j0aB1I8R0K4nePwiT61siagfDQfwI63uW2/yp8s+IORR5sxmTHCXg83mref0 rYoTQjOvbpQo/UIKhNgaWaXpPY/aEiZZFL+iVOidSJpzcAFvypR5yVOfhK//zKWy6vNa mu/SWOflmTITbeg0vCSo2jtXV0pgiopm+yrHK0TSEnHspo8oeUP7fBFTx4AO4z7JyjnZ qYF0R9WldF7LWBeaLZSqCpbS65LDUg9VPHkt34DFxDx9jnZf+v+BwySu36kU+OkzR0p5 zpJfCRfHEhWJ7NVWdZut/2Eh94Z7pWot0MAaM8AwzR9l60bABBvSGFClO/ffUBRRADdj Yweg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727814453; x=1728419253; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qD7v3ZFGzDO3rZ5/zAQpp+VpbAmOnF0NWp2xESDN9aY=; b=qcWa8pSRmuJ7fWnna3o28+uOV9oT9Z8c6UMzoP4DuLTglCuHdTHNQg4FT/LaaOWHMR cu3IHJRyYW+2Ch5isOEUmWumN3S1CXlHFb1dK/nynnP40SHIkOgdIcyyYbiFkA02RfFg Qe9J+9AItQkR6w0T0rSYjEBX80GqyeR6l+F6zXV04Oq3XDvmJ0l0uClI0cw6x8notvva F2NkiBXWAveQzz/h9GOQKFzWIzb7hxFsrXDEj3MsTSE/z7oo244sG8Ej1sT8jKu9jBTp VAE1/GsarFMp0Q65PeqDi2Z5B4HWv8bDdG78kOiXD7f06q7yD7BDo6oUgrP8BZg4H668 5eLg== X-Forwarded-Encrypted: i=1; AJvYcCUnzMR1J+/LVuiaXvggqmPExicx/irRnPvys6s/N6suc2gEBNNOk3aXgIFngWuyx43V8+TCL75U7Y2sfQX6@vger.kernel.org, AJvYcCWXyrgCKKyQ/NieuiZsE3ta94gAL0aAXAlpKYF+G0GGqhpVlcwXqKzZfJChfgjBRQbhgWKAvK8CJ6U=@vger.kernel.org X-Gm-Message-State: AOJu0YyeZ+PKjV8hYm2udZET/PoaAKfJgRUHAsZ7tKG7HDIQp0YgM15y xJ5N16wD+AYr05vQ5HrGlU1P1TGfonPkvTGImk6sxakFfoDsUtZK X-Google-Smtp-Source: AGHT+IGQLSBVSwDZ+R4yiiPWFBZebp6M/p3K1PqcN0jlHaUJFfkfCcUvQg6TPyq7aHPkRft+8wnuRg== X-Received: by 2002:adf:e447:0:b0:374:d1dd:1cc1 with SMTP id ffacd0b85a97d-37cfb8a490bmr493759f8f.2.1727814453012; Tue, 01 Oct 2024 13:27:33 -0700 (PDT) Received: from localhost.localdomain ([146.70.124.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd5730ecasm12604353f8f.81.2024.10.01.13.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 13:27:32 -0700 (PDT) From: Tudor Gheorghiu To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Tudor Gheorghiu , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: iio: frequency: rename macros Date: Tue, 1 Oct 2024 23:24:30 +0300 Message-ID: <20241001202430.15874-2-tudor.reda@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The frequency iio drivers use custom defined macros (inside dds.h) in order to define sysfs attributes more easily. However, due to their naming choice and the fact that in some of them the first and/or second arguments are decimal, checkpatch will throw errors in the source files they are used in (ad9832.c and ad9834.c). This is because it thinks the argument is _mode, therefore it expects octal notation, even if the argument itself does not represent file permissions. Example: ERROR: Use 4 digit octal (0777) not decimal permissions +static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL); By re-naming the custom macros, we will avoid these false positive checkpatch errors. Signed-off-by: Tudor Gheorghiu Suggested-by: Nam Cao --- drivers/staging/iio/frequency/ad9832.c | 26 +++++++++++----------- drivers/staging/iio/frequency/ad9834.c | 30 +++++++++++++------------- drivers/staging/iio/frequency/dds.h | 20 ++++++++--------- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index 6c390c4eb26d..621543e50dc5 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -252,22 +252,22 @@ static ssize_t ad9832_write(struct device *dev, struc= t device_attribute *attr, * see dds.h for further information */ =20 -static IIO_DEV_ATTR_FREQ(0, 0, 0200, NULL, ad9832_write, AD9832_FREQ0HM); -static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM); -static IIO_DEV_ATTR_FREQSYMBOL(0, 0200, NULL, ad9832_write, AD9832_FREQ_SY= M); -static IIO_CONST_ATTR_FREQ_SCALE(0, "1"); /* 1Hz */ - -static IIO_DEV_ATTR_PHASE(0, 0, 0200, NULL, ad9832_write, AD9832_PHASE0H); -static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9832_write, AD9832_PHASE1H); -static IIO_DEV_ATTR_PHASE(0, 2, 0200, NULL, ad9832_write, AD9832_PHASE2H); -static IIO_DEV_ATTR_PHASE(0, 3, 0200, NULL, ad9832_write, AD9832_PHASE3H); -static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, +static IIO_DEV_FREQ_ATTR(0, 0, 0200, NULL, ad9832_write, AD9832_FREQ0HM); +static IIO_DEV_FREQ_ATTR(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM); +static IIO_DEV_FREQSYMBOL_ATTR(0, 0200, NULL, ad9832_write, AD9832_FREQ_SY= M); +static IIO_CONST_FREQ_SCALE_ATTR(0, "1"); /* 1Hz */ + +static IIO_DEV_PHASE_ATTR(0, 0, 0200, NULL, ad9832_write, AD9832_PHASE0H); +static IIO_DEV_PHASE_ATTR(0, 1, 0200, NULL, ad9832_write, AD9832_PHASE1H); +static IIO_DEV_PHASE_ATTR(0, 2, 0200, NULL, ad9832_write, AD9832_PHASE2H); +static IIO_DEV_PHASE_ATTR(0, 3, 0200, NULL, ad9832_write, AD9832_PHASE3H); +static IIO_DEV_PHASESYMBOL_ATTR(0, 0200, NULL, ad9832_write, AD9832_PHASE_SYM); -static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/ +static IIO_CONST_PHASE_SCALE_ATTR(0, "0.0015339808"); /* 2PI/2^12 rad*/ =20 -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, +static IIO_DEV_PINCONTROL_EN_ATTR(0, 0200, NULL, ad9832_write, AD9832_PINCTRL_EN); -static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, +static IIO_DEV_OUT_ENABLE_ATTR(0, 0200, NULL, ad9832_write, AD9832_OUTPUT_EN); =20 static struct attribute *ad9832_attributes[] =3D { diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index 47e7d7e6d920..e1f7469d8011 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -321,21 +321,21 @@ static IIO_DEVICE_ATTR(out_altvoltage0_out1_wavetype_= available, 0444, * see dds.h for further information */ =20 -static IIO_DEV_ATTR_FREQ(0, 0, 0200, NULL, ad9834_write, AD9834_REG_FREQ0); -static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9834_write, AD9834_REG_FREQ1); -static IIO_DEV_ATTR_FREQSYMBOL(0, 0200, NULL, ad9834_write, AD9834_FSEL); -static IIO_CONST_ATTR_FREQ_SCALE(0, "1"); /* 1Hz */ - -static IIO_DEV_ATTR_PHASE(0, 0, 0200, NULL, ad9834_write, AD9834_REG_PHASE= 0); -static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE= 1); -static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL); -static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/ - -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_= SW); -static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET); -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPB= ITEN); -static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0); -static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1); +static IIO_DEV_FREQ_ATTR(0, 0, 0200, NULL, ad9834_write, AD9834_REG_FREQ0); +static IIO_DEV_FREQ_ATTR(0, 1, 0200, NULL, ad9834_write, AD9834_REG_FREQ1); +static IIO_DEV_FREQSYMBOL_ATTR(0, 0200, NULL, ad9834_write, AD9834_FSEL); +static IIO_CONST_FREQ_SCALE_ATTR(0, "1"); /* 1Hz */ + +static IIO_DEV_PHASE_ATTR(0, 0, 0200, NULL, ad9834_write, AD9834_REG_PHASE= 0); +static IIO_DEV_PHASE_ATTR(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE= 1); +static IIO_DEV_PHASESYMBOL_ATTR(0, 0200, NULL, ad9834_write, AD9834_PSEL); +static IIO_CONST_PHASE_SCALE_ATTR(0, "0.0015339808"); /* 2PI/2^12 rad*/ + +static IIO_DEV_PINCONTROL_EN_ATTR(0, 0200, NULL, ad9834_write, AD9834_PIN_= SW); +static IIO_DEV_OUT_ENABLE_ATTR(0, 0200, NULL, ad9834_write, AD9834_RESET); +static IIO_DEV_OUTY_ENABLE_ATTR(0, 1, 0200, NULL, ad9834_write, AD9834_OPB= ITEN); +static IIO_DEV_OUT_WAVETYPE_ATTR(0, 0, ad9834_store_wavetype, 0); +static IIO_DEV_OUT_WAVETYPE_ATTR(0, 1, ad9834_store_wavetype, 1); =20 static struct attribute *ad9834_attributes[] =3D { &iio_dev_attr_out_altvoltage0_frequency0.dev_attr.attr, diff --git a/drivers/staging/iio/frequency/dds.h b/drivers/staging/iio/freq= uency/dds.h index 2ebe68eb7398..7f28eb437305 100644 --- a/drivers/staging/iio/frequency/dds.h +++ b/drivers/staging/iio/frequency/dds.h @@ -11,7 +11,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_frequencyY */ =20 -#define IIO_DEV_ATTR_FREQ(_channel, _num, _mode, _show, _store, _addr) \ +#define IIO_DEV_FREQ_ATTR(_channel, _num, _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_frequency##_num, \ _mode, _show, _store, _addr) =20 @@ -19,14 +19,14 @@ * /sys/bus/iio/devices/.../out_altvoltageX_frequencyY_scale */ =20 -#define IIO_CONST_ATTR_FREQ_SCALE(_channel, _string) \ +#define IIO_CONST_FREQ_SCALE_ATTR(_channel, _string) \ IIO_CONST_ATTR(out_altvoltage##_channel##_frequency_scale, _string) =20 /** * /sys/bus/iio/devices/.../out_altvoltageX_frequencysymbol */ =20 -#define IIO_DEV_ATTR_FREQSYMBOL(_channel, _mode, _show, _store, _addr) \ +#define IIO_DEV_FREQSYMBOL_ATTR(_channel, _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_frequencysymbol, \ _mode, _show, _store, _addr) =20 @@ -34,7 +34,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_phaseY */ =20 -#define IIO_DEV_ATTR_PHASE(_channel, _num, _mode, _show, _store, _addr) \ +#define IIO_DEV_PHASE_ATTR(_channel, _num, _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_phase##_num, \ _mode, _show, _store, _addr) =20 @@ -42,14 +42,14 @@ * /sys/bus/iio/devices/.../out_altvoltageX_phaseY_scale */ =20 -#define IIO_CONST_ATTR_PHASE_SCALE(_channel, _string) \ +#define IIO_CONST_PHASE_SCALE_ATTR(_channel, _string) \ IIO_CONST_ATTR(out_altvoltage##_channel##_phase_scale, _string) =20 /** * /sys/bus/iio/devices/.../out_altvoltageX_phasesymbol */ =20 -#define IIO_DEV_ATTR_PHASESYMBOL(_channel, _mode, _show, _store, _addr) \ +#define IIO_DEV_PHASESYMBOL_ATTR(_channel, _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_phasesymbol, \ _mode, _show, _store, _addr) =20 @@ -57,7 +57,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_pincontrol_en */ =20 -#define IIO_DEV_ATTR_PINCONTROL_EN(_channel, _mode, _show, _store, _addr)\ +#define IIO_DEV_PINCONTROL_EN_ATTR(_channel, _mode, _show, _store, _addr)\ IIO_DEVICE_ATTR(out_altvoltage##_channel##_pincontrol_en, \ _mode, _show, _store, _addr) =20 @@ -81,7 +81,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_out_enable */ =20 -#define IIO_DEV_ATTR_OUT_ENABLE(_channel, _mode, _show, _store, _addr) \ +#define IIO_DEV_OUT_ENABLE_ATTR(_channel, _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_out_enable, \ _mode, _show, _store, _addr) =20 @@ -89,7 +89,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_outY_enable */ =20 -#define IIO_DEV_ATTR_OUTY_ENABLE(_channel, _output, \ +#define IIO_DEV_OUTY_ENABLE_ATTR(_channel, _output, \ _mode, _show, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_out##_output##_enable,\ _mode, _show, _store, _addr) @@ -98,7 +98,7 @@ * /sys/bus/iio/devices/.../out_altvoltageX_outY_wavetype */ =20 -#define IIO_DEV_ATTR_OUT_WAVETYPE(_channel, _output, _store, _addr) \ +#define IIO_DEV_OUT_WAVETYPE_ATTR(_channel, _output, _store, _addr) \ IIO_DEVICE_ATTR(out_altvoltage##_channel##_out##_output##_wavetype,\ 0200, NULL, _store, _addr) =20 --=20 2.43.0