From nobody Thu Nov 28 18:54:28 2024 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874F41990A1; Mon, 30 Sep 2024 15:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727710347; cv=none; b=HR4bxm6yD3cx1X/fEF14rX3DEgBvT8B/DZSiMZMytEbB4pVQYw7HqP9gm8RIpIlrCsnTD/j+xJIHMv54G3mYTzOvsyu3G4f0pssbiGkbforFdnd6Mk4dxdfF38gKeAlUkNvWrD90fD3XkDUC59TZ3KtBiV6TFUVg0D9m4BJFsek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727710347; c=relaxed/simple; bh=2wQl/VLOHLkG9pjPWFcWisup0t5KvV8JA6u2m3rRhWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GhJrAkSvdVOJ+MsKjKx9NtaMCkGUWkUKuURmH2PxOsPUSd3CdYGaKT1kdIbOYFOBFn2brKvlx49ukIojlMmT2MlPK8FDaiQBmijzqmQ9mBcNFK8zogIVuhxIraQwdmUNOWmyL2nU9yTKkSAGLcsJEGKhPt8y643fwtXIeBiHBpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=YtM7iDla; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="YtM7iDla" Received: by mail.gandi.net (Postfix) with ESMTPSA id A188340005; Mon, 30 Sep 2024 15:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727710343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMYvnzBIhRioyKhVje/Xu2+NURr078CBubcECinfAuM=; b=YtM7iDlail7kwyzfuuOYHOMYRqxvOWDU3Rzr2FKhWl/mfqU43HRKhBWyuey7OtGvIWOE3C qUMAsqtOaZUFMHOxqMErBSxxAjqFaujiphfyPBa2FIWxdeFy6Fg/MKWiRImBvPQ+7PV/fB PKi162289CfJn/2Be4ZOriHiHyrQmdL0z+lqhPgjYNEI69uY/AFmBFSvh/e/cRFhg5fecj q4KqAQhFhlZ9Wom0ABiv2tUMFnT10HBn/8bcWPBqEdZLs0TcbIyCyklY81bFGvctBJEJr2 6Mmxf2VQ+f1G/JOlMPdBlO1/Cgy9oHzYz26httbg7c4n7z+04tzOIXpOWT+qOw== From: Louis Chauvet Date: Mon, 30 Sep 2024 17:31:43 +0200 Subject: [PATCH v11 03/15] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240930-yuv-v11-3-4b1a26bcfc96@bootlin.com> References: <20240930-yuv-v11-0-4b1a26bcfc96@bootlin.com> In-Reply-To: <20240930-yuv-v11-0-4b1a26bcfc96@bootlin.com> To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jonathan Corbet , Louis Chauvet , Simona Vetter , rdunlap@infradead.org, arthurgrillo@riseup.net, pekka.paalanen@haloniitty.fi, Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, thomas.petazzoni@bootlin.com, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, Pekka Paalanen X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=13184; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=2wQl/VLOHLkG9pjPWFcWisup0t5KvV8JA6u2m3rRhWQ=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBm+sRurxY5qU29i2tsZSFwbcX5rHOlkN1j4BdOV b2aIGt45BSJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZvrEbgAKCRAgrS7GWxAs 4q+fEAC9KL+mCD75ejrFcoZy0ppMviXW7DyZTCJu+Vxx7iY4Brt9nQnHU1oBKHUxqt9IrAiqnDh daSZ0i8ntQJNYUHepyQpR1YSEjhstY6sqmbPJRESZZ5OsWLgGD9kPJNyIyTLMqQeWBaFyv2jZsp 5nJ5B3A3mUZNZvEQ20Fqh63UVxoBBKon76ODb8XhnCnzCvbW2y5rFT/bqzYcHOE3R5yqhPzNYqh oHtCUNJS3qz6FJwyG6kWNZ057Jhmastp5cucxQ/xSpwgbz4qBKHYC8BE7ANL1Yzi1rD2+zcQUEs 1gzF+f1Y5Pm/EtJsqNHFlXUFxpI6nBiDHZXeQkRtfHd0S7/wrs8mibI1bFfVlH1IQGDpoyNFc6l MqZJvwc3AkD+QFSIdZE97QZ7u7EqLY/f9XjadLlmDsE0DlSGlM7lKw3o/zrmGnCw94qoI3s4a3L HE8z8gXTkl3HCuzujk+mmOxCXRMln+rLtKKP2L5ORZx2d46eQmTRQ33pIGA94ERkCb7g2aLLNGz QFEyDeMtTBOrI5yecLdWnInMqYeR0tjnzxDril05r8OC1DNPiY4LoVCFmX0shm07vclh2/U3mdR 0+2ZMXsNjhU72Pxh1nDGRYEVDqd5XM7XSCG9Uq1YjirtofaGsGki36/Tl1YYrTp/R+w5YMaBG6y M/TxTNAqHHQXuJA== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the compiler to check if the passed functions take the correct arguments. Such typedefs will help ensuring consistency across the code base in case of update of these prototypes. Rename input/output variable in a consistent way between read_line and write_line. A warn has been added in get_pixel_*_function to alert when an unsupported pixel format is requested. As those formats are checked before atomic_update callbacks, it should never happen. Document for those typedefs. Reviewed-by: Pekka Paalanen Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 23 ++++++- drivers/gpu/drm/vkms/vkms_formats.c | 124 ++++++++++++++++++++------------= ---- drivers/gpu/drm/vkms/vkms_formats.h | 4 +- drivers/gpu/drm/vkms/vkms_plane.c | 2 +- 4 files changed, 94 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index fcb5a5ff7df7..137348f4adb2 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -53,12 +53,31 @@ struct line_buffer { struct pixel_argb_u16 *pixels; }; =20 +/** + * typedef pixel_write_t - These functions are used to read a pixel from a + * &struct pixel_argb_u16, convert it in a specific format and write it in= the @dst_pixels + * buffer. + * + * @out_pixel: destination address to write the pixel + * @in_pixel: pixel to write + */ +typedef void (*pixel_write_t)(u8 *out_pixel, struct pixel_argb_u16 *in_pix= el); + struct vkms_writeback_job { struct iosys_map data[DRM_FORMAT_MAX_PLANES]; struct vkms_frame_info wb_frame_info; - void (*pixel_write)(u8 *dst_pixels, struct pixel_argb_u16 *in_pixel); + pixel_write_t pixel_write; }; =20 +/** + * typedef pixel_read_t - These functions are used to read a pixel in the = source frame, + * convert it to `struct pixel_argb_u16` and write it to @out_pixel. + * + * @in_pixel: pointer to the pixel to read + * @out_pixel: pointer to write the converted pixel + */ +typedef void (*pixel_read_t)(u8 *in_pixel, struct pixel_argb_u16 *out_pixe= l); + /** * struct vkms_plane_state - Driver specific plane state * @base: base plane state @@ -69,7 +88,7 @@ struct vkms_writeback_job { struct vkms_plane_state { struct drm_shadow_plane_state base; struct vkms_frame_info *frame_info; - void (*pixel_read)(u8 *src_buffer, struct pixel_argb_u16 *out_pixel); + pixel_read_t pixel_read; }; =20 struct vkms_plane { diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkm= s_formats.c index 2a0fbe27d8b2..b9544e67cd4f 100644 --- a/drivers/gpu/drm/vkms/vkms_formats.c +++ b/drivers/gpu/drm/vkms/vkms_formats.c @@ -75,7 +75,7 @@ static int get_x_position(const struct vkms_frame_info *f= rame_info, int limit, i * They are used in the vkms_compose_row() function to handle multiple for= mats. */ =20 -static void ARGB8888_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *ou= t_pixel) +static void ARGB8888_to_argb_u16(u8 *in_pixel, struct pixel_argb_u16 *out_= pixel) { /* * The 257 is the "conversion ratio". This number is obtained by the @@ -83,48 +83,48 @@ static void ARGB8888_to_argb_u16(u8 *src_pixels, struct= pixel_argb_u16 *out_pixe * the best color value in a pixel format with more possibilities. * A similar idea applies to others RGB color conversions. */ - out_pixel->a =3D (u16)src_pixels[3] * 257; - out_pixel->r =3D (u16)src_pixels[2] * 257; - out_pixel->g =3D (u16)src_pixels[1] * 257; - out_pixel->b =3D (u16)src_pixels[0] * 257; + out_pixel->a =3D (u16)in_pixel[3] * 257; + out_pixel->r =3D (u16)in_pixel[2] * 257; + out_pixel->g =3D (u16)in_pixel[1] * 257; + out_pixel->b =3D (u16)in_pixel[0] * 257; } =20 -static void XRGB8888_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *ou= t_pixel) +static void XRGB8888_to_argb_u16(u8 *in_pixel, struct pixel_argb_u16 *out_= pixel) { out_pixel->a =3D (u16)0xffff; - out_pixel->r =3D (u16)src_pixels[2] * 257; - out_pixel->g =3D (u16)src_pixels[1] * 257; - out_pixel->b =3D (u16)src_pixels[0] * 257; + out_pixel->r =3D (u16)in_pixel[2] * 257; + out_pixel->g =3D (u16)in_pixel[1] * 257; + out_pixel->b =3D (u16)in_pixel[0] * 257; } =20 -static void ARGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16= *out_pixel) +static void ARGB16161616_to_argb_u16(u8 *in_pixel, struct pixel_argb_u16 *= out_pixel) { - __le16 *pixels =3D (__force __le16 *)src_pixels; + __le16 *pixel =3D (__le16 *)in_pixel; =20 - out_pixel->a =3D le16_to_cpu(pixels[3]); - out_pixel->r =3D le16_to_cpu(pixels[2]); - out_pixel->g =3D le16_to_cpu(pixels[1]); - out_pixel->b =3D le16_to_cpu(pixels[0]); + out_pixel->a =3D le16_to_cpu(pixel[3]); + out_pixel->r =3D le16_to_cpu(pixel[2]); + out_pixel->g =3D le16_to_cpu(pixel[1]); + out_pixel->b =3D le16_to_cpu(pixel[0]); } =20 -static void XRGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16= *out_pixel) +static void XRGB16161616_to_argb_u16(u8 *in_pixel, struct pixel_argb_u16 *= out_pixel) { - __le16 *pixels =3D (__force __le16 *)src_pixels; + __le16 *pixel =3D (__le16 *)in_pixel; =20 out_pixel->a =3D (u16)0xffff; - out_pixel->r =3D le16_to_cpu(pixels[2]); - out_pixel->g =3D le16_to_cpu(pixels[1]); - out_pixel->b =3D le16_to_cpu(pixels[0]); + out_pixel->r =3D le16_to_cpu(pixel[2]); + out_pixel->g =3D le16_to_cpu(pixel[1]); + out_pixel->b =3D le16_to_cpu(pixel[0]); } =20 -static void RGB565_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_= pixel) +static void RGB565_to_argb_u16(u8 *in_pixel, struct pixel_argb_u16 *out_pi= xel) { - __le16 *pixels =3D (__force __le16 *)src_pixels; + __le16 *pixel =3D (__le16 *)in_pixel; =20 s64 fp_rb_ratio =3D drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(31)); s64 fp_g_ratio =3D drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(63)); =20 - u16 rgb_565 =3D le16_to_cpu(*pixels); + u16 rgb_565 =3D le16_to_cpu(*pixel); s64 fp_r =3D drm_int2fixp((rgb_565 >> 11) & 0x1f); s64 fp_g =3D drm_int2fixp((rgb_565 >> 5) & 0x3f); s64 fp_b =3D drm_int2fixp(rgb_565 & 0x1f); @@ -168,12 +168,12 @@ void vkms_compose_row(struct line_buffer *stage_buffe= r, struct vkms_plane_state =20 /* * The following functions take one &struct pixel_argb_u16 and convert it = to a specific format. - * The result is stored in @dst_pixels. + * The result is stored in @out_pixel. * * They are used in vkms_writeback_row() to convert and store a pixel from= the src_buffer to * the writeback buffer. */ -static void argb_u16_to_ARGB8888(u8 *dst_pixels, struct pixel_argb_u16 *in= _pixel) +static void argb_u16_to_ARGB8888(u8 *out_pixel, struct pixel_argb_u16 *in_= pixel) { /* * This sequence below is important because the format's byte order is @@ -185,43 +185,43 @@ static void argb_u16_to_ARGB8888(u8 *dst_pixels, stru= ct pixel_argb_u16 *in_pixel * | Addr + 2 | =3D Red channel * | Addr + 3 | =3D Alpha channel */ - dst_pixels[3] =3D DIV_ROUND_CLOSEST(in_pixel->a, 257); - dst_pixels[2] =3D DIV_ROUND_CLOSEST(in_pixel->r, 257); - dst_pixels[1] =3D DIV_ROUND_CLOSEST(in_pixel->g, 257); - dst_pixels[0] =3D DIV_ROUND_CLOSEST(in_pixel->b, 257); + out_pixel[3] =3D DIV_ROUND_CLOSEST(in_pixel->a, 257); + out_pixel[2] =3D DIV_ROUND_CLOSEST(in_pixel->r, 257); + out_pixel[1] =3D DIV_ROUND_CLOSEST(in_pixel->g, 257); + out_pixel[0] =3D DIV_ROUND_CLOSEST(in_pixel->b, 257); } =20 -static void argb_u16_to_XRGB8888(u8 *dst_pixels, struct pixel_argb_u16 *in= _pixel) +static void argb_u16_to_XRGB8888(u8 *out_pixel, struct pixel_argb_u16 *in_= pixel) { - dst_pixels[3] =3D 0xff; - dst_pixels[2] =3D DIV_ROUND_CLOSEST(in_pixel->r, 257); - dst_pixels[1] =3D DIV_ROUND_CLOSEST(in_pixel->g, 257); - dst_pixels[0] =3D DIV_ROUND_CLOSEST(in_pixel->b, 257); + out_pixel[3] =3D 0xff; + out_pixel[2] =3D DIV_ROUND_CLOSEST(in_pixel->r, 257); + out_pixel[1] =3D DIV_ROUND_CLOSEST(in_pixel->g, 257); + out_pixel[0] =3D DIV_ROUND_CLOSEST(in_pixel->b, 257); } =20 -static void argb_u16_to_ARGB16161616(u8 *dst_pixels, struct pixel_argb_u16= *in_pixel) +static void argb_u16_to_ARGB16161616(u8 *out_pixel, struct pixel_argb_u16 = *in_pixel) { - __le16 *pixels =3D (__force __le16 *)dst_pixels; + __le16 *pixel =3D (__le16 *)out_pixel; =20 - pixels[3] =3D cpu_to_le16(in_pixel->a); - pixels[2] =3D cpu_to_le16(in_pixel->r); - pixels[1] =3D cpu_to_le16(in_pixel->g); - pixels[0] =3D cpu_to_le16(in_pixel->b); + pixel[3] =3D cpu_to_le16(in_pixel->a); + pixel[2] =3D cpu_to_le16(in_pixel->r); + pixel[1] =3D cpu_to_le16(in_pixel->g); + pixel[0] =3D cpu_to_le16(in_pixel->b); } =20 -static void argb_u16_to_XRGB16161616(u8 *dst_pixels, struct pixel_argb_u16= *in_pixel) +static void argb_u16_to_XRGB16161616(u8 *out_pixel, struct pixel_argb_u16 = *in_pixel) { - __le16 *pixels =3D (__force __le16 *)dst_pixels; + __le16 *pixel =3D (__le16 *)out_pixel; =20 - pixels[3] =3D cpu_to_le16(0xffff); - pixels[2] =3D cpu_to_le16(in_pixel->r); - pixels[1] =3D cpu_to_le16(in_pixel->g); - pixels[0] =3D cpu_to_le16(in_pixel->b); + pixel[3] =3D cpu_to_le16(0xffff); + pixel[2] =3D cpu_to_le16(in_pixel->r); + pixel[1] =3D cpu_to_le16(in_pixel->g); + pixel[0] =3D cpu_to_le16(in_pixel->b); } =20 -static void argb_u16_to_RGB565(u8 *dst_pixels, struct pixel_argb_u16 *in_p= ixel) +static void argb_u16_to_RGB565(u8 *out_pixel, struct pixel_argb_u16 *in_pi= xel) { - __le16 *pixels =3D (__force __le16 *)dst_pixels; + __le16 *pixel =3D (__le16 *)out_pixel; =20 s64 fp_rb_ratio =3D drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(31)); s64 fp_g_ratio =3D drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(63)); @@ -234,7 +234,7 @@ static void argb_u16_to_RGB565(u8 *dst_pixels, struct p= ixel_argb_u16 *in_pixel) u16 g =3D drm_fixp2int(drm_fixp_div(fp_g, fp_g_ratio)); u16 b =3D drm_fixp2int(drm_fixp_div(fp_b, fp_rb_ratio)); =20 - *pixels =3D cpu_to_le16(r << 11 | g << 5 | b); + *pixel =3D cpu_to_le16(r << 11 | g << 5 | b); } =20 /** @@ -259,13 +259,13 @@ void vkms_writeback_row(struct vkms_writeback_job *wb, } =20 /** - * get_pixel_conversion_function() - Retrieve the correct read_pixel funct= ion for a specific + * get_pixel_read_function() - Retrieve the correct read_pixel function fo= r a specific * format. The returned pointer is NULL for unsupported pixel formats. The= caller must ensure that * the pointer is valid before using it in a vkms_plane_state. * * @format: DRM_FORMAT_* value for which to obtain a conversion function (= see [drm_fourcc.h]) */ -void *get_pixel_conversion_function(u32 format) +pixel_read_t get_pixel_read_function(u32 format) { switch (format) { case DRM_FORMAT_ARGB8888: @@ -279,7 +279,15 @@ void *get_pixel_conversion_function(u32 format) case DRM_FORMAT_RGB565: return &RGB565_to_argb_u16; default: - return NULL; + /* + * This is a bug in vkms_plane_atomic_check(). All the supported + * format must: + * - Be listed in vkms_formats in vkms_plane.c + * - Have a pixel_read callback defined here + */ + pr_err("Pixel format %p4cc is not supported by VKMS planes. This is a ke= rnel bug, atomic check must forbid this configuration.\n", + &format); + BUG(); } } =20 @@ -290,7 +298,7 @@ void *get_pixel_conversion_function(u32 format) * * @format: DRM_FORMAT_* value for which to obtain a conversion function (= see [drm_fourcc.h]) */ -void *get_pixel_write_function(u32 format) +pixel_write_t get_pixel_write_function(u32 format) { switch (format) { case DRM_FORMAT_ARGB8888: @@ -304,6 +312,14 @@ void *get_pixel_write_function(u32 format) case DRM_FORMAT_RGB565: return &argb_u16_to_RGB565; default: - return NULL; + /* + * This is a bug in vkms_writeback_atomic_check. All the supported + * format must: + * - Be listed in vkms_wb_formats in vkms_writeback.c + * - Have a pixel_write callback defined here + */ + pr_err("Pixel format %p4cc is not supported by VKMS writeback. This is a= kernel bug, atomic check must forbid this configuration.\n", + &format); + BUG(); } } diff --git a/drivers/gpu/drm/vkms/vkms_formats.h b/drivers/gpu/drm/vkms/vkm= s_formats.h index cf59c2ed8e9a..3ecea4563254 100644 --- a/drivers/gpu/drm/vkms/vkms_formats.h +++ b/drivers/gpu/drm/vkms/vkms_formats.h @@ -5,8 +5,8 @@ =20 #include "vkms_drv.h" =20 -void *get_pixel_conversion_function(u32 format); +pixel_read_t get_pixel_read_function(u32 format); =20 -void *get_pixel_write_function(u32 format); +pixel_write_t get_pixel_write_function(u32 format); =20 #endif /* _VKMS_FORMATS_H_ */ diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_= plane.c index 21b5adfb44aa..10e9b23dab28 100644 --- a/drivers/gpu/drm/vkms/vkms_plane.c +++ b/drivers/gpu/drm/vkms/vkms_plane.c @@ -125,7 +125,7 @@ static void vkms_plane_atomic_update(struct drm_plane *= plane, drm_rect_rotate(&frame_info->rotated, drm_rect_width(&frame_info->rotated= ), drm_rect_height(&frame_info->rotated), frame_info->rotation); =20 - vkms_plane_state->pixel_read =3D get_pixel_conversion_function(fmt); + vkms_plane_state->pixel_read =3D get_pixel_read_function(fmt); } =20 static int vkms_plane_atomic_check(struct drm_plane *plane, --=20 2.46.2