From nobody Thu Nov 28 15:50:55 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37C81198A22 for ; Mon, 30 Sep 2024 18:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719435; cv=none; b=mGnFq2pkoEPI+2D8WNasdty24OxJjboyUt13+YXl+2sLjTN2r4T9CHR8tIKYm86WPWxma04d0zcI4gRr5hSqVk+JItJuRHkDn8EJ/X3UrZuT9ibCbfAt+IrFDHFik/YenV2D6Fr9pB+M2kSxEwcK+3K3ZomC/cFjnUoJuPuRUQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719435; c=relaxed/simple; bh=bHrj5XU1WNzRAcUZhM6zhztuPGa/+td5l0FMRUYbbrg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qC+u8TrhQzdwywzIvjqlL3ZcLhdsTwOBXyzt2ObjLZJFlNKluXCmQuMBRKw6asO4lEY56+Vg/w7BqOrAeBRiWg0mnCPxd0cPvOkZIyrqhOUlGx7pfas3Hs5K0mopPs4jgqPORLTWiwBjzTG/Qq1y5Sa9gRf77fkS1o10esytHDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svKkS-0000Fn-I4 for linux-kernel@vger.kernel.org; Mon, 30 Sep 2024 20:03:52 +0200 Received: from [2a0a:edc0:0:b01:1d::7b] (helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1svKkS-002gbF-3P for linux-kernel@vger.kernel.org; Mon, 30 Sep 2024 20:03:52 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id C6EAB346EEC for ; Mon, 30 Sep 2024 18:03:51 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id 6D796346EE2; Mon, 30 Sep 2024 18:03:49 +0000 (UTC) Received: from [172.20.34.65] (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id ba283306; Mon, 30 Sep 2024 18:03:48 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 30 Sep 2024 20:03:46 +0200 Subject: [PATCH can-next] can: mcan: m_can_open(): simplify condition to call free_irq() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240930-m_can-simplify-v1-1-43312571c028@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAAHo+mYC/x2M7QpAMBRAX0X3t9X1uXgVScwdtxhtEi3vbvw8d c7x4MgyOagjD5ZOdryZAEkcgZp7M5HgMTCkmOZYZSjWTvVGOF73hfUtdIGyRCkLnQ0Qot2S5us fNvCZhq4D2ud5AUj4UShqAAAA X-Change-ID: 20240930-m_can-simplify-f50760775f3b To: Chandrasekar Ramakrishnan , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , kernel@pengutronix.de, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Kleine-Budde X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1054; i=mkl@pengutronix.de; h=from:subject:message-id; bh=bHrj5XU1WNzRAcUZhM6zhztuPGa/+td5l0FMRUYbbrg=; b=owEBbQGS/pANAwAKASg4oj56LbxvAcsmYgBm+ugCHKCkPGOqDDsaOfFGV/0XKrT13Nx/vade6 GF/kd5k2umJATMEAAEKAB0WIQRQQLqG4LYE3Sm8Pl8oOKI+ei28bwUCZvroAgAKCRAoOKI+ei28 b8ykB/9BzThpl4+t7d0D6bw9vO4GHbbbxC8najj8MZm/ds8yS1e9clrD98uoi1jpoDQoRw1przq NKqDJU4nArMumTxcWR59gPiDz5FV4zKNcfXNspwRu9WHLIdn6QYanjkiXS4An0jqo4MRN/aLrnw 00PYP/gI0EUqh94uBxKRXjszUICRFti9z4bs7zny1rYZb/qgtyrBMQTFKgy5Es3zMD1AGTVi7m+ T7oG9OJ/lMAtZM4tLP+1xo71R4OE7iR3kueUMnQ8JaSxnapa5sKuBMqBSp41K8YRzSeq561N2eQ 0napL+AgSu5z0SbiTQhU5P3q6uDdj/2K2KLqY5oY5W+LVJuT X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The condition to call free_irq() in the error cleanup path of m_can_open() can be simplified. The "is_peripheral" case also has a "dev->irq !=3D 0". Simplify the condition, call free_irq() if "dev->irq !=3D 0", i.e. the device has an interrupt. Signed-off-by: Marc Kleine-Budde Reviewed-by: Simon Horman --- drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index a978b960f1f1e1e8273216ff330ab789d0fd6d51..66a8673e51eab8c901434de16c6= 40045f7d0dd70 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -2070,7 +2070,7 @@ static int m_can_open(struct net_device *dev) return 0; =20 exit_start_fail: - if (cdev->is_peripheral || dev->irq) + if (dev->irq) free_irq(dev->irq, dev); exit_irq_fail: if (cdev->is_peripheral) --- base-commit: c824deb1a89755f70156b5cdaf569fca80698719 change-id: 20240930-m_can-simplify-f50760775f3b Best regards, --=20 Marc Kleine-Budde