From nobody Fri Nov 29 00:56:06 2024 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E865B1B07A7 for ; Thu, 26 Sep 2024 23:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727393811; cv=none; b=qIWuAkhZ/MqtxjMZSlIqNybR9POimKpb6OjRx6x0ZNE0jk3FvOhL6+EmXzd7/W0sdJyzNm0sOlOIorHlbReqRLYh00d57qZE3xbgPdf+hwaYbzkLfCy4oabVvI/Dzfs79LAXYcSuZe/0ULZ9YpSZZ4x7798RHPkfq9uSPrrDZPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727393811; c=relaxed/simple; bh=3vyvMvkO3Wyq1P4R+cw5CeJ/ZKfVE2YqNvhB7LdkgvE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=u9yqbQhrvqyCaNFF/GrUZk5clI0xBv9fhSUlSKRNbyff82Ova9iS2ugDBHiH8hWj+CJCqLExt8hIQn4WHM4/GONGvqScI8/Mu/RkCJ4cp2ANnUSfv/yPIDFex3WKKtrNrx2AdaCFB5BKlEMWLeLIvnB24OnXPuyH8+O/hpJKtfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VQ8vUqUZ; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VQ8vUqUZ" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e25d494faa4so1113277276.0 for ; Thu, 26 Sep 2024 16:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727393809; x=1727998609; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/iuxb3h278Dc+JtJQ9VvOQ0vkunN058i5/6AjQ3E3ks=; b=VQ8vUqUZrMX6k/MD35HdssE1ItwSF4rmvDPBiJ9NErWiaQctAKZ2SLNhmGDzI7lc0p AAfeGpTYw6evxroj7TpjwrfxqIOcxpQdD1MoNKGSy0Xg8aUsyzPJscIzokfiltcnwHyJ +PVTdF7TS1rI3Y0ms+ixIKuWqWq1tj5geKxpT8FY6xz9VIdwXAWeZV03sxE6vIq0pJYF P0yfpnvvsrcdKY+x0FzeFqkKM/u3NAUlE+QCdtffH/VOPEkIrgEeEk6NzyHRw+dcRdR2 5SbatdeEtawerISrRTBjqjzOYmfBQYV76hjaagKJ1hvVAOOFMslCDRk6IrTNvifpJ4Hg gyxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727393809; x=1727998609; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/iuxb3h278Dc+JtJQ9VvOQ0vkunN058i5/6AjQ3E3ks=; b=QHVRDkyypBdy1xLTrt+jPHucyjKRMU+sB0rUZRLCO/G0ClQ0yWenL8gWBccpFAnHuG VaCp+bfYWYDd/HocUJe/9NB0Wb5g+Ub2kyJNvwCpBjIsQo/Qzc3nAps9WEx0qWFPPRWE h3kedGPEznhufdFDt7IASx4wy37QztYzz4LC5+zKI5YDSN7q68zsZ2IzTxPtcOzdjf1Y 2c0Ddmxx0ZLFe96J7IYvWM4GeeuY+G9YamxlUPfz2FVtBc+9dc059qYyMQdhYtGY/np0 d8ayR38W2HCkkEGWD1aQQxhzU69BOweRWM5RdL1lyKhkZDVQrQBk7esek4J42lyL23m3 H1bQ== X-Gm-Message-State: AOJu0YzZMp3r+b+RPk3NgNt+DGI6YFuVkx3F4W6uFSEq24tGTmq4QgOg OTqaLqat5SfzNdt1L700CMxUDhKzxR1WDlPwDaQXnu9SdqHBtasjYAGG5Z0jiri6weoWlR8GkBz 1IcHm+MRzjA== X-Google-Smtp-Source: AGHT+IHBVAPawG1xZ8PVs7gjULOKJDTEQX7j5JE8yqCAQXtSxFo6puwM71uXOnRfMu8FHut5bqq89unj6w+mvA== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a25:e906:0:b0:e25:e391:5739 with SMTP id 3f1490d57ef6-e260495ec2amr1466276.0.1727393808817; Thu, 26 Sep 2024 16:36:48 -0700 (PDT) Date: Thu, 26 Sep 2024 23:36:15 +0000 In-Reply-To: <20240926233632.821189-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240926233632.821189-1-cmllamas@google.com> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog Message-ID: <20240926233632.821189-5-cmllamas@google.com> Subject: [PATCH v2 4/8] binder: fix BINDER_WORK_FROZEN_BINDER debug logs From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Yu-Ting Tseng Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Alice Ryhl , stable@vger.kernel.org, Todd Kjos Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BINDER_WORK_FROZEN_BINDER type is not handled in the binder_logs entries and it shows up as "unknown work" when logged: proc 649 context binder-test thread 649: l 00 need_return 0 tr 0 ref 13: desc 1 node 8 s 1 w 0 d 0000000053c4c0c3 unknown work: type 10 This patch add the freeze work type and is now logged as such: proc 637 context binder-test thread 637: l 00 need_return 0 tr 0 ref 8: desc 1 node 3 s 1 w 0 d 00000000dc39e9c6 has frozen binder Fixes: d579b04a52a1 ("binder: frozen notification") Cc: stable@vger.kernel.org Acked-by: Todd Kjos Signed-off-by: Carlos Llamas Reviewed-by: Alice Ryhl --- drivers/android/binder.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index d955135ee37a..2be9f3559ed7 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -6408,6 +6408,9 @@ static void print_binder_work_ilocked(struct seq_file= *m, case BINDER_WORK_CLEAR_DEATH_NOTIFICATION: seq_printf(m, "%shas cleared death notification\n", prefix); break; + case BINDER_WORK_FROZEN_BINDER: + seq_printf(m, "%shas frozen binder\n", prefix); + break; default: seq_printf(m, "%sunknown work: type %d\n", prefix, w->type); break; --=20 2.46.1.824.gd892dcdcdd-goog