From nobody Fri Nov 29 00:46:30 2024 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD78A156F39 for ; Thu, 26 Sep 2024 14:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727362785; cv=none; b=gF7uUbcwCiymB7GjVLvL9F3S8J9dGxJosPQ8qKvf4L6nELsk6IEnhfstU8PjYzq1R6wP8jJPHdodO5y2/K+yFBIGEHKjOYn813DZuFv2LobZMPAL7zsmOyG2TD6TbWw9Vnj/cZ5StaXEHIW6sIZWW8lZnZawHZ/moJlySGMeIIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727362785; c=relaxed/simple; bh=J6EBGaktQEIu0VpIbJIaFWXDXCR1uIR4hNwqEN2XYQ4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=aoYOIpNIpQnMkOAWsFdi+d4+AnEW4xWlZq0p6808bkNwk/m2dyilBZRdpmHkNB12q/wVLgI8URNP334OgR0ZHLNhh7Wc/FJr09zx8JhsRfH1Yiv/F6OBm5SEONMmdcCMkrIk9mXcIn5/xF3OgFtUAgIySij8JbiXAeSstDNvpQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XmwL22I1; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XmwL22I1" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e25cfee6581so978879276.2 for ; Thu, 26 Sep 2024 07:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727362783; x=1727967583; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Z2HODxaqAHzELuUx1xsYuulIg8XkoDAyXEK+wa7uqt4=; b=XmwL22I1mJFkLG67JEuvnupFkmYajuENO0j/jiDBzAVJZvsxhE9xMEbHfN68R60MYP T6/f1BSjumfCfdclzFn0OHdUmfzX26vZjD/YaYEcW7auDhzn+n3LFNV9/5CaPftqew+L ZhDAERRFoGRSVPEh8C5FIhn6z664rJ7DNCeFqHj7Lyjea99AKhtmnIHJsbQn6yu5bIFE Kc1SGuYyN7/aoMVG9Ak42Jlk0QS0GM9u0x/RQc8MnUuQ47bWR5O94P6aXUjZDxilB+S3 NWFt9S2uVkm1yhPwzewzXiUXebLQFl9BULlpmwmlOCrgHKiy+ynZ7JcFEPAXrghHUpAX M2sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727362783; x=1727967583; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z2HODxaqAHzELuUx1xsYuulIg8XkoDAyXEK+wa7uqt4=; b=dXarBa5z4VlMqCRCQKlVz4fFn6QmS1uWpbkWwVu7oaXsuX9nzEHYcvNzwJN1iqWdX+ pxCuTOTs30XoZiLZc2a6gHnOABGhor1u+lOapMKng61D+5IoiG9mJQyAfNqD3RLwEQ68 kfMqeVfHbfQEJZ+pa+J3mWVATCQpfEHivsMUkx4itctH7faXMISgmSnrI1utE/NTUnZ2 P0LgPUYjJuG1VVnlmQAqPbKlhjqNEerkE+ezI7DHtkH8yr7RJm0VaH4PbeyoSOMb+ZBD fJa5qmZSsuVqhNUzkdXkO3hRsK+tFVFh5JA27QI4ilXvuWR1KpZmVw0AnK7FFnZgVJwW ZNDw== X-Forwarded-Encrypted: i=1; AJvYcCUy0hsMScBdBbIxeEXNeEkvnllM2B4awRDqBWwymwvsi63H9Xp+H4KUzqWcaJXCSpD0mZKbgwSQ8pIf9lI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq8MJqyP+8kCRNc6I9PCH9dxB/gMjlGCZUjjeRnJdY5VwfUpEw fHSkOv4n6FTle8hv4WbjbHzGfa23drLRN/xmjaadEsET+H+1tXyW/ADig240u+IAouH+oALG+6m 3oG/wVaYuqLrIog== X-Google-Smtp-Source: AGHT+IEguqZ3KMFd8ePo88MXCzgONy3nQRtjG18qWhiIa6RhW90LDIg8vul7ERYQkvCgYgZUJSpHwfUb7nLAmd8= X-Received: from aliceryhl.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:35bd]) (user=aliceryhl job=sendgmr) by 2002:a25:d608:0:b0:e11:6a73:b0d with SMTP id 3f1490d57ef6-e24d9dc640bmr4525276.6.1727362782693; Thu, 26 Sep 2024 07:59:42 -0700 (PDT) Date: Thu, 26 Sep 2024 14:58:57 +0000 In-Reply-To: <20240926-b4-miscdevice-v1-0-7349c2b2837a@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240926-b4-miscdevice-v1-0-7349c2b2837a@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=15628; i=aliceryhl@google.com; h=from:subject:message-id; bh=J6EBGaktQEIu0VpIbJIaFWXDXCR1uIR4hNwqEN2XYQ4=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBm9XbTMB2KXt4UicQ0jDm5xwwbVCabQZr4BkEFY G+JfbmA8GCJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCZvV20wAKCRAEWL7uWMY5 RnILD/9UysiU1PquvE+YXTDIrG86uR5k55PO2MPQSYCrwvrjFIoFvx2f+sFshxNXOtdnA1XmkeT JlGw1ZthZ/FbTSJM0uOwW4fgCm7Gy7pN2ds1djZaFkD4Wt02JZMfmoM4ornCXKHgbMu062Ckgd1 S+lcFoxQ4CQqgsOu8B87HGWzShtQCQoaBDl60rer1zQzFDoRKsvrKTeuNGVQtWDl7cOkFhr81Qr e+KuGWjUkuIMaszHhUChEr1YJSlV3CEdfBhPoV3Tdv808Hhox56OpCSi5WKM7o/U89o+InwUwnY SnG2bDb40XJdVRLeotBMhO2vJOfXVl0clZ8TT83vtBXe7soImDsSsqHRCje3laAzEV4YgARZSKF pc7zrBBhYNJLs2GPOwyITfdGe9U8p1pE6vcoUEEKrMbYBN/jsYjF1Y0w4nVW03e9g0FkNUrpp6T qRKAsolW7XgMaQRXVMbdm4d442wxShcg0D6sPBsfK3YgEfmu/NlyIJCNLC6IkWouoPoC9ERWDmK zwm1F7D/EJKsSmyWLulT1H9St9fawTcPZaMiKekIXMp1ZyAAXXaAIlOhi1pNgzGVvGKXaT9AjHs aFgy0TfXjsC+VOroGrtRnL6Wrtv0rtbc+IFw93ccRFykS1qVSDXPELb+BjX0MnKyhxdBxmhDG19 vDWNemNzdD4kBwA== X-Mailer: b4 0.13.0 Message-ID: <20240926-b4-miscdevice-v1-3-7349c2b2837a@google.com> Subject: [PATCH 3/3] rust: miscdevice: add abstraction for defining miscdevices From: Alice Ryhl To: Greg Kroah-Hartman , Arnd Bergmann , Miguel Ojeda , Alexander Viro , Christian Brauner , Jan Kara Cc: Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Provide a `MiscDevice` trait that lets you specify the file operations that you wish to provide for your misc device. Most operations are optional. In the future, the file operations in the `MiscDevice` can be moved to a general `FileOperations` trait so that it is useful for other file systems too. Signed-off-by: Alice Ryhl --- rust/bindings/bindings_helper.h | 1 + rust/kernel/lib.rs | 1 + rust/kernel/miscdevice.rs | 401 ++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 403 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index ca13659ded4c..ec2e28ef6568 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 819126fc2d89..bf97817842c9 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -41,6 +41,7 @@ #[cfg(CONFIG_KUNIT)] pub mod kunit; pub mod list; +pub mod miscdevice; pub mod mm; #[cfg(CONFIG_NET)] pub mod net; diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs new file mode 100644 index 000000000000..6c4e33d77c58 --- /dev/null +++ b/rust/kernel/miscdevice.rs @@ -0,0 +1,401 @@ +// SPDX-License-Identifier: GPL-2.0 + +// Copyright (C) 2024 Google LLC. + +//! Miscdevice support. +//! +//! C headers: [`include/linux/miscdevice.h`](srctree/include/linux/miscde= vice.h). +//! +//! Reference: + +use crate::{ + bindings, + error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR}, + fs::{File, LocalFile}, + mm::virt::VmArea, + prelude::*, + str::CStr, + types::{ForeignOwnable, Opaque}, +}; +use core::{ + ffi::{c_int, c_long, c_uint, c_ulong}, + marker::PhantomData, + mem::MaybeUninit, + pin::Pin, + ptr::NonNull, +}; + +/// The kernel `loff_t` type. +#[allow(non_camel_case_types)] +pub type loff_t =3D bindings::loff_t; + +/// Options for creating a misc device. +#[derive(Copy, Clone)] +pub struct MiscDeviceOptions { + /// The name of the miscdevice. + pub name: &'static CStr, +} + +impl MiscDeviceOptions { + /// Create a raw `struct miscdev` ready for registration. + pub const fn into_raw(self) -> bindings::miscdevice { + // SAFETY: All zeros is valid for this C type. + let mut result: bindings::miscdevice =3D unsafe { MaybeUninit::zer= oed().assume_init() }; + result.minor =3D bindings::MISC_DYNAMIC_MINOR as _; + result.name =3D self.name.as_char_ptr(); + result.fops =3D create_vtable::(); + result + } +} + +/// A registration of a miscdevice. +/// +/// # Invariants +/// +/// `inner` is a registered misc device. +#[repr(transparent)] +#[pin_data(PinnedDrop)] +pub struct MiscDeviceRegistration { + #[pin] + inner: Opaque, + _t: PhantomData, +} + +unsafe impl Send for MiscDeviceRegistration {} +unsafe impl Sync for MiscDeviceRegistration {} + +impl MiscDeviceRegistration { + /// Register a misc device. + pub fn register(opts: MiscDeviceOptions) -> impl PinInit { + try_pin_init!(Self { + inner <- Opaque::try_ffi_init(move |slot: *mut bindings::miscd= evice| { + // SAFETY: The initializer can write to the provided `slot= `. + unsafe { slot.write(opts.into_raw::()) }; + + // SAFETY: We just wrote the misc device options to the sl= ot. The miscdevice will + // get unregistered before `slot` is deallocated because t= he memory is pinned and + // the destructor of this type deallocates the memory. + // INVARIANT: If this returns `Ok(())`, then the `slot` wi= ll contain a registered + // misc device. + to_result(unsafe { bindings::misc_register(slot) }) + }), + _t: PhantomData, + }) + } + + /// Returns the private data associated with the provided file. + /// + /// Returns `None` if the file is not associated with this misc device. + pub fn try_get_private_data<'a>( + &self, + file: &'a LocalFile, + ) -> Option<::Borrowed<'a>> { + // SAFETY: `fops` of a miscdevice is immutable after initializatio= n. + let fops_this =3D unsafe { (*self.as_raw()).fops }; + // SAFETY: `f_op` of a file is immutable after initialization. + let fops_file =3D unsafe { (*file.as_ptr()).f_op }; + + if core::ptr::eq(fops_this, fops_file) { + // SAFETY: We know that `file` is associated with a `MiscDevic= eRegistration`, so + // `private_data` is immutable. + let private_data =3D unsafe { (*file.as_ptr()).private_data }; + // SAFETY: + // * The fops match, so the file's private date has the right = type. + // * The returned borrow cannot outlive the file. + Some(unsafe { ::borrow(private_data)= }) + } else { + None + } + } + + /// Returns a raw pointer to the misc device. + pub fn as_raw(&self) -> *mut bindings::miscdevice { + self.inner.get() + } +} + +#[pinned_drop] +impl PinnedDrop for MiscDeviceRegistration { + fn drop(self: Pin<&mut Self>) { + // SAFETY: We know that the device is registered by the type invar= iants. + unsafe { bindings::misc_deregister(self.inner.get()) }; + } +} + +/// Trait implemented by the private data of an open misc device. +#[vtable] +pub trait MiscDevice { + /// What kind of pointer should `Self` be wrapped in. + type Ptr: ForeignOwnable + Send + Sync; + + /// Called when the misc device is opened. + /// + /// The returned pointer will be stored as the private data for the fi= le. + fn open(_file: &File) -> Result; + + /// Called when the misc device is released. + fn release(device: Self::Ptr, _file: &File) { + drop(device); + } + + /// Handle for mmap. + fn mmap( + _device: ::Borrowed<'_>, + _file: &File, + _vma: Pin<&mut VmArea>, + ) -> Result<()> { + kernel::build_error(VTABLE_DEFAULT_ERROR) + } + + /// Seeks this miscdevice. + fn llseek( + _device: ::Borrowed<'_>, + _file: &LocalFile, + _offset: loff_t, + _whence: c_int, + ) -> Result { + kernel::build_error(VTABLE_DEFAULT_ERROR) + } + + /// Read from this miscdevice. + fn read_iter(_kiocb: Kiocb<'_, Self::Ptr>, _iov: &mut IovIter) -> Resu= lt { + kernel::build_error(VTABLE_DEFAULT_ERROR) + } + + /// Handler for ioctls + /// + /// The `cmd` argument is usually manipulated using the utilties in [`= kernel::ioctl`]. + /// + /// [`kernel::ioctl`]: mod@crate::ioctl + fn ioctl( + _device: ::Borrowed<'_>, + _file: &File, + _cmd: u32, + _arg: usize, + ) -> Result { + kernel::build_error(VTABLE_DEFAULT_ERROR) + } + + /// Handler for ioctls + /// + /// Used for 32-bit userspace on 64-bit platforms. + #[cfg(CONFIG_COMPAT)] + fn compat_ioctl( + device: ::Borrowed<'_>, + file: &File, + cmd: u32, + arg: usize, + ) -> Result { + Self::ioctl(device, file, cmd, arg) + } +} + +/// Wrapper for the kernel's `struct kiocb`. +/// +/// The type `T` represents the private data of the file. +pub struct Kiocb<'a, T> { + inner: NonNull, + _phantom: PhantomData<&'a T>, +} + +impl<'a, T: ForeignOwnable> Kiocb<'a, T> { + /// Get the private data in this kiocb. + pub fn private_data(&self) -> ::Borrowed<'a> { + // SAFETY: The `kiocb` lets us access the private data. + let private =3D unsafe { (*(*self.inner.as_ptr()).ki_filp).private= _data }; + // SAFETY: The kiocb has shared access to the private data. + unsafe { ::borrow(private) } + } + + /// Gets the current value of `ki_pos`. + pub fn ki_pos(&self) -> loff_t { + // SAFETY: The `kiocb` can access `ki_pos`. + unsafe { (*self.inner.as_ptr()).ki_pos } + } + + /// Gets a mutable reference to the `ki_pos` field. + pub fn ki_pos_mut(&mut self) -> &mut loff_t { + // SAFETY: The `kiocb` can access `ki_pos`. + unsafe { &mut (*self.inner.as_ptr()).ki_pos } + } +} + +/// Wrapper for the kernel's `struct iov_iter`. +pub struct IovIter { + inner: Opaque, +} + +impl IovIter { + /// Gets a raw pointer to the contents. + pub fn as_raw(&self) -> *mut bindings::iov_iter { + self.inner.get() + } +} + +const fn create_vtable() -> &'static bindings::file_operati= ons { + const fn maybe_fn(check: bool, func: T) -> Option { + if check { + Some(func) + } else { + None + } + } + + struct VtableHelper { + _t: PhantomData, + } + impl VtableHelper { + const VTABLE: bindings::file_operations =3D bindings::file_operati= ons { + open: Some(fops_open::), + release: Some(fops_release::), + mmap: maybe_fn(T::HAS_MMAP, fops_mmap::), + llseek: maybe_fn(T::HAS_LLSEEK, fops_llseek::), + read_iter: maybe_fn(T::HAS_READ_ITER, fops_read_iter::), + unlocked_ioctl: maybe_fn(T::HAS_IOCTL, fops_ioctl::), + #[cfg(CONFIG_COMPAT)] + compat_ioctl: maybe_fn(T::HAS_IOCTL || T::HAS_COMPAT_IOCTL, fo= ps_compat_ioctl::), + ..unsafe { MaybeUninit::zeroed().assume_init() } + }; + } + + &VtableHelper::::VTABLE +} + +unsafe extern "C" fn fops_open( + inode: *mut bindings::inode, + file: *mut bindings::file, +) -> c_int { + // SAFETY: The pointers are valid and for a file being opened. + let ret =3D unsafe { bindings::generic_file_open(inode, file) }; + if ret !=3D 0 { + return ret; + } + + // SAFETY: + // * The file is valid for the duration of this call. + // * There is no active fdget_pos region on the file on this thread. + let ptr =3D match T::open(unsafe { File::from_raw_file(file) }) { + Ok(ptr) =3D> ptr, + Err(err) =3D> return err.to_errno(), + }; + + // SAFETY: The open call of a file owns the private data. + unsafe { (*file).private_data =3D ptr.into_foreign().cast_mut() }; + + 0 +} + +unsafe extern "C" fn fops_release( + _inode: *mut bindings::inode, + file: *mut bindings::file, +) -> c_int { + // SAFETY: The release call of a file owns the private data. + let private =3D unsafe { (*file).private_data }; + // SAFETY: We are taking ownership of the private data, so we can drop= it. + let ptr =3D unsafe { ::from_foreign(private)= }; + // SAFETY: + // * The file is valid for the duration of this call. + // * There is no active fdget_pos region on the file on this thread. + T::release(ptr, unsafe { File::from_raw_file(file) }); + + 0 +} + +unsafe extern "C" fn fops_mmap( + file: *mut bindings::file, + vma: *mut bindings::vm_area_struct, +) -> c_int { + // SAFETY: The release call of a file owns the private data. + let private =3D unsafe { (*file).private_data }; + // SAFETY: Ioctl calls can borrow the private data of the file. + let device =3D unsafe { ::borrow(private) }; + // SAFETY: + // * The file is valid for the duration of this call. + // * There is no active fdget_pos region on the file on this thread. + let file =3D unsafe { File::from_raw_file(file) }; + // SAFETY: The caller ensures that the vma is valid. + let area =3D unsafe { kernel::mm::virt::VmArea::from_raw_mut(vma) }; + + match T::mmap(device, file, area) { + Ok(()) =3D> 0, + Err(err) =3D> err.to_errno() as c_int, + } +} + +unsafe extern "C" fn fops_llseek( + file: *mut bindings::file, + offset: loff_t, + whence: c_int, +) -> loff_t { + // SAFETY: The release call of a file owns the private data. + let private =3D unsafe { (*file).private_data }; + // SAFETY: Ioctl calls can borrow the private data of the file. + let device =3D unsafe { ::borrow(private) }; + // SAFETY: + // * The file is valid for the duration of this call. + // * We are inside an fdget_pos region, so there cannot be any active = fdget_pos regions on + // other threads. + let file =3D unsafe { LocalFile::from_raw_file(file) }; + + match T::llseek(device, file, offset, whence) { + Ok(res) =3D> res as loff_t, + Err(err) =3D> err.to_errno() as loff_t, + } +} + +unsafe extern "C" fn fops_read_iter( + kiocb: *mut bindings::kiocb, + iter: *mut bindings::iov_iter, +) -> isize { + let kiocb =3D Kiocb { + inner: unsafe { NonNull::new_unchecked(kiocb) }, + _phantom: PhantomData, + }; + let iov =3D unsafe { &mut *iter.cast::() }; + + match T::read_iter(kiocb, iov) { + Ok(res) =3D> res as isize, + Err(err) =3D> err.to_errno() as isize, + } +} + +unsafe extern "C" fn fops_ioctl( + file: *mut bindings::file, + cmd: c_uint, + arg: c_ulong, +) -> c_long { + // SAFETY: The release call of a file owns the private data. + let private =3D unsafe { (*file).private_data }; + // SAFETY: Ioctl calls can borrow the private data of the file. + let device =3D unsafe { ::borrow(private) }; + // SAFETY: + // * The file is valid for the duration of this call. + // * There is no active fdget_pos region on the file on this thread. + let file =3D unsafe { File::from_raw_file(file) }; + + match T::ioctl(device, file, cmd as u32, arg as usize) { + Ok(ret) =3D> ret, + Err(err) =3D> err.to_errno() as c_long, + } +} + +#[cfg(CONFIG_COMPAT)] +unsafe extern "C" fn fops_compat_ioctl( + file: *mut bindings::file, + cmd: c_uint, + arg: c_ulong, +) -> c_long { + // SAFETY: The release call of a file owns the private data. + let private =3D unsafe { (*file).private_data }; + // SAFETY: Ioctl calls can borrow the private data of the file. + let device =3D unsafe { ::borrow(private) }; + // SAFETY: + // * The file is valid for the duration of this call. + // * There is no active fdget_pos region on the file on this thread. + let file =3D unsafe { File::from_raw_file(file) }; + + match T::compat_ioctl(device, file, cmd as u32, arg as usize) { + Ok(ret) =3D> ret, + Err(err) =3D> err.to_errno() as c_long, + } +} --=20 2.46.0.792.g87dc391469-goog