From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDDE15B546 for ; Wed, 25 Sep 2024 22:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; cv=none; b=dqhRwys+Y3mIwLYkV7Fhsm03zGC4Iq8AZ1fSddqQdGk9VP0EHCW0NTABgIJVMutWsLkqw5czfMO7OWdotQCB6t5r740PJ6lzbSUFcPxZHioTlhiEaixs42PJtYyCdKJlHh/9c6qZlXxctl/Yo4n/r8n4q6ywkYxAjgOTj+Xxcg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; c=relaxed/simple; bh=2ZYSqY3YIGLo7CuilsPs1sMc9iXpAcknGqjh1CS/kBc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WLMD6Z3/ccczbAEn0pkr239bu3hroz7i7zcSqmji+UCcnyDVmGmi6pn/wIiZiuPooXF6N/XO0/jhqKkS0HDmEl/PkvpPlwi9VAuqZASnuIavPFOdteFGdA/RZ8X4Ukhauvf8K5OiCbP9g1cPXQXNSD8VvnBc1li2SOdFkhqgXR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=CbcVFJ+T; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="CbcVFJ+T" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 769CA2C01C6; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=STYkyKa8X2kiOpfc1gaS05ML/Z5qdUmGOlnZJgX7SUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CbcVFJ+TK7MQAn/2ctkhAW+sFRohopNQ7ouJl3JorsIyPW8vYJiBIfG5Szz7bV2j1 dx1LYi+uoS9irYlI+z5GhUJm2jFExqvel6+lJ0tVs+eFrfh3jm3uZcVmiMUT5ar7RT xKhQkGphoUUOl0SX7ev9fB96jk0NacFso0C6JHAJNTYL89d+psS5IXKXe+bj2kcyKq Iky3vRXyJHkMqp1H87a4LEqvXPYv2LsJembHuYuTXuly6ECETfMy5TKRegc9zvs2w3 o7XyDJFZ6/Vk68DXqu6Ag4YjzAAbOyF+LbsRC/JcyP0VTO893HX9pLtgby0sDs5wgw u3Jhd9b44d3fw== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 0C28913EE56; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 09B5028044A; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 1/6] dt-bindings: reset: syscon-reboot: Add reg property Date: Thu, 26 Sep 2024 09:58:42 +1200 Message-ID: <20240925215847.3594898-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=8QneSPuuVenq9H3OMoEA:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" The syscon-reboot binding used 'offset' for historical reasons. Having a reg property is appropriate when these nodes are children of a MMIO bus. Add a reg property and modify the constraints so that one of 'reg' or 'offset' is expected. Signed-off-by: Chris Packham Reviewed-by: Krzysztof Kozlowski --- Notes: Changes in v5: - New, suggested by Krzysztof .../bindings/power/reset/syscon-reboot.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.ya= ml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml index 75061124d9a8..19d3093e6cd2 100644 --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml @@ -31,6 +31,10 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: Offset in the register map for the reboot register (in by= tes). =20 + reg: + maxItems: 1 + description: Base address and size for the reboot register. + regmap: $ref: /schemas/types.yaml#/definitions/phandle deprecated: true @@ -45,9 +49,14 @@ properties: priority: default: 192 =20 +oneOf: + - required: + - offset + - required: + - reg + required: - compatible - - offset =20 additionalProperties: false =20 --=20 2.46.2 From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D85AC156F23 for ; Wed, 25 Sep 2024 22:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; cv=none; b=rIaZnVb2zkDQpzpXZwkcL+lccYQMuLcBUplNzUnKNZGlpkP0EqOXqpbEfkDR/PQ4Dl6K86qfzrGMRpkEvHwmrER5uDQuAXFy5wm+6ZVrIz7G3vPIy4+s2iAk2Obk9XA5W/oQg7WCG7iIqJRi9g4hYEMJcDLsBfh+VK/PQLZxyOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; c=relaxed/simple; bh=KCRZkJVUVCRux8zh/Yuzd2PQ/uHmMLXlhfYhvvFa7ds=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pByI8vcnEBzSbWwZA4aIygMoGJyeCLRTOgc8ZwsUukd/+NTHboH5thqsrrKufVQO8hkjT3yadCVAmFOIfE+jsyEmkqLgz94PZAlb9Or3Y6AELlPuh2+sNhOgpBu6KMjLZPDsBm8OlGV/Fi7BjBn3PNY5fI8DHfaKkWY/u9oT3h4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=KkbhBtss; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="KkbhBtss" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 55C212C0125; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=W3ZRm9QfitUJ3rBWGirI0fRXOd+dseX1PtPwNOyjLqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KkbhBtssVNbePHgGwD5q9ztrzfoWtP5WM/KkkF7qULCHSHc4UlNJscvmEKgaaio6q rn4MsM7gCFxNXpXCff3l6IGZfT0Y6whmbdPfz1fTON77ROZT2w5DdWDAv5JlSWisZm LJI2bda/BZcjcwyeTfmcNsKMsH3YV5g1GDBjYj7RG5ZdvXHOdFwFprXZ4nocpMxGqZ Uw5UQtwIJ/VVah3NbwoZNNtoOTfHhY7EljJPAQ2h+FSSx6SjkRk9VY/HaXXkCOor16 jV3iB045ypgAxSqujQLq1HW5ZXLJFwRiCqQYTpmZrmXXha3ssTCMs3Gd23wZf56b7L /TvcqMrqBeRNg== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 0DAD013EE83; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 0B801280571; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 2/6] power: reset: syscon-reboot: Accept reg property Date: Thu, 26 Sep 2024 09:58:43 +1200 Message-ID: <20240925215847.3594898-3-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=GF1LeCK7rlvhbTvQy6cA:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" For historical reasons syscon-reboot has used an 'offset' property. As a child on a MMIO bus having a 'reg' property is more appropriate. Accept 'reg' as an alternative to 'offset'. Signed-off-by: Chris Packham Reviewed-by: Krzysztof Kozlowski --- Notes: Changes in v5: - New, making the driver accept the updated binding drivers/power/reset/syscon-reboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/reset/syscon-reboot.c b/drivers/power/reset/sysc= on-reboot.c index 4d622c19bc48..d623d77e657e 100644 --- a/drivers/power/reset/syscon-reboot.c +++ b/drivers/power/reset/syscon-reboot.c @@ -61,7 +61,8 @@ static int syscon_reboot_probe(struct platform_device *pd= ev) priority =3D 192; =20 if (of_property_read_u32(pdev->dev.of_node, "offset", &ctx->offset)) - return -EINVAL; + if (of_property_read_u32(pdev->dev.of_node, "reg", &ctx->offset)) + return -EINVAL; =20 value_err =3D of_property_read_u32(pdev->dev.of_node, "value", &ctx->valu= e); mask_err =3D of_property_read_u32(pdev->dev.of_node, "mask", &ctx->mask); --=20 2.46.2 From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571BD17C9AA for ; Wed, 25 Sep 2024 22:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301618; cv=none; b=N72bgWskG3tIGOgWsZb8wYsfWzG0+fsen2S+rRwWb0ngOnHCl1zTsGyzsPx9LA2Mcr0k8VcgUxjq7CzMRCjbMVBAinm73ACALiQrFG1bb9RsTWUGrlJOGuC9LgHNB1BG6SU1EUlQx3FA9OwGW/jIAIGayr/gllPL+o6JSpdl//Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301618; c=relaxed/simple; bh=4q8WHJ+bmrZ+QjH4javT6Df80/Nqulphj2L9wBDW6JY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r/kNo3d6e/UxgLOmxD2zTLsd2ytLJJh4OfYm9dgGd3FTrZyU5jBhIHStFgMFketp2rb1UirDf86mKOsevt7LuE8R08XPzvA6NkZT0rooLm7az+qniFVcMAlMo5mhU3wDMw+fnHio9k6dm1XBFmWTtfqvyPquKOD/6xrB3ggPipI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=Rn/QZp6x; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="Rn/QZp6x" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id A4EE62C0540; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=+EG/UmIZW8mL9dPyplH2lKzdLhmhd1svUmlP+xMtltY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rn/QZp6xungmGO35FRqWMh5pijw27aJ+5OU9Ve23hgoSsYuhGzhfALRK9l/AFBhRn j8pHXEAhPzIbBaW589UNj8tWhrckl23ACMh0CWVSKeLi+7xO8kp9OBcCg6RDE8qnEw XFvHDHzBXgj9SlJ0f5qQe6BGT7YsFAb7BmP86Yw70CJMnigwZmDfsMkrMQ+KO4ESz8 8dyXkQtj8xnDQPEkjsv3jso4fKIEbis4oDSGErIy50BzoXM8Ti220nwAwUxQY/GEvW 23ZoNaZxBCkGyI94A8CGjQGwkGhAlR0KjPiGdO1yEL0VqYa434eKYWbR9fltfsjb/A zB0CAKeUiwEzA== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 125A913EE85; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 113A4280532; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Date: Thu, 26 Sep 2024 09:58:44 +1200 Message-ID: <20240925215847.3594898-4-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=gEfo2CItAAAA:8 a=Ax3GeT8WF174fsDHF1QA:9 a=3ZKOabzyN94A:10 a=sptkURWiP4Gy88Gu7hUp:22 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" Add device tree schema for the Realtek RTL9300 switches. The RTL9300 family is made up of the RTL9301, RTL9302B, RTL9302C and RTL9303. These have the same SoC differ in the Ethernet switch/SERDES arrangement. Currently the only supported features are the syscon-reboot and i2c controllers. The syscon-reboot is needed to be able to reboot the board. The I2C controllers are slightly unusual because they each own an SCL pin (GPIO8 for the first controller, GPIO 17 for the second) but have 8 common SDA pins which can be assigned to either controller (but not both). Signed-off-by: Chris Packham Reviewed-by: Krzysztof Kozlowski --- Notes: Changes in v5: I've combined the two series I had in flight so this is the combination of adding the switch syscon, the reboot and i2c. It makes the changelog a bit meaningless so I've dropped the earlier commentary. =20 As requested I've put a more complete example in the main rtl9300-switch.yaml. =20 I've kept rtl9300-i2c.yaml separate for now but link to it with a $ref from rtl9300-switch.yaml to reduce clutter. The example in rtl9300-i2c.yaml is technically duplicating part of the example from rtl9300-switch.yaml but I feel it's nice to be able to see the example next to where the properties are defined. .../bindings/i2c/realtek,rtl9300-i2c.yaml | 98 +++++++++++++++ .../bindings/mfd/realtek,rtl9300-switch.yaml | 115 ++++++++++++++++++ 2 files changed, 213 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/realtek,rtl9300-i= 2c.yaml create mode 100644 Documentation/devicetree/bindings/mfd/realtek,rtl9300-s= witch.yaml diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml= b/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml new file mode 100644 index 000000000000..e8cf328b2710 --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/realtek,rtl9300-i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek RTL I2C Controller + +maintainers: + - Chris Packham + +description: + The RTL9300 SoC has two I2C controllers. Each of these has an SCL line (= which + if not-used for SCL can be a GPIO). There are 8 common SDA lines that ca= n be + assigned to either I2C controller. + +properties: + compatible: + items: + - enum: + - realtek,rtl9301-i2c + - realtek,rtl9302b-i2c + - realtek,rtl9302c-i2c + - realtek,rtl9303-i2c + - const: realtek,rtl9300-i2c + + reg: + description: Register offset and size this I2C controller. + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + '^i2c@[0-7]$': + $ref: /schemas/i2c/i2c-controller.yaml + unevaluatedProperties: false + + properties: + reg: + description: The SDA pin associated with the I2C bus. + maxItems: 1 + + required: + - reg + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + i2c@36c { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; + reg =3D <0x36c 0x14>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + i2c@0 { + reg =3D <0>; + #address-cells =3D <1>; + #size-cells =3D <0>; + gpio@20 { + compatible =3D "nxp,pca9555"; + gpio-controller; + #gpio-cells =3D <2>; + reg =3D <0x20>; + }; + }; + + i2c@2 { + reg =3D <2>; + #address-cells =3D <1>; + #size-cells =3D <0>; + gpio@20 { + compatible =3D "nxp,pca9555"; + gpio-controller; + #gpio-cells =3D <2>; + reg =3D <0x20>; + }; + }; + }; + i2c@388 { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; + reg =3D <0x388 0x14>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + i2c@7 { + reg =3D <7>; + #address-cells =3D <1>; + #size-cells =3D <0>; + }; + }; diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.y= aml b/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.yaml new file mode 100644 index 000000000000..a8e75b1bd286 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.yaml @@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/realtek,rtl9300-switch.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek Switch with Internal CPU + +maintainers: + - Chris Packham + +description: + The RTL9302 is an Ethernet switch with an integrated CPU. A number of + different peripherals are accessed through a common register block, + represented here as a syscon node. + +properties: + compatible: + items: + - enum: + - realtek,rtl9301-switch + - realtek,rtl9302b-switch + - realtek,rtl9302c-switch + - realtek,rtl9303-switch + - const: realtek,rtl9300-switch + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + +patternProperties: + 'reboot@[0-9a-f]+$': + $ref: /schemas/power/reset/syscon-reboot.yaml# + + 'i2c@[0-9a-f]+$': + $ref: /schemas/i2c/realtek,rtl9300-i2c.yaml# + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + ethernet-switch@1b000000 { + compatible =3D "realtek,rtl9302c-switch", "realtek,rtl9300-switch", = "syscon", "simple-mfd"; + reg =3D <0x1b000000 0x10000>; + #address-cells =3D <1>; + #size-cells =3D <1>; + + reboot@c { + compatible =3D "syscon-reboot"; + reg =3D <0x0c 0x4>; + value =3D <0x01>; + }; + + i2c@36c { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; + reg =3D <0x36c 0x14>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + i2c@0 { + reg =3D <0>; + #address-cells =3D <1>; + #size-cells =3D <0>; + gpio@20 { + compatible =3D "nxp,pca9555"; + gpio-controller; + #gpio-cells =3D <2>; + reg =3D <0x20>; + }; + }; + + i2c@2 { + reg =3D <2>; + #address-cells =3D <1>; + #size-cells =3D <0>; + gpio@20 { + compatible =3D "nxp,pca9555"; + gpio-controller; + #gpio-cells =3D <2>; + reg =3D <0x20>; + }; + }; + }; + + i2c@388 { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; + reg =3D <0x388 0x14>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + i2c@7 { + reg =3D <7>; + #address-cells =3D <1>; + #size-cells =3D <0>; + gpio@20 { + compatible =3D "nxp,pca9555"; + gpio-controller; + #gpio-cells =3D <2>; + reg =3D <0x20>; + }; + }; + }; + }; + --=20 2.46.2 From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EABF315B0FC for ; Wed, 25 Sep 2024 22:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; cv=none; b=tM8Vkfj9dzcuhS/NSEcWZ/wHZlPtXKXfCfrXJrA57NfXTUymXEd/M1hV4yKoFP5dVYoIBecDgYH428UhJiwLAGed26mlGwVPiilmYAxR8FfUegT4AdDqVhQ8Skqol9nYDtw57DO4NV4Gic8KZdLtPKWspC18DuH99Yn7LLL7G68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; c=relaxed/simple; bh=F2P+ohYGp93QxNyi2S7crC8h83jU2nxmGlbtFFBqFmo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SLO3at+OUHutiic01hTem43rFp1TPEBcxHtTKNW++Diey5CiM0n3k9EreJCXZnvKOVTb1xpPQ1A6i4K9Rk0mB4an+R+VogbxOdtHO9gG+kKHf3MvymYRKNumJA+dcIGH/HFHkx78xltBLZS8xQY3tBdplSkQfgNyKytMgJel+YQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=ctgJpC6M; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="ctgJpC6M" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 985832C0362; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=eCWCvALzZIe/c7GsZzUhAGEnwDZr6bpNwKlvZjiQP4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ctgJpC6MY1337YU9gTsDS2SaLp+YB5hrxNlFUurq7iEgVBvT+ZzMovo6Qm4gCztC7 Sr62aFX/jZK85cW5p6PpeRZBCBmE8Kjt8B5eoy6N6hxD2l6+r1MSzU54KonNXWwuce BzvS/eqTw9il4Zm0x9PeST7ZTpGxHJyJRUy9BORPIv4af/snq4JFqzC+WCzMVSP1Rf 6tEjOvgdqyJkjwbZtyKdVl+OWRD/CtOLnqoJf4DzNWVH/Fbdz8K9q4oHIfNcXbz7fT xjMeBn9IpWjdNEqSln4Wyrj9Gc7U5QVbbY/QnI3d+PVtzzQVIexu8XSoHB9AfN529f 0snCqaQFw3AiA== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 170FA13EE36; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 1569C280532; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 4/6] mips: dts: realtek: Add syscon-reboot node Date: Thu, 26 Sep 2024 09:58:45 +1200 Message-ID: <20240925215847.3594898-5-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=wvvtYBgb9FI6sUgW-XsA:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" The board level reset on systems using the RTL9302 can be driven via the switch. Use a syscon-reboot node to represent this. Signed-off-by: Chris Packham Reviewed-by: Krzysztof Kozlowski --- Notes: Changes in v5: - Krzysztof did technically give a r-by on v4 but given the changes to the rest of the series I haven't included it. - Use reg instead of offset - Add a rtl9302c.dtsi for the specific chip which pulls in the generic rtl930x.dtsi and updates a few of the compatibles on the way through. - Update Cameo board to use rtl9302c.dtsi Changes in v4: - None Changes in v3: - None Changes in v2: - drop redundant status =3D "okay" .../dts/realtek/cameo-rtl9302c-2x-rtl8224-2xge.dts | 2 +- arch/mips/boot/dts/realtek/rtl9302c.dtsi | 7 +++++++ arch/mips/boot/dts/realtek/rtl930x.dtsi | 13 +++++++++++++ 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 arch/mips/boot/dts/realtek/rtl9302c.dtsi diff --git a/arch/mips/boot/dts/realtek/cameo-rtl9302c-2x-rtl8224-2xge.dts = b/arch/mips/boot/dts/realtek/cameo-rtl9302c-2x-rtl8224-2xge.dts index 77d2566545f2..6789bf374044 100644 --- a/arch/mips/boot/dts/realtek/cameo-rtl9302c-2x-rtl8224-2xge.dts +++ b/arch/mips/boot/dts/realtek/cameo-rtl9302c-2x-rtl8224-2xge.dts @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later /dts-v1/; =20 -#include "rtl930x.dtsi" +#include "rtl9302c.dtsi" =20 #include #include diff --git a/arch/mips/boot/dts/realtek/rtl9302c.dtsi b/arch/mips/boot/dts/= realtek/rtl9302c.dtsi new file mode 100644 index 000000000000..80d9f407e758 --- /dev/null +++ b/arch/mips/boot/dts/realtek/rtl9302c.dtsi @@ -0,0 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause + +#include "rtl930x.dtsi" + +&switch0 { + compatible =3D "realtek,rtl9302c-switch", "realtek,rtl9300-switch", "sysc= on", "simple-mfd"; +}; diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/r= ealtek/rtl930x.dtsi index f271940f82be..89b8854596cd 100644 --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi @@ -29,6 +29,19 @@ lx_clk: clock-175mhz { #clock-cells =3D <0>; clock-frequency =3D <175000000>; }; + + switch0: switch@1b000000 { + compatible =3D "realtek,rtl9300-switch", "syscon", "simple-mfd"; + reg =3D <0x1b000000 0x10000>; + #address-cells =3D <1>; + #size-cells =3D <1>; + + reboot@c { + compatible =3D "syscon-reboot"; + reg =3D <0x0c 0x4>; + value =3D <0x01>; + }; + }; }; =20 &soc { --=20 2.46.2 From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE97B15B14B for ; Wed, 25 Sep 2024 22:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; cv=none; b=WlyfXqPnGmC5RwQW3g/K+MyC0w+v4D2tI6yz2goTh6hJhNfGHfZ4eFLGziZlBwKmQXf76x9Eg3qzJ8/AucENcAyfaVHu4+YGnL2fq9GDgkACx6Akv/oRLOM7x1QMzVvaOsAgOYpYK7i1PXxoa9k5cDjOzUOiUwwJIDsTPof0jDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301613; c=relaxed/simple; bh=a8e87PAzFf0cbE/cQriNWQpzrXU54uLCeBwkMiHvOoY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OK0hErjGRns4xC3F0DB3mjpa2aGf4gYSr0N12yuaBX1eHr9lJcDMei619O9cgGV+6WGUhA1Xa+2AQ1P8ECQiYtMDOPG0Bc67cJaKblhZN/SQRKhgCm/RCppEDtTmJzM48o0UYbtcHFJalYoYGaNfI9NDTAhRGeAJqq0ET2MF1Ts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=uOeyXgw1; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="uOeyXgw1" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 742512C012B; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=Iz/5Wmx6vYq4KfW4FdtZTS8j0NRcbAdMtTuLit7NagI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uOeyXgw1KDFB4S5e8F4KOrJwjXyMXiXW9YGUoQEq/pKbb5wwKbM8lhPYdyCfJkRmd gMzt50r8MByjd4shuffV1K/ZWmFyMal/gXfp6Lp9DDN2S3Op7bTDW6j0vy0VZjwgEl KpYx8yleHQcbnYsonqaojXp2JnguEcxCg/O96FDluhENtiEKfX4Nzd0pX8+TckVW+a SfTYiCWrSvpCQDI9tf9S9oF/JoRCALf9hndL6H2q8PXstmWaECT1vOM9JwrvnKYCJ0 hkE5t9ks+BARdJbcec0hRXLRM9UOBGrqRjufx74+78W7zktCxcNyvo6IDwIS4tDQ91 TYfftQBk2aItw== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 1ACC213EE87; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 19894280532; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 5/6] mips: dts: realtek: Add I2C controllers Date: Thu, 26 Sep 2024 09:58:46 +1200 Message-ID: <20240925215847.3594898-6-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=8-27D3ImJB-g1dBfIooA:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" Add the I2C controllers that are part of the RTL9300 SoC. Signed-off-by: Chris Packham Reviewed-by: Krzysztof Kozlowski --- Notes: Changes in v5: - Update compatibles Changes in v4: - Skipped due to combining patch series Changes in v3: - None Changes in v2: - Use reg property arch/mips/boot/dts/realtek/rtl9302c.dtsi | 8 ++++++++ arch/mips/boot/dts/realtek/rtl930x.dtsi | 16 ++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/arch/mips/boot/dts/realtek/rtl9302c.dtsi b/arch/mips/boot/dts/= realtek/rtl9302c.dtsi index 80d9f407e758..56c35e8b8b62 100644 --- a/arch/mips/boot/dts/realtek/rtl9302c.dtsi +++ b/arch/mips/boot/dts/realtek/rtl9302c.dtsi @@ -5,3 +5,11 @@ &switch0 { compatible =3D "realtek,rtl9302c-switch", "realtek,rtl9300-switch", "sysc= on", "simple-mfd"; }; + +&i2c0 { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; +}; + +&i2c1 { + compatible =3D "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c"; +}; diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/r= ealtek/rtl930x.dtsi index 89b8854596cd..2fb8461af575 100644 --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi @@ -41,6 +41,22 @@ reboot@c { reg =3D <0x0c 0x4>; value =3D <0x01>; }; + + i2c0: i2c@36c { + compatible =3D "realtek,rtl9300-i2c"; + reg =3D <0x36c 0x14>; + status =3D "disabled"; + #address-cells =3D <1>; + #size-cells =3D <0>; + }; + + i2c1: i2c@388 { + compatible =3D "realtek,rtl9300-i2c"; + reg =3D <0x388 0x14>; + status =3D "disabled"; + #address-cells =3D <1>; + #size-cells =3D <0>; + }; }; }; =20 --=20 2.46.2 From nobody Fri Nov 29 01:35:14 2024 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565A717C9A9 for ; Wed, 25 Sep 2024 22:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301618; cv=none; b=gThF6OTc13rsrUlNDjvR/KxJGIIexA+S4dk48ISLWfIOY/kABxMBR5UOGjUIS0D6KYi8p2qshiGNSRJVDrYFx3DE+9JayFO0DaX8N+gx3KxyGhj5Lyiz64Ntw4NY8+HabjU4BEkl+z+afey4B8H7J3PZ73efIPIu6j8QCYcbArI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301618; c=relaxed/simple; bh=eR0VPBJjH+p15Nx8QDxJ3L7rS8n7yehCEe7pb4TXfUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rn0P/130rZ6EiGutfyd6pod5t0kNQL6ucjpEL2gDXOUCdPe/v5mvpFrOijCm6lSquEBF/fE8D8UQB1JgNqClxKpTEcLeANcclWSEdJf7Tyrmot4k+IAmGu9IDSBVJMCSVh3lOjoNJOxYIycA5P9l5vwGwJwWBVEooWXi/7ozIl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=q2H8nXIj; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="q2H8nXIj" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id B771F2C0613; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1727301602; bh=xnDhSlCYTZ7a98did69fDnK8F3pZq1fD0GSB/W+bC/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q2H8nXIjhkReyaIKqynS3Mx148ruZmJfpY6snn0Essh7Pw+oNwdaIKCwSDQlJ9TN4 j/MxuHWuk5TRXcboWqFlhptdmePWGzxAmMzWmhdKs/S31i3tlY0ayTLJpGxP3Mos/o 5Z0In+0F93YcPXpMuR6etnJz8nh+39lswL9ac3vPJvx2V8Zj6j8SwuRZ9LeCOAkaTv yT/dQDo8BLNVfv+IVVEvKZKrAxfbQbk3lt9EndVAaMecJV5SYXdZ2XMGdYhkFZdw5m ni1gRQqozU3G+yuqMiLT6YxHtGjLyW5uAcq/+DdoR4/w3bWypwPPrqNb7NgTCf6V2N dWV3N8MIzrtzQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Thu, 26 Sep 2024 10:00:02 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 1ECE413EE83; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 1DC9B280532; Thu, 26 Sep 2024 10:00:02 +1200 (NZST) From: Chris Packham To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: [PATCH v5 6/6] i2c: Add driver for the RTL9300 I2C controller Date: Thu, 26 Sep 2024 09:58:47 +1200 Message-ID: <20240925215847.3594898-7-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> References: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.4 cv=Id0kWnqa c=1 sm=1 tr=0 ts=66f487e2 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=EaEq8P2WXUwA:10 a=jdP34snFAAAA:8 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=UgJECxHJAAAA:8 a=aaOI7ajaZ5fHE1syFM0A:9 a=3ZKOabzyN94A:10 a=jlphF6vWLdwq7oh3TaWq:22 a=-El7cUbtino8hM1DCn8D:22 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Content-Type: text/plain; charset="utf-8" Add support for the I2C controller on the RTL9300 SoC. There are two I2C controllers in the RTL9300 that are part of the Ethernet switch register block. Each of these controllers owns a SCL pin (GPIO8 for the fiorst I2C controller, GPIO17 for the second). There are 8 possible SDA pins (GPIO9-16) that can be assigned to either I2C controller. This relationship is represented in the device tree with a child node for each SDA line in use. This is based on the openwrt implementation[1] but has been significantly modified [1] - https://git.openwrt.org/?p=3Dopenwrt/openwrt.git;a=3Dblob;f=3Dtarget/= linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c Signed-off-by: Chris Packham --- Notes: Changes in v5: - Make lock part of struct rtl9300_i2c - Fix alignment in rtl9300_i2c_smbus_xfer Changes in v4: - skipped due to combining patch series Changes in v3: - None Changes in v2: - Replace a number of return 0; with tail calls - Add enum rtl9300_bus_freq - Use RTL9300_ prefix on new defines - Use reg property for register offset - Hard code RTL9300_I2C_MST_GLB_CTRL address as this does not need to come from DT binding - Use GENMASK() where appropriate - Propagate read/write errors through to rtl9300_i2c_smbus_xfer() - Don't error out on bad clock-frequency - Use devm_i2c_add_adapter() - Put more information in the commit message - Integrated multiplexing function, an adapter is created per SDA line MAINTAINERS | 7 + drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-rtl9300.c | 422 +++++++++++++++++++++++++++++++ 4 files changed, 440 insertions(+) create mode 100644 drivers/i2c/busses/i2c-rtl9300.c diff --git a/MAINTAINERS b/MAINTAINERS index f328373463b0..9e123e9839a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19887,6 +19887,13 @@ S: Maintained T: git https://github.com/pkshih/rtw.git F: drivers/net/wireless/realtek/rtl8xxxu/ =20 +RTL9300 I2C DRIVER (rtl9300-i2c) +M: Chris Packham +L: linux-i2c@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml +F: drivers/i2c/busses/i2c-rtl9300.c + RTRS TRANSPORT DRIVERS M: Md. Haris Iqbal M: Jack Wang diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index a22f9125322a..927b583002c7 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -1041,6 +1041,16 @@ config I2C_RK3X This driver can also be built as a module. If so, the module will be called i2c-rk3x. =20 +config I2C_RTL9300 + tristate "Realtek RTL9300 I2C controller" + depends on MACH_REALTEK_RTL || COMPILE_TEST + help + Say Y here to include support for the I2C controller in Realtek + RTL9300 SoCs. + + This driver can also be built as a module. If so, the module will + be called i2c-rtl9300. + config I2C_RZV2M tristate "Renesas RZ/V2M adapter" depends on ARCH_RENESAS || COMPILE_TEST diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile index 78d0561339e5..ac2f9f22803c 100644 --- a/drivers/i2c/busses/Makefile +++ b/drivers/i2c/busses/Makefile @@ -102,6 +102,7 @@ obj-$(CONFIG_I2C_QCOM_GENI) +=3D i2c-qcom-geni.o obj-$(CONFIG_I2C_QUP) +=3D i2c-qup.o obj-$(CONFIG_I2C_RIIC) +=3D i2c-riic.o obj-$(CONFIG_I2C_RK3X) +=3D i2c-rk3x.o +obj-$(CONFIG_I2C_RTL9300) +=3D i2c-rtl9300.o obj-$(CONFIG_I2C_RZV2M) +=3D i2c-rzv2m.o obj-$(CONFIG_I2C_S3C2410) +=3D i2c-s3c2410.o obj-$(CONFIG_I2C_SH7760) +=3D i2c-sh7760.o diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9= 300.c new file mode 100644 index 000000000000..ed9a45a9d803 --- /dev/null +++ b/drivers/i2c/busses/i2c-rtl9300.c @@ -0,0 +1,422 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include +#include +#include + +enum rtl9300_bus_freq { + RTL9300_I2C_STD_FREQ, + RTL9300_I2C_FAST_FREQ, +}; + +struct rtl9300_i2c; + +struct rtl9300_i2c_chan { + struct i2c_adapter adap; + struct rtl9300_i2c *i2c; + enum rtl9300_bus_freq bus_freq; + u8 sda_pin; +}; + +#define RTL9300_I2C_MUX_NCHAN 8 + +struct rtl9300_i2c { + struct regmap *regmap; + struct device *dev; + struct rtl9300_i2c_chan chans[RTL9300_I2C_MUX_NCHAN]; + u32 reg_base; + u8 sda_pin; + struct mutex lock; +}; + +#define RTL9300_I2C_MST_CTRL1 0x0 +#define RTL9300_I2C_MST_CTRL1_MEM_ADDR_OFS 8 +#define RTL9300_I2C_MST_CTRL1_MEM_ADDR_MASK GENMASK(31, 8) +#define RTL9300_I2C_MST_CTRL1_SDA_OUT_SEL_OFS 4 +#define RTL9300_I2C_MST_CTRL1_SDA_OUT_SEL_MASK GENMASK(6, 4) +#define RTL9300_I2C_MST_CTRL1_GPIO_SCL_SEL BIT(3) +#define RTL9300_I2C_MST_CTRL1_RWOP BIT(2) +#define RTL9300_I2C_MST_CTRL1_I2C_FAIL BIT(1) +#define RTL9300_I2C_MST_CTRL1_I2C_TRIG BIT(0) +#define RTL9300_I2C_MST_CTRL2 0x4 +#define RTL9300_I2C_MST_CTRL2_RD_MODE BIT(15) +#define RTL9300_I2C_MST_CTRL2_DEV_ADDR_OFS 8 +#define RTL9300_I2C_MST_CTRL2_DEV_ADDR_MASK GENMASK(14, 8) +#define RTL9300_I2C_MST_CTRL2_DATA_WIDTH_OFS 4 +#define RTL9300_I2C_MST_CTRL2_DATA_WIDTH_MASK GENMASK(7, 4) +#define RTL9300_I2C_MST_CTRL2_MEM_ADDR_WIDTH_OFS 2 +#define RTL9300_I2C_MST_CTRL2_MEM_ADDR_WIDTH_MASK GENMASK(3, 2) +#define RTL9300_I2C_MST_CTRL2_SCL_FREQ_OFS 0 +#define RTL9300_I2C_MST_CTRL2_SCL_FREQ_MASK GENMASK(1, 0) +#define RTL9300_I2C_MST_DATA_WORD0 0x8 +#define RTL9300_I2C_MST_DATA_WORD1 0xc +#define RTL9300_I2C_MST_DATA_WORD2 0x10 +#define RTL9300_I2C_MST_DATA_WORD3 0x14 + +#define RTL9300_I2C_MST_GLB_CTRL 0x384 + +static int rtl9300_i2c_reg_addr_set(struct rtl9300_i2c *i2c, u32 reg, u16 = len) +{ + u32 val, mask; + int ret; + + val =3D len << RTL9300_I2C_MST_CTRL2_MEM_ADDR_WIDTH_OFS; + mask =3D RTL9300_I2C_MST_CTRL2_MEM_ADDR_WIDTH_MASK; + + ret =3D regmap_update_bits(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_C= TRL2, mask, val); + if (ret) + return ret; + + val =3D reg << RTL9300_I2C_MST_CTRL1_MEM_ADDR_OFS; + mask =3D RTL9300_I2C_MST_CTRL1_MEM_ADDR_MASK; + + return regmap_update_bits(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_CT= RL1, mask, val); +} + +static int rtl9300_i2c_config_io(struct rtl9300_i2c *i2c, u8 sda_pin) +{ + int ret; + u32 val, mask; + + ret =3D regmap_update_bits(i2c->regmap, RTL9300_I2C_MST_GLB_CTRL, BIT(sda= _pin), BIT(sda_pin)); + if (ret) + return ret; + + val =3D (sda_pin << RTL9300_I2C_MST_CTRL1_SDA_OUT_SEL_OFS) | + RTL9300_I2C_MST_CTRL1_GPIO_SCL_SEL; + mask =3D RTL9300_I2C_MST_CTRL1_SDA_OUT_SEL_MASK | RTL9300_I2C_MST_CTRL1_G= PIO_SCL_SEL; + + return regmap_update_bits(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_CT= RL1, mask, val); +} + +static int rtl9300_i2c_config_xfer(struct rtl9300_i2c *i2c, struct rtl9300= _i2c_chan *chan, + u16 addr, u16 len) +{ + u32 val, mask; + + val =3D chan->bus_freq << RTL9300_I2C_MST_CTRL2_SCL_FREQ_OFS; + mask =3D RTL9300_I2C_MST_CTRL2_SCL_FREQ_MASK; + + val |=3D addr << RTL9300_I2C_MST_CTRL2_DEV_ADDR_OFS; + mask |=3D RTL9300_I2C_MST_CTRL2_DEV_ADDR_MASK; + + val |=3D ((len - 1) & 0xf) << RTL9300_I2C_MST_CTRL2_DATA_WIDTH_OFS; + mask |=3D RTL9300_I2C_MST_CTRL2_DATA_WIDTH_MASK; + + mask |=3D RTL9300_I2C_MST_CTRL2_RD_MODE; + + return regmap_update_bits(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_CT= RL2, mask, val); +} + +static int rtl9300_i2c_read(struct rtl9300_i2c *i2c, u8 *buf, int len) +{ + u32 vals[4] =3D {}; + int i, ret; + + if (len > 16) + return -EIO; + + ret =3D regmap_bulk_read(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_DAT= A_WORD0, + vals, ARRAY_SIZE(vals)); + if (ret) + return ret; + + for (i =3D 0; i < len; i++) { + buf[i] =3D vals[i/4] & 0xff; + vals[i/4] >>=3D 8; + } + + return 0; +} + +static int rtl9300_i2c_write(struct rtl9300_i2c *i2c, u8 *buf, int len) +{ + u32 vals[4] =3D {}; + int i; + + if (len > 16) + return -EIO; + + for (i =3D 0; i < len; i++) { + if (i % 4 =3D=3D 0) + vals[i/4] =3D 0; + vals[i/4] <<=3D 8; + vals[i/4] |=3D buf[i]; + } + + return regmap_bulk_write(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_DAT= A_WORD0, + vals, ARRAY_SIZE(vals)); +} + +static int rtl9300_i2c_writel(struct rtl9300_i2c *i2c, u32 data) +{ + return regmap_write(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_DATA_WOR= D0, data); +} + +static int rtl9300_i2c_execute_xfer(struct rtl9300_i2c *i2c, char read_wri= te, + int size, union i2c_smbus_data *data, int len) +{ + u32 val, mask; + int ret; + + val =3D read_write =3D=3D I2C_SMBUS_WRITE ? RTL9300_I2C_MST_CTRL1_RWOP : = 0; + mask =3D RTL9300_I2C_MST_CTRL1_RWOP; + + val |=3D RTL9300_I2C_MST_CTRL1_I2C_TRIG; + mask |=3D RTL9300_I2C_MST_CTRL1_I2C_TRIG; + + ret =3D regmap_update_bits(i2c->regmap, i2c->reg_base + RTL9300_I2C_MST_C= TRL1, mask, val); + if (ret) + return ret; + + ret =3D regmap_read_poll_timeout(i2c->regmap, i2c->reg_base + RTL9300_I2C= _MST_CTRL1, + val, !(val & RTL9300_I2C_MST_CTRL1_I2C_TRIG), 100, 2000); + if (ret) + return ret; + + if (val & RTL9300_I2C_MST_CTRL1_I2C_FAIL) + return -EIO; + + if (read_write =3D=3D I2C_SMBUS_READ) { + if (size =3D=3D I2C_SMBUS_BYTE || size =3D=3D I2C_SMBUS_BYTE_DATA) { + ret =3D regmap_read(i2c->regmap, + i2c->reg_base + RTL9300_I2C_MST_DATA_WORD0, &val); + if (ret) + return ret; + data->byte =3D val & 0xff; + } else if (size =3D=3D I2C_SMBUS_WORD_DATA) { + ret =3D regmap_read(i2c->regmap, + i2c->reg_base + RTL9300_I2C_MST_DATA_WORD0, &val); + if (ret) + return ret; + data->word =3D val & 0xffff; + } else { + ret =3D rtl9300_i2c_read(i2c, &data->block[0], len); + if (ret) + return ret; + } + } + + return 0; +} + +static int rtl9300_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, unsi= gned short flags, + char read_write, u8 command, int size, + union i2c_smbus_data *data) +{ + struct rtl9300_i2c_chan *chan =3D i2c_get_adapdata(adap); + struct rtl9300_i2c *i2c =3D chan->i2c; + int len =3D 0, ret; + + mutex_lock(&i2c->lock); + if (chan->sda_pin !=3D i2c->sda_pin) { + ret =3D rtl9300_i2c_config_io(i2c, chan->sda_pin); + if (ret) + goto out_unlock; + i2c->sda_pin =3D chan->sda_pin; + } + + switch (size) { + case I2C_SMBUS_QUICK: + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, 0); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_reg_addr_set(i2c, 0, 0); + if (ret) + goto out_unlock; + break; + + case I2C_SMBUS_BYTE: + if (read_write =3D=3D I2C_SMBUS_WRITE) { + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, 0); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_reg_addr_set(i2c, command, 1); + if (ret) + goto out_unlock; + } else { + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, 1); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_reg_addr_set(i2c, 0, 0); + if (ret) + goto out_unlock; + } + break; + + case I2C_SMBUS_BYTE_DATA: + ret =3D rtl9300_i2c_reg_addr_set(i2c, command, 1); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, 1); + if (ret) + goto out_unlock; + if (read_write =3D=3D I2C_SMBUS_WRITE) { + ret =3D rtl9300_i2c_writel(i2c, data->byte); + if (ret) + goto out_unlock; + } + break; + + case I2C_SMBUS_WORD_DATA: + ret =3D rtl9300_i2c_reg_addr_set(i2c, command, 1); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, 2); + if (ret) + goto out_unlock; + if (read_write =3D=3D I2C_SMBUS_WRITE) { + ret =3D rtl9300_i2c_writel(i2c, data->word); + if (ret) + goto out_unlock; + } + break; + + case I2C_SMBUS_BLOCK_DATA: + ret =3D rtl9300_i2c_reg_addr_set(i2c, command, 1); + if (ret) + goto out_unlock; + ret =3D rtl9300_i2c_config_xfer(i2c, chan, addr, data->block[0]); + if (ret) + goto out_unlock; + if (read_write =3D=3D I2C_SMBUS_WRITE) { + ret =3D rtl9300_i2c_write(i2c, &data->block[1], data->block[0]); + if (ret) + goto out_unlock; + } + len =3D data->block[0]; + break; + + default: + dev_err(&adap->dev, "Unsupported transaction %d\n", size); + ret =3D -EOPNOTSUPP; + goto out_unlock; + } + + ret =3D rtl9300_i2c_execute_xfer(i2c, read_write, size, data, len); + +out_unlock: + mutex_unlock(&i2c->lock); + + return ret; +} + +static u32 rtl9300_i2c_func(struct i2c_adapter *a) +{ + return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE | + I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA | + I2C_FUNC_SMBUS_BLOCK_DATA; +} + +static const struct i2c_algorithm rtl9300_i2c_algo =3D { + .smbus_xfer =3D rtl9300_i2c_smbus_xfer, + .functionality =3D rtl9300_i2c_func, +}; + +struct i2c_adapter_quirks rtl9300_i2c_quirks =3D { + .flags =3D I2C_AQ_NO_CLK_STRETCH, + .max_read_len =3D 16, + .max_write_len =3D 16, +}; + +static int rtl9300_i2c_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct rtl9300_i2c_chan *chan; + struct rtl9300_i2c *i2c; + struct i2c_adapter *adap; + u32 clock_freq, sda_pin; + int ret, i =3D 0; + struct fwnode_handle *child; + + i2c =3D devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL); + if (!i2c) + return -ENOMEM; + + i2c->regmap =3D syscon_node_to_regmap(dev->parent->of_node); + if (IS_ERR(i2c->regmap)) + return PTR_ERR(i2c->regmap); + i2c->dev =3D dev; + + mutex_init(&i2c->lock); + + ret =3D device_property_read_u32(dev, "reg", &i2c->reg_base); + if (ret) + return ret; + + platform_set_drvdata(pdev, i2c); + + if (device_get_child_node_count(dev) >=3D RTL9300_I2C_MUX_NCHAN) + return dev_err_probe(dev, -EINVAL, "Too many channels\n"); + + device_for_each_child_node(dev, child) { + chan =3D &i2c->chans[i]; + adap =3D &chan->adap; + + ret =3D fwnode_property_read_u32(child, "reg", &sda_pin); + if (ret) + return ret; + + ret =3D fwnode_property_read_u32(child, "clock-frequency", &clock_freq); + if (ret) + clock_freq =3D I2C_MAX_STANDARD_MODE_FREQ; + + switch (clock_freq) { + case I2C_MAX_STANDARD_MODE_FREQ: + chan->bus_freq =3D RTL9300_I2C_STD_FREQ; + break; + + case I2C_MAX_FAST_MODE_FREQ: + chan->bus_freq =3D RTL9300_I2C_FAST_FREQ; + break; + default: + dev_warn(i2c->dev, "SDA%d clock-frequency %d not supported using defaul= t\n", + sda_pin, clock_freq); + break; + } + + chan->sda_pin =3D sda_pin; + chan->i2c =3D i2c; + adap =3D &i2c->chans[i].adap; + adap->owner =3D THIS_MODULE; + adap->algo =3D &rtl9300_i2c_algo; + adap->quirks =3D &rtl9300_i2c_quirks; + adap->retries =3D 3; + adap->dev.parent =3D dev; + i2c_set_adapdata(adap, chan); + adap->dev.of_node =3D to_of_node(child); + snprintf(adap->name, sizeof(adap->name), "%s SDA%d\n", dev_name(dev), sd= a_pin); + i++; + + ret =3D devm_i2c_add_adapter(dev, adap); + if (ret) + return ret; + } + i2c->sda_pin =3D 0xff; + + return 0; +} + +static const struct of_device_id i2c_rtl9300_dt_ids[] =3D { + { .compatible =3D "realtek,rtl9300-i2c" }, + {} +}; +MODULE_DEVICE_TABLE(of, i2c_rtl9300_dt_ids); + +static struct platform_driver rtl9300_i2c_driver =3D { + .probe =3D rtl9300_i2c_probe, + .driver =3D { + .name =3D "i2c-rtl9300", + .of_match_table =3D i2c_rtl9300_dt_ids, + }, +}; + +module_platform_driver(rtl9300_i2c_driver); + +MODULE_DESCRIPTION("RTL9300 I2C controller driver"); +MODULE_LICENSE("GPL"); --=20 2.46.2