From nobody Fri Nov 29 00:46:26 2024 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632374C91 for ; Wed, 25 Sep 2024 21:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301150; cv=none; b=RV0LcvbnWmdBZO/3ulm/+WvLjGPsbM6IRBdXs+thqy6BGpsmgM4MPFnIXo+ZMCYfeCyS3pRgVho2Iy6QL9BxU1Vh72/rekgVE+qyFXlbpDT6L55JudE416lL3XBW/X84ZyaOKCzV0n08DEjxE4wP99t+6FvQ7TKdrZQY4mL3hUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727301150; c=relaxed/simple; bh=mBPd2UCzvnTfqFzycLAMTDiN5hIG6/mLwH9b3aFZzCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xi4aFT2csPmXPpPs9j4GLehuIOYYF2DG4F/5KsFDZBzT1tkw6cQFu+iuirodbMTRsRnmNQgAccFu+P9GC96C2kBj0mwLycyjhHLvsftStD/ytKyPBa3eqdz31SgKAJ65MU8v3HvVY3hLohPmaptMh1B6Kwi6MBYjpPVFVfI9yK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ixYWtfTx; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ixYWtfTx" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e091682cfbso226215a91.0 for ; Wed, 25 Sep 2024 14:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727301147; x=1727905947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8IMFZ7ULuyZoDeN1Acj+MYR2DjqIALKpB6PITKWqATw=; b=ixYWtfTxavCkcaSFMpnu3ZQ81/ibWjCQCWGKE30jd8Rw2Ao7UmHzF3ftZvGt44hhEA lRgUFo1WaJOUF8CYBVlBwA8ipMV/I2Qxdi7bcWhcNB3SgQBtBkqn7x7LdsT2cSHIL9f5 efH6JYYA2Q3nfv06Zy1KQo7p9+EpoEAly3E6VwfzGC+ZAjfRw/SsmDJH3SMRPUTKX2AZ uG2N2GfeuU37ugJ/bg1v1pT395R2OPvZSO5QyIm37oT87eoycZ6zQ7g9iIhRTjZXym4d q59jkxAdBirZ6HIywVs7fAEiUgnLLneCpxXujIMVknECwkp/ip4zpGh5idS/u8DUgdTV o5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727301147; x=1727905947; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8IMFZ7ULuyZoDeN1Acj+MYR2DjqIALKpB6PITKWqATw=; b=klWkVosYbXm9iUmXpgGPWBv6jEfHov11XO3O/9KL/cwtVw7dOJ+Eq+LFyJCzbVRyJe luvUMrmRdVepeZOUJ9Qt2gZFKzXYdvmjJfVtIsY/tbxhkyJ/noP5ZZgeWRWxg/QMhvLZ B7PkFLA2JpMR3+0zdgCAUF144HlDyC5JZQDM5byyBaK573/GNCWZUQ1hAsYHPI37FZM/ eTBFrj6XJg0pon03vK9H4RNjB/W1VRVt8HzRq+sQe1An08lzDKbGEoPSLk61Hd6QTPov DA6oD/fEsXqRtn589HjZfflDC7eN6SDKmQlwh1CtZp2rEc1j6Isy/9i7+Jy9TeyzMOSn iKtQ== X-Gm-Message-State: AOJu0YzKV372l3izLWBB1qsob4VOfe+j+s9ZLK3cZJU+SESGxmiMnaxg QNK642MPX09M6uW4WUwR13nE75CVMnGxasdzjyxUFGbWA9HxXbsRmtRhZA== X-Google-Smtp-Source: AGHT+IGxpDjLe0Rr8KWwNkwR6rNOLn/iR5DPJ5ofvU0M7fpSWRGZEHEAg5BcHVbEc08rsZgPRAfD9Q== X-Received: by 2002:a17:90a:6b08:b0:2e0:7b35:31ce with SMTP id 98e67ed59e1d1-2e07b3532cfmr3086721a91.34.1727301147217; Wed, 25 Sep 2024 14:52:27 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2a00:79e0:2e14:7:a7cb:a943:3ef3:3eee]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e19c318sm1957356a91.1.2024.09.25.14.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 14:52:26 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong , Chao Yu Subject: [PATCH v3] f2fs: introduce device aliasing file Date: Wed, 25 Sep 2024 14:52:21 -0700 Message-ID: <20240925215221.3045262-1-daeho43@gmail.com> X-Mailer: git-send-email 2.46.0.792.g87dc391469-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Daeho Jeong F2FS should understand how the device aliasing file works and support deleting the file after use. A device aliasing file can be created by mkfs.f2fs tool and it can map the whole device with an extrent, not using node blocks. The file space should be pinned and normally used for read-only usages. Signed-off-by: Daeho Jeong Signed-off-by: Chao Yu --- v3: merged Chao's extent cache sanity check. prevented device aliasing support with noextent mount option v2: changed the position of f2fs_destroy_extent_tree() only for device aliasing files --- fs/f2fs/data.c | 5 +++++ fs/f2fs/extent_cache.c | 45 +++++++++++++++++++++++++++++++++++++++++- fs/f2fs/f2fs.h | 5 +++++ fs/f2fs/file.c | 36 +++++++++++++++++++++++++++++---- fs/f2fs/inode.c | 12 ++++++++++- fs/f2fs/super.c | 4 ++++ fs/f2fs/sysfs.c | 2 ++ 7 files changed, 103 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index b94cf6eea2f9..385b46e62ede 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3441,6 +3441,11 @@ static int prepare_write_begin(struct f2fs_sb_info *= sbi, =20 if (!f2fs_lookup_read_extent_cache_block(inode, index, &dn.data_blkaddr)) { + if (IS_DEVICE_ALIASING(inode)) { + err =3D -ENODATA; + goto out; + } + if (locked) { err =3D f2fs_reserve_block(&dn, index); goto out; diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c index 62ac440d9416..019c1f7b7fa5 100644 --- a/fs/f2fs/extent_cache.c +++ b/fs/f2fs/extent_cache.c @@ -24,6 +24,7 @@ bool sanity_check_extent_cache(struct inode *inode, struc= t page *ipage) struct f2fs_sb_info *sbi =3D F2FS_I_SB(inode); struct f2fs_extent *i_ext =3D &F2FS_INODE(ipage)->i_ext; struct extent_info ei; + int devi; =20 get_read_extent_info(&ei, i_ext); =20 @@ -38,7 +39,36 @@ bool sanity_check_extent_cache(struct inode *inode, stru= ct page *ipage) ei.blk, ei.fofs, ei.len); return false; } - return true; + + if (!IS_DEVICE_ALIASING(inode)) + return true; + + for (devi =3D 0; devi < sbi->s_ndevs; devi++) { + if (FDEV(devi).start_blk !=3D ei.blk || + FDEV(devi).end_blk !=3D ei.blk + ei.len - 1) + continue; + + if (devi =3D=3D 0) { + f2fs_warn(sbi, + "%s: inode (ino=3D%lx) is an alias of meta device", + __func__, inode->i_ino); + return false; + } + + if (bdev_is_zoned(FDEV(devi).bdev)) { + f2fs_warn(sbi, + "%s: device alias inode (ino=3D%lx)'s extent info " + "[%u, %u, %u] maps to zoned block device", + __func__, inode->i_ino, ei.blk, ei.fofs, ei.len); + return false; + } + return true; + } + + f2fs_warn(sbi, "%s: device alias inode (ino=3D%lx)'s extent info " + "[%u, %u, %u] is inconsistent w/ any devices", + __func__, inode->i_ino, ei.blk, ei.fofs, ei.len); + return false; } =20 static void __set_extent_info(struct extent_info *ei, @@ -76,6 +106,9 @@ static bool __init_may_extent_tree(struct inode *inode, = enum extent_type type) =20 static bool __may_extent_tree(struct inode *inode, enum extent_type type) { + if (IS_DEVICE_ALIASING(inode) && type =3D=3D EX_READ) + return true; + /* * for recovered files during mount do not create extents * if shrinker is not registered. @@ -401,6 +434,11 @@ void f2fs_init_read_extent_tree(struct inode *inode, s= truct page *ipage) if (atomic_read(&et->node_cnt) || !ei.len) goto skip; =20 + if (IS_DEVICE_ALIASING(inode)) { + et->largest =3D ei; + goto skip; + } + en =3D __attach_extent_node(sbi, et, &ei, NULL, &et->root.rb_root.rb_node, true); if (en) { @@ -463,6 +501,11 @@ static bool __lookup_extent_tree(struct inode *inode, = pgoff_t pgofs, goto out; } =20 + if (IS_DEVICE_ALIASING(inode)) { + ret =3D false; + goto out; + } + en =3D __lookup_extent_node(&et->root, et->cached_en, pgofs); if (!en) goto out; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 33f5449dc22d..b6ba22a1da47 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -213,6 +213,7 @@ struct f2fs_mount_info { #define F2FS_FEATURE_CASEFOLD 0x00001000 #define F2FS_FEATURE_COMPRESSION 0x00002000 #define F2FS_FEATURE_RO 0x00004000 +#define F2FS_FEATURE_DEVICE_ALIAS 0x00008000 =20 #define __F2FS_HAS_FEATURE(raw_super, mask) \ ((raw_super->feature & cpu_to_le32(mask)) !=3D 0) @@ -3046,6 +3047,7 @@ static inline void f2fs_change_bit(unsigned int nr, c= har *addr) #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories onl= y) */ #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ +#define F2FS_DEVICE_ALIAS_FL 0x80000000 /* File for aliasing a device */ =20 #define F2FS_QUOTA_DEFAULT_FL (F2FS_NOATIME_FL | F2FS_IMMUTABLE_FL) =20 @@ -3061,6 +3063,8 @@ static inline void f2fs_change_bit(unsigned int nr, c= har *addr) /* Flags that are appropriate for non-directories/regular files. */ #define F2FS_OTHER_FLMASK (F2FS_NODUMP_FL | F2FS_NOATIME_FL) =20 +#define IS_DEVICE_ALIASING(inode) (F2FS_I(inode)->i_flags & F2FS_DEVICE_AL= IAS_FL) + static inline __u32 f2fs_mask_flags(umode_t mode, __u32 flags) { if (S_ISDIR(mode)) @@ -4510,6 +4514,7 @@ F2FS_FEATURE_FUNCS(sb_chksum, SB_CHKSUM); F2FS_FEATURE_FUNCS(casefold, CASEFOLD); F2FS_FEATURE_FUNCS(compression, COMPRESSION); F2FS_FEATURE_FUNCS(readonly, RO); +F2FS_FEATURE_FUNCS(device_alias, DEVICE_ALIAS); =20 #ifdef CONFIG_BLK_DEV_ZONED static inline bool f2fs_blkz_is_seq(struct f2fs_sb_info *sbi, int devi, diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 99903eafa7fe..f2d2d84d025b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -725,6 +725,11 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 f= rom, bool lock) =20 trace_f2fs_truncate_blocks_enter(inode, from); =20 + if (IS_DEVICE_ALIASING(inode) && from) { + err =3D -EINVAL; + goto out_err; + } + free_from =3D (pgoff_t)F2FS_BLK_ALIGN(from); =20 if (free_from >=3D max_file_blocks(inode)) @@ -739,6 +744,21 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 f= rom, bool lock) goto out; } =20 + if (IS_DEVICE_ALIASING(inode)) { + struct extent_tree *et =3D F2FS_I(inode)->extent_tree[EX_READ]; + struct extent_info ei =3D et->largest; + unsigned int i; + + for (i =3D 0; i < ei.len; i++) + f2fs_invalidate_blocks(sbi, ei.blk + i); + + dec_valid_block_count(sbi, inode, ei.len); + f2fs_update_time(sbi, REQ_TIME); + + f2fs_put_page(ipage, 1); + goto out; + } + if (f2fs_has_inline_data(inode)) { f2fs_truncate_inline_inode(inode, ipage, from); f2fs_put_page(ipage, 1); @@ -774,7 +794,7 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 fr= om, bool lock) /* lastly zero out the first data page */ if (!err) err =3D truncate_partial_data_page(inode, from, truncate_page); - +out_err: trace_f2fs_truncate_blocks_exit(inode, err); return err; } @@ -992,7 +1012,8 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentr= y *dentry, return -EPERM; =20 if ((attr->ia_valid & ATTR_SIZE)) { - if (!f2fs_is_compress_backend_ready(inode)) + if (!f2fs_is_compress_backend_ready(inode) || + IS_DEVICE_ALIASING(inode)) return -EOPNOTSUPP; if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED) && !IS_ALIGNED(attr->ia_size, @@ -1860,7 +1881,7 @@ static long f2fs_fallocate(struct file *file, int mod= e, return -EIO; if (!f2fs_is_checkpoint_ready(F2FS_I_SB(inode))) return -ENOSPC; - if (!f2fs_is_compress_backend_ready(inode)) + if (!f2fs_is_compress_backend_ready(inode) || IS_DEVICE_ALIASING(inode)) return -EOPNOTSUPP; =20 /* f2fs only support ->fallocate for regular file */ @@ -3296,6 +3317,9 @@ int f2fs_pin_file_control(struct inode *inode, bool i= nc) struct f2fs_inode_info *fi =3D F2FS_I(inode); struct f2fs_sb_info *sbi =3D F2FS_I_SB(inode); =20 + if (IS_DEVICE_ALIASING(inode)) + return -EINVAL; + if (fi->i_gc_failures >=3D sbi->gc_pin_file_threshold) { f2fs_warn(sbi, "%s: Enable GC =3D ino %lx after %x GC trials", __func__, inode->i_ino, fi->i_gc_failures); @@ -3326,6 +3350,9 @@ static int f2fs_ioc_set_pin_file(struct file *filp, u= nsigned long arg) if (f2fs_readonly(sbi->sb)) return -EROFS; =20 + if (!pin && IS_DEVICE_ALIASING(inode)) + return -EOPNOTSUPP; + ret =3D mnt_want_write_file(filp); if (ret) return ret; @@ -4764,7 +4791,8 @@ static int f2fs_preallocate_blocks(struct kiocb *iocb= , struct iov_iter *iter, else return 0; =20 - map.m_may_create =3D true; + if (!IS_DEVICE_ALIASING(inode)) + map.m_may_create =3D true; if (dio) { map.m_seg_type =3D f2fs_rw_hint_to_seg_type(sbi, inode->i_write_hint); diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 1ed86df343a5..25f66a0ed831 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -372,6 +372,12 @@ static bool sanity_check_inode(struct inode *inode, st= ruct page *node_page) return false; } =20 + if ((fi->i_flags & F2FS_DEVICE_ALIAS_FL) && !f2fs_sb_has_device_alias(sbi= )) { + f2fs_warn(sbi, "%s: inode (ino=3D%lx) has device alias flag, but the fea= ture is off", + __func__, inode->i_ino); + return false; + } + return true; } =20 @@ -823,7 +829,8 @@ void f2fs_evict_inode(struct inode *inode) f2fs_bug_on(sbi, get_dirty_pages(inode)); f2fs_remove_dirty_inode(inode); =20 - f2fs_destroy_extent_tree(inode); + if (!IS_DEVICE_ALIASING(inode)) + f2fs_destroy_extent_tree(inode); =20 if (inode->i_nlink || is_bad_inode(inode)) goto no_delete; @@ -879,6 +886,9 @@ void f2fs_evict_inode(struct inode *inode) goto retry; } =20 + if (IS_DEVICE_ALIASING(inode)) + f2fs_destroy_extent_tree(inode); + if (err) { f2fs_update_inode_page(inode); if (dquot_initialize_needed(inode)) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index fc2c586c7619..95097498b544 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -834,6 +834,10 @@ static int parse_options(struct super_block *sb, char = *options, bool is_remount) set_opt(sbi, READ_EXTENT_CACHE); break; case Opt_noextent_cache: + if (F2FS_HAS_FEATURE(sbi, F2FS_FEATURE_DEVICE_ALIAS)) { + f2fs_err(sbi, "device aliasing requires extent cache"); + return -EINVAL; + } clear_opt(sbi, READ_EXTENT_CACHE); break; case Opt_noinline_data: diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index c56e8c873935..e51304bc65ea 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1313,6 +1313,7 @@ F2FS_SB_FEATURE_RO_ATTR(sb_checksum, SB_CHKSUM); F2FS_SB_FEATURE_RO_ATTR(casefold, CASEFOLD); F2FS_SB_FEATURE_RO_ATTR(compression, COMPRESSION); F2FS_SB_FEATURE_RO_ATTR(readonly, RO); +F2FS_SB_FEATURE_RO_ATTR(device_alias, DEVICE_ALIAS); =20 static struct attribute *f2fs_sb_feat_attrs[] =3D { ATTR_LIST(sb_encryption), @@ -1329,6 +1330,7 @@ static struct attribute *f2fs_sb_feat_attrs[] =3D { ATTR_LIST(sb_casefold), ATTR_LIST(sb_compression), ATTR_LIST(sb_readonly), + ATTR_LIST(sb_device_alias), NULL, }; ATTRIBUTE_GROUPS(f2fs_sb_feat); --=20 2.46.0.792.g87dc391469-goog