From nobody Fri Nov 29 03:58:22 2024 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A7531A01C6; Wed, 25 Sep 2024 12:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268569; cv=none; b=kY1K5LGpyobmi5JGu9UIheP7u89ozePOft4MxlTqP8IM+enhCb1FmIJkuK3SaOmAOtlEbmuI+dL2XUAPcoKdY/p7pi4gs2npITnM29/XGyn6nK4/zS2vL4ngGpgbjHX4LIggUpb9An4wTy9tHJ7AZI+9N3+BAE+/C+4QMouP7pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268569; c=relaxed/simple; bh=LFjwnhTyAbIo1KKyGMp8jpEjC4AjTZYnoigdh3c5MUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nQxaNY2wvwLPH3Je+2JLmVZg92qKsPGtfo8nulJiD3tTKfI9IJtcpx+MfR3Oyf76h/gq+aaVCBQzO+3/wkzu8FWzpNy7kfZR6RGxlNOQJKx9tI/qjoQQLyeK/NUmlIU0gzB2ppytpgZsFEEL7ZkhxWZrqp11wODVN4NhJ14A4pY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=J4g5KDA3; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J4g5KDA3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727268566; x=1758804566; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LFjwnhTyAbIo1KKyGMp8jpEjC4AjTZYnoigdh3c5MUY=; b=J4g5KDA3i1YK8i0cMQj/MAwc7tadK/MxECMlWBa3BAkN1r5UuQ10D3KV RzUCHa96h/m3T6tLLb5x1JTZhEYh3M3K20N97yTQASy5iUSk6l4sSZ0ve s8ywnQrQX1sLuJmebin1HlW2HI/Oy0SnuXCsb0urFHtL+el03ZpnDcvSL FlnPsl1oZdcokK8EuOp6IPGYZktWHjuj4iVnG1Bba4F1OELZge4N3T+gt hmEoa/VNi4pB1MaC5K+7A7HRrMMXUlB6lt/xJZlY0P4ATxhj9erjJ6klt sobYHkaOy5ssid/o0frOqBdzPSkeE5qSSdnAEJFtn0zyRKTrh85SghEDJ A==; X-CSE-ConnectionGUID: PmcskdtbS9a6CHg7NCN0dQ== X-CSE-MsgGUID: 9TTHPTytRe21FS151CKbLw== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36878373" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="36878373" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 05:49:21 -0700 X-CSE-ConnectionGUID: UIlv9BReRSizonPprhY3cA== X-CSE-MsgGUID: jiDsDSyGQu+rzbLAPxRFjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="72577340" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa008.jf.intel.com with ESMTP; 25 Sep 2024 05:49:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9837A192; Wed, 25 Sep 2024 15:49:17 +0300 (EEST) From: Andy Shevchenko To: Mario Limonciello , Andy Shevchenko , Andi Shyti , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 1/5] i2c: designware: Use temporary variable for struct device Date: Wed, 25 Sep 2024 15:44:19 +0300 Message-ID: <20240925124916.976173-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> References: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use temporary variable for struct device to make code neater. Reviewed-by: Mario Limonciello Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko Acked-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-pcidrv.c | 29 ++++++------- drivers/i2c/busses/i2c-designware-platdrv.c | 48 ++++++++++----------- 2 files changed, 37 insertions(+), 40 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busse= s/i2c-designware-pcidrv.c index 7b2c5d71a7fc..433cb285d3b2 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -207,6 +207,7 @@ static const struct software_node dgpu_node =3D { static int i2c_dw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { + struct device *device =3D &pdev->dev; struct dw_i2c_dev *dev; struct i2c_adapter *adap; int r; @@ -214,25 +215,22 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, struct dw_scl_sda_cfg *cfg; =20 if (id->driver_data >=3D ARRAY_SIZE(dw_pci_controllers)) - return dev_err_probe(&pdev->dev, -EINVAL, - "Invalid driver data %ld\n", + return dev_err_probe(device, -EINVAL, "Invalid driver data %ld\n", id->driver_data); =20 controller =3D &dw_pci_controllers[id->driver_data]; =20 r =3D pcim_enable_device(pdev); if (r) - return dev_err_probe(&pdev->dev, r, - "Failed to enable I2C PCI device\n"); + return dev_err_probe(device, r, "Failed to enable I2C PCI device\n"); =20 pci_set_master(pdev); =20 r =3D pcim_iomap_regions(pdev, 1 << 0, pci_name(pdev)); if (r) - return dev_err_probe(&pdev->dev, r, - "I/O memory remapping failed\n"); + return dev_err_probe(device, r, "I/O memory remapping failed\n"); =20 - dev =3D devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); + dev =3D devm_kzalloc(device, sizeof(*dev), GFP_KERNEL); if (!dev) return -ENOMEM; =20 @@ -242,7 +240,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, =20 dev->get_clk_rate_khz =3D controller->get_clk_rate_khz; dev->base =3D pcim_iomap_table(pdev)[0]; - dev->dev =3D &pdev->dev; + dev->dev =3D device; dev->irq =3D pci_irq_vector(pdev, 0); dev->flags |=3D controller->flags; =20 @@ -281,14 +279,14 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, if ((dev->flags & MODEL_MASK) =3D=3D MODEL_AMD_NAVI_GPU) { dev->slave =3D i2c_new_ccgx_ucsi(&dev->adapter, dev->irq, &dgpu_node); if (IS_ERR(dev->slave)) - return dev_err_probe(dev->dev, PTR_ERR(dev->slave), + return dev_err_probe(device, PTR_ERR(dev->slave), "register UCSI failed\n"); } =20 - pm_runtime_set_autosuspend_delay(&pdev->dev, 1000); - pm_runtime_use_autosuspend(&pdev->dev); - pm_runtime_put_autosuspend(&pdev->dev); - pm_runtime_allow(&pdev->dev); + pm_runtime_set_autosuspend_delay(device, 1000); + pm_runtime_use_autosuspend(device); + pm_runtime_put_autosuspend(device); + pm_runtime_allow(device); =20 return 0; } @@ -296,11 +294,12 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, static void i2c_dw_pci_remove(struct pci_dev *pdev) { struct dw_i2c_dev *dev =3D pci_get_drvdata(pdev); + struct device *device =3D &pdev->dev; =20 i2c_dw_disable(dev); =20 - pm_runtime_forbid(&pdev->dev); - pm_runtime_get_noresume(&pdev->dev); + pm_runtime_forbid(device); + pm_runtime_get_noresume(device); =20 i2c_del_adapter(&dev->adapter); } diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/buss= es/i2c-designware-platdrv.c index 2d0c7348e491..a3e86930bf41 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -205,6 +205,7 @@ static void i2c_dw_remove_lock_support(struct dw_i2c_de= v *dev) =20 static int dw_i2c_plat_probe(struct platform_device *pdev) { + struct device *device =3D &pdev->dev; struct i2c_adapter *adap; struct dw_i2c_dev *dev; int irq, ret; @@ -213,15 +214,15 @@ static int dw_i2c_plat_probe(struct platform_device *= pdev) if (irq < 0) return irq; =20 - dev =3D devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL); + dev =3D devm_kzalloc(device, sizeof(*dev), GFP_KERNEL); if (!dev) return -ENOMEM; =20 - dev->flags =3D (uintptr_t)device_get_match_data(&pdev->dev); - if (device_property_present(&pdev->dev, "wx,i2c-snps-model")) + dev->flags =3D (uintptr_t)device_get_match_data(device); + if (device_property_present(device, "wx,i2c-snps-model")) dev->flags =3D MODEL_WANGXUN_SP | ACCESS_POLLING; =20 - dev->dev =3D &pdev->dev; + dev->dev =3D device; dev->irq =3D irq; platform_set_drvdata(pdev, dev); =20 @@ -229,7 +230,7 @@ static int dw_i2c_plat_probe(struct platform_device *pd= ev) if (ret) return ret; =20 - dev->rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); + dev->rst =3D devm_reset_control_get_optional_exclusive(device, NULL); if (IS_ERR(dev->rst)) return PTR_ERR(dev->rst); =20 @@ -246,13 +247,13 @@ static int dw_i2c_plat_probe(struct platform_device *= pdev) i2c_dw_configure(dev); =20 /* Optional interface clock */ - dev->pclk =3D devm_clk_get_optional(&pdev->dev, "pclk"); + dev->pclk =3D devm_clk_get_optional(device, "pclk"); if (IS_ERR(dev->pclk)) { ret =3D PTR_ERR(dev->pclk); goto exit_reset; } =20 - dev->clk =3D devm_clk_get_optional(&pdev->dev, NULL); + dev->clk =3D devm_clk_get_optional(device, NULL); if (IS_ERR(dev->clk)) { ret =3D PTR_ERR(dev->clk); goto exit_reset; @@ -280,28 +281,24 @@ static int dw_i2c_plat_probe(struct platform_device *= pdev) I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED; adap->nr =3D -1; =20 - if (dev->flags & ACCESS_NO_IRQ_SUSPEND) { - dev_pm_set_driver_flags(&pdev->dev, - DPM_FLAG_SMART_PREPARE); - } else { - dev_pm_set_driver_flags(&pdev->dev, - DPM_FLAG_SMART_PREPARE | - DPM_FLAG_SMART_SUSPEND); - } + if (dev->flags & ACCESS_NO_IRQ_SUSPEND) + dev_pm_set_driver_flags(device, DPM_FLAG_SMART_PREPARE); + else + dev_pm_set_driver_flags(device, DPM_FLAG_SMART_PREPARE | DPM_FLAG_SMART_= SUSPEND); =20 - device_enable_async_suspend(&pdev->dev); + device_enable_async_suspend(device); =20 /* The code below assumes runtime PM to be disabled. */ - WARN_ON(pm_runtime_enabled(&pdev->dev)); + WARN_ON(pm_runtime_enabled(device)); =20 - pm_runtime_set_autosuspend_delay(&pdev->dev, 1000); - pm_runtime_use_autosuspend(&pdev->dev); - pm_runtime_set_active(&pdev->dev); + pm_runtime_set_autosuspend_delay(device, 1000); + pm_runtime_use_autosuspend(device); + pm_runtime_set_active(device); =20 if (dev->shared_with_punit) - pm_runtime_get_noresume(&pdev->dev); + pm_runtime_get_noresume(device); =20 - pm_runtime_enable(&pdev->dev); + pm_runtime_enable(device); =20 ret =3D i2c_dw_probe(dev); if (ret) @@ -319,15 +316,16 @@ static int dw_i2c_plat_probe(struct platform_device *= pdev) static void dw_i2c_plat_remove(struct platform_device *pdev) { struct dw_i2c_dev *dev =3D platform_get_drvdata(pdev); + struct device *device =3D &pdev->dev; =20 - pm_runtime_get_sync(&pdev->dev); + pm_runtime_get_sync(device); =20 i2c_del_adapter(&dev->adapter); =20 i2c_dw_disable(dev); =20 - pm_runtime_dont_use_autosuspend(&pdev->dev); - pm_runtime_put_sync(&pdev->dev); + pm_runtime_dont_use_autosuspend(device); + pm_runtime_put_sync(device); dw_i2c_plat_pm_cleanup(dev); =20 i2c_dw_remove_lock_support(dev); --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Fri Nov 29 03:58:22 2024 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DECB71A00D7; Wed, 25 Sep 2024 12:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268566; cv=none; b=a4Uj+oxbtBW9z6VtZ4qSf1DvvWfqemM2cKxdtmG88aYuNAu3IWCBb9bK6LxfqCfQXUNaCdIwBv+is7aHRRi59Mrg+cAemsP2I3Sz/TlVef2VlzMmuQVn4OLtsWxshyIpSA+xico8ENMqBqBs4IDZ4dP+jDFPpVC3itIz4ejUyQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268566; c=relaxed/simple; bh=lGffxdgbxA4Ec1+1dFqnZHBgqwkMxcDxvgZGQYPLLXU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sIUIMfSU+Ad3c/GJJvlM3tNhtbYPMGGGXTV4WleHUXPRy4CoVC3g/aToLPAClG8brG+7CaYwBBJLfXeNqbCG2MSUcSGsbHRLDBYtGgu1+NTbNcoq3VNPmaUH4xjpSwIsHUPD41lVP2PJONf7Z5+wudWtXtEUdymnyEPAIZUPb9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=e3LLQDOc; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="e3LLQDOc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727268565; x=1758804565; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lGffxdgbxA4Ec1+1dFqnZHBgqwkMxcDxvgZGQYPLLXU=; b=e3LLQDOchFud3hM49qy/+g7QbSFt87iqWX40ObFYgecamqvxnV4lH6x8 aeegyA6teVA2QK2dJ4jgQ5TuxLFYVELLIGRAItedQAVv0EVzPDUhikvHe T/ca2+Gtp6wBaMGMXZlMe+t+q1YSaHraqo6d9K5VM2ipQeZmV62to1nWI KlzIsm49LESKZPylRvkI72L7CeD8T/J1WVcPOHdoFnBfZHEzaUGbW/Egn hA/ZHT6tG14yBoLtOYtTPntC7L7cQbrfpf5IjXHT/hWXfjG0sFMawFXz4 7of3evkPrPDEOg8232I0HxUXYQgfvkx1JEFXaAqm5J8lXqlsFtqRQ1H5e A==; X-CSE-ConnectionGUID: 0MbAETJTQkGec2tdzKoJ4g== X-CSE-MsgGUID: +2vMJ4x5SDK/qyS8Qt+TcQ== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36878367" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="36878367" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 05:49:21 -0700 X-CSE-ConnectionGUID: 4aol0lnySXmY0UyxzzPSyA== X-CSE-MsgGUID: A9X9JXooRuSWFvBNNwdrng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="72577338" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa008.jf.intel.com with ESMTP; 25 Sep 2024 05:49:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A2498595; Wed, 25 Sep 2024 15:49:17 +0300 (EEST) From: Andy Shevchenko To: Mario Limonciello , Andy Shevchenko , Andi Shyti , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 2/5] i2c: designware: Get rid of redundant 'else' Date: Wed, 25 Sep 2024 15:44:20 +0300 Message-ID: <20240925124916.976173-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> References: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the snippets like the following if (...) return / goto / break / continue ...; else ... the 'else' is redundant. Get rid of it. Reviewed-by: Andi Shyti Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Acked-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busse= s/i2c-designware-common.c index f31d352d98b5..84ca53ee3317 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -676,10 +676,10 @@ int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev) =20 if (abort_source & DW_IC_TX_ARB_LOST) return -EAGAIN; - else if (abort_source & DW_IC_TX_ABRT_GCALL_READ) + if (abort_source & DW_IC_TX_ABRT_GCALL_READ) return -EINVAL; /* wrong msgs[] data */ - else - return -EIO; + + return -EIO; } =20 int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev) --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Fri Nov 29 03:58:22 2024 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 692231A01D5; Wed, 25 Sep 2024 12:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268568; cv=none; b=ip004Ln5roJ4KWGL0rtgVwS4XadMeo9o8xiyPAgA9RMTQbGIU9pDEpWWQmRri86U9VeRhvvFR/SHKbtqAnqASNY5wgQVva/GOF3NjIoHf2AaO3yYW27wnnz4waU6SiMjKZ7wD8S4fdOo/0A+EMmlqrY8XXNBV9D51LHUGCyo/GQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268568; c=relaxed/simple; bh=/TXpA607vG0oOI0BpN5eHgQcE45esS5ompfrTwKMzrc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lnzb4y43cBuu0dv5JUUg43iJ9uqlvtdhMU+PD9h9L5pGxC3YKGOizsTY5JGgr8WcTDneklk98UMeXil2SThmbczK6Oq5tbb6MoDeixkuf/U8HsnkKDviHlHNBE7YE7IASlC/ua1l4rlaUKSt2Ba0U1KyzzterfzcGRWV2R8dy6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=J5iPk8ab; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J5iPk8ab" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727268566; x=1758804566; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/TXpA607vG0oOI0BpN5eHgQcE45esS5ompfrTwKMzrc=; b=J5iPk8abM6N3oiaHz4wj4n54XA14SN3Rul6wCPksiNun+k2ALBeoA5pl Ttqve/39K0rVx3l5Wai7ZydI5qAGJo4PN2oH/Rp68S2xfWNiMo7CflpMZ scZvD+nwRXA5JaWShPlrg8u+bIjs23r4w8A68TiMy6deorKJZqU2MBfWz PBidNIVqI/oL77FmV9WDNxvA7lPrmdl1sq5gMazVxbx24C1o6KrBKV9Mg qnojF+Nz3EXMWzvDXed3AXEB3qxacfCn9Ocl+CASoQONpgivAaL+qtUgl xnJcMa2g1IktFQaQwymY0inxlRfakoCouSMc6SUagMRqQT39dPm+ZrHMd Q==; X-CSE-ConnectionGUID: 7hANOwzlQ1a141ONwXeDnQ== X-CSE-MsgGUID: u81u/Dg7R5uvhoS8YJn7GA== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36878379" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="36878379" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 05:49:22 -0700 X-CSE-ConnectionGUID: mioT3FTNSBWk2IqOmgXuvw== X-CSE-MsgGUID: G7N+hhHMR0GQvA3dcvmbbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="72577341" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa008.jf.intel.com with ESMTP; 25 Sep 2024 05:49:19 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AD3F160C; Wed, 25 Sep 2024 15:49:17 +0300 (EEST) From: Andy Shevchenko To: Mario Limonciello , Andy Shevchenko , Andi Shyti , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 3/5] i2c: designware: Remove 'cond' from i2c_dw_scl_hcnt() Date: Wed, 25 Sep 2024 15:44:21 +0300 Message-ID: <20240925124916.976173-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> References: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'cond' parameter is not being used (always default, hence drop it and hence make it consistent with i2c_dw_scl_lcnt(). Signed-off-by: Andy Shevchenko Acked-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-common.c | 52 +++++++--------------- drivers/i2c/busses/i2c-designware-core.h | 2 +- drivers/i2c/busses/i2c-designware-master.c | 4 -- 3 files changed, 16 insertions(+), 42 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busse= s/i2c-designware-common.c index 84ca53ee3317..9c6166f463a2 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -407,47 +407,26 @@ static u32 i2c_dw_read_scl_reg(struct dw_i2c_dev *dev= , u32 reg) } =20 u32 i2c_dw_scl_hcnt(struct dw_i2c_dev *dev, unsigned int reg, u32 ic_clk, - u32 tSYMBOL, u32 tf, int cond, int offset) + u32 tSYMBOL, u32 tf, int offset) { if (!ic_clk) return i2c_dw_read_scl_reg(dev, reg); =20 /* - * DesignWare I2C core doesn't seem to have solid strategy to meet - * the tHD;STA timing spec. Configuring _HCNT based on tHIGH spec - * will result in violation of the tHD;STA spec. + * Conditional expression: + * + * IC_[FS]S_SCL_HCNT + 3 >=3D IC_CLK * (tHD;STA + tf) + * + * This is just experimental rule; the tHD;STA period turned + * out to be proportinal to (_HCNT + 3). With this setting, + * we could meet both tHIGH and tHD;STA timing specs. + * + * If unsure, you'd better to take this alternative. + * + * The reason why we need to take into account "tf" here, + * is the same as described in i2c_dw_scl_lcnt(). */ - if (cond) - /* - * Conditional expression: - * - * IC_[FS]S_SCL_HCNT + (1+4+3) >=3D IC_CLK * tHIGH - * - * This is based on the DW manuals, and represents an ideal - * configuration. The resulting I2C bus speed will be - * faster than any of the others. - * - * If your hardware is free from tHD;STA issue, try this one. - */ - return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * tSYMBOL, MICRO) - - 8 + offset; - else - /* - * Conditional expression: - * - * IC_[FS]S_SCL_HCNT + 3 >=3D IC_CLK * (tHD;STA + tf) - * - * This is just experimental rule; the tHD;STA period turned - * out to be proportinal to (_HCNT + 3). With this setting, - * we could meet both tHIGH and tHD;STA timing specs. - * - * If unsure, you'd better to take this alternative. - * - * The reason why we need to take into account "tf" here, - * is the same as described in i2c_dw_scl_lcnt(). - */ - return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * (tSYMBOL + tf), MICRO) - - 3 + offset; + return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * (tSYMBOL + tf), MICRO) - 3 + o= ffset; } =20 u32 i2c_dw_scl_lcnt(struct dw_i2c_dev *dev, unsigned int reg, u32 ic_clk, @@ -467,8 +446,7 @@ u32 i2c_dw_scl_lcnt(struct dw_i2c_dev *dev, unsigned in= t reg, u32 ic_clk, * account the fall time of SCL signal (tf). Default tf value * should be 0.3 us, for safety. */ - return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * (tLOW + tf), MICRO) - - 1 + offset; + return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * (tLOW + tf), MICRO) - 1 + offs= et; } =20 int i2c_dw_set_sda_hold(struct dw_i2c_dev *dev) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/= i2c-designware-core.h index 8e8854ec9882..067ed5bcec08 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -328,7 +328,7 @@ struct i2c_dw_semaphore_callbacks { =20 int i2c_dw_init_regmap(struct dw_i2c_dev *dev); u32 i2c_dw_scl_hcnt(struct dw_i2c_dev *dev, unsigned int reg, u32 ic_clk, - u32 tSYMBOL, u32 tf, int cond, int offset); + u32 tSYMBOL, u32 tf, int offset); u32 i2c_dw_scl_lcnt(struct dw_i2c_dev *dev, unsigned int reg, u32 ic_clk, u32 tLOW, u32 tf, int offset); int i2c_dw_set_sda_hold(struct dw_i2c_dev *dev); diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busse= s/i2c-designware-master.c index e8ac9a7bf0b3..09e72ead51ee 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -71,7 +71,6 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *d= ev) ic_clk, 4000, /* tHD;STA =3D tHIGH =3D 4.0 us */ sda_falling_time, - 0, /* 0: DW default, 1: Ideal */ 0); /* No offset */ dev->ss_lcnt =3D i2c_dw_scl_lcnt(dev, @@ -105,7 +104,6 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev = *dev) ic_clk, 260, /* tHIGH =3D 260 ns */ sda_falling_time, - 0, /* DW default */ 0); /* No offset */ dev->fs_lcnt =3D i2c_dw_scl_lcnt(dev, @@ -129,7 +127,6 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev = *dev) ic_clk, 600, /* tHD;STA =3D tHIGH =3D 0.6 us */ sda_falling_time, - 0, /* 0: DW default, 1: Ideal */ 0); /* No offset */ dev->fs_lcnt =3D i2c_dw_scl_lcnt(dev, @@ -161,7 +158,6 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev = *dev) ic_clk, 160, /* tHIGH =3D 160 ns */ sda_falling_time, - 0, /* DW default */ 0); /* No offset */ dev->hs_lcnt =3D i2c_dw_scl_lcnt(dev, --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Fri Nov 29 03:58:22 2024 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C6419F473; Wed, 25 Sep 2024 12:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268566; cv=none; b=r/450xEX25wDVmcrlz4qQ3trlAygQNwKrt4c9sm3UifdJZF6mQNVJ++ZkJ8U4FFDmM9yJChRwijjCYbOKhMxIa4Dqr+bulLS42DD0QOsvbft5e3GAzU6GeRFS1HMeFgHckAAsRY+F2QRjffdhIERZPC6cfPXKnT/oSp5vaBZOGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268566; c=relaxed/simple; bh=70t3hLSLDlpykDIVy85aCrxgzN++uWo5vy1Vhc0fPPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OgW+bR7bJ3RKx8TRViidb3/eCF9F2T5WoXq2aWQ59hrQKbcLsv1p9B3KhNRA9iOk0HH/eWVbq+n74tn3L7YFn5R4tufvhhWyZsAjyZM99yhWoKuK2OyXLN2zUVMDOWYu5Uorg+ZOdd+duASj1RIraQ6i+Skg0QW4zs6CptJklDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BdbbLujJ; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BdbbLujJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727268564; x=1758804564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=70t3hLSLDlpykDIVy85aCrxgzN++uWo5vy1Vhc0fPPo=; b=BdbbLujJlb6DrJ+bKIxkhexYiY4wVlTuPFib+ZOvjipTFmuQ9sPDqpO+ EQ/nnqn/hNJgoObR/IdKg9uN2yDGsAeBWcwXJGkpptmxzpEuSP8HyCvWl Sdw7uk+pyzEQ03ZXU8+gZFO0CX5ISPpeJzKiy8c68gOWdS+dZ2YISzwHL DGZjkjqarcMW7KfPZZxDebR0uOCEfbFYb+o66HrpqsrB2exo2oObmOu+b QNr9GuL6BPiV+QabvvsH7hgnN8NKvkS55HucGWyHex2IHjp1x1/gThN7O eAiVdMGhetatTXGznvj8H7el4vPEnZcLh2jh4hgcPjHAnv+/4dP6SP1ik Q==; X-CSE-ConnectionGUID: bFKwU6pSR5+cHXtOSQ239w== X-CSE-MsgGUID: PJ5TXRIGRqymRbT97h3vzQ== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36878358" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="36878358" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 05:49:21 -0700 X-CSE-ConnectionGUID: MgqSQzG7R0ObNZLcggW1YQ== X-CSE-MsgGUID: ORXjVviiTdmoZMTejZyO8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="72577339" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa008.jf.intel.com with ESMTP; 25 Sep 2024 05:49:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B9982613; Wed, 25 Sep 2024 15:49:17 +0300 (EEST) From: Andy Shevchenko To: Mario Limonciello , Andy Shevchenko , Andi Shyti , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 4/5] i2c: designware: Use sda_hold_time variable name everywhere Date: Wed, 25 Sep 2024 15:44:22 +0300 Message-ID: <20240925124916.976173-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> References: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently the PCI glue driver uses sda_hold variable name, while the rest of the driver use sda_hold_time. This makes things harder to grep. Use sda_hold_time variable name everywhere. Signed-off-by: Andy Shevchenko Acked-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-pcidrv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busse= s/i2c-designware-pcidrv.c index 433cb285d3b2..38265c3dc454 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -51,7 +51,7 @@ struct dw_scl_sda_cfg { u16 fs_hcnt; u16 ss_lcnt; u16 fs_lcnt; - u32 sda_hold; + u32 sda_hold_time; }; =20 struct dw_pci_controller { @@ -76,7 +76,7 @@ static struct dw_scl_sda_cfg byt_config =3D { .fs_hcnt =3D 0x55, .ss_lcnt =3D 0x200, .fs_lcnt =3D 0x99, - .sda_hold =3D 0x6, + .sda_hold_time =3D 0x6, }; =20 /* Haswell HCNT/LCNT/SDA hold time */ @@ -85,14 +85,14 @@ static struct dw_scl_sda_cfg hsw_config =3D { .fs_hcnt =3D 0x48, .ss_lcnt =3D 0x01fb, .fs_lcnt =3D 0xa0, - .sda_hold =3D 0x9, + .sda_hold_time =3D 0x9, }; =20 /* NAVI-AMD HCNT/LCNT/SDA hold time */ static struct dw_scl_sda_cfg navi_amd_config =3D { .ss_hcnt =3D 0x1ae, .ss_lcnt =3D 0x23a, - .sda_hold =3D 0x9, + .sda_hold_time =3D 0x9, }; =20 static u32 mfld_get_clk_rate_khz(struct dw_i2c_dev *dev) @@ -264,7 +264,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, dev->fs_hcnt =3D cfg->fs_hcnt; dev->ss_lcnt =3D cfg->ss_lcnt; dev->fs_lcnt =3D cfg->fs_lcnt; - dev->sda_hold_time =3D cfg->sda_hold; + dev->sda_hold_time =3D cfg->sda_hold_time; } =20 adap =3D &dev->adapter; --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Fri Nov 29 03:58:22 2024 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E463D1A0729; Wed, 25 Sep 2024 12:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268568; cv=none; b=VJ5AGfvRZmmH3Z/mEIBE3a1dXASRZzPOr7kPz+Zm6QcvMcLaJwsTeOqJfFBo4Q/piK6ChmS/wih4JuRuLSaBGRiOLLB0yllRtpSvv0GQcqIi8SJURmCCSncFqcdybI4b1J27mUuflM4S8bi3q/X9X2LfxM1p2b3aaaGmMbpSmok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727268568; c=relaxed/simple; bh=dXkrMSpPQBx3RRntS6GuYymre1vZ2Rb1CiRFyHRh670=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WL4vV981UrYUWeyp6AsGPVV8fuyJY9QBr2VfjEKaqiyGh3t5dSIXjQzXReBGuIlgKd/+d6q5ryBvnBfVL/7m6aOD+ZLiBuIcIksmJYE1O8eukmDymYuwX0An+DA4UhFaM6QICqZkPIC6Cc0321oTmrntwh5v7zFjOxG4r2DzboM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OJ8ep02g; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OJ8ep02g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727268567; x=1758804567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dXkrMSpPQBx3RRntS6GuYymre1vZ2Rb1CiRFyHRh670=; b=OJ8ep02gdIqgeklc/+ozQ7qSngCN0E0curTIScIUd7gGsWh8DbZH+Y+N E6PwyOfvR7qLmAI75vvKBkGhtMWT/ZUs2Rx+guJyF4bIwSN4WsHUomGM0 oDk/XWjDeW9iZ3sZ7r3KDjfP3NR1ChHUQ8mNkN1ANSxIZVGXYMpreA5Ho MGJSiFBBmx8ijgabIxIXmmdGzxa8RLEZXRHniNqRY6cyKdTHuHbyXQsgu 8z9ZnOfVum33W4c+QbA0RdyasKtEgcSusktfAPQ9isRbMjduNH6ogov10 cWyOeKmjTzRiWy7j7IrGo6feiNwvL2bzjNLdXAHfDjtUJ4jANEKoA8DdV A==; X-CSE-ConnectionGUID: Al3JtmsLSu29aYVbRbsxKg== X-CSE-MsgGUID: 6ErsMa2sSbmpXdUK97mbCA== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="29196429" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="29196429" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 05:49:25 -0700 X-CSE-ConnectionGUID: TSYe1ng0SgKBdURfnw2Shg== X-CSE-MsgGUID: rQiW7M2wTquLQ5PHfc9sLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="71845576" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa009.jf.intel.com with ESMTP; 25 Sep 2024 05:49:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C2E7C628; Wed, 25 Sep 2024 15:49:17 +0300 (EEST) From: Andy Shevchenko To: Mario Limonciello , Andy Shevchenko , Andi Shyti , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 5/5] i2c: designware: Fix spelling and other issues in the comments Date: Wed, 25 Sep 2024 15:44:23 +0300 Message-ID: <20240925124916.976173-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> References: <20240925124916.976173-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix spelling and other issues, such as kernel-doc reported about, in the comments. While at it, fix some indentation issues as well. Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Acked-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-amdpsp.c | 10 +++++----- drivers/i2c/busses/i2c-designware-common.c | 8 +++++--- drivers/i2c/busses/i2c-designware-core.h | 10 +++++----- drivers/i2c/busses/i2c-designware-master.c | 13 ++++++++----- drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- drivers/i2c/busses/i2c-designware-slave.c | 6 ++++-- 6 files changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busse= s/i2c-designware-amdpsp.c index 63454b06e5da..8fbd2a10c31a 100644 --- a/drivers/i2c/busses/i2c-designware-amdpsp.c +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c @@ -155,7 +155,7 @@ static void psp_release_i2c_bus_deferred(struct work_st= ruct *work) =20 /* * If there is any pending transaction, cannot release the bus here. - * psp_release_i2c_bus will take care of this later. + * psp_release_i2c_bus() will take care of this later. */ if (psp_i2c_access_count) goto cleanup; @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void) { mutex_lock(&psp_i2c_access_mutex); =20 - /* Return early if mailbox was malfunctional */ + /* Return early if mailbox was malfunctioned */ if (psp_i2c_mbox_fail) goto cleanup; =20 /* - * If we are last owner of PSP semaphore, need to release aribtration + * If we are last owner of PSP semaphore, need to release arbitration * via mailbox. */ psp_i2c_access_count--; @@ -235,9 +235,9 @@ static void psp_release_i2c_bus(void) =20 /* * Locking methods are based on the default implementation from - * drivers/i2c/i2c-core-base.c, but with psp acquire and release operations + * drivers/i2c/i2c-core-base.c, but with PSP acquire and release operations * added. With this in place we can ensure that i2c clients on the bus sha= red - * with psp are able to lock HW access to the bus for arbitrary number of + * with PSP are able to lock HW access to the bus for arbitrary number of * operations - that is e.g. write-wait-read. */ static void i2c_adapter_dw_psp_lock_bus(struct i2c_adapter *adapter, diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busse= s/i2c-designware-common.c index 9c6166f463a2..1c8bcd7aef42 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -127,6 +127,8 @@ static int dw_reg_write_word(void *context, unsigned in= t reg, unsigned int val) * Autodetects needed register access mode and creates the regmap with * corresponding read/write callbacks. This must be called before doing any * other register access. + * + * Return: 0 on success, or negative errno otherwise. */ int i2c_dw_init_regmap(struct dw_i2c_dev *dev) { @@ -174,7 +176,7 @@ int i2c_dw_init_regmap(struct dw_i2c_dev *dev) /* * Note we'll check the return value of the regmap IO accessors only * at the probe stage. The rest of the code won't do this because - * basically we have MMIO-based regmap so non of the read/write methods + * basically we have MMIO-based regmap, so none of the read/write methods * can fail. */ dev->map =3D devm_regmap_init(dev->dev, NULL, dev, &map_cfg); @@ -336,7 +338,7 @@ static u32 i2c_dw_acpi_round_bus_speed(struct device *d= evice) =20 acpi_speed =3D i2c_acpi_find_bus_speed(device); /* - * Some DSTDs use a non standard speed, round down to the lowest + * Some DSDTs use a non standard speed, round down to the lowest * standard speed. */ for (i =3D 0; i < ARRAY_SIZE(supported_speeds); i++) { @@ -547,7 +549,7 @@ void __i2c_dw_disable(struct dw_i2c_dev *dev) =20 /* * Wait 10 times the signaling period of the highest I2C - * transfer supported by the driver (for 400KHz this is + * transfer supported by the driver (for 400kHz this is * 25us) as described in the DesignWare I2C databook. */ usleep_range(25, 250); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/= i2c-designware-core.h index 067ed5bcec08..4b154894d4ce 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -142,10 +142,10 @@ #define DW_IC_SLAVE 1 =20 /* - * Hardware abort codes from the DW_IC_TX_ABRT_SOURCE register + * Hardware abort codes from the DW_IC_TX_ABRT_SOURCE register. * - * Only expected abort codes are listed here - * refer to the datasheet for the full list + * Only expected abort codes are listed here, + * refer to the datasheet for the full list. */ #define ABRT_7B_ADDR_NOACK 0 #define ABRT_10ADDR1_NOACK 1 @@ -200,7 +200,7 @@ struct reset_control; * @rst: optional reset for the controller * @slave: represent an I2C slave device * @get_clk_rate_khz: callback to retrieve IP specific bus speed - * @cmd_err: run time hadware error code + * @cmd_err: run time hardware error code * @msgs: points to an array of messages currently being transferred * @msgs_num: the number of elements in msgs * @msg_write_idx: the element index of the current tx message in the msgs= array @@ -236,7 +236,7 @@ struct reset_control; * @release_lock: function to release a hardware lock on the bus * @semaphore_idx: Index of table with semaphore type attached to the bus.= It's * -1 if there is no semaphore. - * @shared_with_punit: true if this bus is shared with the SoCs PUNIT + * @shared_with_punit: true if this bus is shared with the SoC's PUNIT * @init: function to initialize the I2C hardware * @set_sda_hold_time: callback to retrieve IP specific SDA hold timing * @mode: operation mode - DW_IC_MASTER or DW_IC_SLAVE diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busse= s/i2c-designware-master.c index 09e72ead51ee..528b969253a7 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -180,12 +180,14 @@ static int i2c_dw_set_timings_master(struct dw_i2c_de= v *dev) } =20 /** - * i2c_dw_init_master() - Initialize the designware I2C master hardware + * i2c_dw_init_master() - Initialize the DesignWare I2C master hardware * @dev: device private data * * This functions configures and enables the I2C master. * This function is called during I2C init function, and in case of timeou= t at * run time. + * + * Return: 0 on success, or negative errno otherwise. */ static int i2c_dw_init_master(struct dw_i2c_dev *dev) { @@ -353,7 +355,7 @@ static int amd_i2c_dw_xfer_quirk(struct i2c_adapter *ad= ap, struct i2c_msg *msgs, /* * Initiate the i2c read/write transaction of buffer length, * and poll for bus busy status. For the last message transfer, - * update the command with stopbit enable. + * update the command with stop bit enable. */ for (msg_itr_lmt =3D buf_len; msg_itr_lmt > 0; msg_itr_lmt--) { if (msg_wrt_idx =3D=3D num_msgs - 1 && msg_itr_lmt =3D=3D 1) @@ -398,7 +400,7 @@ static int amd_i2c_dw_xfer_quirk(struct i2c_adapter *ad= ap, struct i2c_msg *msgs, =20 /* * Initiate (and continue) low level master read/write transaction. - * This function is only called from i2c_dw_isr, and pumping i2c_msg + * This function is only called from i2c_dw_isr(), and pumping i2c_msg * messages into the tx buffer. Even if the size of i2c_msg data is * longer than the size of the tx buffer, it handles everything. */ @@ -436,7 +438,8 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev) buf =3D msgs[dev->msg_write_idx].buf; buf_len =3D msgs[dev->msg_write_idx].len; =20 - /* If both IC_EMPTYFIFO_HOLD_MASTER_EN and + /* + * If both IC_EMPTYFIFO_HOLD_MASTER_EN and * IC_RESTART_EN are set, we must manually * set restart bit between messages. */ @@ -967,7 +970,7 @@ static int i2c_dw_init_recovery_info(struct dw_i2c_dev = *dev) rinfo->unprepare_recovery =3D i2c_dw_unprepare_recovery; adap->bus_recovery_info =3D rinfo; =20 - dev_info(dev->dev, "running with gpio recovery mode! scl%s", + dev_info(dev->dev, "running with GPIO recovery mode! scl%s", rinfo->sda_gpiod ? ",sda" : ""); =20 return 0; diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/buss= es/i2c-designware-platdrv.c index a3e86930bf41..b44c5d1a6748 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -72,7 +72,7 @@ static int bt1_i2c_write(void *context, unsigned int reg,= unsigned int val) return ret; =20 return regmap_write(dev->sysmap, BT1_I2C_CTL, - BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK)); + BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK)); } =20 static const struct regmap_config bt1_i2c_cfg =3D { @@ -278,7 +278,7 @@ static int dw_i2c_plat_probe(struct platform_device *pd= ev) adap =3D &dev->adapter; adap->owner =3D THIS_MODULE; adap->class =3D dmi_check_system(dw_i2c_hwmon_class_dmi) ? - I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED; + I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED; adap->nr =3D -1; =20 if (dev->flags & ACCESS_NO_IRQ_SUSPEND) diff --git a/drivers/i2c/busses/i2c-designware-slave.c b/drivers/i2c/busses= /i2c-designware-slave.c index 7035296aa24c..fad568e3523b 100644 --- a/drivers/i2c/busses/i2c-designware-slave.c +++ b/drivers/i2c/busses/i2c-designware-slave.c @@ -32,12 +32,14 @@ static void i2c_dw_configure_fifo_slave(struct dw_i2c_d= ev *dev) } =20 /** - * i2c_dw_init_slave() - Initialize the designware i2c slave hardware + * i2c_dw_init_slave() - Initialize the DesignWare i2c slave hardware * @dev: device private data * * This function configures and enables the I2C in slave mode. * This function is called during I2C init function, and in case of timeou= t at * run time. + * + * Return: 0 on success, or negative errno otherwise. */ static int i2c_dw_init_slave(struct dw_i2c_dev *dev) { @@ -264,7 +266,7 @@ int i2c_dw_probe_slave(struct dw_i2c_dev *dev) ret =3D devm_request_irq(dev->dev, dev->irq, i2c_dw_isr_slave, IRQF_SHARED, dev_name(dev->dev), dev); if (ret) { - dev_err(dev->dev, "failure requesting irq %i: %d\n", + dev_err(dev->dev, "failure requesting IRQ %i: %d\n", dev->irq, ret); return ret; } --=20 2.43.0.rc1.1336.g36b5255a03ac