From nobody Fri Nov 29 09:42:27 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5E114A08D for ; Mon, 23 Sep 2024 15:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727104124; cv=none; b=NFIfIK51wVoccr8lCTINKk+N49jrur3fQd/wGeJ7TPFoQ8atS2ARv8wfov21Zwhn4C6zTGaG8Ug45dQ9Plv5gYtdy6MN4u/kEIZtODfCMahCyM9sdazTrT4FTf+TkGeHPkwPPlskJjAr/aVRO3YmgMRGSUWdEKsp9JTUbd6SBiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727104124; c=relaxed/simple; bh=irBaOeClY+dENutvf8agr+7GSylzFZJEr+v6E45Z5UE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pELLGb2DFQeRcc/sboW/51z5EDgt+LNKT8Oc3z+UxFzu//vMx20WS7RvXZ4/3ZwHiYGHCm23o9zX7QwGF8SgIxdjJifirBTuwWoepXTBiyxxuBSwkDgYLg5leP3uUBQ1iHGt9IscpSeJd+wKN8yFLdXeFZs/jOTL6Z+VQPSoZ/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wnl9zwkL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wnl9zwkL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727104122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7sJs50CQB1rXW7Czy4aIaKRpcUNrb/d4a0miNhatVWk=; b=Wnl9zwkL3FYMi6JzNJ/yTApkOqFNy3WAgb//rGwIjOENJvQKNN4+RQdcHfU7A8HlYRb5QM 6kin8wWd4R2Z1ANH50IAkDD9bf7VfktLoMETJ225D+EbDBlX2zn/joziNiyrCvZRfTdbOh jZuEray+f9VHWs79SZckS5AhyWOpjIY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-MvVAiCEgPwSeBw7yfVwWvA-1; Mon, 23 Sep 2024 11:08:39 -0400 X-MC-Unique: MvVAiCEgPwSeBw7yfVwWvA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4E23195FE03; Mon, 23 Sep 2024 15:08:36 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.145]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C252F1954190; Mon, 23 Sep 2024 15:08:18 +0000 (UTC) From: David Howells To: Christian Brauner , Steve French , Marc Dionne Cc: David Howells , Paulo Alcantara , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 3/8] afs: Fix missing wire-up of afs_retry_request() Date: Mon, 23 Sep 2024 16:07:47 +0100 Message-ID: <20240923150756.902363-4-dhowells@redhat.com> In-Reply-To: <20240923150756.902363-1-dhowells@redhat.com> References: <20240923150756.902363-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Content-Type: text/plain; charset="utf-8" afs_retry_request() is supposed to be pointed to by the afs_req_ops netfs operations table, but the pointer got lost somewhere. The function is used during writeback to rotate through the authentication keys that were in force when the file was modified locally. Fix this by adding the pointer to the function. Fixes: 1ecb146f7cd8 ("netfs, afs: Use writeback retry to deal with alternat= e keys") Reported-by: "Dr. David Alan Gilbert" Signed-off-by: David Howells cc: Marc Dionne cc: Jeff Layton cc: linux-afs@lists.infradead.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/afs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/file.c b/fs/afs/file.c index 1d30924cec5b..f717168da4ab 100644 --- a/fs/afs/file.c +++ b/fs/afs/file.c @@ -425,6 +425,7 @@ const struct netfs_request_ops afs_req_ops =3D { .begin_writeback =3D afs_begin_writeback, .prepare_write =3D afs_prepare_write, .issue_write =3D afs_issue_write, + .retry_request =3D afs_retry_request, }; =20 static void afs_add_open_mmap(struct afs_vnode *vnode)